13111: Fix skipped error check when Write called before WriteHeader.
authorTom Clegg <tclegg@veritasgenetics.com>
Thu, 12 Apr 2018 13:14:52 +0000 (09:14 -0400)
committerTom Clegg <tclegg@veritasgenetics.com>
Thu, 12 Apr 2018 13:14:52 +0000 (09:14 -0400)
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

services/keep-web/handler.go

index 5e14cb4008aa4197956c42f5d8b4281afdaf4d31..389ab73a0cc2159564a8884f33d7cd2feaa64850 100644 (file)
@@ -112,12 +112,12 @@ type updateOnSuccess struct {
 }
 
 func (uos *updateOnSuccess) Write(p []byte) (int, error) {
-       if uos.err != nil {
-               return 0, uos.err
-       }
        if !uos.sentHeader {
                uos.WriteHeader(http.StatusOK)
        }
+       if uos.err != nil {
+               return 0, uos.err
+       }
        return uos.ResponseWriter.Write(p)
 }