13967: Add guard comment re timing out large uploads.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>

diff --git a/services/keep-web/server.go b/services/keep-web/server.go
index b0375ff8d9496dfc41c910a969963209649f9531..586f6b805736e23437357dbc8eb1a8cf4b5a5cc7 100644 (file)
--- a/services/keep-web/server.go
+++ b/services/keep-web/server.go
@@ -25,6 +25,11 @@ func (srv *server) Start(logger *logrus.Logger) error {
        h := &handler{Config: srv.Config}
        reg := prometheus.NewRegistry()
        h.Config.Cache.registry = reg
+       // Warning: when updating this to use Command() from
+       // lib/service, make sure to implement an exemption in
+       // httpserver.HandlerWithDeadline() so large file uploads are
+       // allowed to take longer than the usual API.RequestTimeout.
+       // See #13697.
        mh := httpserver.Instrument(reg, logger, httpserver.AddRequestIDs(httpserver.LogRequests(h)))
        h.MetricsAPI = mh.ServeAPI(h.Config.cluster.ManagementToken, http.NotFoundHandler())
        srv.Handler = mh