12125: Update trash tests

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

diff --git a/apps/workbench/app/views/application/404.html.erb b/apps/workbench/app/views/application/404.html.erb
index 9750b9178b3740561459b0168383ceb065757abd..c09e6349ea387fbbffb8d579aa92defce401045b 100644 (file)
--- a/apps/workbench/app/views/application/404.html.erb
+++ b/apps/workbench/app/views/application/404.html.erb
@@ -45,7 +45,6 @@ SPDX-License-Identifier: AGPL-3.0 %>
       <% end %>
     </p>
 
-
     <p>
       It will be permanently deleted at <%= render_localized_date(untrash_object.delete_at) %>.
     </p>

diff --git a/apps/workbench/test/integration/trash_test.rb b/apps/workbench/test/integration/trash_test.rb
index d01f636dd8d9cb43b317fa8b0a4597164dce54d0..22732a3d95501e9b1f4d7d296fb524157b0dde95 100644 (file)
--- a/apps/workbench/test/integration/trash_test.rb
+++ b/apps/workbench/test/integration/trash_test.rb
@@ -46,7 +46,9 @@ class TrashTest < ActionDispatch::IntegrationTest
 
     wait_for_ajax
 
-    assert_no_text expired1['name']
+    assert_text "The collection with UUID #{expired1['uuid']} is in the trash"
+
+    click_on "Click here to untrash '#{expired1['name']}'"
 
     # verify that the two un-trashed items are now shown in /collections page
     visit page_with_token('active', "/collections")
@@ -76,25 +78,23 @@ class TrashTest < ActionDispatch::IntegrationTest
 
       # Un-trash item
       if method == "button"
-        within('tr', text: deleted['name']) do
+        within('tr', text: deleted['uuid']) do
           first('.fa-recycle').click
         end
+        assert_text "The group with UUID #{deleted['uuid']} is in the trash"
+        click_on "Click here to untrash '#{deleted['name']}'"
       else
-        within('tr', text: deleted['name']) do
+        within('tr', text: deleted['uuid']) do
           first('input').click
         end
         click_button 'Selection...'
         within('.selection-action-container') do
           click_link 'Un-trash selected items'
         end
+        wait_for_ajax
+        assert_no_text deleted['uuid']
       end
 
-      wait_for_ajax
-
-      assert_no_text deleted['name']
-      visit current_path
-      assert_no_text deleted['name']
-
       # check that the un-trashed item are now shown on parent project page
       visit page_with_token('active', "/projects/zzzzz-tpzed-xurymjxw79nv3jz")
       click_on "Subprojects"

diff --git a/services/api/test/fixtures/groups.yml b/services/api/test/fixtures/groups.yml
index 2411831520a9a9365ef55d67686938afbfa26c9f..07d46d86495c6cec831d0d3428fbda0f2a111c22 100644 (file)
--- a/services/api/test/fixtures/groups.yml
+++ b/services/api/test/fixtures/groups.yml
@@ -307,6 +307,7 @@ trashed_project:
   trash_at: 2001-01-01T00:00:00Z
   delete_at: 2038-03-01T00:00:00Z
   is_trashed: true
+  modified_at: 2001-01-01T00:00:00Z
 
 trashed_subproject:
   uuid: zzzzz-j7d0g-trashedproject2
@@ -314,6 +315,7 @@ trashed_subproject:
   name: trashed subproject
   group_class: project
   is_trashed: false
+  modified_at: 2001-01-01T00:00:00Z
 
 trashed_subproject3:
   uuid: zzzzz-j7d0g-trashedproject3
@@ -323,3 +325,4 @@ trashed_subproject3:
   trash_at: 2001-01-01T00:00:00Z
   delete_at: 2038-03-01T00:00:00Z
   is_trashed: true
+  modified_at: 2001-01-01T00:00:00Z
\ No newline at end of file