if self.new_record? || self.state_was == Uncommitted
# Allow create-and-commit in a single operation.
permitted.push(*AttrsPermittedBeforeCommit)
- elsif mounts_changed? && mounts_was.keys == mounts.keys
+ elsif mounts_changed? && mounts_was.keys.sort == mounts.keys.sort
# Ignore the updated mounts if the only changes are default/zero
# values as added by controller, see 17774
only_defaults = true
mounts.each do |path, mount|
(mount.to_a - mounts_was[path].to_a).each do |k, v|
- if !["", false, nil].index(v)
+ if ![0, "", false, nil].index(v)
only_defaults = false
end
end
# controller, does not have any real effect and should be
# accepted/ignored rather than causing an error when the CR state
# dictates those attributes are not allowed to change.
+ ['Committed', true, {priority: 0, mounts: {"/out" => {"capacity" => 0, "kind" => "tmp"}}}, {mounts: {"/out" => {"kind" => "tmp"}}}],
['Committed', true, {priority: 0, mounts: {"/out" => {"capacity" => 1000000, "kind" => "tmp", "exclude_from_output": false}}}],
['Committed', true, {priority: 0, mounts: {"/out" => {"capacity" => 1000000, "kind" => "tmp", "repository_name": ""}}}],
['Committed', true, {priority: 0, mounts: {"/out" => {"capacity" => 1000000, "kind" => "tmp", "content": nil}}}],
['Final', false, {container_count: 2}],
['Final', true, {name: "foobar"}],
['Final', true, {name: "foobar", description: "baz"}],
- ].each do |state, permitted, updates|
+ ].each do |state, permitted, updates, create_attrs|
test "state=#{state} can#{'not' if !permitted} update #{updates.inspect}" do
act_as_user users(:active) do
- cr = create_minimal_req!(priority: 1,
- state: "Committed",
- container_count_max: 1)
+ attrs = {
+ priority: 1,
+ state: "Committed",
+ container_count_max: 1
+ }
+ if !create_attrs.nil?
+ attrs.merge!(create_attrs)
+ end
+ cr = create_minimal_req!(attrs)
case state
when 'Committed'
# already done