17465: Collection.save() adds storage_classes_desired when set on instance.
authorLucas Di Pentima <lucas.dipentima@curii.com>
Wed, 2 Jun 2021 20:24:29 +0000 (17:24 -0300)
committerLucas Di Pentima <lucas.dipentima@curii.com>
Wed, 2 Jun 2021 20:25:30 +0000 (17:25 -0300)
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

sdk/python/arvados/collection.py

index 3910b224305a87e3fa292d21c97827aa36b2049f..c000c80718d510159bee12d8fe6f6f32452cea55 100644 (file)
@@ -1583,6 +1583,8 @@ class Collection(RichCollectionBase):
 
         if storage_classes and type(storage_classes) is not list:
             raise errors.ArgumentError("storage_classes must be list type.")
+        if storage_classes:
+            self._storage_classes_desired = storage_classes
 
         if trash_at and type(trash_at) is not datetime.datetime:
             raise errors.ArgumentError("trash_at must be datetime type.")
@@ -1590,8 +1592,7 @@ class Collection(RichCollectionBase):
         body={}
         if properties:
             body["properties"] = properties
-        if storage_classes:
-            self._storage_classes_desired = storage_classes
+        if self.storage_classes_desired():
             body["storage_classes_desired"] = self.storage_classes_desired()
         if trash_at:
             t = trash_at.strftime("%Y-%m-%dT%H:%M:%S.%fZ")