Fix more golint warnings.

No issue #

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward@curii.com>

diff --git a/lib/controller/handler.go b/lib/controller/handler.go
index 25bba558dc68096796143b1d9bd4483d07a6f44f..6669e020fdb9046abdceca72709348526af663c5 100644 (file)
--- a/lib/controller/handler.go
+++ b/lib/controller/handler.go
@@ -25,6 +25,7 @@ import (
        "git.arvados.org/arvados.git/sdk/go/health"
        "git.arvados.org/arvados.git/sdk/go/httpserver"
        "github.com/jmoiron/sqlx"
+       // sqlx needs lib/pq to talk to PostgreSQL
        _ "github.com/lib/pq"
 )
 

diff --git a/lib/ctrlctx/db.go b/lib/ctrlctx/db.go
index 127be489df3a27e553f6aa421a6f1c40cdbdcc55..36d79d3d2ef89ac9819d12e3f4e2f175c96426bd 100644 (file)
--- a/lib/ctrlctx/db.go
+++ b/lib/ctrlctx/db.go
@@ -12,6 +12,7 @@ import (
        "git.arvados.org/arvados.git/lib/controller/api"
        "git.arvados.org/arvados.git/sdk/go/ctxlog"
        "github.com/jmoiron/sqlx"
+       // sqlx needs lib/pq to talk to PostgreSQL
        _ "github.com/lib/pq"
 )
 

diff --git a/lib/mount/command.go b/lib/mount/command.go
index 86a9085bda46fc69a517ba2be5faf7ea14688394..e92af24075f1b824c741f6f35b4de53e2346b7ed 100644 (file)
--- a/lib/mount/command.go
+++ b/lib/mount/command.go
@@ -9,6 +9,7 @@ import (
        "io"
        "log"
        "net/http"
+       // pprof is only imported to register its HTTP handlers
        _ "net/http/pprof"
        "os"
 

diff --git a/sdk/go/arvadostest/db.go b/sdk/go/arvadostest/db.go
index 41ecfacc480f1df0a94dca4d11faefcc36541194..c20f61db26301be6be323d2097be5c55f3d17037 100644 (file)
--- a/sdk/go/arvadostest/db.go
+++ b/sdk/go/arvadostest/db.go
@@ -10,6 +10,7 @@ import (
        "git.arvados.org/arvados.git/lib/ctrlctx"
        "git.arvados.org/arvados.git/sdk/go/arvados"
        "github.com/jmoiron/sqlx"
+       // sqlx needs lib/pq to talk to PostgreSQL
        _ "github.com/lib/pq"
        "gopkg.in/check.v1"
 )