8876: display "no process has been submitted" when a child uuid is not presented.

diff --git a/apps/workbench/app/models/job_work_unit.rb b/apps/workbench/app/models/job_work_unit.rb
index 49f490dc3a5449ee146d0bd78f745610d116daba..80dea192d1c3b8b3b2383ff7d74048fa00062c17 100644 (file)
--- a/apps/workbench/app/models/job_work_unit.rb
+++ b/apps/workbench/app/models/job_work_unit.rb
@@ -23,6 +23,34 @@ class JobWorkUnit < ProxyWorkUnit
     self.my_children = items
   end
 
+  def parameters
+    get(:script_parameters)
+  end
+
+  def repository
+    get(:repository)
+  end
+
+  def script
+    get(:script)
+  end
+
+  def script_version
+    get(:script_version)
+  end
+
+  def supplied_script_version
+    get(:supplied_script_version)
+  end
+
+  def docker_image
+    get(:docker_image_locator)
+  end
+
+  def nondeterministic
+    get(:nondeterministic)
+  end
+
   def child_summary
     if children.any?
       super

diff --git a/apps/workbench/app/models/proxy_work_unit.rb b/apps/workbench/app/models/proxy_work_unit.rb
index 5d3ecabbcacd642e8d36c748beaac68eb0089f4b..1a24cd5d8721aaf99509e85be30a9eacfe5a8bab 100644 (file)
--- a/apps/workbench/app/models/proxy_work_unit.rb
+++ b/apps/workbench/app/models/proxy_work_unit.rb
@@ -145,38 +145,10 @@ class ProxyWorkUnit < WorkUnit
     end
   end
 
-  def parameters
-    get(:script_parameters)
-  end
-
-  def repository
-    get(:repository)
-  end
-
-  def script
-    get(:script)
-  end
-
-  def script_version
-    get(:script_version)
-  end
-
-  def supplied_script_version
-    get(:supplied_script_version)
-  end
-
   def runtime_constraints
     get(:runtime_constraints)
   end
 
-  def docker_image
-    get(:docker_image_locator)
-  end
-
-  def nondeterministic
-    get(:nondeterministic)
-  end
-
   def priority
     get(:priority)
   end
@@ -194,7 +166,7 @@ class ProxyWorkUnit < WorkUnit
   end
 
   def title
-    "work unit"
+    "process"
   end
 
   def has_unreadable_children

diff --git a/apps/workbench/app/views/work_unit/_component_detail.html.erb b/apps/workbench/app/views/work_unit/_component_detail.html.erb
index d68273a460ed93c54bb2bfb7a16599938302e19c..6f0682583fd50145d85dfc609793d88a1f27e4a8 100644 (file)
--- a/apps/workbench/app/views/work_unit/_component_detail.html.erb
+++ b/apps/workbench/app/views/work_unit/_component_detail.html.erb
@@ -1,6 +1,9 @@
       <div class="container">
         <div class="row">
           <div class="col-md-5">
+            <% if current_obj.uuid.nil? %>
+              No <%= current_obj.title %> has been submitted yet.
+            <% else %>
             <table>
               <% [:uuid, :modified_by_user_uuid, :created_at, :started_at, :finished_at, :output, :priority].each do |k| %>
                 <% val = current_obj.send(k) if current_obj.respond_to?(k) %>
@@ -25,6 +28,7 @@
                 </tr>
                 <% end %>
               <% end %>
+            <% end %>
             </table>
           </div>
           <div class="col-md-6">

diff --git a/apps/workbench/test/integration/jobs_test.rb b/apps/workbench/test/integration/jobs_test.rb
index be6a83dcac16acd2edcf62221d7611654b8efcd6..e39d6f4dbf66576df928df93b7cf43030240d3f2 100644 (file)
--- a/apps/workbench/test/integration/jobs_test.rb
+++ b/apps/workbench/test/integration/jobs_test.rb
@@ -101,7 +101,7 @@ class JobsTest < ActionDispatch::IntegrationTest
       if expect_options
         assert_text 'supplied_script_version: master'
       else
-        assert_no_text 'supplied_script_version: (none)'
+        assert_no_text 'supplied_script_version'
       end
 
       assert_triggers_dom_event 'shown.bs.modal' do