Add explanatory comment about FIXME
authorTom Morris <tfmorris@curoverse.com>
Thu, 6 Oct 2016 21:43:56 +0000 (17:43 -0400)
committerTom Morris <tfmorris@curoverse.com>
Thu, 6 Oct 2016 21:43:56 +0000 (17:43 -0400)
apps/workbench/test/integration_helper.rb

index 424b6665cf1d9df5469ccff761cd3ab35004e10a..3d92585135ff3db934c78cc6a092bf74a8b39054 100644 (file)
@@ -72,6 +72,12 @@ end
 
 module WaitForAjax
   # FIXME: Huge side effect here
+  # The following line changes the global default Capybara wait time, affecting
+  # every test which follows this one. This should be removed and the failing tests
+  # should have their individual wait times increased, if appropriate, using
+  # the using_wait_time(N) construct to temporarily change the wait time.
+  # Note: the below is especially bad because there are places that increase wait
+  # times using a multiplier e.g. using_wait_time(3 * Capybara.default_max_wait_time)
   Capybara.default_max_wait_time = 10
   def wait_for_ajax
     timeout = 10