12256: Comments about workflow references / extra files.
authorPeter Amstutz <pamstutz@veritasgenetics.com>
Thu, 10 May 2018 15:03:29 +0000 (11:03 -0400)
committerPeter Amstutz <pamstutz@veritasgenetics.com>
Thu, 10 May 2018 15:03:29 +0000 (11:03 -0400)
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>

sdk/cwl/arvados_cwl/arvworkflow.py

index 05d4648d153a43a10b5ad0f5fb26bce4600dac41..6f731fd6877b18fc6bc434bd8110fe2b44775196 100644 (file)
@@ -182,6 +182,8 @@ class ArvadosWorkflow(Workflow):
                                         uri,
                                         False)
 
+                    # Discover files/directories referenced by the
+                    # workflow (mainly "default" values)
                     visit_class(packed, ("File", "Directory"), self.wf_reffiles.append)
 
 
@@ -216,6 +218,9 @@ class ArvadosWorkflow(Workflow):
                                  "/keep/%s/%s",
                                  **kwargs)
 
+                # For containers API, we need to make sure any extra
+                # referenced files (ie referenced by the workflow but
+                # not in the inputs) are included in the mounts.
                 kwargs["extra_reffiles"] = copy.deepcopy(self.wf_reffiles)
 
                 def keepmount(obj):