--- /dev/null
+// Copyright (C) The Arvados Authors. All rights reserved.
+//
+// SPDX-License-Identifier: AGPL-3.0
+
+import * as React from "react";
+import { mount, configure, shallow } from "enzyme";
+import * as Adapter from "enzyme-adapter-react-16";
+import ContextMenu from "./context-menu";
+import { ListItem } from "@material-ui/core";
+
+configure({ adapter: new Adapter() });
+
+describe("<ContextMenu />", () => {
+
+ const item = {
+ name: "",
+ owner: "",
+ lastModified: "",
+ type: ""
+ };
+
+ const actions = [[{
+ icon: "",
+ name: "Action 1.1",
+ onClick: jest.fn()
+ },
+ {
+ icon: "",
+ name: "Action 1.2",
+ onClick: jest.fn()
+ },], [{
+ icon: "",
+ name: "Action 2.1",
+ onClick: jest.fn()
+ }]];
+
+ it("calls provided actions with provided item", () => {
+ const contextMenu = mount(<ContextMenu
+ anchorEl={document.createElement("div")}
+ onClose={jest.fn()}
+ {...{ actions, item }} />);
+
+ contextMenu.find(ListItem).at(0).simulate("click");
+ contextMenu.find(ListItem).at(1).simulate("click");
+ contextMenu.find(ListItem).at(2).simulate("click");
+
+ expect(actions[0][0].onClick).toHaveBeenCalledWith(item);
+ expect(actions[0][1].onClick).toHaveBeenCalledWith(item);
+ expect(actions[1][0].onClick).toHaveBeenCalledWith(item);
+ });
+});
\ No newline at end of file
--- /dev/null
+// Copyright (C) The Arvados Authors. All rights reserved.
+//
+// SPDX-License-Identifier: AGPL-3.0
+import * as React from "react";
+import { Popover, List, ListItem, ListItemIcon, ListItemText, Divider } from "@material-ui/core";
+import { DefaultTransformOrigin } from "../popover/helpers";
+
+export interface ContextMenuAction<T> {
+ name: string;
+ icon: string;
+ onClick: (item: T) => void;
+}
+
+export type ContextMenuActionGroup<T> = Array<ContextMenuAction<T>>;
+
+export interface ContextMenuProps<T> {
+ anchorEl?: HTMLElement;
+ item?: T;
+ onClose: () => void;
+ actions: Array<ContextMenuActionGroup<T>>;
+}
+
+export default class ContextMenu<T> extends React.PureComponent<ContextMenuProps<T>> {
+ render() {
+ const { anchorEl, onClose, actions, item } = this.props;
+ return <Popover
+ anchorEl={anchorEl}
+ open={Boolean(anchorEl)}
+ onClose={onClose}
+ transformOrigin={DefaultTransformOrigin}
+ anchorOrigin={DefaultTransformOrigin}>
+ <List dense>
+ {actions.map((group, groupIndex) =>
+ <React.Fragment key={groupIndex}>
+ {group.map((action, actionIndex) =>
+ <ListItem
+ button
+ key={actionIndex}
+ onClick={() => item && action.onClick(item)}>
+ <ListItemIcon>
+ <i className={action.icon} />
+ </ListItemIcon>
+ <ListItemText>
+ {action.name}
+ </ListItemText>
+ </ListItem>)}
+ {groupIndex < actions.length - 1 && <Divider />}
+ </React.Fragment>)}
+ </List>
+ </Popover>;
+ }
+}
// SPDX-License-Identifier: AGPL-3.0
import * as React from 'react';
-import { DataTable, DataTableProps, DataColumn, ColumnSelector } from "../../components/data-table";
-import { Typography, Grid, ListItem, Divider, List, ListItemIcon, ListItemText, Paper, Toolbar } from '@material-ui/core';
-import IconButton, { IconButtonProps } from '@material-ui/core/IconButton';
+import { DataTable, DataColumn, ColumnSelector } from "../../components/data-table";
+import { Typography, Grid, Paper, Toolbar } from '@material-ui/core';
+import IconButton from '@material-ui/core/IconButton';
import MoreVertIcon from "@material-ui/icons/MoreVert";
-import Popover from '../popover/popover';
import { formatFileSize, formatDate } from '../../common/formatters';
import { DataItem } from './data-item';
-
+import { mockAnchorFromMouseEvent } from '../popover/helpers';
+import ContextMenu from '../context-menu/context-menu';
+
+export interface DataExplorerContextActions {
+ onAddToFavourite: (dataIitem: DataItem) => void;
+ onCopy: (dataIitem: DataItem) => void;
+ onDownload: (dataIitem: DataItem) => void;
+ onMoveTo: (dataIitem: DataItem) => void;
+ onRemove: (dataIitem: DataItem) => void;
+ onRename: (dataIitem: DataItem) => void;
+ onShare: (dataIitem: DataItem) => void;
+}
interface DataExplorerProps {
items: DataItem[];
onItemClick: (item: DataItem) => void;
+ contextActions: DataExplorerContextActions;
}
-type DataExplorerState = Pick<DataTableProps<DataItem>, "columns">;
+interface DataExplorerState {
+ columns: Array<DataColumn<DataItem>>;
+ contextMenu: {
+ anchorEl?: HTMLElement;
+ item?: DataItem;
+ };
+}
class DataExplorer extends React.Component<DataExplorerProps, DataExplorerState> {
state: DataExplorerState = {
- columns: [
- {
- name: "Name",
- selected: true,
- render: item => this.renderName(item)
- },
- {
- name: "Status",
- selected: true,
- render: item => renderStatus(item.status)
- },
- {
- name: "Type",
- selected: true,
- render: item => renderType(item.type)
- },
- {
- name: "Owner",
- selected: true,
- render: item => renderOwner(item.owner)
- },
- {
- name: "File size",
- selected: true,
- render: (item) => renderFileSize(item.fileSize)
- },
- {
- name: "Last modified",
- selected: true,
- render: item => renderDate(item.lastModified)
- },
- {
- name: "Actions",
- selected: true,
- configurable: false,
- renderHeader: () => null,
- render: renderItemActions
- }
- ]
+ contextMenu: {},
+ columns: [{
+ name: "Name",
+ selected: true,
+ render: item => this.renderName(item)
+ }, {
+ name: "Status",
+ selected: true,
+ render: item => renderStatus(item.status)
+ }, {
+ name: "Type",
+ selected: true,
+ render: item => renderType(item.type)
+ }, {
+ name: "Owner",
+ selected: true,
+ render: item => renderOwner(item.owner)
+ }, {
+ name: "File size",
+ selected: true,
+ render: item => renderFileSize(item.fileSize)
+ }, {
+ name: "Last modified",
+ selected: true,
+ render: item => renderDate(item.lastModified)
+ }, {
+ name: "Actions",
+ selected: true,
+ configurable: false,
+ renderHeader: () => null,
+ render: item => this.renderActions(item)
+ }]
};
+ contextMenuActions = [[{
+ icon: "fas fa-users fa-fw",
+ name: "Share",
+ onClick: this.handleContextAction("onShare")
+ }, {
+ icon: "fas fa-sign-out-alt fa-fw",
+ name: "Move to",
+ onClick: this.handleContextAction("onMoveTo")
+ }, {
+ icon: "fas fa-star fa-fw",
+ name: "Add to favourite",
+ onClick: this.handleContextAction("onAddToFavourite")
+ }, {
+ icon: "fas fa-edit fa-fw",
+ name: "Rename",
+ onClick: this.handleContextAction("onRename")
+ }, {
+ icon: "fas fa-copy fa-fw",
+ name: "Make a copy",
+ onClick: this.handleContextAction("onCopy")
+ }, {
+ icon: "fas fa-download fa-fw",
+ name: "Download",
+ onClick: this.handleContextAction("onDownload")
+ }], [{
+ icon: "fas fa-trash-alt fa-fw",
+ name: "Remove",
+ onClick: this.handleContextAction("onRemove")
+ }
+ ]];
+
render() {
return <Paper>
+ <ContextMenu
+ {...this.state.contextMenu}
+ actions={this.contextMenuActions}
+ onClose={this.closeContextMenu} />
<Toolbar>
<Grid container justify="flex-end">
<ColumnSelector
</Toolbar>
<DataTable
columns={this.state.columns}
- items={this.props.items} />
+ items={this.props.items}
+ onRowContextMenu={this.openItemMenuOnRowClick} />
<Toolbar />
</Paper>;
}
</Grid>
</Grid>
+ renderActions = (item: DataItem) =>
+ <Grid container justify="flex-end">
+ <IconButton onClick={event => this.openItemMenuOnActionsClick(event, item)}>
+ <MoreVertIcon />
+ </IconButton>
+ </Grid>
+
+ openItemMenuOnRowClick = (event: React.MouseEvent<HTMLElement>, item: DataItem) => {
+ event.preventDefault();
+ this.setState({
+ contextMenu: {
+ anchorEl: mockAnchorFromMouseEvent(event),
+ item
+ }
+ });
+ }
+
+ openItemMenuOnActionsClick = (event: React.MouseEvent<HTMLElement>, item: DataItem) => {
+ this.setState({
+ contextMenu: {
+ anchorEl: event.currentTarget,
+ item
+ }
+ });
+ }
+
+ closeContextMenu = () => {
+ this.setState({ contextMenu: {} });
+ }
+
+ handleContextAction(action: keyof DataExplorerContextActions) {
+ return (item: DataItem) => {
+ this.closeContextMenu();
+ this.props.contextActions[action](item);
+ };
+ }
+
}
const renderIcon = (dataItem: DataItem) => {
{status || "-"}
</Typography>;
-const renderItemActions = () =>
- <Grid container justify="flex-end">
- <Popover triggerComponent={ItemActionsTrigger}>
- <List dense>
- {[{
- icon: "fas fa-users",
- label: "Share"
- },
- {
- icon: "fas fa-sign-out-alt",
- label: "Move to"
- },
- {
- icon: "fas fa-star",
- label: "Add to favourite"
- },
- {
- icon: "fas fa-edit",
- label: "Rename"
- },
- {
- icon: "fas fa-copy",
- label: "Make a copy"
- },
- {
- icon: "fas fa-download",
- label: "Download"
- }].map(renderAction)}
- < Divider />
- {renderAction({ icon: "fas fa-trash-alt", label: "Remove" })}
- </List>
- </Popover>
- </Grid>;
-
-const renderAction = (action: { label: string, icon: string }, index?: number) =>
- <ListItem button key={index}>
- <ListItemIcon>
- <i className={action.icon} />
- </ListItemIcon>
- <ListItemText>
- {action.label}
- </ListItemText>
- </ListItem>;
-
-const ItemActionsTrigger: React.SFC<IconButtonProps> = (props) =>
- <IconButton {...props}>
- <MoreVertIcon />
- </IconButton>;
-
export default DataExplorer;
projects / arvados.git / commitdiff