9799: Fix method def style

diff --git a/apps/workbench/test/integration/websockets_test.rb b/apps/workbench/test/integration/websockets_test.rb
index 54712d396a84e0ac75445b84232b036fe28f1333..38917f05ae3ad60213afaaae9c2196df706022b7 100644 (file)
--- a/apps/workbench/test/integration/websockets_test.rb
+++ b/apps/workbench/test/integration/websockets_test.rb
@@ -6,7 +6,7 @@ class WebsocketTest < ActionDispatch::IntegrationTest
     @dispatch_client = ArvadosApiClient.new
   end
 
-  def dispatch_log body
+  def dispatch_log(body)
     use_token :dispatch1 do
       @dispatch_client.api('logs', '', log: body)
     end

diff --git a/apps/workbench/test/test_helper.rb b/apps/workbench/test/test_helper.rb
index 73bfda6ae626c79b165634e1b81a6076b7809fcb..b8aa82e1afa88debb5168d94909a2c2579e1dc62 100644 (file)
--- a/apps/workbench/test/test_helper.rb
+++ b/apps/workbench/test/test_helper.rb
@@ -31,7 +31,7 @@ class ActiveSupport::TestCase
   # Note: You'll currently still have to declare fixtures explicitly
   # in integration tests -- they do not yet inherit this setting
   fixtures :all
-  def use_token token_name
+  def use_token(token_name)
     user_was = Thread.current[:user]
     token_was = Thread.current[:arvados_api_token]
     auth = api_fixture('api_client_authorizations')[token_name.to_s]

diff --git a/services/api/app/models/container.rb b/services/api/app/models/container.rb
index f73c8b7009f9c7cdf18b8acfe98014bfb1dae1ef..5ab1145055de1746b6ce89c7262218f0a861c625 100644 (file)
--- a/services/api/app/models/container.rb
+++ b/services/api/app/models/container.rb
@@ -76,7 +76,7 @@ class Container < ArvadosModel
     end
   end
 
-  def self.readable_by *users_list
+  def self.readable_by(*users_list)
     if users_list.select { |u| u.is_admin }.any?
       return self
     end

diff --git a/services/api/app/models/log.rb b/services/api/app/models/log.rb
index 5b3f544f0ace09428c9553bd480408357cb686bf..ee75ec3b5d332d4b3a33890da7ad254db44dce4a 100644 (file)
--- a/services/api/app/models/log.rb
+++ b/services/api/app/models/log.rb
@@ -53,7 +53,7 @@ class Log < ArvadosModel
     self
   end
 
-  def self.readable_by *users_list
+  def self.readable_by(*users_list)
     if users_list.select { |u| u.is_admin }.any?
       return self
     end

diff --git a/services/api/test/unit/permission_test.rb b/services/api/test/unit/permission_test.rb
index 5bc296aded9a2ec116c1a20f8bf52e2091323e6d..79fc1f29c7bf46a2f1efb3ae8f9dd298f0222015 100644 (file)
--- a/services/api/test/unit/permission_test.rb
+++ b/services/api/test/unit/permission_test.rb
@@ -354,7 +354,7 @@ class PermissionTest < ActiveSupport::TestCase
     end
   end
 
-  def container_logs container, user
+  def container_logs(container, user)
     Log.readable_by(users(user)).
       where(object_uuid: containers(container).uuid, event_type: "test")
   end