5737: Fix accidental use of local variable instead of intended instance method
authorTom Clegg <tom@curoverse.com>
Tue, 11 Oct 2016 01:37:02 +0000 (21:37 -0400)
committerTom Clegg <tom@curoverse.com>
Wed, 12 Oct 2016 15:30:18 +0000 (11:30 -0400)
services/api/app/models/collection.rb
services/api/app/models/job.rb

index 2de6285ca6f0df41ea45cc22df41784285dd30f5..1c3a29a7c30756e162e201d9237e976a5ea0c133 100644 (file)
@@ -204,7 +204,7 @@ class Collection < ArvadosModel
         utf8 = manifest_text
         utf8.force_encoding Encoding::UTF_8
         if utf8.valid_encoding? and utf8 == manifest_text.encode(Encoding::UTF_8)
-          manifest_text = utf8
+          self.manifest_text = utf8
           return true
         end
       rescue
index f2bd751caa15147cba51d1de3f27f1ec7215b70a..ef3d0b5e1028b41a2bab4d63aa300efb4743bc0a 100644 (file)
@@ -340,7 +340,7 @@ class Job < ArvadosModel
         assign_uuid
         Commit.tag_in_internal_repository repository, script_version, uuid
       rescue
-        uuid = uuid_was
+        self.uuid = uuid_was
         raise
       end
     end