14325: Note assumption concurrent dispatchers share a VM size menu.

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg@veritasgenetics.com>

diff --git a/lib/dispatchcloud/container/queue.go b/lib/dispatchcloud/container/queue.go
index 464e31186d9ff5ddb8c648f51d1c54bb4c15c759..d49d0166a3fba5ec1eee1c84b5f22b7586588fa9 100644 (file)
--- a/lib/dispatchcloud/container/queue.go
+++ b/lib/dispatchcloud/container/queue.go
@@ -212,6 +212,9 @@ func (cq *Queue) Update() error {
 func (cq *Queue) addEnt(uuid string, ctr arvados.Container) {
        it, err := cq.chooseType(&ctr)
        if err != nil && (ctr.State == arvados.ContainerStateQueued || ctr.State == arvados.ContainerStateLocked) {
+               // We assume here that any chooseType error is a hard
+               // error: it wouldn't help to try again, or to leave
+               // it for a different dispatcher process to attempt.
                errorString := err.Error()
                cq.logger.WithField("ContainerUUID", ctr.UUID).Warn("cancel container with no suitable instance type")
                go func() {