10008: Comment to explain known deficiencies.
authorTom Clegg <tom@curoverse.com>
Wed, 26 Oct 2016 15:13:10 +0000 (11:13 -0400)
committerTom Clegg <tom@curoverse.com>
Wed, 26 Oct 2016 15:13:10 +0000 (11:13 -0400)
services/fuse/tests/test_token_expiry.py

index 415f9bbc485289118d10881b956fb8408ba41a34..e082e525c5d8b910b8d58a0c32b5631c2027549c 100644 (file)
@@ -35,6 +35,11 @@ class TokenExpiryTest(IntegrationTest):
     @mock.patch('arvados.keep.KeepClient.get')
     @IntegrationTest.mount(argv=['--mount-by-id', 'zzz'])
     def test_refresh_old_manifest(self, mocked_get, mocked_time, mocked_open):
+        # This test (and associated behavior) is still not strong
+        # enough. We should ensure old tokens are never used even if
+        # blobSignatureTtl seconds elapse between open() and
+        # read(). See https://dev.arvados.org/issues/10008
+
         mocked_get.return_value = 'fake data'
         mocked_time.side_effect = self.fake_time
         mocked_open.side_effect = self.fake_open