#
# SPDX-License-Identifier: AGPL-3.0
-from __future__ import absolute_import
import arvados
import arvados.keep
import arvados_fuse as fuse
import logging
import multiprocessing
import os
-from . import run_test_server
import shutil
import signal
import subprocess
import time
import unittest
-logger = logging.getLogger('arvados.arv-mount')
+import pytest
+from . import run_test_server
from .integration_test import workerPool
+logger = logging.getLogger('arvados.arv-mount')
+
def make_block_cache(disk_cache):
if disk_cache:
disk_cache_dir = os.path.join(os.path.expanduser("~"), ".cache", "arvados", "keep")
llfuse.close()
def make_mount(self, root_class, **root_kwargs):
- enable_write = True
- if 'enable_write' in root_kwargs:
- enable_write = root_kwargs.pop('enable_write')
+ enable_write = root_kwargs.pop('enable_write', True)
self.operations = fuse.Operations(
- os.getuid(), os.getgid(),
+ os.getuid(),
+ os.getgid(),
api_client=self.api,
- enable_write=enable_write)
+ enable_write=enable_write,
+ )
self.operations.inodes.add_entry(root_class(
- llfuse.ROOT_INODE, self.operations.inodes, self.api, 0, enable_write, **root_kwargs))
+ llfuse.ROOT_INODE,
+ self.operations.inodes,
+ self.api,
+ 0,
+ enable_write,
+ root_kwargs.pop('filters', None),
+ **root_kwargs,
+ ))
llfuse.init(self.operations, self.mounttmp, [])
self.llfuse_thread = threading.Thread(None, lambda: self._llfuse_main())
self.llfuse_thread.daemon = True
self.operations.events.close(timeout=10)
subprocess.call(["fusermount", "-u", "-z", self.mounttmp])
t0 = time.time()
- self.llfuse_thread.join(timeout=10)
+ self.llfuse_thread.join(timeout=60)
if self.llfuse_thread.is_alive():
- logger.warning("MountTestBase.tearDown():"
- " llfuse thread still alive 10s after umount"
- " -- exiting with SIGKILL")
- os.kill(os.getpid(), signal.SIGKILL)
+ # pytest uses exit status 2 when test collection failed.
+ # A UnitTest failing in setup/teardown counts as a
+ # collection failure, so pytest will exit with status 2
+ # no matter what status you specify here. run-tests.sh
+ # looks for this status, so specify 2 just to keep
+ # everything as consistent as possible.
+ # TODO: If we refactor these tests so they're not built
+ # on unittest, consider using a dedicated, non-pytest
+ # exit code like TEMPFAIL.
+ pytest.exit("llfuse thread outlived test - aborting test suite to avoid deadlock", 2)
waited = time.time() - t0
if waited > 0.1:
logger.warning("MountTestBase.tearDown(): waited %f s for llfuse thread to end", waited)