1 class Arvados::V1::ApiClientAuthorizationsController < ApplicationController
2 accept_attribute_as_json :scopes, Array
3 before_filter :current_api_client_is_trusted
4 before_filter :admin_required, :only => :create_system_auth
5 skip_before_filter :render_404_if_no_object, :only => :create_system_auth
7 def self._create_system_auth_requires_parameters
9 api_client_id: {type: 'integer', required: false},
10 scopes: {type: 'array', required: false}
13 def create_system_auth
14 @object = ApiClientAuthorization.
15 new(user_id: system_user.id,
16 api_client_id: params[:api_client_id] || current_api_client.andand.id,
17 created_by_ip_address: remote_ip,
18 scopes: Oj.load(params[:scopes] || '["all"]'))
24 # Note: the user could specify a owner_uuid for a different user, which on
25 # the surface appears to be a security hole. However, the record will be
26 # rejected before being saved to the database by the ApiClientAuthorization
27 # model which enforces that user_id == current user or the user is an
30 if resource_attrs[:owner_uuid]
31 # The model has an owner_id attribute instead of owner_uuid, but
32 # we can't expect the client to know the local numeric ID. We
33 # translate UUID to numeric ID here.
34 resource_attrs[:user_id] =
35 User.where(uuid: resource_attrs.delete(:owner_uuid)).first.andand.id
36 elsif not resource_attrs[:user_id]
37 resource_attrs[:user_id] = current_user.id
39 resource_attrs[:api_client_id] = Thread.current[:api_client].id
46 ["#{table_name}.created_at desc"]
49 def find_objects_for_index
50 # Here we are deliberately less helpful about searching for client
51 # authorizations. We look up tokens belonging to the current user
52 # and filter by exact matches on uuid, api_token, and scopes.
55 wanted_scopes.concat(@filters.map { |attr, operator, operand|
56 ((attr == 'scopes') and (operator == '=')) ? operand : nil
58 @filters.select! { |attr, operator, operand|
59 operator == '=' && (attr == 'uuid' || attr == 'api_token')
63 wanted_scopes << @where['scopes']
64 @where.select! { |attr, val|
65 # "where":{"uuid":"zzzzz-zzzzz-zzzzzzzzzzzzzzz"} is OK but
66 # "where":{"api_client_id":1} is not supported
67 # "where":{"uuid":["contains","-"]} is not supported
68 # "where":{"uuid":["uuid1","uuid2","uuid3"]} is not supported
69 val.is_a?(String) && (attr == 'uuid' || attr == 'api_token')
72 @objects = model_class.
73 includes(:user, :api_client).
74 where('user_id=?', current_user.id)
76 wanted_scopes.compact.each do |scope_list|
77 sorted_scopes = scope_list.sort
78 @objects = @objects.select { |auth| auth.scopes.sort == sorted_scopes }
82 def find_object_by_uuid
83 uuid_param = params[:uuid] || params[:id]
84 if (uuid_param != current_api_client_authorization.andand.uuid and
85 not Thread.current[:api_client].andand.is_trusted)
92 @filters = [['uuid', '=', uuid_param]]
93 find_objects_for_index
94 @object = @objects.first
97 def current_api_client_is_trusted
98 if Thread.current[:api_client].andand.is_trusted
101 # A non-trusted client can do a search for its own token if it
102 # explicitly restricts the search to its own UUID or api_token.
103 # Any other kind of query must return 403, even if it matches only
104 # the current token, because that's currently how Workbench knows
105 # (after searching on scopes) the difference between "the token
106 # I'm using now *is* the only sharing token for this collection"
107 # (403) and "my token is trusted, and there is one sharing token
108 # for this collection" (200).
110 # The @filters test here also prevents a non-trusted token from
111 # filtering on its own scopes, and discovering whether any _other_
112 # equally scoped tokens exist (403=yes, 200=no).
113 if (@objects.andand.count == 1 and
114 @objects.first.uuid == current_api_client_authorization.andand.uuid and
115 (@filters.map(&:first) & %w(uuid api_token)).any?)
122 send_error('Forbidden: this API client cannot manipulate other clients\' access tokens.',