services/nodemanager/tests/test_computenode_dispatch.py

   1 #!/usr/bin/env python
   2
   3 from __future__ import absolute_import, print_function
   4
   5 import time
   6 import unittest
   7
   8 import arvados.errors as arverror
   9 import httplib2
  10 import mock
  11 import pykka
  12 import threading
  13
  14 from libcloud.common.exceptions import BaseHTTPError
  15
  16 import arvnodeman.computenode.dispatch as dispatch
  17 from arvnodeman.computenode.driver import BaseComputeNodeDriver
  18 from . import testutil
  19
  20 class ComputeNodeSetupActorTestCase(testutil.ActorTestMixin, unittest.TestCase):
  21     def make_mocks(self, arvados_effect=None):
  22         if arvados_effect is None:
  23             arvados_effect = [testutil.arvados_node_mock()]
  24         self.arvados_effect = arvados_effect
  25         self.timer = testutil.MockTimer()
  26         self.api_client = mock.MagicMock(name='api_client')
  27         self.api_client.nodes().create().execute.side_effect = arvados_effect
  28         self.api_client.nodes().update().execute.side_effect = arvados_effect
  29         self.cloud_client = mock.MagicMock(name='cloud_client')
  30         self.cloud_client.create_node.return_value = testutil.cloud_node_mock(1)
  31
  32     def make_actor(self, arv_node=None):
  33         if not hasattr(self, 'timer'):
  34             self.make_mocks(arvados_effect=[arv_node] if arv_node else None)
  35         self.setup_actor = dispatch.ComputeNodeSetupActor.start(
  36             self.timer, self.api_client, self.cloud_client,
  37             testutil.MockSize(1), arv_node).proxy()
  38
  39     def assert_node_properties_updated(self, uuid=None,
  40                                        size=testutil.MockSize(1)):
  41         self.api_client.nodes().update.assert_any_call(
  42             uuid=(uuid or self.arvados_effect[-1]['uuid']),
  43             body={
  44                 'properties': {
  45                     'cloud_node': {
  46                         'size': size.id,
  47                         'price': size.price}}})
  48
  49     def test_creation_without_arvados_node(self):
  50         self.make_actor()
  51         finished = threading.Event()
  52         self.setup_actor.subscribe(lambda _: finished.set())
  53         self.assertEqual(self.arvados_effect[-1],
  54                          self.setup_actor.arvados_node.get(self.TIMEOUT))
  55         assert(finished.wait(self.TIMEOUT))
  56         self.assertEqual(1, self.api_client.nodes().create().execute.call_count)
  57         self.assertEqual(1, self.api_client.nodes().update().execute.call_count)
  58         self.assert_node_properties_updated()
  59         self.assertEqual(self.cloud_client.create_node(),
  60                          self.setup_actor.cloud_node.get(self.TIMEOUT))
  61
  62     def test_creation_with_arvados_node(self):
  63         self.make_mocks(arvados_effect=[testutil.arvados_node_mock()]*2)
  64         self.make_actor(testutil.arvados_node_mock())
  65         finished = threading.Event()
  66         self.setup_actor.subscribe(lambda _: finished.set())
  67         self.assertEqual(self.arvados_effect[-1],
  68                          self.setup_actor.arvados_node.get(self.TIMEOUT))
  69         assert(finished.wait(self.TIMEOUT))
  70         self.assert_node_properties_updated()
  71         self.assertEqual(2, self.api_client.nodes().update().execute.call_count)
  72         self.assertEqual(self.cloud_client.create_node(),
  73                          self.setup_actor.cloud_node.get(self.TIMEOUT))
  74
  75     def test_failed_arvados_calls_retried(self):
  76         self.make_mocks([
  77                 arverror.ApiError(httplib2.Response({'status': '500'}), ""),
  78                 testutil.arvados_node_mock(),
  79                 ])
  80         self.make_actor()
  81         self.wait_for_assignment(self.setup_actor, 'arvados_node')
  82
  83     def test_failed_cloud_calls_retried(self):
  84         self.make_mocks()
  85         self.cloud_client.create_node.side_effect = [
  86             Exception("test cloud creation error"),
  87             self.cloud_client.create_node.return_value,
  88             ]
  89         self.make_actor()
  90         self.wait_for_assignment(self.setup_actor, 'cloud_node')
  91
  92     def test_basehttperror_retried(self):
  93         self.make_mocks()
  94         self.cloud_client.create_node.side_effect = [
  95             BaseHTTPError(500, "Try again"),
  96             self.cloud_client.create_node.return_value,
  97             ]
  98         self.make_actor()
  99         self.wait_for_assignment(self.setup_actor, 'cloud_node')
 100         self.assertEqual(1, self.cloud_client.post_create_node.call_count)
 101
 102     def test_instance_exceeded_not_retried(self):
 103         self.make_mocks()
 104         self.cloud_client.create_node.side_effect = [
 105             BaseHTTPError(400, "InstanceLimitExceeded"),
 106             self.cloud_client.create_node.return_value,
 107             ]
 108         self.make_actor()
 109         done = self.FUTURE_CLASS()
 110         self.setup_actor.subscribe(done.set)
 111         done.get(self.TIMEOUT)
 112         self.assertEqual(0, self.cloud_client.post_create_node.call_count)
 113
 114     def test_failed_post_create_retried(self):
 115         self.make_mocks()
 116         self.cloud_client.post_create_node.side_effect = [
 117             Exception("test cloud post-create error"), None]
 118         self.make_actor()
 119         done = self.FUTURE_CLASS()
 120         self.setup_actor.subscribe(done.set)
 121         done.get(self.TIMEOUT)
 122         self.assertEqual(2, self.cloud_client.post_create_node.call_count)
 123
 124     def test_stop_when_no_cloud_node(self):
 125         self.make_mocks(
 126             arverror.ApiError(httplib2.Response({'status': '500'}), ""))
 127         self.make_actor()
 128         self.assertTrue(
 129             self.setup_actor.stop_if_no_cloud_node().get(self.TIMEOUT))
 130         self.assertTrue(
 131             self.setup_actor.actor_ref.actor_stopped.wait(self.TIMEOUT))
 132
 133     def test_no_stop_when_cloud_node(self):
 134         self.make_actor()
 135         self.wait_for_assignment(self.setup_actor, 'cloud_node')
 136         self.assertFalse(
 137             self.setup_actor.stop_if_no_cloud_node().get(self.TIMEOUT))
 138         self.assertTrue(self.stop_proxy(self.setup_actor),
 139                         "actor was stopped by stop_if_no_cloud_node")
 140
 141     def test_subscribe(self):
 142         self.make_mocks(
 143             arverror.ApiError(httplib2.Response({'status': '500'}), ""))
 144         self.make_actor()
 145         subscriber = mock.Mock(name='subscriber_mock')
 146         self.setup_actor.subscribe(subscriber)
 147         retry_resp = [testutil.arvados_node_mock()]
 148         self.api_client.nodes().create().execute.side_effect = retry_resp
 149         self.api_client.nodes().update().execute.side_effect = retry_resp
 150         self.wait_for_assignment(self.setup_actor, 'cloud_node')
 151         self.assertEqual(self.setup_actor.actor_ref.actor_urn,
 152                          subscriber.call_args[0][0].actor_ref.actor_urn)
 153
 154     def test_late_subscribe(self):
 155         self.make_actor()
 156         subscriber = mock.Mock(name='subscriber_mock')
 157         self.wait_for_assignment(self.setup_actor, 'cloud_node')
 158         self.setup_actor.subscribe(subscriber).get(self.TIMEOUT)
 159         self.stop_proxy(self.setup_actor)
 160         self.assertEqual(self.setup_actor.actor_ref.actor_urn,
 161                          subscriber.call_args[0][0].actor_ref.actor_urn)
 162
 163
 164 class ComputeNodeShutdownActorMixin(testutil.ActorTestMixin):
 165     def make_mocks(self, cloud_node=None, arvados_node=None,
 166                    shutdown_open=True, node_broken=False):
 167         self.timer = testutil.MockTimer()
 168         self.shutdowns = testutil.MockShutdownTimer()
 169         self.shutdowns._set_state(shutdown_open, 300)
 170         self.cloud_client = mock.MagicMock(name='cloud_client')
 171         self.cloud_client.broken.return_value = node_broken
 172         self.arvados_client = mock.MagicMock(name='arvados_client')
 173         self.updates = mock.MagicMock(name='update_mock')
 174         if cloud_node is None:
 175             cloud_node = testutil.cloud_node_mock()
 176         self.cloud_node = cloud_node
 177         self.arvados_node = arvados_node
 178
 179     def make_actor(self, cancellable=True, start_time=None):
 180         if not hasattr(self, 'timer'):
 181             self.make_mocks()
 182         if start_time is None:
 183             start_time = time.time()
 184         monitor_actor = dispatch.ComputeNodeMonitorActor.start(
 185             self.cloud_node, start_time, self.shutdowns,
 186             testutil.cloud_node_fqdn, self.timer, self.updates, self.cloud_client,
 187             self.arvados_node)
 188         self.shutdown_actor = self.ACTOR_CLASS.start(
 189             self.timer, self.cloud_client, self.arvados_client, monitor_actor,
 190             cancellable).proxy()
 191         self.monitor_actor = monitor_actor.proxy()
 192
 193     def check_success_flag(self, expected, allow_msg_count=1):
 194         # allow_msg_count is the number of internal messages that may
 195         # need to be handled for shutdown to finish.
 196         for try_num in range(1 + allow_msg_count):
 197             last_flag = self.shutdown_actor.success.get(self.TIMEOUT)
 198             if last_flag is expected:
 199                 break
 200         else:
 201             self.fail("success flag {} is not {}".format(last_flag, expected))
 202
 203     def test_cancellable_shutdown(self, *mocks):
 204         self.make_mocks(shutdown_open=True, arvados_node=testutil.arvados_node_mock(crunch_worker_state="busy"))
 205         self.cloud_client.destroy_node.return_value = True
 206         self.make_actor(cancellable=True)
 207         self.check_success_flag(False)
 208         self.assertFalse(self.cloud_client.destroy_node.called)
 209
 210     def test_uncancellable_shutdown(self, *mocks):
 211         self.make_mocks(shutdown_open=True, arvados_node=testutil.arvados_node_mock(crunch_worker_state="busy"))
 212         self.cloud_client.destroy_node.return_value = True
 213         self.make_actor(cancellable=False)
 214         self.check_success_flag(True, 2)
 215         self.assertTrue(self.cloud_client.destroy_node.called)
 216
 217     def test_arvados_node_cleaned_after_shutdown(self, *mocks):
 218         cloud_node = testutil.cloud_node_mock(62)
 219         arv_node = testutil.arvados_node_mock(62)
 220         self.make_mocks(cloud_node, arv_node)
 221         self.make_actor()
 222         self.check_success_flag(True, 3)
 223         update_mock = self.arvados_client.nodes().update
 224         self.assertTrue(update_mock.called)
 225         update_kwargs = update_mock.call_args_list[0][1]
 226         self.assertEqual(arv_node['uuid'], update_kwargs.get('uuid'))
 227         self.assertIn('body', update_kwargs)
 228         for clear_key in ['slot_number', 'hostname', 'ip_address',
 229                           'first_ping_at', 'last_ping_at']:
 230             self.assertIn(clear_key, update_kwargs['body'])
 231             self.assertIsNone(update_kwargs['body'][clear_key])
 232         self.assertTrue(update_mock().execute.called)
 233
 234     def test_arvados_node_not_cleaned_after_shutdown_cancelled(self, *mocks):
 235         cloud_node = testutil.cloud_node_mock(61)
 236         arv_node = testutil.arvados_node_mock(61)
 237         self.make_mocks(cloud_node, arv_node, shutdown_open=False)
 238         self.cloud_client.destroy_node.return_value = False
 239         self.make_actor(cancellable=True)
 240         self.shutdown_actor.cancel_shutdown("test")
 241         self.check_success_flag(False, 2)
 242         self.assertFalse(self.arvados_client.nodes().update.called)
 243
 244
 245 class ComputeNodeShutdownActorTestCase(ComputeNodeShutdownActorMixin,
 246                                        unittest.TestCase):
 247     ACTOR_CLASS = dispatch.ComputeNodeShutdownActor
 248
 249     def test_easy_shutdown(self):
 250         self.make_actor(start_time=0)
 251         self.check_success_flag(True)
 252         self.assertTrue(self.cloud_client.destroy_node.called)
 253
 254     def test_shutdown_cancelled_when_destroy_node_fails(self):
 255         self.make_mocks(node_broken=True)
 256         self.cloud_client.destroy_node.return_value = False
 257         self.make_actor(start_time=0)
 258         self.check_success_flag(False, 2)
 259         self.assertEqual(1, self.cloud_client.destroy_node.call_count)
 260         self.assertEqual(self.ACTOR_CLASS.DESTROY_FAILED,
 261                          self.shutdown_actor.cancel_reason.get(self.TIMEOUT))
 262
 263     def test_late_subscribe(self):
 264         self.make_actor()
 265         subscriber = mock.Mock(name='subscriber_mock')
 266         self.shutdown_actor.subscribe(subscriber).get(self.TIMEOUT)
 267         self.stop_proxy(self.shutdown_actor)
 268         self.assertTrue(subscriber.called)
 269         self.assertEqual(self.shutdown_actor.actor_ref.actor_urn,
 270                          subscriber.call_args[0][0].actor_ref.actor_urn)
 271
 272
 273 class ComputeNodeUpdateActorTestCase(testutil.ActorTestMixin,
 274                                      unittest.TestCase):
 275     ACTOR_CLASS = dispatch.ComputeNodeUpdateActor
 276
 277     def make_actor(self):
 278         self.driver = mock.MagicMock(name='driver_mock')
 279         self.timer = mock.MagicMock(name='timer_mock')
 280         self.updater = self.ACTOR_CLASS.start(self.driver, self.timer).proxy()
 281
 282     def test_node_sync(self, *args):
 283         self.make_actor()
 284         cloud_node = testutil.cloud_node_mock()
 285         arv_node = testutil.arvados_node_mock()
 286         self.updater.sync_node(cloud_node, arv_node).get(self.TIMEOUT)
 287         self.driver().sync_node.assert_called_with(cloud_node, arv_node)
 288
 289     @testutil.no_sleep
 290     def test_node_sync_error(self, *args):
 291         self.make_actor()
 292         cloud_node = testutil.cloud_node_mock()
 293         arv_node = testutil.arvados_node_mock()
 294         self.driver().sync_node.side_effect = (IOError, Exception, True)
 295         self.updater.sync_node(cloud_node, arv_node).get(self.TIMEOUT)
 296         self.updater.sync_node(cloud_node, arv_node).get(self.TIMEOUT)
 297         self.updater.sync_node(cloud_node, arv_node).get(self.TIMEOUT)
 298         self.driver().sync_node.assert_called_with(cloud_node, arv_node)
 299
 300 class ComputeNodeMonitorActorTestCase(testutil.ActorTestMixin,
 301                                       unittest.TestCase):
 302     def make_mocks(self, node_num):
 303         self.shutdowns = testutil.MockShutdownTimer()
 304         self.shutdowns._set_state(False, 300)
 305         self.timer = mock.MagicMock(name='timer_mock')
 306         self.updates = mock.MagicMock(name='update_mock')
 307         self.cloud_mock = testutil.cloud_node_mock(node_num)
 308         self.subscriber = mock.Mock(name='subscriber_mock')
 309         self.cloud_client = mock.MagicMock(name='cloud_client')
 310         self.cloud_client.broken.return_value = False
 311
 312     def make_actor(self, node_num=1, arv_node=None, start_time=None):
 313         if not hasattr(self, 'cloud_mock'):
 314             self.make_mocks(node_num)
 315         if start_time is None:
 316             start_time = time.time()
 317         self.node_actor = dispatch.ComputeNodeMonitorActor.start(
 318             self.cloud_mock, start_time, self.shutdowns,
 319             testutil.cloud_node_fqdn, self.timer, self.updates, self.cloud_client,
 320             arv_node, boot_fail_after=300).proxy()
 321         self.node_actor.subscribe(self.subscriber).get(self.TIMEOUT)
 322
 323     def node_state(self, *states):
 324         return self.node_actor.in_state(*states).get(self.TIMEOUT)
 325
 326     def test_in_state_when_unpaired(self):
 327         self.make_actor()
 328         self.assertTrue(self.node_state('unpaired'))
 329
 330     def test_in_state_when_pairing_stale(self):
 331         self.make_actor(arv_node=testutil.arvados_node_mock(
 332                 job_uuid=None, age=90000))
 333         self.assertTrue(self.node_state('down'))
 334
 335     def test_in_state_when_no_state_available(self):
 336         self.make_actor(arv_node=testutil.arvados_node_mock(
 337                 crunch_worker_state=None))
 338         print(self.node_actor.get_state().get())
 339         self.assertTrue(self.node_state('idle'))
 340
 341     def test_in_state_when_no_state_available_old(self):
 342         self.make_actor(arv_node=testutil.arvados_node_mock(
 343                 crunch_worker_state=None, age=90000))
 344         print(self.node_actor.get_state().get())
 345         self.assertTrue(self.node_state('down'))
 346
 347     def test_in_idle_state(self):
 348         self.make_actor(2, arv_node=testutil.arvados_node_mock(job_uuid=None))
 349         self.assertTrue(self.node_state('idle'))
 350         self.assertFalse(self.node_state('busy'))
 351         self.assertTrue(self.node_state('idle', 'busy'))
 352
 353     def test_in_busy_state(self):
 354         self.make_actor(3, arv_node=testutil.arvados_node_mock(job_uuid=True))
 355         self.assertFalse(self.node_state('idle'))
 356         self.assertTrue(self.node_state('busy'))
 357         self.assertTrue(self.node_state('idle', 'busy'))
 358
 359     def test_init_shutdown_scheduling(self):
 360         self.make_actor()
 361         self.assertTrue(self.timer.schedule.called)
 362         self.assertEqual(300, self.timer.schedule.call_args[0][0])
 363
 364     def test_shutdown_window_close_scheduling(self):
 365         self.make_actor()
 366         self.shutdowns._set_state(False, 600)
 367         self.timer.schedule.reset_mock()
 368         self.node_actor.consider_shutdown().get(self.TIMEOUT)
 369         self.stop_proxy(self.node_actor)
 370         self.assertTrue(self.timer.schedule.called)
 371         self.assertEqual(600, self.timer.schedule.call_args[0][0])
 372         self.assertFalse(self.subscriber.called)
 373
 374     def test_shutdown_subscription(self):
 375         self.make_actor(start_time=0)
 376         self.shutdowns._set_state(True, 600)
 377         self.node_actor.consider_shutdown().get(self.TIMEOUT)
 378         self.assertTrue(self.subscriber.called)
 379         self.assertEqual(self.node_actor.actor_ref.actor_urn,
 380                          self.subscriber.call_args[0][0].actor_ref.actor_urn)
 381
 382     def test_no_shutdown_booting(self):
 383         self.make_actor()
 384         self.shutdowns._set_state(True, 600)
 385         self.assertEquals(self.node_actor.shutdown_eligible().get(self.TIMEOUT),
 386                           (False, "node state is ('unpaired', 'open', 'boot wait', 'idle exceeded')"))
 387
 388     def test_shutdown_without_arvados_node(self):
 389         self.make_actor(start_time=0)
 390         self.shutdowns._set_state(True, 600)
 391         self.assertEquals((True, "node state is ('unpaired', 'open', 'boot exceeded', 'idle exceeded')"),
 392                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
 393
 394     def test_shutdown_missing(self):
 395         arv_node = testutil.arvados_node_mock(10, job_uuid=None,
 396                                               crunch_worker_state="down",
 397                                               last_ping_at='1970-01-01T01:02:03.04050607Z')
 398         self.make_actor(10, arv_node)
 399         self.shutdowns._set_state(True, 600)
 400         self.assertEquals((True, "node state is ('down', 'open', 'boot wait', 'idle exceeded')"),
 401                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
 402
 403     def test_shutdown_running_broken(self):
 404         arv_node = testutil.arvados_node_mock(12, job_uuid=None,
 405                                               crunch_worker_state="down")
 406         self.make_actor(12, arv_node)
 407         self.shutdowns._set_state(True, 600)
 408         self.cloud_client.broken.return_value = True
 409         self.assertEquals((True, "node state is ('down', 'open', 'boot wait', 'idle exceeded')"),
 410                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
 411
 412     def test_shutdown_missing_broken(self):
 413         arv_node = testutil.arvados_node_mock(11, job_uuid=None,
 414                                               crunch_worker_state="down",
 415                                               last_ping_at='1970-01-01T01:02:03.04050607Z')
 416         self.make_actor(11, arv_node)
 417         self.shutdowns._set_state(True, 600)
 418         self.cloud_client.broken.return_value = True
 419         self.assertEquals(self.node_actor.shutdown_eligible().get(self.TIMEOUT), (True, "node state is ('down', 'open', 'boot wait', 'idle exceeded')"))
 420
 421     def test_no_shutdown_when_window_closed(self):
 422         self.make_actor(3, testutil.arvados_node_mock(3, job_uuid=None))
 423         self.assertEquals((False, "node state is ('idle', 'closed', 'boot wait', 'idle exceeded')"),
 424                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
 425
 426     def test_no_shutdown_when_node_running_job(self):
 427         self.make_actor(4, testutil.arvados_node_mock(4, job_uuid=True))
 428         self.shutdowns._set_state(True, 600)
 429         self.assertEquals((False, "node state is ('busy', 'open', 'boot wait', 'idle exceeded')"),
 430                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
 431
 432     def test_shutdown_when_node_state_unknown(self):
 433         self.make_actor(5, testutil.arvados_node_mock(
 434             5, crunch_worker_state=None))
 435         self.shutdowns._set_state(True, 600)
 436         self.assertEquals((True, "node state is ('idle', 'open', 'boot wait', 'idle exceeded')"),
 437                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
 438
 439     def test_no_shutdown_when_node_state_stale(self):
 440         self.make_actor(6, testutil.arvados_node_mock(6, age=90000))
 441         self.shutdowns._set_state(True, 600)
 442         self.assertEquals((False, "node state is stale"),
 443                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
 444
 445     def test_arvados_node_match(self):
 446         self.make_actor(2)
 447         arv_node = testutil.arvados_node_mock(
 448             2, hostname='compute-two.zzzzz.arvadosapi.com')
 449         self.cloud_client.node_id.return_value = '2'
 450         pair_id = self.node_actor.offer_arvados_pair(arv_node).get(self.TIMEOUT)
 451         self.assertEqual(self.cloud_mock.id, pair_id)
 452         self.stop_proxy(self.node_actor)
 453         self.updates.sync_node.assert_called_with(self.cloud_mock, arv_node)
 454
 455     def test_arvados_node_mismatch(self):
 456         self.make_actor(3)
 457         arv_node = testutil.arvados_node_mock(1)
 458         self.assertIsNone(
 459             self.node_actor.offer_arvados_pair(arv_node).get(self.TIMEOUT))
 460
 461     def test_arvados_node_mismatch_first_ping_too_early(self):
 462         self.make_actor(4)
 463         arv_node = testutil.arvados_node_mock(
 464             4, first_ping_at='1971-03-02T14:15:16.1717282Z')
 465         self.assertIsNone(
 466             self.node_actor.offer_arvados_pair(arv_node).get(self.TIMEOUT))
 467
 468     def test_update_cloud_node(self):
 469         self.make_actor(1)
 470         self.make_mocks(2)
 471         self.cloud_mock.id = '1'
 472         self.node_actor.update_cloud_node(self.cloud_mock)
 473         current_cloud = self.node_actor.cloud_node.get(self.TIMEOUT)
 474         self.assertEqual([testutil.ip_address_mock(2)],
 475                          current_cloud.private_ips)
 476
 477     def test_missing_cloud_node_update(self):
 478         self.make_actor(1)
 479         self.node_actor.update_cloud_node(None)
 480         current_cloud = self.node_actor.cloud_node.get(self.TIMEOUT)
 481         self.assertEqual([testutil.ip_address_mock(1)],
 482                          current_cloud.private_ips)
 483
 484     def test_update_arvados_node(self):
 485         self.make_actor(3)
 486         job_uuid = 'zzzzz-jjjjj-updatejobnode00'
 487         new_arvados = testutil.arvados_node_mock(3, job_uuid)
 488         self.node_actor.update_arvados_node(new_arvados)
 489         current_arvados = self.node_actor.arvados_node.get(self.TIMEOUT)
 490         self.assertEqual(job_uuid, current_arvados['job_uuid'])
 491
 492     def test_missing_arvados_node_update(self):
 493         self.make_actor(4, testutil.arvados_node_mock(4))
 494         self.node_actor.update_arvados_node(None)
 495         current_arvados = self.node_actor.arvados_node.get(self.TIMEOUT)
 496         self.assertEqual(testutil.ip_address_mock(4),
 497                          current_arvados['ip_address'])
 498
 499     def test_update_arvados_node_syncs_when_fqdn_mismatch(self):
 500         self.make_mocks(5)
 501         self.cloud_mock.extra['testname'] = 'cloudfqdn.zzzzz.arvadosapi.com'
 502         self.make_actor()
 503         arv_node = testutil.arvados_node_mock(5)
 504         self.node_actor.update_arvados_node(arv_node).get(self.TIMEOUT)
 505         self.assertEqual(1, self.updates.sync_node.call_count)
 506
 507     def test_update_arvados_node_skips_sync_when_fqdn_match(self):
 508         self.make_mocks(6)
 509         arv_node = testutil.arvados_node_mock(6)
 510         self.cloud_mock.extra['testname'] ='{n[hostname]}.{n[domain]}'.format(
 511             n=arv_node)
 512         self.make_actor()
 513         self.node_actor.update_arvados_node(arv_node).get(self.TIMEOUT)
 514         self.assertEqual(0, self.updates.sync_node.call_count)