3 // Dispatcher service for Crunch that submits containers to the slurm queue.
8 "git.curoverse.com/arvados.git/sdk/go/arvados"
9 "git.curoverse.com/arvados.git/sdk/go/arvadosclient"
10 "git.curoverse.com/arvados.git/sdk/go/config"
11 "git.curoverse.com/arvados.git/sdk/go/dispatch"
12 "github.com/coreos/go-systemd/daemon"
23 // Config used by crunch-dispatch-slurm
27 SbatchArguments []string
28 PollPeriod arvados.Duration
30 // crunch-run command to invoke. The container UUID will be
31 // appended. If nil, []string{"crunch-run"} will be used.
33 // Example: []string{"crunch-run", "--cgroup-parent-subsystem=memory"}
34 CrunchRunCommand []string
49 const defaultConfigPath = "/etc/arvados/crunch-dispatch-slurm/crunch-dispatch-slurm.yml"
52 flags := flag.NewFlagSet("crunch-dispatch-slurm", flag.ExitOnError)
53 flags.Usage = func() { usage(flags) }
55 configPath := flags.String(
58 "`path` to JSON or YAML configuration file")
60 // Parse args; omit the first arg which is the command name
61 flags.Parse(os.Args[1:])
63 err := readConfig(&theConfig, *configPath)
68 if theConfig.CrunchRunCommand == nil {
69 theConfig.CrunchRunCommand = []string{"crunch-run"}
72 if theConfig.PollPeriod == 0 {
73 theConfig.PollPeriod = arvados.Duration(10 * time.Second)
76 if theConfig.Client.APIHost != "" || theConfig.Client.AuthToken != "" {
77 // Copy real configs into env vars so [a]
78 // MakeArvadosClient() uses them, and [b] they get
79 // propagated to crunch-run via SLURM.
80 os.Setenv("ARVADOS_API_HOST", theConfig.Client.APIHost)
81 os.Setenv("ARVADOS_API_TOKEN", theConfig.Client.AuthToken)
82 os.Setenv("ARVADOS_API_HOST_INSECURE", "")
83 if theConfig.Client.Insecure {
84 os.Setenv("ARVADOS_API_HOST_INSECURE", "1")
86 os.Setenv("ARVADOS_KEEP_SERVICES", strings.Join(theConfig.Client.KeepServiceURIs, " "))
87 os.Setenv("ARVADOS_EXTERNAL_CLIENT", "")
89 log.Printf("warning: Client credentials missing from config, so falling back on environment variables (deprecated).")
92 arv, err := arvadosclient.MakeArvadosClient()
94 log.Printf("Error making Arvados client: %v", err)
99 squeueUpdater.StartMonitor(time.Duration(theConfig.PollPeriod))
100 defer squeueUpdater.Done()
102 dispatcher := dispatch.Dispatcher{
105 PollInterval: time.Duration(theConfig.PollPeriod),
108 if _, err := daemon.SdNotify(false, "READY=1"); err != nil {
109 log.Printf("Error notifying init daemon: %v", err)
112 return dispatcher.Run()
116 func sbatchFunc(container arvados.Container) *exec.Cmd {
117 memPerCPU := math.Ceil(float64(container.RuntimeConstraints.RAM) / (float64(container.RuntimeConstraints.VCPUs) * 1048576))
119 var sbatchArgs []string
120 sbatchArgs = append(sbatchArgs, "--share")
121 sbatchArgs = append(sbatchArgs, theConfig.SbatchArguments...)
122 sbatchArgs = append(sbatchArgs, fmt.Sprintf("--job-name=%s", container.UUID))
123 sbatchArgs = append(sbatchArgs, fmt.Sprintf("--mem-per-cpu=%d", int(memPerCPU)))
124 sbatchArgs = append(sbatchArgs, fmt.Sprintf("--cpus-per-task=%d", container.RuntimeConstraints.VCPUs))
125 if container.SchedulingParameters.Partitions != nil {
126 sbatchArgs = append(sbatchArgs, fmt.Sprintf("--partition=%s", strings.Join(container.SchedulingParameters.Partitions, ",")))
129 return exec.Command("sbatch", sbatchArgs...)
133 func scancelFunc(container arvados.Container) *exec.Cmd {
134 return exec.Command("scancel", "--name="+container.UUID)
137 // Wrap these so that they can be overridden by tests
138 var sbatchCmd = sbatchFunc
139 var scancelCmd = scancelFunc
141 // Submit job to slurm using sbatch.
142 func submit(dispatcher *dispatch.Dispatcher,
143 container arvados.Container, crunchRunCommand []string) (submitErr error) {
145 // If we didn't get as far as submitting a slurm job,
146 // unlock the container and return it to the queue.
147 if submitErr == nil {
148 // OK, no cleanup needed
151 err := dispatcher.Unlock(container.UUID)
153 log.Printf("Error unlocking container %s: %v", container.UUID, err)
157 // Create the command and attach to stdin/stdout
158 cmd := sbatchCmd(container)
159 stdinWriter, stdinerr := cmd.StdinPipe()
161 submitErr = fmt.Errorf("Error creating stdin pipe %v: %q", container.UUID, stdinerr)
165 stdoutReader, stdoutErr := cmd.StdoutPipe()
166 if stdoutErr != nil {
167 submitErr = fmt.Errorf("Error creating stdout pipe %v: %q", container.UUID, stdoutErr)
171 stderrReader, stderrErr := cmd.StderrPipe()
172 if stderrErr != nil {
173 submitErr = fmt.Errorf("Error creating stderr pipe %v: %q", container.UUID, stderrErr)
177 // Mutex between squeue sync and running sbatch or scancel.
178 squeueUpdater.SlurmLock.Lock()
179 defer squeueUpdater.SlurmLock.Unlock()
181 log.Printf("sbatch starting: %+q", cmd.Args)
184 submitErr = fmt.Errorf("Error starting sbatch: %v", err)
188 stdoutChan := make(chan []byte)
190 b, _ := ioutil.ReadAll(stdoutReader)
196 stderrChan := make(chan []byte)
198 b, _ := ioutil.ReadAll(stderrReader)
204 // Send a tiny script on stdin to execute the crunch-run command
205 // slurm actually enforces that this must be a #! script
206 io.WriteString(stdinWriter, execScript(append(crunchRunCommand, container.UUID)))
209 stdoutMsg := <-stdoutChan
210 stderrmsg := <-stderrChan
215 submitErr = fmt.Errorf("Container submission failed: %v: %v (stderr: %q)", cmd.Args, err, stderrmsg)
219 log.Printf("sbatch succeeded: %s", strings.TrimSpace(string(stdoutMsg)))
223 // If the container is marked as Locked, check if it is already in the slurm
224 // queue. If not, submit it.
226 // If the container is marked as Running, check if it is in the slurm queue.
227 // If not, mark it as Cancelled.
228 func monitorSubmitOrCancel(dispatcher *dispatch.Dispatcher, container arvados.Container, monitorDone *bool) {
231 if squeueUpdater.CheckSqueue(container.UUID) {
232 // Found in the queue, so continue monitoring
234 } else if container.State == dispatch.Locked && !submitted {
235 // Not in queue but in Locked state and we haven't
236 // submitted it yet, so submit it.
238 log.Printf("About to submit queued container %v", container.UUID)
240 if err := submit(dispatcher, container, theConfig.CrunchRunCommand); err != nil {
241 log.Printf("Error submitting container %s to slurm: %v",
243 // maybe sbatch is broken, put it back to queued
244 dispatcher.Unlock(container.UUID)
248 // Not in queue and we are not going to submit it.
249 // Refresh the container state. If it is
250 // Complete/Cancelled, do nothing, if it is Locked then
251 // release it back to the Queue, if it is Running then
252 // clean up the record.
254 var con arvados.Container
255 err := dispatcher.Arv.Get("containers", container.UUID, nil, &con)
257 log.Printf("Error getting final container state: %v", err)
261 case dispatch.Locked:
262 log.Printf("Container %s in state %v but missing from slurm queue, changing to %v.",
263 container.UUID, con.State, dispatch.Queued)
264 dispatcher.Unlock(container.UUID)
265 case dispatch.Running:
266 st := dispatch.Cancelled
267 log.Printf("Container %s in state %v but missing from slurm queue, changing to %v.",
268 container.UUID, con.State, st)
269 dispatcher.UpdateState(container.UUID, st)
271 // Container state is Queued, Complete or Cancelled so stop monitoring it.
278 // Run or monitor a container.
280 // Monitor status updates. If the priority changes to zero, cancel the
281 // container using scancel.
282 func run(dispatcher *dispatch.Dispatcher,
283 container arvados.Container,
284 status chan arvados.Container) {
286 log.Printf("Monitoring container %v started", container.UUID)
287 defer log.Printf("Monitoring container %v finished", container.UUID)
290 go monitorSubmitOrCancel(dispatcher, container, &monitorDone)
292 for container = range status {
293 if container.State == dispatch.Locked || container.State == dispatch.Running {
294 if container.Priority == 0 {
295 log.Printf("Canceling container %s", container.UUID)
297 // Mutex between squeue sync and running sbatch or scancel.
298 squeueUpdater.SlurmLock.Lock()
299 cmd := scancelCmd(container)
300 msg, err := cmd.CombinedOutput()
301 squeueUpdater.SlurmLock.Unlock()
304 log.Printf("Error stopping container %s with %v %v: %v %v",
305 container.UUID, cmd.Path, cmd.Args, err, string(msg))
306 if squeueUpdater.CheckSqueue(container.UUID) {
307 log.Printf("Container %s is still in squeue after scancel.",
313 err = dispatcher.UpdateState(container.UUID, dispatch.Cancelled)
320 func readConfig(dst interface{}, path string) error {
321 err := config.LoadFile(dst, path)
322 if err != nil && os.IsNotExist(err) && path == defaultConfigPath {
323 log.Printf("Config not specified. Continue with default configuration.")