services/crunch-run/crunchrun_test.go

   1 // Copyright (C) The Arvados Authors. All rights reserved.
   2 //
   3 // SPDX-License-Identifier: AGPL-3.0
   4
   5 package main
   6
   7 import (
   8         "bufio"
   9         "bytes"
  10         "crypto/md5"
  11         "encoding/json"
  12         "errors"
  13         "fmt"
  14         "io"
  15         "io/ioutil"
  16         "net"
  17         "os"
  18         "os/exec"
  19         "runtime/pprof"
  20         "sort"
  21         "strings"
  22         "sync"
  23         "syscall"
  24         "testing"
  25         "time"
  26
  27         "git.curoverse.com/arvados.git/sdk/go/arvados"
  28         "git.curoverse.com/arvados.git/sdk/go/arvadosclient"
  29         "git.curoverse.com/arvados.git/sdk/go/arvadostest"
  30         "git.curoverse.com/arvados.git/sdk/go/manifest"
  31         "golang.org/x/net/context"
  32
  33         dockertypes "github.com/docker/docker/api/types"
  34         dockercontainer "github.com/docker/docker/api/types/container"
  35         dockernetwork "github.com/docker/docker/api/types/network"
  36         . "gopkg.in/check.v1"
  37 )
  38
  39 // Gocheck boilerplate
  40 func TestCrunchExec(t *testing.T) {
  41         TestingT(t)
  42 }
  43
  44 // Gocheck boilerplate
  45 var _ = Suite(&TestSuite{})
  46
  47 type TestSuite struct {
  48         client *arvados.Client
  49         docker *TestDockerClient
  50         runner *ContainerRunner
  51 }
  52
  53 func (s *TestSuite) SetUpTest(c *C) {
  54         s.client = arvados.NewClientFromEnv()
  55         s.docker = NewTestDockerClient()
  56 }
  57
  58 type ArvTestClient struct {
  59         Total   int64
  60         Calls   int
  61         Content []arvadosclient.Dict
  62         arvados.Container
  63         secretMounts []byte
  64         Logs         map[string]*bytes.Buffer
  65         sync.Mutex
  66         WasSetRunning bool
  67         callraw       bool
  68 }
  69
  70 type KeepTestClient struct {
  71         Called  bool
  72         Content []byte
  73 }
  74
  75 var hwManifest = ". 82ab40c24fc8df01798e57ba66795bb1+841216+Aa124ac75e5168396c73c0a18eda641a4f41791c0@569fa8c3 0:841216:9c31ee32b3d15268a0754e8edc74d4f815ee014b693bc5109058e431dd5caea7.tar\n"
  76 var hwPDH = "a45557269dcb65a6b78f9ac061c0850b+120"
  77 var hwImageId = "9c31ee32b3d15268a0754e8edc74d4f815ee014b693bc5109058e431dd5caea7"
  78
  79 var otherManifest = ". 68a84f561b1d1708c6baff5e019a9ab3+46+Ae5d0af96944a3690becb1decdf60cc1c937f556d@5693216f 0:46:md5sum.txt\n"
  80 var otherPDH = "a3e8f74c6f101eae01fa08bfb4e49b3a+54"
  81
  82 var normalizedManifestWithSubdirs = `. 3e426d509afffb85e06c4c96a7c15e91+27+Aa124ac75e5168396c73c0abcdefgh11234567890@569fa8c3 0:9:file1_in_main.txt 9:18:file2_in_main.txt 0:27:zzzzz-8i9sb-bcdefghijkdhvnk.log.txt
  83 ./subdir1 3e426d509afffb85e06c4c96a7c15e91+27+Aa124ac75e5168396cabcdefghij6419876543234@569fa8c4 0:9:file1_in_subdir1.txt 9:18:file2_in_subdir1.txt
  84 ./subdir1/subdir2 3e426d509afffb85e06c4c96a7c15e91+27+Aa124ac75e5168396c73c0bcdefghijk544332211@569fa8c5 0:9:file1_in_subdir2.txt 9:18:file2_in_subdir2.txt
  85 `
  86
  87 var normalizedWithSubdirsPDH = "a0def87f80dd594d4675809e83bd4f15+367"
  88
  89 var denormalizedManifestWithSubdirs = ". 3e426d509afffb85e06c4c96a7c15e91+27+Aa124ac75e5168396c73c0abcdefgh11234567890@569fa8c3 0:9:file1_in_main.txt 9:18:file2_in_main.txt 0:27:zzzzz-8i9sb-bcdefghijkdhvnk.log.txt 0:10:subdir1/file1_in_subdir1.txt 10:17:subdir1/file2_in_subdir1.txt\n"
  90 var denormalizedWithSubdirsPDH = "b0def87f80dd594d4675809e83bd4f15+367"
  91
  92 var fakeAuthUUID = "zzzzz-gj3su-55pqoyepgi2glem"
  93 var fakeAuthToken = "a3ltuwzqcu2u4sc0q7yhpc2w7s00fdcqecg5d6e0u3pfohmbjt"
  94
  95 type TestDockerClient struct {
  96         imageLoaded string
  97         logReader   io.ReadCloser
  98         logWriter   io.WriteCloser
  99         fn          func(t *TestDockerClient)
 100         exitCode    int
 101         stop        chan bool
 102         cwd         string
 103         env         []string
 104         api         *ArvTestClient
 105         realTemp    string
 106         calledWait  bool
 107         ctrExited   bool
 108 }
 109
 110 func NewTestDockerClient() *TestDockerClient {
 111         t := &TestDockerClient{}
 112         t.logReader, t.logWriter = io.Pipe()
 113         t.stop = make(chan bool, 1)
 114         t.cwd = "/"
 115         return t
 116 }
 117
 118 type MockConn struct {
 119         net.Conn
 120 }
 121
 122 func (m *MockConn) Write(b []byte) (int, error) {
 123         return len(b), nil
 124 }
 125
 126 func NewMockConn() *MockConn {
 127         c := &MockConn{}
 128         return c
 129 }
 130
 131 func (t *TestDockerClient) ContainerAttach(ctx context.Context, container string, options dockertypes.ContainerAttachOptions) (dockertypes.HijackedResponse, error) {
 132         return dockertypes.HijackedResponse{Conn: NewMockConn(), Reader: bufio.NewReader(t.logReader)}, nil
 133 }
 134
 135 func (t *TestDockerClient) ContainerCreate(ctx context.Context, config *dockercontainer.Config, hostConfig *dockercontainer.HostConfig, networkingConfig *dockernetwork.NetworkingConfig, containerName string) (dockercontainer.ContainerCreateCreatedBody, error) {
 136         if config.WorkingDir != "" {
 137                 t.cwd = config.WorkingDir
 138         }
 139         t.env = config.Env
 140         return dockercontainer.ContainerCreateCreatedBody{ID: "abcde"}, nil
 141 }
 142
 143 func (t *TestDockerClient) ContainerStart(ctx context.Context, container string, options dockertypes.ContainerStartOptions) error {
 144         if t.exitCode == 3 {
 145                 return errors.New(`Error response from daemon: oci runtime error: container_linux.go:247: starting container process caused "process_linux.go:359: container init caused \"rootfs_linux.go:54: mounting \\\"/tmp/keep453790790/by_id/99999999999999999999999999999999+99999/myGenome\\\" to rootfs \\\"/tmp/docker/overlay2/9999999999999999999999999999999999999999999999999999999999999999/merged\\\" at \\\"/tmp/docker/overlay2/9999999999999999999999999999999999999999999999999999999999999999/merged/keep/99999999999999999999999999999999+99999/myGenome\\\" caused \\\"no such file or directory\\\"\""`)
 146         }
 147         if t.exitCode == 4 {
 148                 return errors.New(`panic: standard_init_linux.go:175: exec user process caused "no such file or directory"`)
 149         }
 150         if t.exitCode == 5 {
 151                 return errors.New(`Error response from daemon: Cannot start container 41f26cbc43bcc1280f4323efb1830a394ba8660c9d1c2b564ba42bf7f7694845: [8] System error: no such file or directory`)
 152         }
 153         if t.exitCode == 6 {
 154                 return errors.New(`Error response from daemon: Cannot start container 58099cd76c834f3dc2a4fb76c8028f049ae6d4fdf0ec373e1f2cfea030670c2d: [8] System error: exec: "foobar": executable file not found in $PATH`)
 155         }
 156
 157         if container == "abcde" {
 158                 // t.fn gets executed in ContainerWait
 159                 return nil
 160         } else {
 161                 return errors.New("Invalid container id")
 162         }
 163 }
 164
 165 func (t *TestDockerClient) ContainerRemove(ctx context.Context, container string, options dockertypes.ContainerRemoveOptions) error {
 166         t.stop <- true
 167         return nil
 168 }
 169
 170 func (t *TestDockerClient) ContainerWait(ctx context.Context, container string, condition dockercontainer.WaitCondition) (<-chan dockercontainer.ContainerWaitOKBody, <-chan error) {
 171         t.calledWait = true
 172         body := make(chan dockercontainer.ContainerWaitOKBody, 1)
 173         err := make(chan error)
 174         go func() {
 175                 t.fn(t)
 176                 body <- dockercontainer.ContainerWaitOKBody{StatusCode: int64(t.exitCode)}
 177         }()
 178         return body, err
 179 }
 180
 181 func (t *TestDockerClient) ContainerInspect(ctx context.Context, id string) (c dockertypes.ContainerJSON, err error) {
 182         c.ContainerJSONBase = &dockertypes.ContainerJSONBase{}
 183         c.ID = "abcde"
 184         if t.ctrExited {
 185                 c.State = &dockertypes.ContainerState{Status: "exited", Dead: true}
 186         } else {
 187                 c.State = &dockertypes.ContainerState{Status: "running", Pid: 1234, Running: true}
 188         }
 189         return
 190 }
 191
 192 func (t *TestDockerClient) ImageInspectWithRaw(ctx context.Context, image string) (dockertypes.ImageInspect, []byte, error) {
 193         if t.exitCode == 2 {
 194                 return dockertypes.ImageInspect{}, nil, fmt.Errorf("Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?")
 195         }
 196
 197         if t.imageLoaded == image {
 198                 return dockertypes.ImageInspect{}, nil, nil
 199         } else {
 200                 return dockertypes.ImageInspect{}, nil, errors.New("")
 201         }
 202 }
 203
 204 func (t *TestDockerClient) ImageLoad(ctx context.Context, input io.Reader, quiet bool) (dockertypes.ImageLoadResponse, error) {
 205         if t.exitCode == 2 {
 206                 return dockertypes.ImageLoadResponse{}, fmt.Errorf("Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?")
 207         }
 208         _, err := io.Copy(ioutil.Discard, input)
 209         if err != nil {
 210                 return dockertypes.ImageLoadResponse{}, err
 211         } else {
 212                 t.imageLoaded = hwImageId
 213                 return dockertypes.ImageLoadResponse{Body: ioutil.NopCloser(input)}, nil
 214         }
 215 }
 216
 217 func (*TestDockerClient) ImageRemove(ctx context.Context, image string, options dockertypes.ImageRemoveOptions) ([]dockertypes.ImageDeleteResponseItem, error) {
 218         return nil, nil
 219 }
 220
 221 func (client *ArvTestClient) Create(resourceType string,
 222         parameters arvadosclient.Dict,
 223         output interface{}) error {
 224
 225         client.Mutex.Lock()
 226         defer client.Mutex.Unlock()
 227
 228         client.Calls++
 229         client.Content = append(client.Content, parameters)
 230
 231         if resourceType == "logs" {
 232                 et := parameters["log"].(arvadosclient.Dict)["event_type"].(string)
 233                 if client.Logs == nil {
 234                         client.Logs = make(map[string]*bytes.Buffer)
 235                 }
 236                 if client.Logs[et] == nil {
 237                         client.Logs[et] = &bytes.Buffer{}
 238                 }
 239                 client.Logs[et].Write([]byte(parameters["log"].(arvadosclient.Dict)["properties"].(map[string]string)["text"]))
 240         }
 241
 242         if resourceType == "collections" && output != nil {
 243                 mt := parameters["collection"].(arvadosclient.Dict)["manifest_text"].(string)
 244                 outmap := output.(*arvados.Collection)
 245                 outmap.PortableDataHash = fmt.Sprintf("%x+%d", md5.Sum([]byte(mt)), len(mt))
 246                 outmap.UUID = fmt.Sprintf("zzzzz-4zz18-%15.15x", md5.Sum([]byte(mt)))
 247         }
 248
 249         return nil
 250 }
 251
 252 func (client *ArvTestClient) Call(method, resourceType, uuid, action string, parameters arvadosclient.Dict, output interface{}) error {
 253         switch {
 254         case method == "GET" && resourceType == "containers" && action == "auth":
 255                 return json.Unmarshal([]byte(`{
 256                         "kind": "arvados#api_client_authorization",
 257                         "uuid": "`+fakeAuthUUID+`",
 258                         "api_token": "`+fakeAuthToken+`"
 259                         }`), output)
 260         case method == "GET" && resourceType == "containers" && action == "secret_mounts":
 261                 if client.secretMounts != nil {
 262                         return json.Unmarshal(client.secretMounts, output)
 263                 } else {
 264                         return json.Unmarshal([]byte(`{"secret_mounts":{}}`), output)
 265                 }
 266         default:
 267                 return fmt.Errorf("Not found")
 268         }
 269 }
 270
 271 func (client *ArvTestClient) CallRaw(method, resourceType, uuid, action string,
 272         parameters arvadosclient.Dict) (reader io.ReadCloser, err error) {
 273         var j []byte
 274         if method == "GET" && resourceType == "nodes" && uuid == "" && action == "" {
 275                 j = []byte(`{
 276                         "kind": "arvados#nodeList",
 277                         "items": [{
 278                                 "uuid": "zzzzz-7ekkf-2z3mc76g2q73aio",
 279                                 "hostname": "compute2",
 280                                 "properties": {"total_cpu_cores": 16}
 281                         }]}`)
 282         } else if method == "GET" && resourceType == "containers" && action == "" && !client.callraw {
 283                 if uuid == "" {
 284                         j, err = json.Marshal(map[string]interface{}{
 285                                 "items": []interface{}{client.Container},
 286                                 "kind":  "arvados#nodeList",
 287                         })
 288                 } else {
 289                         j, err = json.Marshal(client.Container)
 290                 }
 291         } else {
 292                 j = []byte(`{
 293                         "command": ["sleep", "1"],
 294                         "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
 295                         "cwd": ".",
 296                         "environment": {},
 297                         "mounts": {"/tmp": {"kind": "tmp"}, "/json": {"kind": "json", "content": {"number": 123456789123456789}}},
 298                         "output_path": "/tmp",
 299                         "priority": 1,
 300                         "runtime_constraints": {}
 301                 }`)
 302         }
 303         return ioutil.NopCloser(bytes.NewReader(j)), err
 304 }
 305
 306 func (client *ArvTestClient) Get(resourceType string, uuid string, parameters arvadosclient.Dict, output interface{}) error {
 307         if resourceType == "collections" {
 308                 if uuid == hwPDH {
 309                         output.(*arvados.Collection).ManifestText = hwManifest
 310                 } else if uuid == otherPDH {
 311                         output.(*arvados.Collection).ManifestText = otherManifest
 312                 } else if uuid == normalizedWithSubdirsPDH {
 313                         output.(*arvados.Collection).ManifestText = normalizedManifestWithSubdirs
 314                 } else if uuid == denormalizedWithSubdirsPDH {
 315                         output.(*arvados.Collection).ManifestText = denormalizedManifestWithSubdirs
 316                 }
 317         }
 318         if resourceType == "containers" {
 319                 (*output.(*arvados.Container)) = client.Container
 320         }
 321         return nil
 322 }
 323
 324 func (client *ArvTestClient) Update(resourceType string, uuid string, parameters arvadosclient.Dict, output interface{}) (err error) {
 325         client.Mutex.Lock()
 326         defer client.Mutex.Unlock()
 327         client.Calls++
 328         client.Content = append(client.Content, parameters)
 329         if resourceType == "containers" {
 330                 if parameters["container"].(arvadosclient.Dict)["state"] == "Running" {
 331                         client.WasSetRunning = true
 332                 }
 333         } else if resourceType == "collections" {
 334                 mt := parameters["collection"].(arvadosclient.Dict)["manifest_text"].(string)
 335                 output.(*arvados.Collection).UUID = uuid
 336                 output.(*arvados.Collection).PortableDataHash = fmt.Sprintf("%x", md5.Sum([]byte(mt)))
 337         }
 338         return nil
 339 }
 340
 341 var discoveryMap = map[string]interface{}{
 342         "defaultTrashLifetime":               float64(1209600),
 343         "crunchLimitLogBytesPerJob":          float64(67108864),
 344         "crunchLogThrottleBytes":             float64(65536),
 345         "crunchLogThrottlePeriod":            float64(60),
 346         "crunchLogThrottleLines":             float64(1024),
 347         "crunchLogPartialLineThrottlePeriod": float64(5),
 348         "crunchLogBytesPerEvent":             float64(4096),
 349         "crunchLogSecondsBetweenEvents":      float64(1),
 350 }
 351
 352 func (client *ArvTestClient) Discovery(key string) (interface{}, error) {
 353         return discoveryMap[key], nil
 354 }
 355
 356 // CalledWith returns the parameters from the first API call whose
 357 // parameters match jpath/string. E.g., CalledWith(c, "foo.bar",
 358 // "baz") returns parameters with parameters["foo"]["bar"]=="baz". If
 359 // no call matches, it returns nil.
 360 func (client *ArvTestClient) CalledWith(jpath string, expect interface{}) arvadosclient.Dict {
 361 call:
 362         for _, content := range client.Content {
 363                 var v interface{} = content
 364                 for _, k := range strings.Split(jpath, ".") {
 365                         if dict, ok := v.(arvadosclient.Dict); !ok {
 366                                 continue call
 367                         } else {
 368                                 v = dict[k]
 369                         }
 370                 }
 371                 if v == expect {
 372                         return content
 373                 }
 374         }
 375         return nil
 376 }
 377
 378 func (client *KeepTestClient) LocalLocator(locator string) (string, error) {
 379         return locator, nil
 380 }
 381
 382 func (client *KeepTestClient) PutB(buf []byte) (string, int, error) {
 383         client.Content = buf
 384         return fmt.Sprintf("%x+%d", md5.Sum(buf), len(buf)), len(buf), nil
 385 }
 386
 387 func (client *KeepTestClient) ReadAt(string, []byte, int) (int, error) {
 388         return 0, errors.New("not implemented")
 389 }
 390
 391 func (client *KeepTestClient) ClearBlockCache() {
 392 }
 393
 394 func (client *KeepTestClient) Close() {
 395         client.Content = nil
 396 }
 397
 398 type FileWrapper struct {
 399         io.ReadCloser
 400         len int64
 401 }
 402
 403 func (fw FileWrapper) Readdir(n int) ([]os.FileInfo, error) {
 404         return nil, errors.New("not implemented")
 405 }
 406
 407 func (fw FileWrapper) Seek(int64, int) (int64, error) {
 408         return 0, errors.New("not implemented")
 409 }
 410
 411 func (fw FileWrapper) Size() int64 {
 412         return fw.len
 413 }
 414
 415 func (fw FileWrapper) Stat() (os.FileInfo, error) {
 416         return nil, errors.New("not implemented")
 417 }
 418
 419 func (fw FileWrapper) Truncate(int64) error {
 420         return errors.New("not implemented")
 421 }
 422
 423 func (fw FileWrapper) Write([]byte) (int, error) {
 424         return 0, errors.New("not implemented")
 425 }
 426
 427 func (fw FileWrapper) Sync() error {
 428         return errors.New("not implemented")
 429 }
 430
 431 func (client *KeepTestClient) ManifestFileReader(m manifest.Manifest, filename string) (arvados.File, error) {
 432         if filename == hwImageId+".tar" {
 433                 rdr := ioutil.NopCloser(&bytes.Buffer{})
 434                 client.Called = true
 435                 return FileWrapper{rdr, 1321984}, nil
 436         } else if filename == "/file1_in_main.txt" {
 437                 rdr := ioutil.NopCloser(strings.NewReader("foo"))
 438                 client.Called = true
 439                 return FileWrapper{rdr, 3}, nil
 440         }
 441         return nil, nil
 442 }
 443
 444 func (s *TestSuite) TestLoadImage(c *C) {
 445         cr, err := NewContainerRunner(s.client, &ArvTestClient{},
 446                 &KeepTestClient{}, s.docker, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 447         c.Assert(err, IsNil)
 448
 449         kc := &KeepTestClient{}
 450         defer kc.Close()
 451         cr.ContainerArvClient = &ArvTestClient{}
 452         cr.ContainerKeepClient = kc
 453
 454         _, err = cr.Docker.ImageRemove(nil, hwImageId, dockertypes.ImageRemoveOptions{})
 455         c.Check(err, IsNil)
 456
 457         _, _, err = cr.Docker.ImageInspectWithRaw(nil, hwImageId)
 458         c.Check(err, NotNil)
 459
 460         cr.Container.ContainerImage = hwPDH
 461
 462         // (1) Test loading image from keep
 463         c.Check(kc.Called, Equals, false)
 464         c.Check(cr.ContainerConfig.Image, Equals, "")
 465
 466         err = cr.LoadImage()
 467
 468         c.Check(err, IsNil)
 469         defer func() {
 470                 cr.Docker.ImageRemove(nil, hwImageId, dockertypes.ImageRemoveOptions{})
 471         }()
 472
 473         c.Check(kc.Called, Equals, true)
 474         c.Check(cr.ContainerConfig.Image, Equals, hwImageId)
 475
 476         _, _, err = cr.Docker.ImageInspectWithRaw(nil, hwImageId)
 477         c.Check(err, IsNil)
 478
 479         // (2) Test using image that's already loaded
 480         kc.Called = false
 481         cr.ContainerConfig.Image = ""
 482
 483         err = cr.LoadImage()
 484         c.Check(err, IsNil)
 485         c.Check(kc.Called, Equals, false)
 486         c.Check(cr.ContainerConfig.Image, Equals, hwImageId)
 487
 488 }
 489
 490 type ArvErrorTestClient struct{}
 491
 492 func (ArvErrorTestClient) Create(resourceType string,
 493         parameters arvadosclient.Dict,
 494         output interface{}) error {
 495         return nil
 496 }
 497
 498 func (ArvErrorTestClient) Call(method, resourceType, uuid, action string, parameters arvadosclient.Dict, output interface{}) error {
 499         if method == "GET" && resourceType == "containers" && action == "auth" {
 500                 return nil
 501         }
 502         return errors.New("ArvError")
 503 }
 504
 505 func (ArvErrorTestClient) CallRaw(method, resourceType, uuid, action string,
 506         parameters arvadosclient.Dict) (reader io.ReadCloser, err error) {
 507         return nil, errors.New("ArvError")
 508 }
 509
 510 func (ArvErrorTestClient) Get(resourceType string, uuid string, parameters arvadosclient.Dict, output interface{}) error {
 511         return errors.New("ArvError")
 512 }
 513
 514 func (ArvErrorTestClient) Update(resourceType string, uuid string, parameters arvadosclient.Dict, output interface{}) (err error) {
 515         return nil
 516 }
 517
 518 func (ArvErrorTestClient) Discovery(key string) (interface{}, error) {
 519         return discoveryMap[key], nil
 520 }
 521
 522 type KeepErrorTestClient struct {
 523         KeepTestClient
 524 }
 525
 526 func (*KeepErrorTestClient) ManifestFileReader(manifest.Manifest, string) (arvados.File, error) {
 527         return nil, errors.New("KeepError")
 528 }
 529
 530 func (*KeepErrorTestClient) PutB(buf []byte) (string, int, error) {
 531         return "", 0, errors.New("KeepError")
 532 }
 533
 534 func (*KeepErrorTestClient) LocalLocator(string) (string, error) {
 535         return "", errors.New("KeepError")
 536 }
 537
 538 type KeepReadErrorTestClient struct {
 539         KeepTestClient
 540 }
 541
 542 func (*KeepReadErrorTestClient) ReadAt(string, []byte, int) (int, error) {
 543         return 0, errors.New("KeepError")
 544 }
 545
 546 type ErrorReader struct {
 547         FileWrapper
 548 }
 549
 550 func (ErrorReader) Read(p []byte) (n int, err error) {
 551         return 0, errors.New("ErrorReader")
 552 }
 553
 554 func (ErrorReader) Seek(int64, int) (int64, error) {
 555         return 0, errors.New("ErrorReader")
 556 }
 557
 558 func (KeepReadErrorTestClient) ManifestFileReader(m manifest.Manifest, filename string) (arvados.File, error) {
 559         return ErrorReader{}, nil
 560 }
 561
 562 func (s *TestSuite) TestLoadImageArvError(c *C) {
 563         // (1) Arvados error
 564         kc := &KeepTestClient{}
 565         defer kc.Close()
 566         cr, err := NewContainerRunner(s.client, &ArvErrorTestClient{}, kc, nil, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 567         c.Assert(err, IsNil)
 568
 569         cr.ContainerArvClient = &ArvErrorTestClient{}
 570         cr.ContainerKeepClient = &KeepTestClient{}
 571
 572         cr.Container.ContainerImage = hwPDH
 573
 574         err = cr.LoadImage()
 575         c.Check(err.Error(), Equals, "While getting container image collection: ArvError")
 576 }
 577
 578 func (s *TestSuite) TestLoadImageKeepError(c *C) {
 579         // (2) Keep error
 580         kc := &KeepErrorTestClient{}
 581         cr, err := NewContainerRunner(s.client, &ArvTestClient{}, kc, s.docker, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 582         c.Assert(err, IsNil)
 583
 584         cr.ContainerArvClient = &ArvTestClient{}
 585         cr.ContainerKeepClient = &KeepErrorTestClient{}
 586
 587         cr.Container.ContainerImage = hwPDH
 588
 589         err = cr.LoadImage()
 590         c.Assert(err, NotNil)
 591         c.Check(err.Error(), Equals, "While creating ManifestFileReader for container image: KeepError")
 592 }
 593
 594 func (s *TestSuite) TestLoadImageCollectionError(c *C) {
 595         // (3) Collection doesn't contain image
 596         kc := &KeepReadErrorTestClient{}
 597         cr, err := NewContainerRunner(s.client, &ArvTestClient{}, kc, nil, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 598         c.Assert(err, IsNil)
 599         cr.Container.ContainerImage = otherPDH
 600
 601         cr.ContainerArvClient = &ArvTestClient{}
 602         cr.ContainerKeepClient = &KeepReadErrorTestClient{}
 603
 604         err = cr.LoadImage()
 605         c.Check(err.Error(), Equals, "First file in the container image collection does not end in .tar")
 606 }
 607
 608 func (s *TestSuite) TestLoadImageKeepReadError(c *C) {
 609         // (4) Collection doesn't contain image
 610         kc := &KeepReadErrorTestClient{}
 611         cr, err := NewContainerRunner(s.client, &ArvTestClient{}, kc, s.docker, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 612         c.Assert(err, IsNil)
 613         cr.Container.ContainerImage = hwPDH
 614         cr.ContainerArvClient = &ArvTestClient{}
 615         cr.ContainerKeepClient = &KeepReadErrorTestClient{}
 616
 617         err = cr.LoadImage()
 618         c.Check(err, NotNil)
 619 }
 620
 621 type ClosableBuffer struct {
 622         bytes.Buffer
 623 }
 624
 625 func (*ClosableBuffer) Close() error {
 626         return nil
 627 }
 628
 629 type TestLogs struct {
 630         Stdout ClosableBuffer
 631         Stderr ClosableBuffer
 632 }
 633
 634 func (tl *TestLogs) NewTestLoggingWriter(logstr string) (io.WriteCloser, error) {
 635         if logstr == "stdout" {
 636                 return &tl.Stdout, nil
 637         }
 638         if logstr == "stderr" {
 639                 return &tl.Stderr, nil
 640         }
 641         return nil, errors.New("???")
 642 }
 643
 644 func dockerLog(fd byte, msg string) []byte {
 645         by := []byte(msg)
 646         header := make([]byte, 8+len(by))
 647         header[0] = fd
 648         header[7] = byte(len(by))
 649         copy(header[8:], by)
 650         return header
 651 }
 652
 653 func (s *TestSuite) TestRunContainer(c *C) {
 654         s.docker.fn = func(t *TestDockerClient) {
 655                 t.logWriter.Write(dockerLog(1, "Hello world\n"))
 656                 t.logWriter.Close()
 657         }
 658         kc := &KeepTestClient{}
 659         defer kc.Close()
 660         cr, err := NewContainerRunner(s.client, &ArvTestClient{}, kc, s.docker, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 661         c.Assert(err, IsNil)
 662
 663         cr.ContainerArvClient = &ArvTestClient{}
 664         cr.ContainerKeepClient = &KeepTestClient{}
 665
 666         var logs TestLogs
 667         cr.NewLogWriter = logs.NewTestLoggingWriter
 668         cr.Container.ContainerImage = hwPDH
 669         cr.Container.Command = []string{"./hw"}
 670         err = cr.LoadImage()
 671         c.Check(err, IsNil)
 672
 673         err = cr.CreateContainer()
 674         c.Check(err, IsNil)
 675
 676         err = cr.StartContainer()
 677         c.Check(err, IsNil)
 678
 679         err = cr.WaitFinish()
 680         c.Check(err, IsNil)
 681
 682         c.Check(strings.HasSuffix(logs.Stdout.String(), "Hello world\n"), Equals, true)
 683         c.Check(logs.Stderr.String(), Equals, "")
 684 }
 685
 686 func (s *TestSuite) TestCommitLogs(c *C) {
 687         api := &ArvTestClient{}
 688         kc := &KeepTestClient{}
 689         defer kc.Close()
 690         cr, err := NewContainerRunner(s.client, api, kc, nil, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 691         c.Assert(err, IsNil)
 692         cr.CrunchLog.Timestamper = (&TestTimestamper{}).Timestamp
 693
 694         cr.CrunchLog.Print("Hello world!")
 695         cr.CrunchLog.Print("Goodbye")
 696         cr.finalState = "Complete"
 697
 698         err = cr.CommitLogs()
 699         c.Check(err, IsNil)
 700
 701         c.Check(api.Calls, Equals, 2)
 702         c.Check(api.Content[1]["ensure_unique_name"], Equals, true)
 703         c.Check(api.Content[1]["collection"].(arvadosclient.Dict)["name"], Equals, "logs for zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 704         c.Check(api.Content[1]["collection"].(arvadosclient.Dict)["manifest_text"], Equals, ". 744b2e4553123b02fa7b452ec5c18993+123 0:123:crunch-run.txt\n")
 705         c.Check(*cr.LogsPDH, Equals, "63da7bdacf08c40f604daad80c261e9a+60")
 706 }
 707
 708 func (s *TestSuite) TestUpdateContainerRunning(c *C) {
 709         api := &ArvTestClient{}
 710         kc := &KeepTestClient{}
 711         defer kc.Close()
 712         cr, err := NewContainerRunner(s.client, api, kc, nil, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 713         c.Assert(err, IsNil)
 714
 715         err = cr.UpdateContainerRunning()
 716         c.Check(err, IsNil)
 717
 718         c.Check(api.Content[0]["container"].(arvadosclient.Dict)["state"], Equals, "Running")
 719 }
 720
 721 func (s *TestSuite) TestUpdateContainerComplete(c *C) {
 722         api := &ArvTestClient{}
 723         kc := &KeepTestClient{}
 724         defer kc.Close()
 725         cr, err := NewContainerRunner(s.client, api, kc, nil, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 726         c.Assert(err, IsNil)
 727
 728         cr.LogsPDH = new(string)
 729         *cr.LogsPDH = "d3a229d2fe3690c2c3e75a71a153c6a3+60"
 730
 731         cr.ExitCode = new(int)
 732         *cr.ExitCode = 42
 733         cr.finalState = "Complete"
 734
 735         err = cr.UpdateContainerFinal()
 736         c.Check(err, IsNil)
 737
 738         c.Check(api.Content[0]["container"].(arvadosclient.Dict)["log"], Equals, *cr.LogsPDH)
 739         c.Check(api.Content[0]["container"].(arvadosclient.Dict)["exit_code"], Equals, *cr.ExitCode)
 740         c.Check(api.Content[0]["container"].(arvadosclient.Dict)["state"], Equals, "Complete")
 741 }
 742
 743 func (s *TestSuite) TestUpdateContainerCancelled(c *C) {
 744         api := &ArvTestClient{}
 745         kc := &KeepTestClient{}
 746         defer kc.Close()
 747         cr, err := NewContainerRunner(s.client, api, kc, nil, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 748         c.Assert(err, IsNil)
 749         cr.cCancelled = true
 750         cr.finalState = "Cancelled"
 751
 752         err = cr.UpdateContainerFinal()
 753         c.Check(err, IsNil)
 754
 755         c.Check(api.Content[0]["container"].(arvadosclient.Dict)["log"], IsNil)
 756         c.Check(api.Content[0]["container"].(arvadosclient.Dict)["exit_code"], IsNil)
 757         c.Check(api.Content[0]["container"].(arvadosclient.Dict)["state"], Equals, "Cancelled")
 758 }
 759
 760 // Used by the TestFullRun*() test below to DRY up boilerplate setup to do full
 761 // dress rehearsal of the Run() function, starting from a JSON container record.
 762 func (s *TestSuite) fullRunHelper(c *C, record string, extraMounts []string, exitCode int, fn func(t *TestDockerClient)) (api *ArvTestClient, cr *ContainerRunner, realTemp string) {
 763         rec := arvados.Container{}
 764         err := json.Unmarshal([]byte(record), &rec)
 765         c.Check(err, IsNil)
 766
 767         var sm struct {
 768                 SecretMounts map[string]arvados.Mount `json:"secret_mounts"`
 769         }
 770         err = json.Unmarshal([]byte(record), &sm)
 771         c.Check(err, IsNil)
 772         secretMounts, err := json.Marshal(sm)
 773         c.Logf("%s %q", sm, secretMounts)
 774         c.Check(err, IsNil)
 775
 776         s.docker.exitCode = exitCode
 777         s.docker.fn = fn
 778         s.docker.ImageRemove(nil, hwImageId, dockertypes.ImageRemoveOptions{})
 779
 780         api = &ArvTestClient{Container: rec}
 781         s.docker.api = api
 782         kc := &KeepTestClient{}
 783         defer kc.Close()
 784         cr, err = NewContainerRunner(s.client, api, kc, s.docker, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
 785         c.Assert(err, IsNil)
 786         s.runner = cr
 787         cr.statInterval = 100 * time.Millisecond
 788         cr.containerWatchdogInterval = time.Second
 789         am := &ArvMountCmdLine{}
 790         cr.RunArvMount = am.ArvMountTest
 791
 792         realTemp, err = ioutil.TempDir("", "crunchrun_test1-")
 793         c.Assert(err, IsNil)
 794         defer os.RemoveAll(realTemp)
 795
 796         s.docker.realTemp = realTemp
 797
 798         tempcount := 0
 799         cr.MkTempDir = func(_ string, prefix string) (string, error) {
 800                 tempcount++
 801                 d := fmt.Sprintf("%s/%s%d", realTemp, prefix, tempcount)
 802                 err := os.Mkdir(d, os.ModePerm)
 803                 if err != nil && strings.Contains(err.Error(), ": file exists") {
 804                         // Test case must have pre-populated the tempdir
 805                         err = nil
 806                 }
 807                 return d, err
 808         }
 809         cr.MkArvClient = func(token string) (IArvadosClient, IKeepClient, *arvados.Client, error) {
 810                 return &ArvTestClient{secretMounts: secretMounts}, &KeepTestClient{}, nil, nil
 811         }
 812
 813         if extraMounts != nil && len(extraMounts) > 0 {
 814                 err := cr.SetupArvMountPoint("keep")
 815                 c.Check(err, IsNil)
 816
 817                 for _, m := range extraMounts {
 818                         os.MkdirAll(cr.ArvMountPoint+"/by_id/"+m, os.ModePerm)
 819                 }
 820         }
 821
 822         err = cr.Run()
 823         if api.CalledWith("container.state", "Complete") != nil {
 824                 c.Check(err, IsNil)
 825         }
 826         if exitCode != 2 {
 827                 c.Check(api.WasSetRunning, Equals, true)
 828                 var lastupdate arvadosclient.Dict
 829                 for _, content := range api.Content {
 830                         if content["container"] != nil {
 831                                 lastupdate = content["container"].(arvadosclient.Dict)
 832                         }
 833                 }
 834                 if lastupdate["log"] == nil {
 835                         c.Errorf("no container update with non-nil log -- updates were: %v", api.Content)
 836                 }
 837         }
 838
 839         if err != nil {
 840                 for k, v := range api.Logs {
 841                         c.Log(k)
 842                         c.Log(v.String())
 843                 }
 844         }
 845
 846         return
 847 }
 848
 849 func (s *TestSuite) TestFullRunHello(c *C) {
 850         api, _, _ := s.fullRunHelper(c, `{
 851     "command": ["echo", "hello world"],
 852     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
 853     "cwd": ".",
 854     "environment": {},
 855     "mounts": {"/tmp": {"kind": "tmp"} },
 856     "output_path": "/tmp",
 857     "priority": 1,
 858         "runtime_constraints": {}
 859 }`, nil, 0, func(t *TestDockerClient) {
 860                 t.logWriter.Write(dockerLog(1, "hello world\n"))
 861                 t.logWriter.Close()
 862         })
 863
 864         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
 865         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
 866         c.Check(strings.HasSuffix(api.Logs["stdout"].String(), "hello world\n"), Equals, true)
 867
 868 }
 869
 870 func (s *TestSuite) TestRunTimeExceeded(c *C) {
 871         api, _, _ := s.fullRunHelper(c, `{
 872     "command": ["sleep", "3"],
 873     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
 874     "cwd": ".",
 875     "environment": {},
 876     "mounts": {"/tmp": {"kind": "tmp"} },
 877     "output_path": "/tmp",
 878     "priority": 1,
 879         "runtime_constraints": {},
 880         "scheduling_parameters":{"max_run_time": 1}
 881 }`, nil, 0, func(t *TestDockerClient) {
 882                 time.Sleep(3 * time.Second)
 883                 t.logWriter.Close()
 884         })
 885
 886         c.Check(api.CalledWith("container.state", "Cancelled"), NotNil)
 887         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*maximum run time exceeded.*")
 888 }
 889
 890 func (s *TestSuite) TestContainerWaitFails(c *C) {
 891         api, _, _ := s.fullRunHelper(c, `{
 892     "command": ["sleep", "3"],
 893     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
 894     "cwd": ".",
 895     "mounts": {"/tmp": {"kind": "tmp"} },
 896     "output_path": "/tmp",
 897     "priority": 1
 898 }`, nil, 0, func(t *TestDockerClient) {
 899                 t.ctrExited = true
 900                 time.Sleep(10 * time.Second)
 901                 t.logWriter.Close()
 902         })
 903
 904         c.Check(api.CalledWith("container.state", "Cancelled"), NotNil)
 905         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*Container is not running.*")
 906 }
 907
 908 func (s *TestSuite) TestCrunchstat(c *C) {
 909         api, _, _ := s.fullRunHelper(c, `{
 910                 "command": ["sleep", "1"],
 911                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
 912                 "cwd": ".",
 913                 "environment": {},
 914                 "mounts": {"/tmp": {"kind": "tmp"} },
 915                 "output_path": "/tmp",
 916                 "priority": 1,
 917                 "runtime_constraints": {}
 918         }`, nil, 0, func(t *TestDockerClient) {
 919                 time.Sleep(time.Second)
 920                 t.logWriter.Close()
 921         })
 922
 923         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
 924         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
 925
 926         // We didn't actually start a container, so crunchstat didn't
 927         // find accounting files and therefore didn't log any stats.
 928         // It should have logged a "can't find accounting files"
 929         // message after one poll interval, though, so we can confirm
 930         // it's alive:
 931         c.Assert(api.Logs["crunchstat"], NotNil)
 932         c.Check(api.Logs["crunchstat"].String(), Matches, `(?ms).*cgroup stats files have not appeared after 100ms.*`)
 933
 934         // The "files never appeared" log assures us that we called
 935         // (*crunchstat.Reporter)Stop(), and that we set it up with
 936         // the correct container ID "abcde":
 937         c.Check(api.Logs["crunchstat"].String(), Matches, `(?ms).*cgroup stats files never appeared for abcde\n`)
 938 }
 939
 940 func (s *TestSuite) TestNodeInfoLog(c *C) {
 941         os.Setenv("SLURMD_NODENAME", "compute2")
 942         api, _, _ := s.fullRunHelper(c, `{
 943                 "command": ["sleep", "1"],
 944                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
 945                 "cwd": ".",
 946                 "environment": {},
 947                 "mounts": {"/tmp": {"kind": "tmp"} },
 948                 "output_path": "/tmp",
 949                 "priority": 1,
 950                 "runtime_constraints": {}
 951         }`, nil, 0,
 952                 func(t *TestDockerClient) {
 953                         time.Sleep(time.Second)
 954                         t.logWriter.Close()
 955                 })
 956
 957         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
 958         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
 959
 960         c.Assert(api.Logs["node"], NotNil)
 961         json := api.Logs["node"].String()
 962         c.Check(json, Matches, `(?ms).*"uuid": *"zzzzz-7ekkf-2z3mc76g2q73aio".*`)
 963         c.Check(json, Matches, `(?ms).*"total_cpu_cores": *16.*`)
 964         c.Check(json, Not(Matches), `(?ms).*"info":.*`)
 965
 966         c.Assert(api.Logs["node-info"], NotNil)
 967         json = api.Logs["node-info"].String()
 968         c.Check(json, Matches, `(?ms).*Host Information.*`)
 969         c.Check(json, Matches, `(?ms).*CPU Information.*`)
 970         c.Check(json, Matches, `(?ms).*Memory Information.*`)
 971         c.Check(json, Matches, `(?ms).*Disk Space.*`)
 972         c.Check(json, Matches, `(?ms).*Disk INodes.*`)
 973 }
 974
 975 func (s *TestSuite) TestContainerRecordLog(c *C) {
 976         api, _, _ := s.fullRunHelper(c, `{
 977                 "command": ["sleep", "1"],
 978                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
 979                 "cwd": ".",
 980                 "environment": {},
 981                 "mounts": {"/tmp": {"kind": "tmp"} },
 982                 "output_path": "/tmp",
 983                 "priority": 1,
 984                 "runtime_constraints": {}
 985         }`, nil, 0,
 986                 func(t *TestDockerClient) {
 987                         time.Sleep(time.Second)
 988                         t.logWriter.Close()
 989                 })
 990
 991         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
 992         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
 993
 994         c.Assert(api.Logs["container"], NotNil)
 995         c.Check(api.Logs["container"].String(), Matches, `(?ms).*container_image.*`)
 996 }
 997
 998 func (s *TestSuite) TestFullRunStderr(c *C) {
 999         api, _, _ := s.fullRunHelper(c, `{
1000     "command": ["/bin/sh", "-c", "echo hello ; echo world 1>&2 ; exit 1"],
1001     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1002     "cwd": ".",
1003     "environment": {},
1004     "mounts": {"/tmp": {"kind": "tmp"} },
1005     "output_path": "/tmp",
1006     "priority": 1,
1007     "runtime_constraints": {}
1008 }`, nil, 1, func(t *TestDockerClient) {
1009                 t.logWriter.Write(dockerLog(1, "hello\n"))
1010                 t.logWriter.Write(dockerLog(2, "world\n"))
1011                 t.logWriter.Close()
1012         })
1013
1014         final := api.CalledWith("container.state", "Complete")
1015         c.Assert(final, NotNil)
1016         c.Check(final["container"].(arvadosclient.Dict)["exit_code"], Equals, 1)
1017         c.Check(final["container"].(arvadosclient.Dict)["log"], NotNil)
1018
1019         c.Check(strings.HasSuffix(api.Logs["stdout"].String(), "hello\n"), Equals, true)
1020         c.Check(strings.HasSuffix(api.Logs["stderr"].String(), "world\n"), Equals, true)
1021 }
1022
1023 func (s *TestSuite) TestFullRunDefaultCwd(c *C) {
1024         api, _, _ := s.fullRunHelper(c, `{
1025     "command": ["pwd"],
1026     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1027     "cwd": ".",
1028     "environment": {},
1029     "mounts": {"/tmp": {"kind": "tmp"} },
1030     "output_path": "/tmp",
1031     "priority": 1,
1032     "runtime_constraints": {}
1033 }`, nil, 0, func(t *TestDockerClient) {
1034                 t.logWriter.Write(dockerLog(1, t.cwd+"\n"))
1035                 t.logWriter.Close()
1036         })
1037
1038         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1039         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1040         c.Log(api.Logs["stdout"])
1041         c.Check(strings.HasSuffix(api.Logs["stdout"].String(), "/\n"), Equals, true)
1042 }
1043
1044 func (s *TestSuite) TestFullRunSetCwd(c *C) {
1045         api, _, _ := s.fullRunHelper(c, `{
1046     "command": ["pwd"],
1047     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1048     "cwd": "/bin",
1049     "environment": {},
1050     "mounts": {"/tmp": {"kind": "tmp"} },
1051     "output_path": "/tmp",
1052     "priority": 1,
1053     "runtime_constraints": {}
1054 }`, nil, 0, func(t *TestDockerClient) {
1055                 t.logWriter.Write(dockerLog(1, t.cwd+"\n"))
1056                 t.logWriter.Close()
1057         })
1058
1059         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1060         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1061         c.Check(strings.HasSuffix(api.Logs["stdout"].String(), "/bin\n"), Equals, true)
1062 }
1063
1064 func (s *TestSuite) TestStopOnSignal(c *C) {
1065         s.testStopContainer(c, func(cr *ContainerRunner) {
1066                 go func() {
1067                         for !s.docker.calledWait {
1068                                 time.Sleep(time.Millisecond)
1069                         }
1070                         cr.SigChan <- syscall.SIGINT
1071                 }()
1072         })
1073 }
1074
1075 func (s *TestSuite) TestStopOnArvMountDeath(c *C) {
1076         s.testStopContainer(c, func(cr *ContainerRunner) {
1077                 cr.ArvMountExit = make(chan error)
1078                 go func() {
1079                         cr.ArvMountExit <- exec.Command("true").Run()
1080                         close(cr.ArvMountExit)
1081                 }()
1082         })
1083 }
1084
1085 func (s *TestSuite) testStopContainer(c *C, setup func(cr *ContainerRunner)) {
1086         record := `{
1087     "command": ["/bin/sh", "-c", "echo foo && sleep 30 && echo bar"],
1088     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1089     "cwd": ".",
1090     "environment": {},
1091     "mounts": {"/tmp": {"kind": "tmp"} },
1092     "output_path": "/tmp",
1093     "priority": 1,
1094     "runtime_constraints": {}
1095 }`
1096
1097         rec := arvados.Container{}
1098         err := json.Unmarshal([]byte(record), &rec)
1099         c.Check(err, IsNil)
1100
1101         s.docker.fn = func(t *TestDockerClient) {
1102                 <-t.stop
1103                 t.logWriter.Write(dockerLog(1, "foo\n"))
1104                 t.logWriter.Close()
1105         }
1106         s.docker.ImageRemove(nil, hwImageId, dockertypes.ImageRemoveOptions{})
1107
1108         api := &ArvTestClient{Container: rec}
1109         kc := &KeepTestClient{}
1110         defer kc.Close()
1111         cr, err := NewContainerRunner(s.client, api, kc, s.docker, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
1112         c.Assert(err, IsNil)
1113         cr.RunArvMount = func([]string, string) (*exec.Cmd, error) { return nil, nil }
1114         cr.MkArvClient = func(token string) (IArvadosClient, IKeepClient, *arvados.Client, error) {
1115                 return &ArvTestClient{}, &KeepTestClient{}, nil, nil
1116         }
1117         setup(cr)
1118
1119         done := make(chan error)
1120         go func() {
1121                 done <- cr.Run()
1122         }()
1123         select {
1124         case <-time.After(20 * time.Second):
1125                 pprof.Lookup("goroutine").WriteTo(os.Stderr, 1)
1126                 c.Fatal("timed out")
1127         case err = <-done:
1128                 c.Check(err, IsNil)
1129         }
1130         for k, v := range api.Logs {
1131                 c.Log(k)
1132                 c.Log(v.String())
1133         }
1134
1135         c.Check(api.CalledWith("container.log", nil), NotNil)
1136         c.Check(api.CalledWith("container.state", "Cancelled"), NotNil)
1137         c.Check(api.Logs["stdout"].String(), Matches, "(?ms).*foo\n$")
1138 }
1139
1140 func (s *TestSuite) TestFullRunSetEnv(c *C) {
1141         api, _, _ := s.fullRunHelper(c, `{
1142     "command": ["/bin/sh", "-c", "echo $FROBIZ"],
1143     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1144     "cwd": "/bin",
1145     "environment": {"FROBIZ": "bilbo"},
1146     "mounts": {"/tmp": {"kind": "tmp"} },
1147     "output_path": "/tmp",
1148     "priority": 1,
1149     "runtime_constraints": {}
1150 }`, nil, 0, func(t *TestDockerClient) {
1151                 t.logWriter.Write(dockerLog(1, t.env[0][7:]+"\n"))
1152                 t.logWriter.Close()
1153         })
1154
1155         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1156         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1157         c.Check(strings.HasSuffix(api.Logs["stdout"].String(), "bilbo\n"), Equals, true)
1158 }
1159
1160 type ArvMountCmdLine struct {
1161         Cmd   []string
1162         token string
1163 }
1164
1165 func (am *ArvMountCmdLine) ArvMountTest(c []string, token string) (*exec.Cmd, error) {
1166         am.Cmd = c
1167         am.token = token
1168         return nil, nil
1169 }
1170
1171 func stubCert(temp string) string {
1172         path := temp + "/ca-certificates.crt"
1173         crt, _ := os.Create(path)
1174         crt.Close()
1175         arvadosclient.CertFiles = []string{path}
1176         return path
1177 }
1178
1179 func (s *TestSuite) TestSetupMounts(c *C) {
1180         api := &ArvTestClient{}
1181         kc := &KeepTestClient{}
1182         defer kc.Close()
1183         cr, err := NewContainerRunner(s.client, api, kc, nil, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
1184         c.Assert(err, IsNil)
1185         am := &ArvMountCmdLine{}
1186         cr.RunArvMount = am.ArvMountTest
1187         cr.ContainerArvClient = &ArvTestClient{}
1188         cr.ContainerKeepClient = &KeepTestClient{}
1189
1190         realTemp, err := ioutil.TempDir("", "crunchrun_test1-")
1191         c.Assert(err, IsNil)
1192         certTemp, err := ioutil.TempDir("", "crunchrun_test2-")
1193         c.Assert(err, IsNil)
1194         stubCertPath := stubCert(certTemp)
1195
1196         cr.parentTemp = realTemp
1197
1198         defer os.RemoveAll(realTemp)
1199         defer os.RemoveAll(certTemp)
1200
1201         i := 0
1202         cr.MkTempDir = func(_ string, prefix string) (string, error) {
1203                 i++
1204                 d := fmt.Sprintf("%s/%s%d", realTemp, prefix, i)
1205                 err := os.Mkdir(d, os.ModePerm)
1206                 if err != nil && strings.Contains(err.Error(), ": file exists") {
1207                         // Test case must have pre-populated the tempdir
1208                         err = nil
1209                 }
1210                 return d, err
1211         }
1212
1213         checkEmpty := func() {
1214                 // Should be deleted.
1215                 _, err := os.Stat(realTemp)
1216                 c.Assert(os.IsNotExist(err), Equals, true)
1217
1218                 // Now recreate it for the next test.
1219                 c.Assert(os.Mkdir(realTemp, 0777), IsNil)
1220         }
1221
1222         {
1223                 i = 0
1224                 cr.ArvMountPoint = ""
1225                 cr.Container.Mounts = make(map[string]arvados.Mount)
1226                 cr.Container.Mounts["/tmp"] = arvados.Mount{Kind: "tmp"}
1227                 cr.Container.OutputPath = "/tmp"
1228                 cr.statInterval = 5 * time.Second
1229                 err := cr.SetupMounts()
1230                 c.Check(err, IsNil)
1231                 c.Check(am.Cmd, DeepEquals, []string{"--foreground", "--allow-other",
1232                         "--read-write", "--crunchstat-interval=5",
1233                         "--mount-by-pdh", "by_id", realTemp + "/keep1"})
1234                 c.Check(cr.Binds, DeepEquals, []string{realTemp + "/tmp2:/tmp"})
1235                 os.RemoveAll(cr.ArvMountPoint)
1236                 cr.CleanupDirs()
1237                 checkEmpty()
1238         }
1239
1240         {
1241                 i = 0
1242                 cr.ArvMountPoint = ""
1243                 cr.Container.Mounts = make(map[string]arvados.Mount)
1244                 cr.Container.Mounts["/out"] = arvados.Mount{Kind: "tmp"}
1245                 cr.Container.Mounts["/tmp"] = arvados.Mount{Kind: "tmp"}
1246                 cr.Container.OutputPath = "/out"
1247
1248                 err := cr.SetupMounts()
1249                 c.Check(err, IsNil)
1250                 c.Check(am.Cmd, DeepEquals, []string{"--foreground", "--allow-other",
1251                         "--read-write", "--crunchstat-interval=5",
1252                         "--mount-by-pdh", "by_id", realTemp + "/keep1"})
1253                 c.Check(cr.Binds, DeepEquals, []string{realTemp + "/tmp2:/out", realTemp + "/tmp3:/tmp"})
1254                 os.RemoveAll(cr.ArvMountPoint)
1255                 cr.CleanupDirs()
1256                 checkEmpty()
1257         }
1258
1259         {
1260                 i = 0
1261                 cr.ArvMountPoint = ""
1262                 cr.Container.Mounts = make(map[string]arvados.Mount)
1263                 cr.Container.Mounts["/tmp"] = arvados.Mount{Kind: "tmp"}
1264                 cr.Container.OutputPath = "/tmp"
1265
1266                 apiflag := true
1267                 cr.Container.RuntimeConstraints.API = &apiflag
1268
1269                 err := cr.SetupMounts()
1270                 c.Check(err, IsNil)
1271                 c.Check(am.Cmd, DeepEquals, []string{"--foreground", "--allow-other",
1272                         "--read-write", "--crunchstat-interval=5",
1273                         "--mount-by-pdh", "by_id", realTemp + "/keep1"})
1274                 c.Check(cr.Binds, DeepEquals, []string{realTemp + "/tmp2:/tmp", stubCertPath + ":/etc/arvados/ca-certificates.crt:ro"})
1275                 os.RemoveAll(cr.ArvMountPoint)
1276                 cr.CleanupDirs()
1277                 checkEmpty()
1278
1279                 apiflag = false
1280         }
1281
1282         {
1283                 i = 0
1284                 cr.ArvMountPoint = ""
1285                 cr.Container.Mounts = map[string]arvados.Mount{
1286                         "/keeptmp": {Kind: "collection", Writable: true},
1287                 }
1288                 cr.Container.OutputPath = "/keeptmp"
1289
1290                 os.MkdirAll(realTemp+"/keep1/tmp0", os.ModePerm)
1291
1292                 err := cr.SetupMounts()
1293                 c.Check(err, IsNil)
1294                 c.Check(am.Cmd, DeepEquals, []string{"--foreground", "--allow-other",
1295                         "--read-write", "--crunchstat-interval=5",
1296                         "--mount-tmp", "tmp0", "--mount-by-pdh", "by_id", realTemp + "/keep1"})
1297                 c.Check(cr.Binds, DeepEquals, []string{realTemp + "/keep1/tmp0:/keeptmp"})
1298                 os.RemoveAll(cr.ArvMountPoint)
1299                 cr.CleanupDirs()
1300                 checkEmpty()
1301         }
1302
1303         {
1304                 i = 0
1305                 cr.ArvMountPoint = ""
1306                 cr.Container.Mounts = map[string]arvados.Mount{
1307                         "/keepinp": {Kind: "collection", PortableDataHash: "59389a8f9ee9d399be35462a0f92541c+53"},
1308                         "/keepout": {Kind: "collection", Writable: true},
1309                 }
1310                 cr.Container.OutputPath = "/keepout"
1311
1312                 os.MkdirAll(realTemp+"/keep1/by_id/59389a8f9ee9d399be35462a0f92541c+53", os.ModePerm)
1313                 os.MkdirAll(realTemp+"/keep1/tmp0", os.ModePerm)
1314
1315                 err := cr.SetupMounts()
1316                 c.Check(err, IsNil)
1317                 c.Check(am.Cmd, DeepEquals, []string{"--foreground", "--allow-other",
1318                         "--read-write", "--crunchstat-interval=5",
1319                         "--mount-tmp", "tmp0", "--mount-by-pdh", "by_id", realTemp + "/keep1"})
1320                 sort.StringSlice(cr.Binds).Sort()
1321                 c.Check(cr.Binds, DeepEquals, []string{realTemp + "/keep1/by_id/59389a8f9ee9d399be35462a0f92541c+53:/keepinp:ro",
1322                         realTemp + "/keep1/tmp0:/keepout"})
1323                 os.RemoveAll(cr.ArvMountPoint)
1324                 cr.CleanupDirs()
1325                 checkEmpty()
1326         }
1327
1328         {
1329                 i = 0
1330                 cr.ArvMountPoint = ""
1331                 cr.Container.RuntimeConstraints.KeepCacheRAM = 512
1332                 cr.Container.Mounts = map[string]arvados.Mount{
1333                         "/keepinp": {Kind: "collection", PortableDataHash: "59389a8f9ee9d399be35462a0f92541c+53"},
1334                         "/keepout": {Kind: "collection", Writable: true},
1335                 }
1336                 cr.Container.OutputPath = "/keepout"
1337
1338                 os.MkdirAll(realTemp+"/keep1/by_id/59389a8f9ee9d399be35462a0f92541c+53", os.ModePerm)
1339                 os.MkdirAll(realTemp+"/keep1/tmp0", os.ModePerm)
1340
1341                 err := cr.SetupMounts()
1342                 c.Check(err, IsNil)
1343                 c.Check(am.Cmd, DeepEquals, []string{"--foreground", "--allow-other",
1344                         "--read-write", "--crunchstat-interval=5",
1345                         "--file-cache", "512", "--mount-tmp", "tmp0", "--mount-by-pdh", "by_id", realTemp + "/keep1"})
1346                 sort.StringSlice(cr.Binds).Sort()
1347                 c.Check(cr.Binds, DeepEquals, []string{realTemp + "/keep1/by_id/59389a8f9ee9d399be35462a0f92541c+53:/keepinp:ro",
1348                         realTemp + "/keep1/tmp0:/keepout"})
1349                 os.RemoveAll(cr.ArvMountPoint)
1350                 cr.CleanupDirs()
1351                 checkEmpty()
1352         }
1353
1354         for _, test := range []struct {
1355                 in  interface{}
1356                 out string
1357         }{
1358                 {in: "foo", out: `"foo"`},
1359                 {in: nil, out: `null`},
1360                 {in: map[string]int64{"foo": 123456789123456789}, out: `{"foo":123456789123456789}`},
1361         } {
1362                 i = 0
1363                 cr.ArvMountPoint = ""
1364                 cr.Container.Mounts = map[string]arvados.Mount{
1365                         "/mnt/test.json": {Kind: "json", Content: test.in},
1366                 }
1367                 err := cr.SetupMounts()
1368                 c.Check(err, IsNil)
1369                 sort.StringSlice(cr.Binds).Sort()
1370                 c.Check(cr.Binds, DeepEquals, []string{realTemp + "/json2/mountdata.json:/mnt/test.json:ro"})
1371                 content, err := ioutil.ReadFile(realTemp + "/json2/mountdata.json")
1372                 c.Check(err, IsNil)
1373                 c.Check(content, DeepEquals, []byte(test.out))
1374                 os.RemoveAll(cr.ArvMountPoint)
1375                 cr.CleanupDirs()
1376                 checkEmpty()
1377         }
1378
1379         for _, test := range []struct {
1380                 in  interface{}
1381                 out string
1382         }{
1383                 {in: "foo", out: `foo`},
1384                 {in: nil, out: "error"},
1385                 {in: map[string]int64{"foo": 123456789123456789}, out: "error"},
1386         } {
1387                 i = 0
1388                 cr.ArvMountPoint = ""
1389                 cr.Container.Mounts = map[string]arvados.Mount{
1390                         "/mnt/test.txt": {Kind: "text", Content: test.in},
1391                 }
1392                 err := cr.SetupMounts()
1393                 if test.out == "error" {
1394                         c.Check(err.Error(), Equals, "content for mount \"/mnt/test.txt\" must be a string")
1395                 } else {
1396                         c.Check(err, IsNil)
1397                         sort.StringSlice(cr.Binds).Sort()
1398                         c.Check(cr.Binds, DeepEquals, []string{realTemp + "/text2/mountdata.text:/mnt/test.txt:ro"})
1399                         content, err := ioutil.ReadFile(realTemp + "/text2/mountdata.text")
1400                         c.Check(err, IsNil)
1401                         c.Check(content, DeepEquals, []byte(test.out))
1402                 }
1403                 os.RemoveAll(cr.ArvMountPoint)
1404                 cr.CleanupDirs()
1405                 checkEmpty()
1406         }
1407
1408         // Read-only mount points are allowed underneath output_dir mount point
1409         {
1410                 i = 0
1411                 cr.ArvMountPoint = ""
1412                 cr.Container.Mounts = make(map[string]arvados.Mount)
1413                 cr.Container.Mounts = map[string]arvados.Mount{
1414                         "/tmp":     {Kind: "tmp"},
1415                         "/tmp/foo": {Kind: "collection"},
1416                 }
1417                 cr.Container.OutputPath = "/tmp"
1418
1419                 os.MkdirAll(realTemp+"/keep1/tmp0", os.ModePerm)
1420
1421                 err := cr.SetupMounts()
1422                 c.Check(err, IsNil)
1423                 c.Check(am.Cmd, DeepEquals, []string{"--foreground", "--allow-other",
1424                         "--read-write", "--crunchstat-interval=5",
1425                         "--file-cache", "512", "--mount-tmp", "tmp0", "--mount-by-pdh", "by_id", realTemp + "/keep1"})
1426                 c.Check(cr.Binds, DeepEquals, []string{realTemp + "/tmp2:/tmp", realTemp + "/keep1/tmp0:/tmp/foo:ro"})
1427                 os.RemoveAll(cr.ArvMountPoint)
1428                 cr.CleanupDirs()
1429                 checkEmpty()
1430         }
1431
1432         // Writable mount points copied to output_dir mount point
1433         {
1434                 i = 0
1435                 cr.ArvMountPoint = ""
1436                 cr.Container.Mounts = make(map[string]arvados.Mount)
1437                 cr.Container.Mounts = map[string]arvados.Mount{
1438                         "/tmp": {Kind: "tmp"},
1439                         "/tmp/foo": {Kind: "collection",
1440                                 PortableDataHash: "59389a8f9ee9d399be35462a0f92541c+53",
1441                                 Writable:         true},
1442                         "/tmp/bar": {Kind: "collection",
1443                                 PortableDataHash: "59389a8f9ee9d399be35462a0f92541d+53",
1444                                 Path:             "baz",
1445                                 Writable:         true},
1446                 }
1447                 cr.Container.OutputPath = "/tmp"
1448
1449                 os.MkdirAll(realTemp+"/keep1/by_id/59389a8f9ee9d399be35462a0f92541c+53", os.ModePerm)
1450                 os.MkdirAll(realTemp+"/keep1/by_id/59389a8f9ee9d399be35462a0f92541d+53/baz", os.ModePerm)
1451
1452                 rf, _ := os.Create(realTemp + "/keep1/by_id/59389a8f9ee9d399be35462a0f92541d+53/baz/quux")
1453                 rf.Write([]byte("bar"))
1454                 rf.Close()
1455
1456                 err := cr.SetupMounts()
1457                 c.Check(err, IsNil)
1458                 _, err = os.Stat(cr.HostOutputDir + "/foo")
1459                 c.Check(err, IsNil)
1460                 _, err = os.Stat(cr.HostOutputDir + "/bar/quux")
1461                 c.Check(err, IsNil)
1462                 os.RemoveAll(cr.ArvMountPoint)
1463                 cr.CleanupDirs()
1464                 checkEmpty()
1465         }
1466
1467         // Only mount points of kind 'collection' are allowed underneath output_dir mount point
1468         {
1469                 i = 0
1470                 cr.ArvMountPoint = ""
1471                 cr.Container.Mounts = make(map[string]arvados.Mount)
1472                 cr.Container.Mounts = map[string]arvados.Mount{
1473                         "/tmp":     {Kind: "tmp"},
1474                         "/tmp/foo": {Kind: "tmp"},
1475                 }
1476                 cr.Container.OutputPath = "/tmp"
1477
1478                 err := cr.SetupMounts()
1479                 c.Check(err, NotNil)
1480                 c.Check(err, ErrorMatches, `Only mount points of kind 'collection', 'text' or 'json' are supported underneath the output_path.*`)
1481                 os.RemoveAll(cr.ArvMountPoint)
1482                 cr.CleanupDirs()
1483                 checkEmpty()
1484         }
1485
1486         // Only mount point of kind 'collection' is allowed for stdin
1487         {
1488                 i = 0
1489                 cr.ArvMountPoint = ""
1490                 cr.Container.Mounts = make(map[string]arvados.Mount)
1491                 cr.Container.Mounts = map[string]arvados.Mount{
1492                         "stdin": {Kind: "tmp"},
1493                 }
1494
1495                 err := cr.SetupMounts()
1496                 c.Check(err, NotNil)
1497                 c.Check(err, ErrorMatches, `Unsupported mount kind 'tmp' for stdin.*`)
1498                 os.RemoveAll(cr.ArvMountPoint)
1499                 cr.CleanupDirs()
1500                 checkEmpty()
1501         }
1502
1503         // git_tree mounts
1504         {
1505                 i = 0
1506                 cr.ArvMountPoint = ""
1507                 (*GitMountSuite)(nil).useTestGitServer(c)
1508                 cr.token = arvadostest.ActiveToken
1509                 cr.Container.Mounts = make(map[string]arvados.Mount)
1510                 cr.Container.Mounts = map[string]arvados.Mount{
1511                         "/tip": {
1512                                 Kind:   "git_tree",
1513                                 UUID:   arvadostest.Repository2UUID,
1514                                 Commit: "fd3531f42995344f36c30b79f55f27b502f3d344",
1515                                 Path:   "/",
1516                         },
1517                         "/non-tip": {
1518                                 Kind:   "git_tree",
1519                                 UUID:   arvadostest.Repository2UUID,
1520                                 Commit: "5ebfab0522851df01fec11ec55a6d0f4877b542e",
1521                                 Path:   "/",
1522                         },
1523                 }
1524                 cr.Container.OutputPath = "/tmp"
1525
1526                 err := cr.SetupMounts()
1527                 c.Check(err, IsNil)
1528
1529                 // dirMap[mountpoint] == tmpdir
1530                 dirMap := make(map[string]string)
1531                 for _, bind := range cr.Binds {
1532                         tokens := strings.Split(bind, ":")
1533                         dirMap[tokens[1]] = tokens[0]
1534
1535                         if cr.Container.Mounts[tokens[1]].Writable {
1536                                 c.Check(len(tokens), Equals, 2)
1537                         } else {
1538                                 c.Check(len(tokens), Equals, 3)
1539                                 c.Check(tokens[2], Equals, "ro")
1540                         }
1541                 }
1542
1543                 data, err := ioutil.ReadFile(dirMap["/tip"] + "/dir1/dir2/file with mode 0644")
1544                 c.Check(err, IsNil)
1545                 c.Check(string(data), Equals, "\000\001\002\003")
1546                 _, err = ioutil.ReadFile(dirMap["/tip"] + "/file only on testbranch")
1547                 c.Check(err, FitsTypeOf, &os.PathError{})
1548                 c.Check(os.IsNotExist(err), Equals, true)
1549
1550                 data, err = ioutil.ReadFile(dirMap["/non-tip"] + "/dir1/dir2/file with mode 0644")
1551                 c.Check(err, IsNil)
1552                 c.Check(string(data), Equals, "\000\001\002\003")
1553                 data, err = ioutil.ReadFile(dirMap["/non-tip"] + "/file only on testbranch")
1554                 c.Check(err, IsNil)
1555                 c.Check(string(data), Equals, "testfile\n")
1556
1557                 cr.CleanupDirs()
1558                 checkEmpty()
1559         }
1560 }
1561
1562 func (s *TestSuite) TestStdout(c *C) {
1563         helperRecord := `{
1564                 "command": ["/bin/sh", "-c", "echo $FROBIZ"],
1565                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1566                 "cwd": "/bin",
1567                 "environment": {"FROBIZ": "bilbo"},
1568                 "mounts": {"/tmp": {"kind": "tmp"}, "stdout": {"kind": "file", "path": "/tmp/a/b/c.out"} },
1569                 "output_path": "/tmp",
1570                 "priority": 1,
1571                 "runtime_constraints": {}
1572         }`
1573
1574         api, cr, _ := s.fullRunHelper(c, helperRecord, nil, 0, func(t *TestDockerClient) {
1575                 t.logWriter.Write(dockerLog(1, t.env[0][7:]+"\n"))
1576                 t.logWriter.Close()
1577         })
1578
1579         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1580         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1581         c.Check(cr.ContainerArvClient.(*ArvTestClient).CalledWith("collection.manifest_text", "./a/b 307372fa8fd5c146b22ae7a45b49bc31+6 0:6:c.out\n"), NotNil)
1582 }
1583
1584 // Used by the TestStdoutWithWrongPath*()
1585 func (s *TestSuite) stdoutErrorRunHelper(c *C, record string, fn func(t *TestDockerClient)) (api *ArvTestClient, cr *ContainerRunner, err error) {
1586         rec := arvados.Container{}
1587         err = json.Unmarshal([]byte(record), &rec)
1588         c.Check(err, IsNil)
1589
1590         s.docker.fn = fn
1591         s.docker.ImageRemove(nil, hwImageId, dockertypes.ImageRemoveOptions{})
1592
1593         api = &ArvTestClient{Container: rec}
1594         kc := &KeepTestClient{}
1595         defer kc.Close()
1596         cr, err = NewContainerRunner(s.client, api, kc, s.docker, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
1597         c.Assert(err, IsNil)
1598         am := &ArvMountCmdLine{}
1599         cr.RunArvMount = am.ArvMountTest
1600         cr.MkArvClient = func(token string) (IArvadosClient, IKeepClient, *arvados.Client, error) {
1601                 return &ArvTestClient{}, &KeepTestClient{}, nil, nil
1602         }
1603
1604         err = cr.Run()
1605         return
1606 }
1607
1608 func (s *TestSuite) TestStdoutWithWrongPath(c *C) {
1609         _, _, err := s.stdoutErrorRunHelper(c, `{
1610     "mounts": {"/tmp": {"kind": "tmp"}, "stdout": {"kind": "file", "path":"/tmpa.out"} },
1611     "output_path": "/tmp"
1612 }`, func(t *TestDockerClient) {})
1613
1614         c.Check(err, NotNil)
1615         c.Check(strings.Contains(err.Error(), "Stdout path does not start with OutputPath"), Equals, true)
1616 }
1617
1618 func (s *TestSuite) TestStdoutWithWrongKindTmp(c *C) {
1619         _, _, err := s.stdoutErrorRunHelper(c, `{
1620     "mounts": {"/tmp": {"kind": "tmp"}, "stdout": {"kind": "tmp", "path":"/tmp/a.out"} },
1621     "output_path": "/tmp"
1622 }`, func(t *TestDockerClient) {})
1623
1624         c.Check(err, NotNil)
1625         c.Check(strings.Contains(err.Error(), "Unsupported mount kind 'tmp' for stdout"), Equals, true)
1626 }
1627
1628 func (s *TestSuite) TestStdoutWithWrongKindCollection(c *C) {
1629         _, _, err := s.stdoutErrorRunHelper(c, `{
1630     "mounts": {"/tmp": {"kind": "tmp"}, "stdout": {"kind": "collection", "path":"/tmp/a.out"} },
1631     "output_path": "/tmp"
1632 }`, func(t *TestDockerClient) {})
1633
1634         c.Check(err, NotNil)
1635         c.Check(strings.Contains(err.Error(), "Unsupported mount kind 'collection' for stdout"), Equals, true)
1636 }
1637
1638 func (s *TestSuite) TestFullRunWithAPI(c *C) {
1639         defer os.Setenv("ARVADOS_API_HOST", os.Getenv("ARVADOS_API_HOST"))
1640         os.Setenv("ARVADOS_API_HOST", "test.arvados.org")
1641         api, _, _ := s.fullRunHelper(c, `{
1642     "command": ["/bin/sh", "-c", "echo $ARVADOS_API_HOST"],
1643     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1644     "cwd": "/bin",
1645     "environment": {},
1646     "mounts": {"/tmp": {"kind": "tmp"} },
1647     "output_path": "/tmp",
1648     "priority": 1,
1649     "runtime_constraints": {"API": true}
1650 }`, nil, 0, func(t *TestDockerClient) {
1651                 t.logWriter.Write(dockerLog(1, t.env[1][17:]+"\n"))
1652                 t.logWriter.Close()
1653         })
1654
1655         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1656         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1657         c.Check(strings.HasSuffix(api.Logs["stdout"].String(), "test.arvados.org\n"), Equals, true)
1658         c.Check(api.CalledWith("container.output", "d41d8cd98f00b204e9800998ecf8427e+0"), NotNil)
1659 }
1660
1661 func (s *TestSuite) TestFullRunSetOutput(c *C) {
1662         defer os.Setenv("ARVADOS_API_HOST", os.Getenv("ARVADOS_API_HOST"))
1663         os.Setenv("ARVADOS_API_HOST", "test.arvados.org")
1664         api, _, _ := s.fullRunHelper(c, `{
1665     "command": ["/bin/sh", "-c", "echo $ARVADOS_API_HOST"],
1666     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1667     "cwd": "/bin",
1668     "environment": {},
1669     "mounts": {"/tmp": {"kind": "tmp"} },
1670     "output_path": "/tmp",
1671     "priority": 1,
1672     "runtime_constraints": {"API": true}
1673 }`, nil, 0, func(t *TestDockerClient) {
1674                 t.api.Container.Output = "d4ab34d3d4f8a72f5c4973051ae69fab+122"
1675                 t.logWriter.Close()
1676         })
1677
1678         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1679         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1680         c.Check(api.CalledWith("container.output", "d4ab34d3d4f8a72f5c4973051ae69fab+122"), NotNil)
1681 }
1682
1683 func (s *TestSuite) TestStdoutWithExcludeFromOutputMountPointUnderOutputDir(c *C) {
1684         helperRecord := `{
1685                 "command": ["/bin/sh", "-c", "echo $FROBIZ"],
1686                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1687                 "cwd": "/bin",
1688                 "environment": {"FROBIZ": "bilbo"},
1689                 "mounts": {
1690         "/tmp": {"kind": "tmp"},
1691         "/tmp/foo": {"kind": "collection",
1692                      "portable_data_hash": "a3e8f74c6f101eae01fa08bfb4e49b3a+54",
1693                      "exclude_from_output": true
1694         },
1695         "stdout": {"kind": "file", "path": "/tmp/a/b/c.out"}
1696     },
1697                 "output_path": "/tmp",
1698                 "priority": 1,
1699                 "runtime_constraints": {}
1700         }`
1701
1702         extraMounts := []string{"a3e8f74c6f101eae01fa08bfb4e49b3a+54"}
1703
1704         api, cr, _ := s.fullRunHelper(c, helperRecord, extraMounts, 0, func(t *TestDockerClient) {
1705                 t.logWriter.Write(dockerLog(1, t.env[0][7:]+"\n"))
1706                 t.logWriter.Close()
1707         })
1708
1709         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1710         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1711         c.Check(cr.ContainerArvClient.(*ArvTestClient).CalledWith("collection.manifest_text", "./a/b 307372fa8fd5c146b22ae7a45b49bc31+6 0:6:c.out\n"), NotNil)
1712 }
1713
1714 func (s *TestSuite) TestStdoutWithMultipleMountPointsUnderOutputDir(c *C) {
1715         helperRecord := `{
1716                 "command": ["/bin/sh", "-c", "echo $FROBIZ"],
1717                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1718                 "cwd": "/bin",
1719                 "environment": {"FROBIZ": "bilbo"},
1720                 "mounts": {
1721         "/tmp": {"kind": "tmp"},
1722         "/tmp/foo/bar": {"kind": "collection", "portable_data_hash": "a0def87f80dd594d4675809e83bd4f15+367", "path":"/file2_in_main.txt"},
1723         "/tmp/foo/sub1": {"kind": "collection", "portable_data_hash": "a0def87f80dd594d4675809e83bd4f15+367", "path":"/subdir1"},
1724         "/tmp/foo/sub1file2": {"kind": "collection", "portable_data_hash": "a0def87f80dd594d4675809e83bd4f15+367", "path":"/subdir1/file2_in_subdir1.txt"},
1725         "/tmp/foo/baz/sub2file2": {"kind": "collection", "portable_data_hash": "a0def87f80dd594d4675809e83bd4f15+367", "path":"/subdir1/subdir2/file2_in_subdir2.txt"},
1726         "stdout": {"kind": "file", "path": "/tmp/a/b/c.out"}
1727     },
1728                 "output_path": "/tmp",
1729                 "priority": 1,
1730                 "runtime_constraints": {}
1731         }`
1732
1733         extraMounts := []string{
1734                 "a0def87f80dd594d4675809e83bd4f15+367/file2_in_main.txt",
1735                 "a0def87f80dd594d4675809e83bd4f15+367/subdir1/file2_in_subdir1.txt",
1736                 "a0def87f80dd594d4675809e83bd4f15+367/subdir1/subdir2/file2_in_subdir2.txt",
1737         }
1738
1739         api, runner, realtemp := s.fullRunHelper(c, helperRecord, extraMounts, 0, func(t *TestDockerClient) {
1740                 t.logWriter.Write(dockerLog(1, t.env[0][7:]+"\n"))
1741                 t.logWriter.Close()
1742         })
1743
1744         c.Check(runner.Binds, DeepEquals, []string{realtemp + "/tmp2:/tmp",
1745                 realtemp + "/keep1/by_id/a0def87f80dd594d4675809e83bd4f15+367/file2_in_main.txt:/tmp/foo/bar:ro",
1746                 realtemp + "/keep1/by_id/a0def87f80dd594d4675809e83bd4f15+367/subdir1/subdir2/file2_in_subdir2.txt:/tmp/foo/baz/sub2file2:ro",
1747                 realtemp + "/keep1/by_id/a0def87f80dd594d4675809e83bd4f15+367/subdir1:/tmp/foo/sub1:ro",
1748                 realtemp + "/keep1/by_id/a0def87f80dd594d4675809e83bd4f15+367/subdir1/file2_in_subdir1.txt:/tmp/foo/sub1file2:ro",
1749         })
1750
1751         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1752         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1753         for _, v := range api.Content {
1754                 if v["collection"] != nil {
1755                         c.Check(v["ensure_unique_name"], Equals, true)
1756                         collection := v["collection"].(arvadosclient.Dict)
1757                         if strings.Index(collection["name"].(string), "output") == 0 {
1758                                 manifest := collection["manifest_text"].(string)
1759
1760                                 c.Check(manifest, Equals, `./a/b 307372fa8fd5c146b22ae7a45b49bc31+6 0:6:c.out
1761 ./foo 3e426d509afffb85e06c4c96a7c15e91+27+Aa124ac75e5168396c73c0abcdefgh11234567890@569fa8c3 3e426d509afffb85e06c4c96a7c15e91+27+Aa124ac75e5168396cabcdefghij6419876543234@569fa8c4 9:18:bar 36:18:sub1file2
1762 ./foo/baz 3e426d509afffb85e06c4c96a7c15e91+27+Aa124ac75e5168396c73c0bcdefghijk544332211@569fa8c5 9:18:sub2file2
1763 ./foo/sub1 3e426d509afffb85e06c4c96a7c15e91+27+Aa124ac75e5168396cabcdefghij6419876543234@569fa8c4 0:9:file1_in_subdir1.txt 9:18:file2_in_subdir1.txt
1764 ./foo/sub1/subdir2 3e426d509afffb85e06c4c96a7c15e91+27+Aa124ac75e5168396c73c0bcdefghijk544332211@569fa8c5 0:9:file1_in_subdir2.txt 9:18:file2_in_subdir2.txt
1765 `)
1766                         }
1767                 }
1768         }
1769 }
1770
1771 func (s *TestSuite) TestStdoutWithMountPointsUnderOutputDirDenormalizedManifest(c *C) {
1772         helperRecord := `{
1773                 "command": ["/bin/sh", "-c", "echo $FROBIZ"],
1774                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1775                 "cwd": "/bin",
1776                 "environment": {"FROBIZ": "bilbo"},
1777                 "mounts": {
1778         "/tmp": {"kind": "tmp"},
1779         "/tmp/foo/bar": {"kind": "collection", "portable_data_hash": "b0def87f80dd594d4675809e83bd4f15+367", "path": "/subdir1/file2_in_subdir1.txt"},
1780         "stdout": {"kind": "file", "path": "/tmp/a/b/c.out"}
1781     },
1782                 "output_path": "/tmp",
1783                 "priority": 1,
1784                 "runtime_constraints": {}
1785         }`
1786
1787         extraMounts := []string{
1788                 "b0def87f80dd594d4675809e83bd4f15+367/subdir1/file2_in_subdir1.txt",
1789         }
1790
1791         api, _, _ := s.fullRunHelper(c, helperRecord, extraMounts, 0, func(t *TestDockerClient) {
1792                 t.logWriter.Write(dockerLog(1, t.env[0][7:]+"\n"))
1793                 t.logWriter.Close()
1794         })
1795
1796         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1797         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1798         for _, v := range api.Content {
1799                 if v["collection"] != nil {
1800                         collection := v["collection"].(arvadosclient.Dict)
1801                         if strings.Index(collection["name"].(string), "output") == 0 {
1802                                 manifest := collection["manifest_text"].(string)
1803
1804                                 c.Check(manifest, Equals, `./a/b 307372fa8fd5c146b22ae7a45b49bc31+6 0:6:c.out
1805 ./foo 3e426d509afffb85e06c4c96a7c15e91+27+Aa124ac75e5168396c73c0abcdefgh11234567890@569fa8c3 10:17:bar
1806 `)
1807                         }
1808                 }
1809         }
1810 }
1811
1812 func (s *TestSuite) TestOutputError(c *C) {
1813         helperRecord := `{
1814                 "command": ["/bin/sh", "-c", "echo $FROBIZ"],
1815                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1816                 "cwd": "/bin",
1817                 "environment": {"FROBIZ": "bilbo"},
1818                 "mounts": {
1819         "/tmp": {"kind": "tmp"}
1820     },
1821                 "output_path": "/tmp",
1822                 "priority": 1,
1823                 "runtime_constraints": {}
1824         }`
1825
1826         extraMounts := []string{}
1827
1828         api, _, _ := s.fullRunHelper(c, helperRecord, extraMounts, 0, func(t *TestDockerClient) {
1829                 os.Symlink("/etc/hosts", t.realTemp+"/tmp2/baz")
1830                 t.logWriter.Close()
1831         })
1832
1833         c.Check(api.CalledWith("container.state", "Cancelled"), NotNil)
1834 }
1835
1836 func (s *TestSuite) TestStdinCollectionMountPoint(c *C) {
1837         helperRecord := `{
1838                 "command": ["/bin/sh", "-c", "echo $FROBIZ"],
1839                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1840                 "cwd": "/bin",
1841                 "environment": {"FROBIZ": "bilbo"},
1842                 "mounts": {
1843         "/tmp": {"kind": "tmp"},
1844         "stdin": {"kind": "collection", "portable_data_hash": "b0def87f80dd594d4675809e83bd4f15+367", "path": "/file1_in_main.txt"},
1845         "stdout": {"kind": "file", "path": "/tmp/a/b/c.out"}
1846     },
1847                 "output_path": "/tmp",
1848                 "priority": 1,
1849                 "runtime_constraints": {}
1850         }`
1851
1852         extraMounts := []string{
1853                 "b0def87f80dd594d4675809e83bd4f15+367/file1_in_main.txt",
1854         }
1855
1856         api, _, _ := s.fullRunHelper(c, helperRecord, extraMounts, 0, func(t *TestDockerClient) {
1857                 t.logWriter.Write(dockerLog(1, t.env[0][7:]+"\n"))
1858                 t.logWriter.Close()
1859         })
1860
1861         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1862         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1863         for _, v := range api.Content {
1864                 if v["collection"] != nil {
1865                         collection := v["collection"].(arvadosclient.Dict)
1866                         if strings.Index(collection["name"].(string), "output") == 0 {
1867                                 manifest := collection["manifest_text"].(string)
1868                                 c.Check(manifest, Equals, `./a/b 307372fa8fd5c146b22ae7a45b49bc31+6 0:6:c.out
1869 `)
1870                         }
1871                 }
1872         }
1873 }
1874
1875 func (s *TestSuite) TestStdinJsonMountPoint(c *C) {
1876         helperRecord := `{
1877                 "command": ["/bin/sh", "-c", "echo $FROBIZ"],
1878                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1879                 "cwd": "/bin",
1880                 "environment": {"FROBIZ": "bilbo"},
1881                 "mounts": {
1882         "/tmp": {"kind": "tmp"},
1883         "stdin": {"kind": "json", "content": "foo"},
1884         "stdout": {"kind": "file", "path": "/tmp/a/b/c.out"}
1885     },
1886                 "output_path": "/tmp",
1887                 "priority": 1,
1888                 "runtime_constraints": {}
1889         }`
1890
1891         api, _, _ := s.fullRunHelper(c, helperRecord, nil, 0, func(t *TestDockerClient) {
1892                 t.logWriter.Write(dockerLog(1, t.env[0][7:]+"\n"))
1893                 t.logWriter.Close()
1894         })
1895
1896         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
1897         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
1898         for _, v := range api.Content {
1899                 if v["collection"] != nil {
1900                         collection := v["collection"].(arvadosclient.Dict)
1901                         if strings.Index(collection["name"].(string), "output") == 0 {
1902                                 manifest := collection["manifest_text"].(string)
1903                                 c.Check(manifest, Equals, `./a/b 307372fa8fd5c146b22ae7a45b49bc31+6 0:6:c.out
1904 `)
1905                         }
1906                 }
1907         }
1908 }
1909
1910 func (s *TestSuite) TestStderrMount(c *C) {
1911         api, cr, _ := s.fullRunHelper(c, `{
1912     "command": ["/bin/sh", "-c", "echo hello;exit 1"],
1913     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1914     "cwd": ".",
1915     "environment": {},
1916     "mounts": {"/tmp": {"kind": "tmp"},
1917                "stdout": {"kind": "file", "path": "/tmp/a/out.txt"},
1918                "stderr": {"kind": "file", "path": "/tmp/b/err.txt"}},
1919     "output_path": "/tmp",
1920     "priority": 1,
1921     "runtime_constraints": {}
1922 }`, nil, 1, func(t *TestDockerClient) {
1923                 t.logWriter.Write(dockerLog(1, "hello\n"))
1924                 t.logWriter.Write(dockerLog(2, "oops\n"))
1925                 t.logWriter.Close()
1926         })
1927
1928         final := api.CalledWith("container.state", "Complete")
1929         c.Assert(final, NotNil)
1930         c.Check(final["container"].(arvadosclient.Dict)["exit_code"], Equals, 1)
1931         c.Check(final["container"].(arvadosclient.Dict)["log"], NotNil)
1932
1933         c.Check(cr.ContainerArvClient.(*ArvTestClient).CalledWith("collection.manifest_text", "./a b1946ac92492d2347c6235b4d2611184+6 0:6:out.txt\n./b 38af5c54926b620264ab1501150cf189+5 0:5:err.txt\n"), NotNil)
1934 }
1935
1936 func (s *TestSuite) TestNumberRoundTrip(c *C) {
1937         kc := &KeepTestClient{}
1938         defer kc.Close()
1939         cr, err := NewContainerRunner(s.client, &ArvTestClient{callraw: true}, kc, nil, "zzzzz-zzzzz-zzzzzzzzzzzzzzz")
1940         c.Assert(err, IsNil)
1941         cr.fetchContainerRecord()
1942
1943         jsondata, err := json.Marshal(cr.Container.Mounts["/json"].Content)
1944
1945         c.Check(err, IsNil)
1946         c.Check(string(jsondata), Equals, `{"number":123456789123456789}`)
1947 }
1948
1949 func (s *TestSuite) TestFullBrokenDocker1(c *C) {
1950         tf, err := ioutil.TempFile("", "brokenNodeHook-")
1951         c.Assert(err, IsNil)
1952         defer os.Remove(tf.Name())
1953
1954         tf.Write([]byte(`#!/bin/sh
1955 exec echo killme
1956 `))
1957         tf.Close()
1958         os.Chmod(tf.Name(), 0700)
1959
1960         ech := tf.Name()
1961         brokenNodeHook = &ech
1962
1963         api, _, _ := s.fullRunHelper(c, `{
1964     "command": ["echo", "hello world"],
1965     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1966     "cwd": ".",
1967     "environment": {},
1968     "mounts": {"/tmp": {"kind": "tmp"} },
1969     "output_path": "/tmp",
1970     "priority": 1,
1971     "runtime_constraints": {}
1972 }`, nil, 2, func(t *TestDockerClient) {
1973                 t.logWriter.Write(dockerLog(1, "hello world\n"))
1974                 t.logWriter.Close()
1975         })
1976
1977         c.Check(api.CalledWith("container.state", "Queued"), NotNil)
1978         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*unable to run containers.*")
1979         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*Running broken node hook.*")
1980         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*killme.*")
1981
1982 }
1983
1984 func (s *TestSuite) TestFullBrokenDocker2(c *C) {
1985         ech := ""
1986         brokenNodeHook = &ech
1987
1988         api, _, _ := s.fullRunHelper(c, `{
1989     "command": ["echo", "hello world"],
1990     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
1991     "cwd": ".",
1992     "environment": {},
1993     "mounts": {"/tmp": {"kind": "tmp"} },
1994     "output_path": "/tmp",
1995     "priority": 1,
1996     "runtime_constraints": {}
1997 }`, nil, 2, func(t *TestDockerClient) {
1998                 t.logWriter.Write(dockerLog(1, "hello world\n"))
1999                 t.logWriter.Close()
2000         })
2001
2002         c.Check(api.CalledWith("container.state", "Queued"), NotNil)
2003         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*unable to run containers.*")
2004         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*No broken node hook.*")
2005 }
2006
2007 func (s *TestSuite) TestFullBrokenDocker3(c *C) {
2008         ech := ""
2009         brokenNodeHook = &ech
2010
2011         api, _, _ := s.fullRunHelper(c, `{
2012     "command": ["echo", "hello world"],
2013     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
2014     "cwd": ".",
2015     "environment": {},
2016     "mounts": {"/tmp": {"kind": "tmp"} },
2017     "output_path": "/tmp",
2018     "priority": 1,
2019     "runtime_constraints": {}
2020 }`, nil, 3, func(t *TestDockerClient) {
2021                 t.logWriter.Write(dockerLog(1, "hello world\n"))
2022                 t.logWriter.Close()
2023         })
2024
2025         c.Check(api.CalledWith("container.state", "Cancelled"), NotNil)
2026         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*unable to run containers.*")
2027 }
2028
2029 func (s *TestSuite) TestBadCommand1(c *C) {
2030         ech := ""
2031         brokenNodeHook = &ech
2032
2033         api, _, _ := s.fullRunHelper(c, `{
2034     "command": ["echo", "hello world"],
2035     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
2036     "cwd": ".",
2037     "environment": {},
2038     "mounts": {"/tmp": {"kind": "tmp"} },
2039     "output_path": "/tmp",
2040     "priority": 1,
2041     "runtime_constraints": {}
2042 }`, nil, 4, func(t *TestDockerClient) {
2043                 t.logWriter.Write(dockerLog(1, "hello world\n"))
2044                 t.logWriter.Close()
2045         })
2046
2047         c.Check(api.CalledWith("container.state", "Cancelled"), NotNil)
2048         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*Possible causes:.*is missing.*")
2049 }
2050
2051 func (s *TestSuite) TestBadCommand2(c *C) {
2052         ech := ""
2053         brokenNodeHook = &ech
2054
2055         api, _, _ := s.fullRunHelper(c, `{
2056     "command": ["echo", "hello world"],
2057     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
2058     "cwd": ".",
2059     "environment": {},
2060     "mounts": {"/tmp": {"kind": "tmp"} },
2061     "output_path": "/tmp",
2062     "priority": 1,
2063     "runtime_constraints": {}
2064 }`, nil, 5, func(t *TestDockerClient) {
2065                 t.logWriter.Write(dockerLog(1, "hello world\n"))
2066                 t.logWriter.Close()
2067         })
2068
2069         c.Check(api.CalledWith("container.state", "Cancelled"), NotNil)
2070         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*Possible causes:.*is missing.*")
2071 }
2072
2073 func (s *TestSuite) TestBadCommand3(c *C) {
2074         ech := ""
2075         brokenNodeHook = &ech
2076
2077         api, _, _ := s.fullRunHelper(c, `{
2078     "command": ["echo", "hello world"],
2079     "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
2080     "cwd": ".",
2081     "environment": {},
2082     "mounts": {"/tmp": {"kind": "tmp"} },
2083     "output_path": "/tmp",
2084     "priority": 1,
2085     "runtime_constraints": {}
2086 }`, nil, 6, func(t *TestDockerClient) {
2087                 t.logWriter.Write(dockerLog(1, "hello world\n"))
2088                 t.logWriter.Close()
2089         })
2090
2091         c.Check(api.CalledWith("container.state", "Cancelled"), NotNil)
2092         c.Check(api.Logs["crunch-run"].String(), Matches, "(?ms).*Possible causes:.*is missing.*")
2093 }
2094
2095 func (s *TestSuite) TestSecretTextMountPoint(c *C) {
2096         // under normal mounts, gets captured in output, oops
2097         helperRecord := `{
2098                 "command": ["true"],
2099                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
2100                 "cwd": "/bin",
2101                 "mounts": {
2102                     "/tmp": {"kind": "tmp"},
2103                     "/tmp/secret.conf": {"kind": "text", "content": "mypassword"}
2104                 },
2105                 "secret_mounts": {
2106                 },
2107                 "output_path": "/tmp",
2108                 "priority": 1,
2109                 "runtime_constraints": {}
2110         }`
2111
2112         api, cr, _ := s.fullRunHelper(c, helperRecord, nil, 0, func(t *TestDockerClient) {
2113                 content, err := ioutil.ReadFile(t.realTemp + "/tmp2/secret.conf")
2114                 c.Check(err, IsNil)
2115                 c.Check(content, DeepEquals, []byte("mypassword"))
2116                 t.logWriter.Close()
2117         })
2118
2119         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
2120         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
2121         c.Check(cr.ContainerArvClient.(*ArvTestClient).CalledWith("collection.manifest_text", ". 34819d7beeabb9260a5c854bc85b3e44+10 0:10:secret.conf\n"), NotNil)
2122         c.Check(cr.ContainerArvClient.(*ArvTestClient).CalledWith("collection.manifest_text", ""), IsNil)
2123
2124         // under secret mounts, not captured in output
2125         helperRecord = `{
2126                 "command": ["true"],
2127                 "container_image": "d4ab34d3d4f8a72f5c4973051ae69fab+122",
2128                 "cwd": "/bin",
2129                 "mounts": {
2130                     "/tmp": {"kind": "tmp"}
2131                 },
2132                 "secret_mounts": {
2133                     "/tmp/secret.conf": {"kind": "text", "content": "mypassword"}
2134                 },
2135                 "output_path": "/tmp",
2136                 "priority": 1,
2137                 "runtime_constraints": {}
2138         }`
2139
2140         api, cr, _ = s.fullRunHelper(c, helperRecord, nil, 0, func(t *TestDockerClient) {
2141                 content, err := ioutil.ReadFile(t.realTemp + "/tmp2/secret.conf")
2142                 c.Check(err, IsNil)
2143                 c.Check(content, DeepEquals, []byte("mypassword"))
2144                 t.logWriter.Close()
2145         })
2146
2147         c.Check(api.CalledWith("container.exit_code", 0), NotNil)
2148         c.Check(api.CalledWith("container.state", "Complete"), NotNil)
2149         c.Check(cr.ContainerArvClient.(*ArvTestClient).CalledWith("collection.manifest_text", ". 34819d7beeabb9260a5c854bc85b3e44+10 0:10:secret.conf\n"), IsNil)
2150         c.Check(cr.ContainerArvClient.(*ArvTestClient).CalledWith("collection.manifest_text", ""), NotNil)
2151 }
2152
2153 type FakeProcess struct {
2154         cmdLine []string
2155 }
2156
2157 func (fp FakeProcess) CmdlineSlice() ([]string, error) {
2158         return fp.cmdLine, nil
2159 }