18 "git.curoverse.com/arvados.git/sdk/go/arvados"
19 "git.curoverse.com/arvados.git/sdk/go/arvadosclient"
20 "git.curoverse.com/arvados.git/sdk/go/arvadostest"
21 "git.curoverse.com/arvados.git/sdk/go/dispatch"
25 // Gocheck boilerplate
26 func Test(t *testing.T) {
30 var _ = Suite(&TestSuite{})
31 var _ = Suite(&MockArvadosServerSuite{})
33 type TestSuite struct{}
34 type MockArvadosServerSuite struct{}
36 var initialArgs []string
38 func (s *TestSuite) SetUpSuite(c *C) {
42 func (s *TestSuite) TearDownSuite(c *C) {
45 func (s *TestSuite) SetUpTest(c *C) {
46 args := []string{"crunch-dispatch-slurm"}
49 arvadostest.StartAPI()
50 os.Setenv("ARVADOS_API_TOKEN", arvadostest.Dispatch1Token)
53 func (s *TestSuite) TearDownTest(c *C) {
58 func (s *MockArvadosServerSuite) TearDownTest(c *C) {
59 arvadostest.ResetEnv()
62 func (s *TestSuite) TestIntegrationNormal(c *C) {
64 container := s.integrationTest(c,
67 return exec.Command("true")
69 return exec.Command("echo", "zzzzz-dz642-queuedcontainer")
73 func(dispatcher *dispatch.Dispatcher, container arvados.Container) {
74 dispatcher.UpdateState(container.UUID, dispatch.Running)
75 time.Sleep(3 * time.Second)
76 dispatcher.UpdateState(container.UUID, dispatch.Complete)
79 c.Check(container.State, Equals, arvados.ContainerStateComplete)
82 func (s *TestSuite) TestIntegrationCancel(c *C) {
84 var scancelCmdLine []string
85 defer func(orig func(arvados.Container) *exec.Cmd) {
89 scancelCmd = func(container arvados.Container) *exec.Cmd {
90 if attempt++; attempt == 1 {
91 return exec.Command("false")
93 scancelCmdLine = scancelFunc(container).Args
94 cmd = exec.Command("echo")
99 container := s.integrationTest(c,
101 if cmd != nil && cmd.ProcessState != nil {
102 return exec.Command("true")
104 return exec.Command("echo", "zzzzz-dz642-queuedcontainer")
108 func(dispatcher *dispatch.Dispatcher, container arvados.Container) {
109 dispatcher.UpdateState(container.UUID, dispatch.Running)
110 time.Sleep(1 * time.Second)
111 dispatcher.Arv.Update("containers", container.UUID,
113 "container": arvadosclient.Dict{"priority": 0}},
116 c.Check(container.State, Equals, arvados.ContainerStateCancelled)
117 c.Check(scancelCmdLine, DeepEquals, []string{"scancel", "--name=zzzzz-dz642-queuedcontainer"})
120 func (s *TestSuite) TestIntegrationMissingFromSqueue(c *C) {
121 container := s.integrationTest(c, func() *exec.Cmd { return exec.Command("echo") }, []string{"sbatch", "--share",
122 fmt.Sprintf("--job-name=%s", "zzzzz-dz642-queuedcontainer"),
123 fmt.Sprintf("--mem-per-cpu=%d", 2862),
124 fmt.Sprintf("--cpus-per-task=%d", 4)},
125 func(dispatcher *dispatch.Dispatcher, container arvados.Container) {
126 dispatcher.UpdateState(container.UUID, dispatch.Running)
127 time.Sleep(3 * time.Second)
128 dispatcher.UpdateState(container.UUID, dispatch.Complete)
130 c.Check(container.State, Equals, arvados.ContainerStateCancelled)
133 func (s *TestSuite) integrationTest(c *C,
134 newSqueueCmd func() *exec.Cmd,
135 sbatchCmdComps []string,
136 runContainer func(*dispatch.Dispatcher, arvados.Container)) arvados.Container {
137 arvadostest.ResetEnv()
139 arv, err := arvadosclient.MakeArvadosClient()
142 var sbatchCmdLine []string
144 // Override sbatchCmd
145 defer func(orig func(arvados.Container) *exec.Cmd) {
148 sbatchCmd = func(container arvados.Container) *exec.Cmd {
149 sbatchCmdLine = sbatchFunc(container).Args
150 return exec.Command("sh")
153 // Override squeueCmd
154 defer func(orig func() *exec.Cmd) {
157 squeueCmd = newSqueueCmd
159 // There should be one queued container
160 params := arvadosclient.Dict{
161 "filters": [][]string{{"state", "=", "Queued"}},
163 var containers arvados.ContainerList
164 err = arv.List("containers", params, &containers)
166 c.Check(len(containers.Items), Equals, 1)
168 theConfig.CrunchRunCommand = []string{"echo"}
170 ctx, cancel := context.WithCancel(context.Background())
171 dispatcher := dispatch.Dispatcher{
173 PollPeriod: time.Duration(1) * time.Second,
174 RunContainer: func(disp *dispatch.Dispatcher, ctr arvados.Container, status <-chan arvados.Container) {
175 go runContainer(disp, ctr)
176 run(disp, ctr, status)
181 sqCheck = &SqueueChecker{Period: 500 * time.Millisecond}
183 err = dispatcher.Run(ctx)
184 c.Assert(err, Equals, context.Canceled)
188 c.Check(sbatchCmdLine, DeepEquals, sbatchCmdComps)
190 // There should be no queued containers now
191 err = arv.List("containers", params, &containers)
193 c.Check(len(containers.Items), Equals, 0)
195 // Previously "Queued" container should now be in "Complete" state
196 var container arvados.Container
197 err = arv.Get("containers", "zzzzz-dz642-queuedcontainer", nil, &container)
202 func (s *MockArvadosServerSuite) TestAPIErrorGettingContainers(c *C) {
203 apiStubResponses := make(map[string]arvadostest.StubResponse)
204 apiStubResponses["/arvados/v1/api_client_authorizations/current"] = arvadostest.StubResponse{200, `{"uuid":"` + arvadostest.Dispatch1AuthUUID + `"}`}
205 apiStubResponses["/arvados/v1/containers"] = arvadostest.StubResponse{500, string(`{}`)}
207 testWithServerStub(c, apiStubResponses, "echo", "Error getting list of containers")
210 func testWithServerStub(c *C, apiStubResponses map[string]arvadostest.StubResponse, crunchCmd string, expected string) {
211 apiStub := arvadostest.ServerStub{apiStubResponses}
213 api := httptest.NewServer(&apiStub)
216 arv := &arvadosclient.ArvadosClient{
218 ApiServer: api.URL[7:],
220 Client: &http.Client{Transport: &http.Transport{}},
224 buf := bytes.NewBuffer(nil)
225 log.SetOutput(io.MultiWriter(buf, os.Stderr))
226 defer log.SetOutput(os.Stderr)
228 theConfig.CrunchRunCommand = []string{crunchCmd}
230 ctx, cancel := context.WithCancel(context.Background())
231 dispatcher := dispatch.Dispatcher{
233 PollPeriod: time.Duration(1) * time.Second,
234 RunContainer: func(disp *dispatch.Dispatcher, ctr arvados.Container, status <-chan arvados.Container) {
236 time.Sleep(1 * time.Second)
237 disp.UpdateState(ctr.UUID, dispatch.Running)
238 disp.UpdateState(ctr.UUID, dispatch.Complete)
240 run(disp, ctr, status)
246 for i := 0; i < 80 && !strings.Contains(buf.String(), expected); i++ {
247 time.Sleep(100 * time.Millisecond)
252 err := dispatcher.Run(ctx)
253 c.Assert(err, Equals, context.Canceled)
255 c.Check(buf.String(), Matches, `(?ms).*`+expected+`.*`)
258 func (s *MockArvadosServerSuite) TestNoSuchConfigFile(c *C) {
260 err := readConfig(&config, "/nosuchdir89j7879/8hjwr7ojgyy7")
261 c.Assert(err, NotNil)
264 func (s *MockArvadosServerSuite) TestBadSbatchArgsConfig(c *C) {
267 tmpfile, err := ioutil.TempFile(os.TempDir(), "config")
269 defer os.Remove(tmpfile.Name())
271 _, err = tmpfile.Write([]byte(`{"SbatchArguments": "oops this is not a string array"}`))
274 err = readConfig(&config, tmpfile.Name())
275 c.Assert(err, NotNil)
278 func (s *MockArvadosServerSuite) TestNoSuchArgInConfigIgnored(c *C) {
281 tmpfile, err := ioutil.TempFile(os.TempDir(), "config")
283 defer os.Remove(tmpfile.Name())
285 _, err = tmpfile.Write([]byte(`{"NoSuchArg": "Nobody loves me, not one tiny hunk."}`))
288 err = readConfig(&config, tmpfile.Name())
290 c.Check(0, Equals, len(config.SbatchArguments))
293 func (s *MockArvadosServerSuite) TestReadConfig(c *C) {
296 tmpfile, err := ioutil.TempFile(os.TempDir(), "config")
298 defer os.Remove(tmpfile.Name())
300 args := []string{"--arg1=v1", "--arg2", "--arg3=v3"}
301 argsS := `{"SbatchArguments": ["--arg1=v1", "--arg2", "--arg3=v3"]}`
302 _, err = tmpfile.Write([]byte(argsS))
305 err = readConfig(&config, tmpfile.Name())
307 c.Check(3, Equals, len(config.SbatchArguments))
308 c.Check(args, DeepEquals, config.SbatchArguments)
311 func (s *MockArvadosServerSuite) TestSbatchFuncWithNoConfigArgs(c *C) {
312 testSbatchFuncWithArgs(c, nil)
315 func (s *MockArvadosServerSuite) TestSbatchFuncWithEmptyConfigArgs(c *C) {
316 testSbatchFuncWithArgs(c, []string{})
319 func (s *MockArvadosServerSuite) TestSbatchFuncWithConfigArgs(c *C) {
320 testSbatchFuncWithArgs(c, []string{"--arg1=v1", "--arg2"})
323 func testSbatchFuncWithArgs(c *C, args []string) {
324 theConfig.SbatchArguments = append(theConfig.SbatchArguments, args...)
326 container := arvados.Container{UUID: "123", RuntimeConstraints: arvados.RuntimeConstraints{RAM: 250000000, VCPUs: 2}}
327 sbatchCmd := sbatchFunc(container)
329 var expected []string
330 expected = append(expected, "sbatch", "--share")
331 expected = append(expected, theConfig.SbatchArguments...)
332 expected = append(expected, "--job-name=123", "--mem-per-cpu=120", "--cpus-per-task=2")
334 c.Check(sbatchCmd.Args, DeepEquals, expected)
337 func (s *MockArvadosServerSuite) TestSbatchPartition(c *C) {
338 theConfig.SbatchArguments = nil
339 container := arvados.Container{UUID: "123", RuntimeConstraints: arvados.RuntimeConstraints{RAM: 250000000, VCPUs: 1}, SchedulingParameters: arvados.SchedulingParameters{Partitions: []string{"blurb", "b2"}}}
340 sbatchCmd := sbatchFunc(container)
342 var expected []string
343 expected = append(expected, "sbatch", "--share")
344 expected = append(expected, "--job-name=123", "--mem-per-cpu=239", "--cpus-per-task=1", "--partition=blurb,b2")
346 c.Check(sbatchCmd.Args, DeepEquals, expected)