lib/controller/localdb/login_oidc_test.go

   1 // Copyright (C) The Arvados Authors. All rights reserved.
   2 //
   3 // SPDX-License-Identifier: AGPL-3.0
   4
   5 package localdb
   6
   7 import (
   8         "bytes"
   9         "context"
  10         "crypto/hmac"
  11         "crypto/sha256"
  12         "encoding/json"
  13         "fmt"
  14         "io"
  15         "net/http"
  16         "net/http/httptest"
  17         "net/url"
  18         "sort"
  19         "strings"
  20         "testing"
  21         "time"
  22
  23         "git.arvados.org/arvados.git/lib/config"
  24         "git.arvados.org/arvados.git/lib/controller/rpc"
  25         "git.arvados.org/arvados.git/sdk/go/arvados"
  26         "git.arvados.org/arvados.git/sdk/go/arvadostest"
  27         "git.arvados.org/arvados.git/sdk/go/auth"
  28         "git.arvados.org/arvados.git/sdk/go/ctxlog"
  29         "github.com/jmoiron/sqlx"
  30         check "gopkg.in/check.v1"
  31 )
  32
  33 // Gocheck boilerplate
  34 func Test(t *testing.T) {
  35         check.TestingT(t)
  36 }
  37
  38 var _ = check.Suite(&OIDCLoginSuite{})
  39
  40 type OIDCLoginSuite struct {
  41         cluster      *arvados.Cluster
  42         localdb      *Conn
  43         railsSpy     *arvadostest.Proxy
  44         fakeProvider *arvadostest.OIDCProvider
  45 }
  46
  47 func (s *OIDCLoginSuite) TearDownSuite(c *check.C) {
  48         // Undo any changes/additions to the user database so they
  49         // don't affect subsequent tests.
  50         arvadostest.ResetEnv()
  51         c.Check(arvados.NewClientFromEnv().RequestAndDecode(nil, "POST", "database/reset", nil, nil), check.IsNil)
  52 }
  53
  54 func (s *OIDCLoginSuite) SetUpTest(c *check.C) {
  55         s.fakeProvider = arvadostest.NewOIDCProvider(c)
  56         s.fakeProvider.AuthEmail = "active-user@arvados.local"
  57         s.fakeProvider.AuthEmailVerified = true
  58         s.fakeProvider.AuthName = "Fake User Name"
  59         s.fakeProvider.ValidCode = fmt.Sprintf("abcdefgh-%d", time.Now().Unix())
  60         s.fakeProvider.PeopleAPIResponse = map[string]interface{}{}
  61
  62         cfg, err := config.NewLoader(nil, ctxlog.TestLogger(c)).Load()
  63         c.Assert(err, check.IsNil)
  64         s.cluster, err = cfg.GetCluster("")
  65         c.Assert(err, check.IsNil)
  66         s.cluster.Login.SSO.Enable = false
  67         s.cluster.Login.Google.Enable = true
  68         s.cluster.Login.Google.ClientID = "test%client$id"
  69         s.cluster.Login.Google.ClientSecret = "test#client/secret"
  70         s.cluster.Users.PreferDomainForUsername = "PreferDomainForUsername.example.com"
  71         s.fakeProvider.ValidClientID = "test%client$id"
  72         s.fakeProvider.ValidClientSecret = "test#client/secret"
  73
  74         s.localdb = NewConn(s.cluster)
  75         c.Assert(s.localdb.loginController, check.FitsTypeOf, (*oidcLoginController)(nil))
  76         s.localdb.loginController.(*oidcLoginController).Issuer = s.fakeProvider.Issuer.URL
  77         s.localdb.loginController.(*oidcLoginController).peopleAPIBasePath = s.fakeProvider.PeopleAPI.URL
  78
  79         s.railsSpy = arvadostest.NewProxy(c, s.cluster.Services.RailsAPI)
  80         *s.localdb.railsProxy = *rpc.NewConn(s.cluster.ClusterID, s.railsSpy.URL, true, rpc.PassthroughTokenProvider)
  81 }
  82
  83 func (s *OIDCLoginSuite) TearDownTest(c *check.C) {
  84         s.railsSpy.Close()
  85 }
  86
  87 func (s *OIDCLoginSuite) TestGoogleLogout(c *check.C) {
  88         resp, err := s.localdb.Logout(context.Background(), arvados.LogoutOptions{ReturnTo: "https://foo.example.com/bar"})
  89         c.Check(err, check.IsNil)
  90         c.Check(resp.RedirectLocation, check.Equals, "https://foo.example.com/bar")
  91 }
  92
  93 func (s *OIDCLoginSuite) TestGoogleLogin_Start_Bogus(c *check.C) {
  94         resp, err := s.localdb.Login(context.Background(), arvados.LoginOptions{})
  95         c.Check(err, check.IsNil)
  96         c.Check(resp.RedirectLocation, check.Equals, "")
  97         c.Check(resp.HTML.String(), check.Matches, `.*missing return_to parameter.*`)
  98 }
  99
 100 func (s *OIDCLoginSuite) TestGoogleLogin_Start(c *check.C) {
 101         for _, remote := range []string{"", "zzzzz"} {
 102                 resp, err := s.localdb.Login(context.Background(), arvados.LoginOptions{Remote: remote, ReturnTo: "https://app.example.com/foo?bar"})
 103                 c.Check(err, check.IsNil)
 104                 target, err := url.Parse(resp.RedirectLocation)
 105                 c.Check(err, check.IsNil)
 106                 issuerURL, _ := url.Parse(s.fakeProvider.Issuer.URL)
 107                 c.Check(target.Host, check.Equals, issuerURL.Host)
 108                 q := target.Query()
 109                 c.Check(q.Get("client_id"), check.Equals, "test%client$id")
 110                 state := s.localdb.loginController.(*oidcLoginController).parseOAuth2State(q.Get("state"))
 111                 c.Check(state.verify([]byte(s.cluster.SystemRootToken)), check.Equals, true)
 112                 c.Check(state.Time, check.Not(check.Equals), 0)
 113                 c.Check(state.Remote, check.Equals, remote)
 114                 c.Check(state.ReturnTo, check.Equals, "https://app.example.com/foo?bar")
 115         }
 116 }
 117
 118 func (s *OIDCLoginSuite) TestGoogleLogin_InvalidCode(c *check.C) {
 119         state := s.startLogin(c)
 120         resp, err := s.localdb.Login(context.Background(), arvados.LoginOptions{
 121                 Code:  "first-try-a-bogus-code",
 122                 State: state,
 123         })
 124         c.Check(err, check.IsNil)
 125         c.Check(resp.RedirectLocation, check.Equals, "")
 126         c.Check(resp.HTML.String(), check.Matches, `(?ms).*error in OAuth2 exchange.*cannot fetch token.*`)
 127 }
 128
 129 func (s *OIDCLoginSuite) TestGoogleLogin_InvalidState(c *check.C) {
 130         s.startLogin(c)
 131         resp, err := s.localdb.Login(context.Background(), arvados.LoginOptions{
 132                 Code:  s.fakeProvider.ValidCode,
 133                 State: "bogus-state",
 134         })
 135         c.Check(err, check.IsNil)
 136         c.Check(resp.RedirectLocation, check.Equals, "")
 137         c.Check(resp.HTML.String(), check.Matches, `(?ms).*invalid OAuth2 state.*`)
 138 }
 139
 140 func (s *OIDCLoginSuite) setupPeopleAPIError(c *check.C) {
 141         s.fakeProvider.PeopleAPI = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
 142                 w.WriteHeader(http.StatusForbidden)
 143                 fmt.Fprintln(w, `Error 403: accessNotConfigured`)
 144         }))
 145         s.localdb.loginController.(*oidcLoginController).peopleAPIBasePath = s.fakeProvider.PeopleAPI.URL
 146 }
 147
 148 func (s *OIDCLoginSuite) TestGoogleLogin_PeopleAPIDisabled(c *check.C) {
 149         s.localdb.loginController.(*oidcLoginController).UseGooglePeopleAPI = false
 150         s.fakeProvider.AuthEmail = "joe.smith@primary.example.com"
 151         s.setupPeopleAPIError(c)
 152         state := s.startLogin(c)
 153         _, err := s.localdb.Login(context.Background(), arvados.LoginOptions{
 154                 Code:  s.fakeProvider.ValidCode,
 155                 State: state,
 156         })
 157         c.Check(err, check.IsNil)
 158         authinfo := getCallbackAuthInfo(c, s.railsSpy)
 159         c.Check(authinfo.Email, check.Equals, "joe.smith@primary.example.com")
 160 }
 161
 162 func (s *OIDCLoginSuite) TestConfig(c *check.C) {
 163         s.cluster.Login.Google.Enable = false
 164         s.cluster.Login.OpenIDConnect.Enable = true
 165         s.cluster.Login.OpenIDConnect.Issuer = "https://accounts.example.com/"
 166         s.cluster.Login.OpenIDConnect.ClientID = "oidc-client-id"
 167         s.cluster.Login.OpenIDConnect.ClientSecret = "oidc-client-secret"
 168         s.cluster.Login.OpenIDConnect.AuthenticationRequestParameters = map[string]string{"testkey": "testvalue"}
 169         localdb := NewConn(s.cluster)
 170         ctrl := localdb.loginController.(*oidcLoginController)
 171         c.Check(ctrl.Issuer, check.Equals, "https://accounts.example.com/")
 172         c.Check(ctrl.ClientID, check.Equals, "oidc-client-id")
 173         c.Check(ctrl.ClientSecret, check.Equals, "oidc-client-secret")
 174         c.Check(ctrl.UseGooglePeopleAPI, check.Equals, false)
 175         c.Check(ctrl.AuthParams["testkey"], check.Equals, "testvalue")
 176
 177         for _, enableAltEmails := range []bool{false, true} {
 178                 s.cluster.Login.OpenIDConnect.Enable = false
 179                 s.cluster.Login.Google.Enable = true
 180                 s.cluster.Login.Google.ClientID = "google-client-id"
 181                 s.cluster.Login.Google.ClientSecret = "google-client-secret"
 182                 s.cluster.Login.Google.AlternateEmailAddresses = enableAltEmails
 183                 s.cluster.Login.Google.AuthenticationRequestParameters = map[string]string{"testkey": "testvalue"}
 184                 localdb = NewConn(s.cluster)
 185                 ctrl = localdb.loginController.(*oidcLoginController)
 186                 c.Check(ctrl.Issuer, check.Equals, "https://accounts.google.com")
 187                 c.Check(ctrl.ClientID, check.Equals, "google-client-id")
 188                 c.Check(ctrl.ClientSecret, check.Equals, "google-client-secret")
 189                 c.Check(ctrl.UseGooglePeopleAPI, check.Equals, enableAltEmails)
 190                 c.Check(ctrl.AuthParams["testkey"], check.Equals, "testvalue")
 191         }
 192 }
 193
 194 func (s *OIDCLoginSuite) TestGoogleLogin_PeopleAPIError(c *check.C) {
 195         s.setupPeopleAPIError(c)
 196         state := s.startLogin(c)
 197         resp, err := s.localdb.Login(context.Background(), arvados.LoginOptions{
 198                 Code:  s.fakeProvider.ValidCode,
 199                 State: state,
 200         })
 201         c.Check(err, check.IsNil)
 202         c.Check(resp.RedirectLocation, check.Equals, "")
 203 }
 204
 205 func (s *OIDCLoginSuite) TestOIDCAuthorizer(c *check.C) {
 206         s.cluster.Login.Google.Enable = false
 207         s.cluster.Login.OpenIDConnect.Enable = true
 208         json.Unmarshal([]byte(fmt.Sprintf("%q", s.fakeProvider.Issuer.URL)), &s.cluster.Login.OpenIDConnect.Issuer)
 209         s.cluster.Login.OpenIDConnect.ClientID = "oidc#client#id"
 210         s.cluster.Login.OpenIDConnect.ClientSecret = "oidc#client#secret"
 211         s.fakeProvider.ValidClientID = "oidc#client#id"
 212         s.fakeProvider.ValidClientSecret = "oidc#client#secret"
 213         db := arvadostest.DB(c, s.cluster)
 214
 215         tokenCacheTTL = time.Millisecond
 216         tokenCacheRaceWindow = time.Millisecond
 217
 218         oidcAuthorizer := OIDCAccessTokenAuthorizer(s.cluster, func(context.Context) (*sqlx.DB, error) { return db, nil })
 219         accessToken := s.fakeProvider.ValidAccessToken()
 220
 221         mac := hmac.New(sha256.New, []byte(s.cluster.SystemRootToken))
 222         io.WriteString(mac, accessToken)
 223         hmac := fmt.Sprintf("%x", mac.Sum(nil))
 224
 225         cleanup := func() {
 226                 _, err := db.Exec(`delete from api_client_authorizations where api_token=$1`, hmac)
 227                 c.Check(err, check.IsNil)
 228         }
 229         cleanup()
 230         defer cleanup()
 231
 232         ctx := auth.NewContext(context.Background(), &auth.Credentials{Tokens: []string{accessToken}})
 233         var exp1 time.Time
 234         oidcAuthorizer.WrapCalls(func(ctx context.Context, opts interface{}) (interface{}, error) {
 235                 creds, ok := auth.FromContext(ctx)
 236                 c.Assert(ok, check.Equals, true)
 237                 c.Assert(creds.Tokens, check.HasLen, 1)
 238                 c.Check(creds.Tokens[0], check.Equals, accessToken)
 239
 240                 err := db.QueryRowContext(ctx, `select expires_at at time zone 'UTC' from api_client_authorizations where api_token=$1`, hmac).Scan(&exp1)
 241                 c.Check(err, check.IsNil)
 242                 c.Check(exp1.Sub(time.Now()) > -time.Second, check.Equals, true)
 243                 c.Check(exp1.Sub(time.Now()) < time.Second, check.Equals, true)
 244                 return nil, nil
 245         })(ctx, nil)
 246
 247         // If the token is used again after the in-memory cache
 248         // expires, oidcAuthorizer must re-checks the token and update
 249         // the expires_at value in the database.
 250         time.Sleep(3 * time.Millisecond)
 251         oidcAuthorizer.WrapCalls(func(ctx context.Context, opts interface{}) (interface{}, error) {
 252                 var exp time.Time
 253                 err := db.QueryRowContext(ctx, `select expires_at at time zone 'UTC' from api_client_authorizations where api_token=$1`, hmac).Scan(&exp)
 254                 c.Check(err, check.IsNil)
 255                 c.Check(exp.Sub(exp1) > 0, check.Equals, true)
 256                 c.Check(exp.Sub(exp1) < time.Second, check.Equals, true)
 257                 return nil, nil
 258         })(ctx, nil)
 259 }
 260
 261 func (s *OIDCLoginSuite) TestGenericOIDCLogin(c *check.C) {
 262         s.cluster.Login.Google.Enable = false
 263         s.cluster.Login.OpenIDConnect.Enable = true
 264         json.Unmarshal([]byte(fmt.Sprintf("%q", s.fakeProvider.Issuer.URL)), &s.cluster.Login.OpenIDConnect.Issuer)
 265         s.cluster.Login.OpenIDConnect.ClientID = "oidc#client#id"
 266         s.cluster.Login.OpenIDConnect.ClientSecret = "oidc#client#secret"
 267         s.cluster.Login.OpenIDConnect.AuthenticationRequestParameters = map[string]string{"testkey": "testvalue"}
 268         s.fakeProvider.ValidClientID = "oidc#client#id"
 269         s.fakeProvider.ValidClientSecret = "oidc#client#secret"
 270         for _, trial := range []struct {
 271                 expectEmail string // "" if failure expected
 272                 setup       func()
 273         }{
 274                 {
 275                         expectEmail: "user@oidc.example.com",
 276                         setup: func() {
 277                                 c.Log("=== succeed because email_verified is false but not required")
 278                                 s.fakeProvider.AuthEmail = "user@oidc.example.com"
 279                                 s.fakeProvider.AuthEmailVerified = false
 280                                 s.cluster.Login.OpenIDConnect.EmailClaim = "email"
 281                                 s.cluster.Login.OpenIDConnect.EmailVerifiedClaim = ""
 282                                 s.cluster.Login.OpenIDConnect.UsernameClaim = ""
 283                         },
 284                 },
 285                 {
 286                         expectEmail: "",
 287                         setup: func() {
 288                                 c.Log("=== fail because email_verified is false and required")
 289                                 s.fakeProvider.AuthEmail = "user@oidc.example.com"
 290                                 s.fakeProvider.AuthEmailVerified = false
 291                                 s.cluster.Login.OpenIDConnect.EmailClaim = "email"
 292                                 s.cluster.Login.OpenIDConnect.EmailVerifiedClaim = "email_verified"
 293                                 s.cluster.Login.OpenIDConnect.UsernameClaim = ""
 294                         },
 295                 },
 296                 {
 297                         expectEmail: "user@oidc.example.com",
 298                         setup: func() {
 299                                 c.Log("=== succeed because email_verified is false but config uses custom 'verified' claim")
 300                                 s.fakeProvider.AuthEmail = "user@oidc.example.com"
 301                                 s.fakeProvider.AuthEmailVerified = false
 302                                 s.cluster.Login.OpenIDConnect.EmailClaim = "email"
 303                                 s.cluster.Login.OpenIDConnect.EmailVerifiedClaim = "alt_verified"
 304                                 s.cluster.Login.OpenIDConnect.UsernameClaim = ""
 305                         },
 306                 },
 307                 {
 308                         expectEmail: "alt_email@example.com",
 309                         setup: func() {
 310                                 c.Log("=== succeed with custom 'email' and 'email_verified' claims")
 311                                 s.fakeProvider.AuthEmail = "bad@wrong.example.com"
 312                                 s.fakeProvider.AuthEmailVerified = false
 313                                 s.cluster.Login.OpenIDConnect.EmailClaim = "alt_email"
 314                                 s.cluster.Login.OpenIDConnect.EmailVerifiedClaim = "alt_verified"
 315                                 s.cluster.Login.OpenIDConnect.UsernameClaim = "alt_username"
 316                         },
 317                 },
 318         } {
 319                 trial.setup()
 320                 if s.railsSpy != nil {
 321                         s.railsSpy.Close()
 322                 }
 323                 s.railsSpy = arvadostest.NewProxy(c, s.cluster.Services.RailsAPI)
 324                 s.localdb = NewConn(s.cluster)
 325                 *s.localdb.railsProxy = *rpc.NewConn(s.cluster.ClusterID, s.railsSpy.URL, true, rpc.PassthroughTokenProvider)
 326
 327                 state := s.startLogin(c, func(form url.Values) {
 328                         c.Check(form.Get("testkey"), check.Equals, "testvalue")
 329                 })
 330                 resp, err := s.localdb.Login(context.Background(), arvados.LoginOptions{
 331                         Code:  s.fakeProvider.ValidCode,
 332                         State: state,
 333                 })
 334                 c.Assert(err, check.IsNil)
 335                 if trial.expectEmail == "" {
 336                         c.Check(resp.HTML.String(), check.Matches, `(?ms).*Login error.*`)
 337                         c.Check(resp.RedirectLocation, check.Equals, "")
 338                         continue
 339                 }
 340                 c.Check(resp.HTML.String(), check.Equals, "")
 341                 target, err := url.Parse(resp.RedirectLocation)
 342                 c.Assert(err, check.IsNil)
 343                 token := target.Query().Get("api_token")
 344                 c.Check(token, check.Matches, `v2/zzzzz-gj3su-.{15}/.{32,50}`)
 345                 authinfo := getCallbackAuthInfo(c, s.railsSpy)
 346                 c.Check(authinfo.Email, check.Equals, trial.expectEmail)
 347
 348                 switch s.cluster.Login.OpenIDConnect.UsernameClaim {
 349                 case "alt_username":
 350                         c.Check(authinfo.Username, check.Equals, "desired-username")
 351                 case "":
 352                         c.Check(authinfo.Username, check.Equals, "")
 353                 default:
 354                         c.Fail() // bad test case
 355                 }
 356         }
 357 }
 358
 359 func (s *OIDCLoginSuite) TestGoogleLogin_Success(c *check.C) {
 360         s.cluster.Login.Google.AuthenticationRequestParameters["prompt"] = "consent"
 361         s.cluster.Login.Google.AuthenticationRequestParameters["foo"] = "bar"
 362         state := s.startLogin(c, func(form url.Values) {
 363                 c.Check(form.Get("foo"), check.Equals, "bar")
 364                 c.Check(form.Get("prompt"), check.Equals, "consent")
 365         })
 366         resp, err := s.localdb.Login(context.Background(), arvados.LoginOptions{
 367                 Code:  s.fakeProvider.ValidCode,
 368                 State: state,
 369         })
 370         c.Check(err, check.IsNil)
 371         c.Check(resp.HTML.String(), check.Equals, "")
 372         target, err := url.Parse(resp.RedirectLocation)
 373         c.Check(err, check.IsNil)
 374         c.Check(target.Host, check.Equals, "app.example.com")
 375         c.Check(target.Path, check.Equals, "/foo")
 376         token := target.Query().Get("api_token")
 377         c.Check(token, check.Matches, `v2/zzzzz-gj3su-.{15}/.{32,50}`)
 378
 379         authinfo := getCallbackAuthInfo(c, s.railsSpy)
 380         c.Check(authinfo.FirstName, check.Equals, "Fake User")
 381         c.Check(authinfo.LastName, check.Equals, "Name")
 382         c.Check(authinfo.Email, check.Equals, "active-user@arvados.local")
 383         c.Check(authinfo.AlternateEmails, check.HasLen, 0)
 384
 385         // Try using the returned Arvados token.
 386         c.Logf("trying an API call with new token %q", token)
 387         ctx := auth.NewContext(context.Background(), &auth.Credentials{Tokens: []string{token}})
 388         cl, err := s.localdb.CollectionList(ctx, arvados.ListOptions{Limit: -1})
 389         c.Check(cl.ItemsAvailable, check.Not(check.Equals), 0)
 390         c.Check(cl.Items, check.Not(check.HasLen), 0)
 391         c.Check(err, check.IsNil)
 392
 393         // Might as well check that bogus tokens aren't accepted.
 394         badtoken := token + "plussomeboguschars"
 395         c.Logf("trying an API call with mangled token %q", badtoken)
 396         ctx = auth.NewContext(context.Background(), &auth.Credentials{Tokens: []string{badtoken}})
 397         cl, err = s.localdb.CollectionList(ctx, arvados.ListOptions{Limit: -1})
 398         c.Check(cl.Items, check.HasLen, 0)
 399         c.Check(err, check.NotNil)
 400         c.Check(err, check.ErrorMatches, `.*401 Unauthorized: Not logged in.*`)
 401 }
 402
 403 func (s *OIDCLoginSuite) TestGoogleLogin_RealName(c *check.C) {
 404         s.fakeProvider.AuthEmail = "joe.smith@primary.example.com"
 405         s.fakeProvider.PeopleAPIResponse = map[string]interface{}{
 406                 "names": []map[string]interface{}{
 407                         {
 408                                 "metadata":   map[string]interface{}{"primary": false},
 409                                 "givenName":  "Joe",
 410                                 "familyName": "Smith",
 411                         },
 412                         {
 413                                 "metadata":   map[string]interface{}{"primary": true},
 414                                 "givenName":  "Joseph",
 415                                 "familyName": "Psmith",
 416                         },
 417                 },
 418         }
 419         state := s.startLogin(c)
 420         s.localdb.Login(context.Background(), arvados.LoginOptions{
 421                 Code:  s.fakeProvider.ValidCode,
 422                 State: state,
 423         })
 424
 425         authinfo := getCallbackAuthInfo(c, s.railsSpy)
 426         c.Check(authinfo.FirstName, check.Equals, "Joseph")
 427         c.Check(authinfo.LastName, check.Equals, "Psmith")
 428 }
 429
 430 func (s *OIDCLoginSuite) TestGoogleLogin_OIDCRealName(c *check.C) {
 431         s.fakeProvider.AuthName = "Joe P. Smith"
 432         s.fakeProvider.AuthEmail = "joe.smith@primary.example.com"
 433         state := s.startLogin(c)
 434         s.localdb.Login(context.Background(), arvados.LoginOptions{
 435                 Code:  s.fakeProvider.ValidCode,
 436                 State: state,
 437         })
 438
 439         authinfo := getCallbackAuthInfo(c, s.railsSpy)
 440         c.Check(authinfo.FirstName, check.Equals, "Joe P.")
 441         c.Check(authinfo.LastName, check.Equals, "Smith")
 442 }
 443
 444 // People API returns some additional email addresses.
 445 func (s *OIDCLoginSuite) TestGoogleLogin_AlternateEmailAddresses(c *check.C) {
 446         s.fakeProvider.AuthEmail = "joe.smith@primary.example.com"
 447         s.fakeProvider.PeopleAPIResponse = map[string]interface{}{
 448                 "emailAddresses": []map[string]interface{}{
 449                         {
 450                                 "metadata": map[string]interface{}{"verified": true},
 451                                 "value":    "joe.smith@work.example.com",
 452                         },
 453                         {
 454                                 "value": "joe.smith@unverified.example.com", // unverified, so this one will be ignored
 455                         },
 456                         {
 457                                 "metadata": map[string]interface{}{"verified": true},
 458                                 "value":    "joe.smith@home.example.com",
 459                         },
 460                 },
 461         }
 462         state := s.startLogin(c)
 463         s.localdb.Login(context.Background(), arvados.LoginOptions{
 464                 Code:  s.fakeProvider.ValidCode,
 465                 State: state,
 466         })
 467
 468         authinfo := getCallbackAuthInfo(c, s.railsSpy)
 469         c.Check(authinfo.Email, check.Equals, "joe.smith@primary.example.com")
 470         c.Check(authinfo.AlternateEmails, check.DeepEquals, []string{"joe.smith@home.example.com", "joe.smith@work.example.com"})
 471 }
 472
 473 // Primary address is not the one initially returned by oidc.
 474 func (s *OIDCLoginSuite) TestGoogleLogin_AlternateEmailAddresses_Primary(c *check.C) {
 475         s.fakeProvider.AuthEmail = "joe.smith@alternate.example.com"
 476         s.fakeProvider.PeopleAPIResponse = map[string]interface{}{
 477                 "emailAddresses": []map[string]interface{}{
 478                         {
 479                                 "metadata": map[string]interface{}{"verified": true, "primary": true},
 480                                 "value":    "joe.smith@primary.example.com",
 481                         },
 482                         {
 483                                 "metadata": map[string]interface{}{"verified": true},
 484                                 "value":    "joe.smith@alternate.example.com",
 485                         },
 486                         {
 487                                 "metadata": map[string]interface{}{"verified": true},
 488                                 "value":    "jsmith+123@preferdomainforusername.example.com",
 489                         },
 490                 },
 491         }
 492         state := s.startLogin(c)
 493         s.localdb.Login(context.Background(), arvados.LoginOptions{
 494                 Code:  s.fakeProvider.ValidCode,
 495                 State: state,
 496         })
 497         authinfo := getCallbackAuthInfo(c, s.railsSpy)
 498         c.Check(authinfo.Email, check.Equals, "joe.smith@primary.example.com")
 499         c.Check(authinfo.AlternateEmails, check.DeepEquals, []string{"joe.smith@alternate.example.com", "jsmith+123@preferdomainforusername.example.com"})
 500         c.Check(authinfo.Username, check.Equals, "jsmith")
 501 }
 502
 503 func (s *OIDCLoginSuite) TestGoogleLogin_NoPrimaryEmailAddress(c *check.C) {
 504         s.fakeProvider.AuthEmail = "joe.smith@unverified.example.com"
 505         s.fakeProvider.AuthEmailVerified = false
 506         s.fakeProvider.PeopleAPIResponse = map[string]interface{}{
 507                 "emailAddresses": []map[string]interface{}{
 508                         {
 509                                 "metadata": map[string]interface{}{"verified": true},
 510                                 "value":    "joe.smith@work.example.com",
 511                         },
 512                         {
 513                                 "metadata": map[string]interface{}{"verified": true},
 514                                 "value":    "joe.smith@home.example.com",
 515                         },
 516                 },
 517         }
 518         state := s.startLogin(c)
 519         s.localdb.Login(context.Background(), arvados.LoginOptions{
 520                 Code:  s.fakeProvider.ValidCode,
 521                 State: state,
 522         })
 523
 524         authinfo := getCallbackAuthInfo(c, s.railsSpy)
 525         c.Check(authinfo.Email, check.Equals, "joe.smith@work.example.com") // first verified email in People response
 526         c.Check(authinfo.AlternateEmails, check.DeepEquals, []string{"joe.smith@home.example.com"})
 527         c.Check(authinfo.Username, check.Equals, "")
 528 }
 529
 530 func (s *OIDCLoginSuite) startLogin(c *check.C, checks ...func(url.Values)) (state string) {
 531         // Initiate login, but instead of following the redirect to
 532         // the provider, just grab state from the redirect URL.
 533         resp, err := s.localdb.Login(context.Background(), arvados.LoginOptions{ReturnTo: "https://app.example.com/foo?bar"})
 534         c.Check(err, check.IsNil)
 535         target, err := url.Parse(resp.RedirectLocation)
 536         c.Check(err, check.IsNil)
 537         state = target.Query().Get("state")
 538         c.Check(state, check.Not(check.Equals), "")
 539         for _, fn := range checks {
 540                 fn(target.Query())
 541         }
 542         s.cluster.Login.OpenIDConnect.AuthenticationRequestParameters = map[string]string{"testkey": "testvalue"}
 543         return
 544 }
 545
 546 func getCallbackAuthInfo(c *check.C, railsSpy *arvadostest.Proxy) (authinfo rpc.UserSessionAuthInfo) {
 547         for _, dump := range railsSpy.RequestDumps {
 548                 c.Logf("spied request: %q", dump)
 549                 split := bytes.Split(dump, []byte("\r\n\r\n"))
 550                 c.Assert(split, check.HasLen, 2)
 551                 hdr, body := string(split[0]), string(split[1])
 552                 if strings.Contains(hdr, "POST /auth/controller/callback") {
 553                         vs, err := url.ParseQuery(body)
 554                         c.Check(json.Unmarshal([]byte(vs.Get("auth_info")), &authinfo), check.IsNil)
 555                         c.Check(err, check.IsNil)
 556                         sort.Strings(authinfo.AlternateEmails)
 557                         return
 558                 }
 559         }
 560         c.Error("callback not found")
 561         return
 562 }