16774: Keep-web errors include messages
[arvados.git] / services / keep-web / s3.go
1 // Copyright (C) The Arvados Authors. All rights reserved.
2 //
3 // SPDX-License-Identifier: AGPL-3.0
4
5 package main
6
7 import (
8         "crypto/hmac"
9         "crypto/sha256"
10         "encoding/xml"
11         "errors"
12         "fmt"
13         "hash"
14         "io"
15         "net/http"
16         "net/url"
17         "os"
18         "path/filepath"
19         "sort"
20         "strconv"
21         "strings"
22         "time"
23
24         "git.arvados.org/arvados.git/sdk/go/arvados"
25         "git.arvados.org/arvados.git/sdk/go/ctxlog"
26         "github.com/AdRoll/goamz/s3"
27 )
28
29 const (
30         s3MaxKeys       = 1000
31         s3SignAlgorithm = "AWS4-HMAC-SHA256"
32         s3MaxClockSkew  = 5 * time.Minute
33 )
34
35 func hmacstring(msg string, key []byte) []byte {
36         h := hmac.New(sha256.New, key)
37         io.WriteString(h, msg)
38         return h.Sum(nil)
39 }
40
41 func hashdigest(h hash.Hash, payload string) string {
42         io.WriteString(h, payload)
43         return fmt.Sprintf("%x", h.Sum(nil))
44 }
45
46 // Signing key for given secret key and request attrs.
47 func s3signatureKey(key, datestamp, regionName, serviceName string) []byte {
48         return hmacstring("aws4_request",
49                 hmacstring(serviceName,
50                         hmacstring(regionName,
51                                 hmacstring(datestamp, []byte("AWS4"+key)))))
52 }
53
54 // Canonical query string for S3 V4 signature: sorted keys, spaces
55 // escaped as %20 instead of +, keyvalues joined with &.
56 func s3querystring(u *url.URL) string {
57         keys := make([]string, 0, len(u.Query()))
58         values := make(map[string]string, len(u.Query()))
59         for k, vs := range u.Query() {
60                 k = strings.Replace(url.QueryEscape(k), "+", "%20", -1)
61                 keys = append(keys, k)
62                 for _, v := range vs {
63                         v = strings.Replace(url.QueryEscape(v), "+", "%20", -1)
64                         if values[k] != "" {
65                                 values[k] += "&"
66                         }
67                         values[k] += k + "=" + v
68                 }
69         }
70         sort.Strings(keys)
71         for i, k := range keys {
72                 keys[i] = values[k]
73         }
74         return strings.Join(keys, "&")
75 }
76
77 func s3stringToSign(alg, scope, signedHeaders string, r *http.Request) (string, error) {
78         timefmt, timestr := "20060102T150405Z", r.Header.Get("X-Amz-Date")
79         if timestr == "" {
80                 timefmt, timestr = time.RFC1123, r.Header.Get("Date")
81         }
82         t, err := time.Parse(timefmt, timestr)
83         if err != nil {
84                 return "", fmt.Errorf("invalid timestamp %q: %s", timestr, err)
85         }
86         if skew := time.Now().Sub(t); skew < -s3MaxClockSkew || skew > s3MaxClockSkew {
87                 return "", errors.New("exceeded max clock skew")
88         }
89
90         var canonicalHeaders string
91         for _, h := range strings.Split(signedHeaders, ";") {
92                 if h == "host" {
93                         canonicalHeaders += h + ":" + r.Host + "\n"
94                 } else {
95                         canonicalHeaders += h + ":" + r.Header.Get(h) + "\n"
96                 }
97         }
98
99         canonicalRequest := fmt.Sprintf("%s\n%s\n%s\n%s\n%s\n%s", r.Method, r.URL.EscapedPath(), s3querystring(r.URL), canonicalHeaders, signedHeaders, r.Header.Get("X-Amz-Content-Sha256"))
100         ctxlog.FromContext(r.Context()).Debugf("s3stringToSign: canonicalRequest %s", canonicalRequest)
101         return fmt.Sprintf("%s\n%s\n%s\n%s", alg, r.Header.Get("X-Amz-Date"), scope, hashdigest(sha256.New(), canonicalRequest)), nil
102 }
103
104 func s3signature(secretKey, scope, signedHeaders, stringToSign string) (string, error) {
105         // scope is {datestamp}/{region}/{service}/aws4_request
106         drs := strings.Split(scope, "/")
107         if len(drs) != 4 {
108                 return "", fmt.Errorf("invalid scope %q", scope)
109         }
110         key := s3signatureKey(secretKey, drs[0], drs[1], drs[2])
111         return hashdigest(hmac.New(sha256.New, key), stringToSign), nil
112 }
113
114 // checks3signature verifies the given S3 V4 signature and returns the
115 // Arvados token that corresponds to the given accessKey. An error is
116 // returned if accessKey is not a valid token UUID or the signature
117 // does not match.
118 func (h *handler) checks3signature(r *http.Request) (string, error) {
119         var key, scope, signedHeaders, signature string
120         authstring := strings.TrimPrefix(r.Header.Get("Authorization"), s3SignAlgorithm+" ")
121         for _, cmpt := range strings.Split(authstring, ",") {
122                 cmpt = strings.TrimSpace(cmpt)
123                 split := strings.SplitN(cmpt, "=", 2)
124                 switch {
125                 case len(split) != 2:
126                         // (?) ignore
127                 case split[0] == "Credential":
128                         keyandscope := strings.SplitN(split[1], "/", 2)
129                         if len(keyandscope) == 2 {
130                                 key, scope = keyandscope[0], keyandscope[1]
131                         }
132                 case split[0] == "SignedHeaders":
133                         signedHeaders = split[1]
134                 case split[0] == "Signature":
135                         signature = split[1]
136                 }
137         }
138
139         client := (&arvados.Client{
140                 APIHost:  h.Config.cluster.Services.Controller.ExternalURL.Host,
141                 Insecure: h.Config.cluster.TLS.Insecure,
142         }).WithRequestID(r.Header.Get("X-Request-Id"))
143         var aca arvados.APIClientAuthorization
144         var secret string
145         var err error
146         if len(key) == 27 && key[5:12] == "-gj3su-" {
147                 // Access key is the UUID of an Arvados token, secret
148                 // key is the secret part.
149                 ctx := arvados.ContextWithAuthorization(r.Context(), "Bearer "+h.Config.cluster.SystemRootToken)
150                 err = client.RequestAndDecodeContext(ctx, &aca, "GET", "arvados/v1/api_client_authorizations/"+key, nil, nil)
151                 secret = aca.APIToken
152         } else {
153                 // Access key and secret key are both an entire
154                 // Arvados token or OIDC access token.
155                 ctx := arvados.ContextWithAuthorization(r.Context(), "Bearer "+key)
156                 err = client.RequestAndDecodeContext(ctx, &aca, "GET", "arvados/v1/api_client_authorizations/current", nil, nil)
157                 secret = key
158         }
159         if err != nil {
160                 ctxlog.FromContext(r.Context()).WithError(err).WithField("UUID", key).Info("token lookup failed")
161                 return "", errors.New("invalid access key")
162         }
163         stringToSign, err := s3stringToSign(s3SignAlgorithm, scope, signedHeaders, r)
164         if err != nil {
165                 return "", err
166         }
167         expect, err := s3signature(secret, scope, signedHeaders, stringToSign)
168         if err != nil {
169                 return "", err
170         } else if expect != signature {
171                 return "", fmt.Errorf("signature does not match (scope %q signedHeaders %q stringToSign %q)", scope, signedHeaders, stringToSign)
172         }
173         return secret, nil
174 }
175
176 func s3ErrorResponse(w http.ResponseWriter, s3code string, message string, resource string, code int) {
177         w.Header().Set("Content-Type", "application/xml")
178         w.Header().Set("X-Content-Type-Options", "nosniff")
179         w.WriteHeader(code)
180         fmt.Fprintf(w, `<?xml version="1.0" encoding="UTF-8"?>
181 <Error>
182   <Code>%v</Code>
183   <Message>%v</Message>
184   <Resource>%v</Resource>
185   <RequestId></RequestId>
186 </Error>`, code, message, resource)
187 }
188
189 var NoSuchKey = "NoSuchKey"
190 var NoSuchBucket = "NoSuchBucket"
191 var InvalidArgument = "InvalidArgument"
192 var InternalError = "InternalError"
193 var UnauthorizedAccess = "UnauthorizedAccess"
194 var InvalidRequest = "InvalidRequest"
195 var SignatureDoesNotMatch = "SignatureDoesNotMatch"
196
197 // serveS3 handles r and returns true if r is a request from an S3
198 // client, otherwise it returns false.
199 func (h *handler) serveS3(w http.ResponseWriter, r *http.Request) bool {
200         var token string
201         if auth := r.Header.Get("Authorization"); strings.HasPrefix(auth, "AWS ") {
202                 split := strings.SplitN(auth[4:], ":", 2)
203                 if len(split) < 2 {
204                         s3ErrorResponse(w, InvalidRequest, "malformed Authorization header", r.URL.Path, http.StatusUnauthorized)
205                         return true
206                 }
207                 token = split[0]
208         } else if strings.HasPrefix(auth, s3SignAlgorithm+" ") {
209                 t, err := h.checks3signature(r)
210                 if err != nil {
211                         s3ErrorResponse(w, SignatureDoesNotMatch, "signature verification failed: "+err.Error(), r.URL.Path, http.StatusForbidden)
212                         return true
213                 }
214                 token = t
215         } else {
216                 return false
217         }
218
219         _, kc, client, release, err := h.getClients(r.Header.Get("X-Request-Id"), token)
220         if err != nil {
221                 s3ErrorResponse(w, InternalError, "Pool failed: "+h.clientPool.Err().Error(), r.URL.Path, http.StatusInternalServerError)
222                 return true
223         }
224         defer release()
225
226         fs := client.SiteFileSystem(kc)
227         fs.ForwardSlashNameSubstitution(h.Config.cluster.Collections.ForwardSlashNameSubstitution)
228
229         var objectNameGiven bool
230         var bucketName string
231         fspath := "/by_id"
232         if id := parseCollectionIDFromDNSName(r.Host); id != "" {
233                 fspath += "/" + id
234                 bucketName = id
235                 objectNameGiven = strings.Count(strings.TrimSuffix(r.URL.Path, "/"), "/") > 0
236         } else {
237                 bucketName = strings.SplitN(strings.TrimPrefix(r.URL.Path, "/"), "/", 2)[0]
238                 objectNameGiven = strings.Count(strings.TrimSuffix(r.URL.Path, "/"), "/") > 1
239         }
240         fspath += r.URL.Path
241
242         switch {
243         case r.Method == http.MethodGet && !objectNameGiven:
244                 // Path is "/{uuid}" or "/{uuid}/", has no object name
245                 if _, ok := r.URL.Query()["versioning"]; ok {
246                         // GetBucketVersioning
247                         w.Header().Set("Content-Type", "application/xml")
248                         io.WriteString(w, xml.Header)
249                         fmt.Fprintln(w, `<VersioningConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/"/>`)
250                 } else {
251                         // ListObjects
252                         h.s3list(bucketName, w, r, fs)
253                 }
254                 return true
255         case r.Method == http.MethodGet || r.Method == http.MethodHead:
256                 fi, err := fs.Stat(fspath)
257                 if r.Method == "HEAD" && !objectNameGiven {
258                         // HeadBucket
259                         if err == nil && fi.IsDir() {
260                                 w.WriteHeader(http.StatusOK)
261                         } else if os.IsNotExist(err) {
262                                 s3ErrorResponse(w, NoSuchBucket, "The specified bucket does not exist.", r.URL.Path, http.StatusNotFound)
263                         } else {
264                                 s3ErrorResponse(w, InternalError, err.Error(), r.URL.Path, http.StatusBadGateway)
265                         }
266                         return true
267                 }
268                 if err == nil && fi.IsDir() && objectNameGiven && strings.HasSuffix(fspath, "/") && h.Config.cluster.Collections.S3FolderObjects {
269                         w.Header().Set("Content-Type", "application/x-directory")
270                         w.WriteHeader(http.StatusOK)
271                         return true
272                 }
273                 if os.IsNotExist(err) ||
274                         (err != nil && err.Error() == "not a directory") ||
275                         (fi != nil && fi.IsDir()) {
276                         s3ErrorResponse(w, NoSuchKey, "The specified key does not exist.", r.URL.Path, http.StatusNotFound)
277                         return true
278                 }
279                 // shallow copy r, and change URL path
280                 r := *r
281                 r.URL.Path = fspath
282                 http.FileServer(fs).ServeHTTP(w, &r)
283                 return true
284         case r.Method == http.MethodPut:
285                 if !objectNameGiven {
286                         s3ErrorResponse(w, InvalidArgument, "Missing object name in PUT request.", r.URL.Path, http.StatusBadRequest)
287                         return true
288                 }
289                 var objectIsDir bool
290                 if strings.HasSuffix(fspath, "/") {
291                         if !h.Config.cluster.Collections.S3FolderObjects {
292                                 s3ErrorResponse(w, InvalidArgument, "invalid object name: trailing slash", r.URL.Path, http.StatusBadRequest)
293                                 return true
294                         }
295                         n, err := r.Body.Read(make([]byte, 1))
296                         if err != nil && err != io.EOF {
297                                 s3ErrorResponse(w, InternalError, fmt.Sprintf("error reading request body: %s", err), r.URL.Path, http.StatusInternalServerError)
298                                 return true
299                         } else if n > 0 {
300                                 s3ErrorResponse(w, InvalidArgument, "cannot create object with trailing '/' char unless content is empty", r.URL.Path, http.StatusBadRequest)
301                                 return true
302                         } else if strings.SplitN(r.Header.Get("Content-Type"), ";", 2)[0] != "application/x-directory" {
303                                 s3ErrorResponse(w, InvalidArgument, "cannot create object with trailing '/' char unless Content-Type is 'application/x-directory'", r.URL.Path, http.StatusBadRequest)
304                                 return true
305                         }
306                         // Given PUT "foo/bar/", we'll use "foo/bar/."
307                         // in the "ensure parents exist" block below,
308                         // and then we'll be done.
309                         fspath += "."
310                         objectIsDir = true
311                 }
312                 fi, err := fs.Stat(fspath)
313                 if err != nil && err.Error() == "not a directory" {
314                         // requested foo/bar, but foo is a file
315                         s3ErrorResponse(w, InvalidArgument, "object name conflicts with existing object", r.URL.Path, http.StatusBadRequest)
316                         return true
317                 }
318                 if strings.HasSuffix(r.URL.Path, "/") && err == nil && !fi.IsDir() {
319                         // requested foo/bar/, but foo/bar is a file
320                         s3ErrorResponse(w, InvalidArgument, "object name conflicts with existing object", r.URL.Path, http.StatusBadRequest)
321                         return true
322                 }
323                 // create missing parent/intermediate directories, if any
324                 for i, c := range fspath {
325                         if i > 0 && c == '/' {
326                                 dir := fspath[:i]
327                                 if strings.HasSuffix(dir, "/") {
328                                         err = errors.New("invalid object name (consecutive '/' chars)")
329                                         s3ErrorResponse(w, InvalidArgument, err.Error(), r.URL.Path, http.StatusBadRequest)
330                                         return true
331                                 }
332                                 err = fs.Mkdir(dir, 0755)
333                                 if err == arvados.ErrInvalidArgument {
334                                         // Cannot create a directory
335                                         // here.
336                                         err = fmt.Errorf("mkdir %q failed: %w", dir, err)
337                                         s3ErrorResponse(w, InvalidArgument, err.Error(), r.URL.Path, http.StatusBadRequest)
338                                         return true
339                                 } else if err != nil && !os.IsExist(err) {
340                                         err = fmt.Errorf("mkdir %q failed: %w", dir, err)
341                                         s3ErrorResponse(w, InternalError, err.Error(), r.URL.Path, http.StatusInternalServerError)
342                                         return true
343                                 }
344                         }
345                 }
346                 if !objectIsDir {
347                         f, err := fs.OpenFile(fspath, os.O_WRONLY|os.O_TRUNC|os.O_CREATE, 0644)
348                         if os.IsNotExist(err) {
349                                 f, err = fs.OpenFile(fspath, os.O_WRONLY|os.O_TRUNC|os.O_CREATE, 0644)
350                         }
351                         if err != nil {
352                                 err = fmt.Errorf("open %q failed: %w", r.URL.Path, err)
353                                 s3ErrorResponse(w, InvalidArgument, err.Error(), r.URL.Path, http.StatusBadRequest)
354                                 return true
355                         }
356                         defer f.Close()
357                         _, err = io.Copy(f, r.Body)
358                         if err != nil {
359                                 err = fmt.Errorf("write to %q failed: %w", r.URL.Path, err)
360                                 s3ErrorResponse(w, InternalError, err.Error(), r.URL.Path, http.StatusBadGateway)
361                                 return true
362                         }
363                         err = f.Close()
364                         if err != nil {
365                                 err = fmt.Errorf("write to %q failed: close: %w", r.URL.Path, err)
366                                 s3ErrorResponse(w, InternalError, err.Error(), r.URL.Path, http.StatusBadGateway)
367                                 return true
368                         }
369                 }
370                 err = fs.Sync()
371                 if err != nil {
372                         err = fmt.Errorf("sync failed: %w", err)
373                         s3ErrorResponse(w, InternalError, err.Error(), r.URL.Path, http.StatusInternalServerError)
374                         return true
375                 }
376                 w.WriteHeader(http.StatusOK)
377                 return true
378         case r.Method == http.MethodDelete:
379                 if !objectNameGiven || r.URL.Path == "/" {
380                         s3ErrorResponse(w, InvalidArgument, "missing object name in DELETE request", r.URL.Path, http.StatusBadRequest)
381                         return true
382                 }
383                 if strings.HasSuffix(fspath, "/") {
384                         fspath = strings.TrimSuffix(fspath, "/")
385                         fi, err := fs.Stat(fspath)
386                         if os.IsNotExist(err) {
387                                 w.WriteHeader(http.StatusNoContent)
388                                 return true
389                         } else if err != nil {
390                                 s3ErrorResponse(w, InternalError, err.Error(), r.URL.Path, http.StatusInternalServerError)
391                                 return true
392                         } else if !fi.IsDir() {
393                                 // if "foo" exists and is a file, then
394                                 // "foo/" doesn't exist, so we say
395                                 // delete was successful.
396                                 w.WriteHeader(http.StatusNoContent)
397                                 return true
398                         }
399                 } else if fi, err := fs.Stat(fspath); err == nil && fi.IsDir() {
400                         // if "foo" is a dir, it is visible via S3
401                         // only as "foo/", not "foo" -- so we leave
402                         // the dir alone and return 204 to indicate
403                         // that "foo" does not exist.
404                         w.WriteHeader(http.StatusNoContent)
405                         return true
406                 }
407                 err = fs.Remove(fspath)
408                 if os.IsNotExist(err) {
409                         w.WriteHeader(http.StatusNoContent)
410                         return true
411                 }
412                 if err != nil {
413                         err = fmt.Errorf("rm failed: %w", err)
414                         s3ErrorResponse(w, InvalidArgument, err.Error(), r.URL.Path, http.StatusBadRequest)
415                         return true
416                 }
417                 err = fs.Sync()
418                 if err != nil {
419                         err = fmt.Errorf("sync failed: %w", err)
420                         s3ErrorResponse(w, InternalError, err.Error(), r.URL.Path, http.StatusInternalServerError)
421                         return true
422                 }
423                 w.WriteHeader(http.StatusNoContent)
424                 return true
425         default:
426                 s3ErrorResponse(w, InvalidRequest, "method not allowed", r.URL.Path, http.StatusMethodNotAllowed)
427
428                 return true
429         }
430 }
431
432 // Call fn on the given path (directory) and its contents, in
433 // lexicographic order.
434 //
435 // If isRoot==true and path is not a directory, return nil.
436 //
437 // If fn returns filepath.SkipDir when called on a directory, don't
438 // descend into that directory.
439 func walkFS(fs arvados.CustomFileSystem, path string, isRoot bool, fn func(path string, fi os.FileInfo) error) error {
440         if isRoot {
441                 fi, err := fs.Stat(path)
442                 if os.IsNotExist(err) || (err == nil && !fi.IsDir()) {
443                         return nil
444                 } else if err != nil {
445                         return err
446                 }
447                 err = fn(path, fi)
448                 if err == filepath.SkipDir {
449                         return nil
450                 } else if err != nil {
451                         return err
452                 }
453         }
454         f, err := fs.Open(path)
455         if os.IsNotExist(err) && isRoot {
456                 return nil
457         } else if err != nil {
458                 return fmt.Errorf("open %q: %w", path, err)
459         }
460         defer f.Close()
461         if path == "/" {
462                 path = ""
463         }
464         fis, err := f.Readdir(-1)
465         if err != nil {
466                 return err
467         }
468         sort.Slice(fis, func(i, j int) bool { return fis[i].Name() < fis[j].Name() })
469         for _, fi := range fis {
470                 err = fn(path+"/"+fi.Name(), fi)
471                 if err == filepath.SkipDir {
472                         continue
473                 } else if err != nil {
474                         return err
475                 }
476                 if fi.IsDir() {
477                         err = walkFS(fs, path+"/"+fi.Name(), false, fn)
478                         if err != nil {
479                                 return err
480                         }
481                 }
482         }
483         return nil
484 }
485
486 var errDone = errors.New("done")
487
488 func (h *handler) s3list(bucket string, w http.ResponseWriter, r *http.Request, fs arvados.CustomFileSystem) {
489         var params struct {
490                 delimiter string
491                 marker    string
492                 maxKeys   int
493                 prefix    string
494         }
495         params.delimiter = r.FormValue("delimiter")
496         params.marker = r.FormValue("marker")
497         if mk, _ := strconv.ParseInt(r.FormValue("max-keys"), 10, 64); mk > 0 && mk < s3MaxKeys {
498                 params.maxKeys = int(mk)
499         } else {
500                 params.maxKeys = s3MaxKeys
501         }
502         params.prefix = r.FormValue("prefix")
503
504         bucketdir := "by_id/" + bucket
505         // walkpath is the directory (relative to bucketdir) we need
506         // to walk: the innermost directory that is guaranteed to
507         // contain all paths that have the requested prefix. Examples:
508         // prefix "foo/bar"  => walkpath "foo"
509         // prefix "foo/bar/" => walkpath "foo/bar"
510         // prefix "foo"      => walkpath ""
511         // prefix ""         => walkpath ""
512         walkpath := params.prefix
513         if cut := strings.LastIndex(walkpath, "/"); cut >= 0 {
514                 walkpath = walkpath[:cut]
515         } else {
516                 walkpath = ""
517         }
518
519         type commonPrefix struct {
520                 Prefix string
521         }
522         type listResp struct {
523                 XMLName string `xml:"http://s3.amazonaws.com/doc/2006-03-01/ ListBucketResult"`
524                 s3.ListResp
525                 // s3.ListResp marshals an empty tag when
526                 // CommonPrefixes is nil, which confuses some clients.
527                 // Fix by using this nested struct instead.
528                 CommonPrefixes []commonPrefix
529                 // Similarly, we need omitempty here, because an empty
530                 // tag confuses some clients (e.g.,
531                 // github.com/aws/aws-sdk-net never terminates its
532                 // paging loop).
533                 NextMarker string `xml:"NextMarker,omitempty"`
534                 // ListObjectsV2 has a KeyCount response field.
535                 KeyCount int
536         }
537         resp := listResp{
538                 ListResp: s3.ListResp{
539                         Name:      bucket,
540                         Prefix:    params.prefix,
541                         Delimiter: params.delimiter,
542                         Marker:    params.marker,
543                         MaxKeys:   params.maxKeys,
544                 },
545         }
546         commonPrefixes := map[string]bool{}
547         err := walkFS(fs, strings.TrimSuffix(bucketdir+"/"+walkpath, "/"), true, func(path string, fi os.FileInfo) error {
548                 if path == bucketdir {
549                         return nil
550                 }
551                 path = path[len(bucketdir)+1:]
552                 filesize := fi.Size()
553                 if fi.IsDir() {
554                         path += "/"
555                         filesize = 0
556                 }
557                 if len(path) <= len(params.prefix) {
558                         if path > params.prefix[:len(path)] {
559                                 // with prefix "foobar", walking "fooz" means we're done
560                                 return errDone
561                         }
562                         if path < params.prefix[:len(path)] {
563                                 // with prefix "foobar", walking "foobag" is pointless
564                                 return filepath.SkipDir
565                         }
566                         if fi.IsDir() && !strings.HasPrefix(params.prefix+"/", path) {
567                                 // with prefix "foo/bar", walking "fo"
568                                 // is pointless (but walking "foo" or
569                                 // "foo/bar" is necessary)
570                                 return filepath.SkipDir
571                         }
572                         if len(path) < len(params.prefix) {
573                                 // can't skip anything, and this entry
574                                 // isn't in the results, so just
575                                 // continue descent
576                                 return nil
577                         }
578                 } else {
579                         if path[:len(params.prefix)] > params.prefix {
580                                 // with prefix "foobar", nothing we
581                                 // see after "foozzz" is relevant
582                                 return errDone
583                         }
584                 }
585                 if path < params.marker || path < params.prefix {
586                         return nil
587                 }
588                 if fi.IsDir() && !h.Config.cluster.Collections.S3FolderObjects {
589                         // Note we don't add anything to
590                         // commonPrefixes here even if delimiter is
591                         // "/". We descend into the directory, and
592                         // return a commonPrefix only if we end up
593                         // finding a regular file inside it.
594                         return nil
595                 }
596                 if params.delimiter != "" {
597                         idx := strings.Index(path[len(params.prefix):], params.delimiter)
598                         if idx >= 0 {
599                                 // with prefix "foobar" and delimiter
600                                 // "z", when we hit "foobar/baz", we
601                                 // add "/baz" to commonPrefixes and
602                                 // stop descending.
603                                 commonPrefixes[path[:len(params.prefix)+idx+1]] = true
604                                 return filepath.SkipDir
605                         }
606                 }
607                 if len(resp.Contents)+len(commonPrefixes) >= params.maxKeys {
608                         resp.IsTruncated = true
609                         if params.delimiter != "" {
610                                 resp.NextMarker = path
611                         }
612                         return errDone
613                 }
614                 resp.Contents = append(resp.Contents, s3.Key{
615                         Key:          path,
616                         LastModified: fi.ModTime().UTC().Format("2006-01-02T15:04:05.999") + "Z",
617                         Size:         filesize,
618                 })
619                 return nil
620         })
621         if err != nil && err != errDone {
622                 http.Error(w, err.Error(), http.StatusInternalServerError)
623                 return
624         }
625         if params.delimiter != "" {
626                 resp.CommonPrefixes = make([]commonPrefix, 0, len(commonPrefixes))
627                 for prefix := range commonPrefixes {
628                         resp.CommonPrefixes = append(resp.CommonPrefixes, commonPrefix{prefix})
629                 }
630                 sort.Slice(resp.CommonPrefixes, func(i, j int) bool { return resp.CommonPrefixes[i].Prefix < resp.CommonPrefixes[j].Prefix })
631         }
632         resp.KeyCount = len(resp.Contents)
633         w.Header().Set("Content-Type", "application/xml")
634         io.WriteString(w, xml.Header)
635         if err := xml.NewEncoder(w).Encode(resp); err != nil {
636                 ctxlog.FromContext(r.Context()).WithError(err).Error("error writing xml response")
637         }
638 }