1 // Copyright (C) The Arvados Authors. All rights reserved.
3 // SPDX-License-Identifier: AGPL-3.0
21 "git.arvados.org/arvados.git/lib/config"
22 "git.arvados.org/arvados.git/sdk/go/arvados"
23 "git.arvados.org/arvados.git/sdk/go/arvadosclient"
24 "git.arvados.org/arvados.git/sdk/go/arvadostest"
25 "git.arvados.org/arvados.git/sdk/go/ctxlog"
26 "git.arvados.org/arvados.git/sdk/go/keepclient"
27 log "github.com/sirupsen/logrus"
33 // Gocheck boilerplate
34 func Test(t *testing.T) {
38 // Gocheck boilerplate
39 var _ = Suite(&ServerRequiredSuite{})
41 // Tests that require the Keep server running
42 type ServerRequiredSuite struct{}
44 // Gocheck boilerplate
45 var _ = Suite(&ServerRequiredConfigYmlSuite{})
47 // Tests that require the Keep servers running as defined in config.yml
48 type ServerRequiredConfigYmlSuite struct{}
50 // Gocheck boilerplate
51 var _ = Suite(&NoKeepServerSuite{})
53 // Test with no keepserver to simulate errors
54 type NoKeepServerSuite struct{}
56 var TestProxyUUID = "zzzzz-bi6l4-lrixqc4fxofbmzz"
58 // Wait (up to 1 second) for keepproxy to listen on a port. This
59 // avoids a race condition where we hit a "connection refused" error
60 // because we start testing the proxy too soon.
61 func waitForListener() {
65 for i := 0; listener == nil && i < 10000; i += ms {
66 time.Sleep(ms * time.Millisecond)
69 panic("Timed out waiting for listener to start")
73 func closeListener() {
79 func (s *ServerRequiredSuite) SetUpSuite(c *C) {
80 arvadostest.StartAPI()
81 arvadostest.StartKeep(2, false)
84 func (s *ServerRequiredSuite) SetUpTest(c *C) {
85 arvadostest.ResetEnv()
88 func (s *ServerRequiredSuite) TearDownSuite(c *C) {
89 arvadostest.StopKeep(2)
93 func (s *ServerRequiredConfigYmlSuite) SetUpSuite(c *C) {
94 arvadostest.StartAPI()
95 // config.yml defines 4 keepstores
96 arvadostest.StartKeep(4, false)
99 func (s *ServerRequiredConfigYmlSuite) SetUpTest(c *C) {
100 arvadostest.ResetEnv()
103 func (s *ServerRequiredConfigYmlSuite) TearDownSuite(c *C) {
104 arvadostest.StopKeep(4)
105 arvadostest.StopAPI()
108 func (s *NoKeepServerSuite) SetUpSuite(c *C) {
109 arvadostest.StartAPI()
110 // We need API to have some keep services listed, but the
111 // services themselves should be unresponsive.
112 arvadostest.StartKeep(2, false)
113 arvadostest.StopKeep(2)
116 func (s *NoKeepServerSuite) SetUpTest(c *C) {
117 arvadostest.ResetEnv()
120 func (s *NoKeepServerSuite) TearDownSuite(c *C) {
121 arvadostest.StopAPI()
124 func runProxy(c *C, bogusClientToken bool, loadKeepstoresFromConfig bool, kp *arvados.UploadDownloadRolePermissions) (*keepclient.KeepClient, *bytes.Buffer) {
125 cfg, err := config.NewLoader(nil, ctxlog.TestLogger(c)).Load()
126 c.Assert(err, Equals, nil)
127 cluster, err := cfg.GetCluster("")
128 c.Assert(err, Equals, nil)
130 if !loadKeepstoresFromConfig {
131 // Do not load Keepstore InternalURLs from the config file
132 cluster.Services.Keepstore.InternalURLs = make(map[arvados.URL]arvados.ServiceInstance)
135 cluster.Services.Keepproxy.InternalURLs = map[arvados.URL]arvados.ServiceInstance{{Host: ":0"}: {}}
138 cluster.Collections.KeepproxyPermission = *kp
142 logbuf := &bytes.Buffer{}
147 defer closeListener()
151 client := arvados.NewClientFromEnv()
152 arv, err := arvadosclient.New(client)
153 c.Assert(err, Equals, nil)
154 if bogusClientToken {
155 arv.ApiToken = "bogus-token"
157 kc := keepclient.New(arv)
158 sr := map[string]string{
159 TestProxyUUID: "http://" + listener.Addr().String(),
161 kc.SetServiceRoots(sr, sr, sr)
162 kc.Arvados.External = true
167 func (s *ServerRequiredSuite) TestResponseViaHeader(c *C) {
168 runProxy(c, false, false, nil)
169 defer closeListener()
171 req, err := http.NewRequest("POST",
172 "http://"+listener.Addr().String()+"/",
173 strings.NewReader("TestViaHeader"))
174 c.Assert(err, Equals, nil)
175 req.Header.Add("Authorization", "OAuth2 "+arvadostest.ActiveToken)
176 resp, err := (&http.Client{}).Do(req)
177 c.Assert(err, Equals, nil)
178 c.Check(resp.Header.Get("Via"), Equals, "HTTP/1.1 keepproxy")
179 c.Assert(resp.StatusCode, Equals, http.StatusOK)
180 locator, err := ioutil.ReadAll(resp.Body)
181 c.Assert(err, Equals, nil)
184 req, err = http.NewRequest("GET",
185 "http://"+listener.Addr().String()+"/"+string(locator),
187 c.Assert(err, Equals, nil)
188 resp, err = (&http.Client{}).Do(req)
189 c.Assert(err, Equals, nil)
190 c.Check(resp.Header.Get("Via"), Equals, "HTTP/1.1 keepproxy")
194 func (s *ServerRequiredSuite) TestLoopDetection(c *C) {
195 kc, _ := runProxy(c, false, false, nil)
196 defer closeListener()
198 sr := map[string]string{
199 TestProxyUUID: "http://" + listener.Addr().String(),
201 router.(*proxyHandler).KeepClient.SetServiceRoots(sr, sr, sr)
203 content := []byte("TestLoopDetection")
204 _, _, err := kc.PutB(content)
205 c.Check(err, ErrorMatches, `.*loop detected.*`)
207 hash := fmt.Sprintf("%x", md5.Sum(content))
208 _, _, _, err = kc.Get(hash)
209 c.Check(err, ErrorMatches, `.*loop detected.*`)
212 func (s *ServerRequiredSuite) TestStorageClassesHeader(c *C) {
213 kc, _ := runProxy(c, false, false, nil)
214 defer closeListener()
216 // Set up fake keepstore to record request headers
218 ts := httptest.NewServer(http.HandlerFunc(
219 func(w http.ResponseWriter, r *http.Request) {
221 http.Error(w, "Error", http.StatusInternalServerError)
225 // Point keepproxy router's keepclient to the fake keepstore
226 sr := map[string]string{
227 TestProxyUUID: ts.URL,
229 router.(*proxyHandler).KeepClient.SetServiceRoots(sr, sr, sr)
231 // Set up client to ask for storage classes to keepproxy
232 kc.StorageClasses = []string{"secure"}
233 content := []byte("Very important data")
234 _, _, err := kc.PutB(content)
236 c.Check(hdr.Get("X-Keep-Storage-Classes"), Equals, "secure")
239 func (s *ServerRequiredSuite) TestStorageClassesConfirmedHeader(c *C) {
240 runProxy(c, false, false, nil)
241 defer closeListener()
243 content := []byte("foo")
244 hash := fmt.Sprintf("%x", md5.Sum(content))
245 client := &http.Client{}
247 req, err := http.NewRequest("PUT",
248 fmt.Sprintf("http://%s/%s", listener.Addr().String(), hash),
249 bytes.NewReader(content))
251 req.Header.Set("X-Keep-Storage-Classes", "default")
252 req.Header.Set("Authorization", "OAuth2 "+arvadostest.ActiveToken)
253 req.Header.Set("Content-Type", "application/octet-stream")
255 resp, err := client.Do(req)
257 c.Assert(resp.StatusCode, Equals, http.StatusOK)
258 c.Assert(resp.Header.Get("X-Keep-Storage-Classes-Confirmed"), Equals, "default=2")
261 func (s *ServerRequiredSuite) TestDesiredReplicas(c *C) {
262 kc, _ := runProxy(c, false, false, nil)
263 defer closeListener()
265 content := []byte("TestDesiredReplicas")
266 hash := fmt.Sprintf("%x", md5.Sum(content))
268 for _, kc.Want_replicas = range []int{0, 1, 2} {
269 locator, rep, err := kc.PutB(content)
270 c.Check(err, Equals, nil)
271 c.Check(rep, Equals, kc.Want_replicas)
273 c.Check(locator, Matches, fmt.Sprintf(`^%s\+%d(\+.+)?$`, hash, len(content)))
278 func (s *ServerRequiredSuite) TestPutWrongContentLength(c *C) {
279 kc, _ := runProxy(c, false, false, nil)
280 defer closeListener()
282 content := []byte("TestPutWrongContentLength")
283 hash := fmt.Sprintf("%x", md5.Sum(content))
285 // If we use http.Client to send these requests to the network
286 // server we just started, the Go http library automatically
287 // fixes the invalid Content-Length header. In order to test
288 // our server behavior, we have to call the handler directly
289 // using an httptest.ResponseRecorder.
290 rtr, err := MakeRESTRouter(kc, 10*time.Second, &arvados.Cluster{}, log.New())
291 c.Assert(err, check.IsNil)
293 type testcase struct {
298 for _, t := range []testcase{
299 {"1", http.StatusBadRequest},
300 {"", http.StatusLengthRequired},
301 {"-1", http.StatusLengthRequired},
302 {"abcdef", http.StatusLengthRequired},
304 req, err := http.NewRequest("PUT",
305 fmt.Sprintf("http://%s/%s+%d", listener.Addr().String(), hash, len(content)),
306 bytes.NewReader(content))
308 req.Header.Set("Content-Length", t.sendLength)
309 req.Header.Set("Authorization", "OAuth2 "+arvadostest.ActiveToken)
310 req.Header.Set("Content-Type", "application/octet-stream")
312 resp := httptest.NewRecorder()
313 rtr.ServeHTTP(resp, req)
314 c.Check(resp.Code, Equals, t.expectStatus)
318 func (s *ServerRequiredSuite) TestManyFailedPuts(c *C) {
319 kc, _ := runProxy(c, false, false, nil)
320 defer closeListener()
321 router.(*proxyHandler).timeout = time.Nanosecond
323 buf := make([]byte, 1<<20)
325 var wg sync.WaitGroup
326 for i := 0; i < 128; i++ {
333 done := make(chan bool)
340 case <-time.After(10 * time.Second):
345 func (s *ServerRequiredSuite) TestPutAskGet(c *C) {
346 kc, logbuf := runProxy(c, false, false, nil)
347 defer closeListener()
349 hash := fmt.Sprintf("%x", md5.Sum([]byte("foo")))
353 _, _, err := kc.Ask(hash)
354 c.Check(err, Equals, keepclient.BlockNotFound)
355 c.Log("Finished Ask (expected BlockNotFound)")
359 reader, _, _, err := kc.Get(hash)
360 c.Check(reader, Equals, nil)
361 c.Check(err, Equals, keepclient.BlockNotFound)
362 c.Log("Finished Get (expected BlockNotFound)")
365 // Note in bug #5309 among other errors keepproxy would set
366 // Content-Length incorrectly on the 404 BlockNotFound response, this
367 // would result in a protocol violation that would prevent reuse of the
368 // connection, which would manifest by the next attempt to use the
369 // connection (in this case the PutB below) failing. So to test for
370 // that bug it's necessary to trigger an error response (such as
371 // BlockNotFound) and then do something else with the same httpClient
377 hash2, rep, err = kc.PutB([]byte("foo"))
378 c.Check(hash2, Matches, fmt.Sprintf(`^%s\+3(\+.+)?$`, hash))
379 c.Check(rep, Equals, 2)
380 c.Check(err, Equals, nil)
381 c.Log("Finished PutB (expected success)")
383 c.Check(logbuf.String(), Matches, `(?ms).*msg="Block upload" locator=acbd18db4cc2f85cedef654fccc4a4d8\+3 user_full_name="TestCase Administrator" user_uuid=zzzzz-tpzed-d9tiejq69daie8f.*`)
388 blocklen, _, err := kc.Ask(hash2)
389 c.Assert(err, Equals, nil)
390 c.Check(blocklen, Equals, int64(3))
391 c.Log("Finished Ask (expected success)")
392 c.Check(logbuf.String(), Matches, `(?ms).*msg="Block download" locator=acbd18db4cc2f85cedef654fccc4a4d8\+3 user_full_name="TestCase Administrator" user_uuid=zzzzz-tpzed-d9tiejq69daie8f.*`)
397 reader, blocklen, _, err := kc.Get(hash2)
398 c.Assert(err, Equals, nil)
399 all, err := ioutil.ReadAll(reader)
401 c.Check(all, DeepEquals, []byte("foo"))
402 c.Check(blocklen, Equals, int64(3))
403 c.Log("Finished Get (expected success)")
404 c.Check(logbuf.String(), Matches, `(?ms).*msg="Block download" locator=acbd18db4cc2f85cedef654fccc4a4d8\+3 user_full_name="TestCase Administrator" user_uuid=zzzzz-tpzed-d9tiejq69daie8f.*`)
411 hash2, rep, err = kc.PutB([]byte(""))
412 c.Check(hash2, Matches, `^d41d8cd98f00b204e9800998ecf8427e\+0(\+.+)?$`)
413 c.Check(rep, Equals, 2)
414 c.Check(err, Equals, nil)
415 c.Log("Finished PutB zero block")
419 reader, blocklen, _, err := kc.Get("d41d8cd98f00b204e9800998ecf8427e")
420 c.Assert(err, Equals, nil)
421 all, err := ioutil.ReadAll(reader)
423 c.Check(all, DeepEquals, []byte(""))
424 c.Check(blocklen, Equals, int64(0))
425 c.Log("Finished Get zero block")
429 func (s *ServerRequiredSuite) TestPutAskGetForbidden(c *C) {
430 kc, _ := runProxy(c, true, false, nil)
431 defer closeListener()
433 hash := fmt.Sprintf("%x+3", md5.Sum([]byte("bar")))
435 _, _, err := kc.Ask(hash)
436 c.Check(err, FitsTypeOf, &keepclient.ErrNotFound{})
438 hash2, rep, err := kc.PutB([]byte("bar"))
439 c.Check(hash2, Equals, "")
440 c.Check(rep, Equals, 0)
441 c.Check(err, FitsTypeOf, keepclient.InsufficientReplicasError(errors.New("")))
443 blocklen, _, err := kc.Ask(hash)
444 c.Check(err, FitsTypeOf, &keepclient.ErrNotFound{})
445 c.Check(err, ErrorMatches, ".*HTTP 403.*")
446 c.Check(blocklen, Equals, int64(0))
448 _, blocklen, _, err = kc.Get(hash)
449 c.Check(err, FitsTypeOf, &keepclient.ErrNotFound{})
450 c.Check(err, ErrorMatches, ".*HTTP 403.*")
451 c.Check(blocklen, Equals, int64(0))
454 func testPermission(c *C, admin bool, perm arvados.UploadDownloadPermission) {
455 kp := arvados.UploadDownloadRolePermissions{}
458 kp.User = arvados.UploadDownloadPermission{Upload: true, Download: true}
460 kp.Admin = arvados.UploadDownloadPermission{Upload: true, Download: true}
464 kc, logbuf := runProxy(c, false, false, &kp)
465 defer closeListener()
467 kc.Arvados.ApiToken = arvadostest.AdminToken
469 kc.Arvados.ApiToken = arvadostest.ActiveToken
472 hash := fmt.Sprintf("%x", md5.Sum([]byte("foo")))
478 hash2, rep, err = kc.PutB([]byte("foo"))
481 c.Check(hash2, Matches, fmt.Sprintf(`^%s\+3(\+.+)?$`, hash))
482 c.Check(rep, Equals, 2)
483 c.Check(err, Equals, nil)
484 c.Log("Finished PutB (expected success)")
486 c.Check(logbuf.String(), Matches, `(?ms).*msg="Block upload" locator=acbd18db4cc2f85cedef654fccc4a4d8\+3 user_full_name="TestCase Administrator" user_uuid=zzzzz-tpzed-d9tiejq69daie8f.*`)
489 c.Check(logbuf.String(), Matches, `(?ms).*msg="Block upload" locator=acbd18db4cc2f85cedef654fccc4a4d8\+3 user_full_name="Active User" user_uuid=zzzzz-tpzed-xurymjxw79nv3jz.*`)
492 c.Check(hash2, Equals, "")
493 c.Check(rep, Equals, 0)
494 c.Check(err, FitsTypeOf, keepclient.InsufficientReplicasError(errors.New("")))
499 // can't test download without upload.
501 reader, blocklen, _, err := kc.Get(hash2)
503 c.Assert(err, Equals, nil)
504 all, err := ioutil.ReadAll(reader)
506 c.Check(all, DeepEquals, []byte("foo"))
507 c.Check(blocklen, Equals, int64(3))
508 c.Log("Finished Get (expected success)")
510 c.Check(logbuf.String(), Matches, `(?ms).*msg="Block download" locator=acbd18db4cc2f85cedef654fccc4a4d8\+3 user_full_name="TestCase Administrator" user_uuid=zzzzz-tpzed-d9tiejq69daie8f.*`)
512 c.Check(logbuf.String(), Matches, `(?ms).*msg="Block download" locator=acbd18db4cc2f85cedef654fccc4a4d8\+3 user_full_name="Active User" user_uuid=zzzzz-tpzed-xurymjxw79nv3jz.*`)
515 c.Check(err, FitsTypeOf, &keepclient.ErrNotFound{})
516 c.Check(err, ErrorMatches, ".*Missing or invalid Authorization header, or method not allowed.*")
517 c.Check(blocklen, Equals, int64(0))
524 func (s *ServerRequiredSuite) TestPutGetPermission(c *C) {
526 for _, adminperm := range []bool{true, false} {
527 for _, userperm := range []bool{true, false} {
529 testPermission(c, true,
530 arvados.UploadDownloadPermission{
534 testPermission(c, true,
535 arvados.UploadDownloadPermission{
539 testPermission(c, false,
540 arvados.UploadDownloadPermission{
544 testPermission(c, false,
545 arvados.UploadDownloadPermission{
553 func (s *ServerRequiredSuite) TestCorsHeaders(c *C) {
554 runProxy(c, false, false, nil)
555 defer closeListener()
558 client := http.Client{}
559 req, err := http.NewRequest("OPTIONS",
560 fmt.Sprintf("http://%s/%x+3", listener.Addr().String(), md5.Sum([]byte("foo"))),
563 req.Header.Add("Access-Control-Request-Method", "PUT")
564 req.Header.Add("Access-Control-Request-Headers", "Authorization, X-Keep-Desired-Replicas")
565 resp, err := client.Do(req)
566 c.Check(err, Equals, nil)
567 c.Check(resp.StatusCode, Equals, 200)
568 body, err := ioutil.ReadAll(resp.Body)
570 c.Check(string(body), Equals, "")
571 c.Check(resp.Header.Get("Access-Control-Allow-Methods"), Equals, "GET, HEAD, POST, PUT, OPTIONS")
572 c.Check(resp.Header.Get("Access-Control-Allow-Origin"), Equals, "*")
576 resp, err := http.Get(
577 fmt.Sprintf("http://%s/%x+3", listener.Addr().String(), md5.Sum([]byte("foo"))))
578 c.Check(err, Equals, nil)
579 c.Check(resp.Header.Get("Access-Control-Allow-Headers"), Equals, "Authorization, Content-Length, Content-Type, X-Keep-Desired-Replicas")
580 c.Check(resp.Header.Get("Access-Control-Allow-Origin"), Equals, "*")
584 func (s *ServerRequiredSuite) TestPostWithoutHash(c *C) {
585 runProxy(c, false, false, nil)
586 defer closeListener()
589 client := http.Client{}
590 req, err := http.NewRequest("POST",
591 "http://"+listener.Addr().String()+"/",
592 strings.NewReader("qux"))
594 req.Header.Add("Authorization", "OAuth2 "+arvadostest.ActiveToken)
595 req.Header.Add("Content-Type", "application/octet-stream")
596 resp, err := client.Do(req)
597 c.Check(err, Equals, nil)
598 body, err := ioutil.ReadAll(resp.Body)
599 c.Check(err, Equals, nil)
600 c.Check(string(body), Matches,
601 fmt.Sprintf(`^%x\+3(\+.+)?$`, md5.Sum([]byte("qux"))))
605 func (s *ServerRequiredSuite) TestStripHint(c *C) {
606 c.Check(removeHint.ReplaceAllString("http://keep.zzzzz.arvadosapi.com:25107/2228819a18d3727630fa30c81853d23f+67108864+A37b6ab198qqqq28d903b975266b23ee711e1852c@55635f73+K@zzzzz", "$1"),
608 "http://keep.zzzzz.arvadosapi.com:25107/2228819a18d3727630fa30c81853d23f+67108864+A37b6ab198qqqq28d903b975266b23ee711e1852c@55635f73")
609 c.Check(removeHint.ReplaceAllString("http://keep.zzzzz.arvadosapi.com:25107/2228819a18d3727630fa30c81853d23f+67108864+K@zzzzz+A37b6ab198qqqq28d903b975266b23ee711e1852c@55635f73", "$1"),
611 "http://keep.zzzzz.arvadosapi.com:25107/2228819a18d3727630fa30c81853d23f+67108864+A37b6ab198qqqq28d903b975266b23ee711e1852c@55635f73")
612 c.Check(removeHint.ReplaceAllString("http://keep.zzzzz.arvadosapi.com:25107/2228819a18d3727630fa30c81853d23f+67108864+A37b6ab198qqqq28d903b975266b23ee711e1852c@55635f73+K@zzzzz-zzzzz-zzzzzzzzzzzzzzz", "$1"),
614 "http://keep.zzzzz.arvadosapi.com:25107/2228819a18d3727630fa30c81853d23f+67108864+A37b6ab198qqqq28d903b975266b23ee711e1852c@55635f73+K@zzzzz-zzzzz-zzzzzzzzzzzzzzz")
615 c.Check(removeHint.ReplaceAllString("http://keep.zzzzz.arvadosapi.com:25107/2228819a18d3727630fa30c81853d23f+67108864+K@zzzzz-zzzzz-zzzzzzzzzzzzzzz+A37b6ab198qqqq28d903b975266b23ee711e1852c@55635f73", "$1"),
617 "http://keep.zzzzz.arvadosapi.com:25107/2228819a18d3727630fa30c81853d23f+67108864+K@zzzzz-zzzzz-zzzzzzzzzzzzzzz+A37b6ab198qqqq28d903b975266b23ee711e1852c@55635f73")
622 // Put one block, with 2 replicas
623 // With no prefix (expect the block locator, twice)
624 // With an existing prefix (expect the block locator, twice)
625 // With a valid but non-existing prefix (expect "\n")
626 // With an invalid prefix (expect error)
627 func (s *ServerRequiredSuite) TestGetIndex(c *C) {
628 getIndexWorker(c, false)
633 // Put one block, with 2 replicas
634 // With no prefix (expect the block locator, twice)
635 // With an existing prefix (expect the block locator, twice)
636 // With a valid but non-existing prefix (expect "\n")
637 // With an invalid prefix (expect error)
638 func (s *ServerRequiredConfigYmlSuite) TestGetIndex(c *C) {
639 getIndexWorker(c, true)
642 func getIndexWorker(c *C, useConfig bool) {
643 kc, _ := runProxy(c, false, useConfig, nil)
644 defer closeListener()
646 // Put "index-data" blocks
647 data := []byte("index-data")
648 hash := fmt.Sprintf("%x", md5.Sum(data))
650 hash2, rep, err := kc.PutB(data)
651 c.Check(hash2, Matches, fmt.Sprintf(`^%s\+10(\+.+)?$`, hash))
652 c.Check(rep, Equals, 2)
653 c.Check(err, Equals, nil)
655 reader, blocklen, _, err := kc.Get(hash)
657 c.Check(blocklen, Equals, int64(10))
658 all, err := ioutil.ReadAll(reader)
660 c.Check(all, DeepEquals, data)
662 // Put some more blocks
663 _, _, err = kc.PutB([]byte("some-more-index-data"))
666 kc.Arvados.ApiToken = arvadostest.SystemRootToken
669 for _, spec := range []struct {
674 {"", true, true}, // with no prefix
675 {hash[:3], true, false}, // with matching prefix
676 {"abcdef", false, false}, // with no such prefix
678 indexReader, err := kc.GetIndex(TestProxyUUID, spec.prefix)
679 c.Assert(err, Equals, nil)
680 indexResp, err := ioutil.ReadAll(indexReader)
681 c.Assert(err, Equals, nil)
682 locators := strings.Split(string(indexResp), "\n")
685 for _, locator := range locators {
689 c.Check(locator[:len(spec.prefix)], Equals, spec.prefix)
690 if locator[:32] == hash {
696 c.Check(gotTestHash == 2, Equals, spec.expectTestHash)
697 c.Check(gotOther > 0, Equals, spec.expectOther)
700 // GetIndex with invalid prefix
701 _, err = kc.GetIndex(TestProxyUUID, "xyz")
702 c.Assert((err != nil), Equals, true)
705 func (s *ServerRequiredSuite) TestCollectionSharingToken(c *C) {
706 kc, _ := runProxy(c, false, false, nil)
707 defer closeListener()
708 hash, _, err := kc.PutB([]byte("shareddata"))
710 kc.Arvados.ApiToken = arvadostest.FooCollectionSharingToken
711 rdr, _, _, err := kc.Get(hash)
713 data, err := ioutil.ReadAll(rdr)
715 c.Check(data, DeepEquals, []byte("shareddata"))
718 func (s *ServerRequiredSuite) TestPutAskGetInvalidToken(c *C) {
719 kc, _ := runProxy(c, false, false, nil)
720 defer closeListener()
723 hash, rep, err := kc.PutB([]byte("foo"))
725 c.Check(rep, Equals, 2)
727 for _, badToken := range []string{
729 "2ym314ysp27sk7h943q6vtc378srb06se3pq6ghurylyf3pdmx", // expired
731 kc.Arvados.ApiToken = badToken
733 // Ask and Get will fail only if the upstream
734 // keepstore server checks for valid signatures.
735 // Without knowing the blob signing key, there is no
736 // way for keepproxy to know whether a given token is
737 // permitted to read a block. So these tests fail:
739 _, _, err = kc.Ask(hash)
740 c.Assert(err, FitsTypeOf, &keepclient.ErrNotFound{})
741 c.Check(err.(*keepclient.ErrNotFound).Temporary(), Equals, false)
742 c.Check(err, ErrorMatches, ".*HTTP 403.*")
744 _, _, _, err = kc.Get(hash)
745 c.Assert(err, FitsTypeOf, &keepclient.ErrNotFound{})
746 c.Check(err.(*keepclient.ErrNotFound).Temporary(), Equals, false)
747 c.Check(err, ErrorMatches, ".*HTTP 403 \"Missing or invalid Authorization header, or method not allowed\".*")
750 _, _, err = kc.PutB([]byte("foo"))
751 c.Check(err, ErrorMatches, ".*403.*Missing or invalid Authorization header, or method not allowed")
755 func (s *ServerRequiredSuite) TestAskGetKeepProxyConnectionError(c *C) {
756 kc, _ := runProxy(c, false, false, nil)
757 defer closeListener()
759 // Point keepproxy at a non-existent keepstore
760 locals := map[string]string{
761 TestProxyUUID: "http://localhost:12345",
763 router.(*proxyHandler).KeepClient.SetServiceRoots(locals, nil, nil)
765 // Ask should result in temporary bad gateway error
766 hash := fmt.Sprintf("%x", md5.Sum([]byte("foo")))
767 _, _, err := kc.Ask(hash)
769 errNotFound, _ := err.(*keepclient.ErrNotFound)
770 c.Check(errNotFound.Temporary(), Equals, true)
771 c.Assert(err, ErrorMatches, ".*HTTP 502.*")
773 // Get should result in temporary bad gateway error
774 _, _, _, err = kc.Get(hash)
776 errNotFound, _ = err.(*keepclient.ErrNotFound)
777 c.Check(errNotFound.Temporary(), Equals, true)
778 c.Assert(err, ErrorMatches, ".*HTTP 502.*")
781 func (s *NoKeepServerSuite) TestAskGetNoKeepServerError(c *C) {
782 kc, _ := runProxy(c, false, false, nil)
783 defer closeListener()
785 hash := fmt.Sprintf("%x", md5.Sum([]byte("foo")))
786 for _, f := range []func() error{
788 _, _, err := kc.Ask(hash)
792 _, _, _, err := kc.Get(hash)
797 c.Assert(err, NotNil)
798 errNotFound, _ := err.(*keepclient.ErrNotFound)
799 c.Check(errNotFound.Temporary(), Equals, true)
800 c.Check(err, ErrorMatches, `.*HTTP 502.*`)
804 func (s *ServerRequiredSuite) TestPing(c *C) {
805 kc, _ := runProxy(c, false, false, nil)
806 defer closeListener()
808 rtr, err := MakeRESTRouter(kc, 10*time.Second, &arvados.Cluster{ManagementToken: arvadostest.ManagementToken}, log.New())
809 c.Assert(err, check.IsNil)
811 req, err := http.NewRequest("GET",
812 "http://"+listener.Addr().String()+"/_health/ping",
815 req.Header.Set("Authorization", "Bearer "+arvadostest.ManagementToken)
817 resp := httptest.NewRecorder()
818 rtr.ServeHTTP(resp, req)
819 c.Check(resp.Code, Equals, 200)
820 c.Assert(resp.Body.String(), Matches, `{"health":"OK"}\n?`)