13111: Ignore projects and collections with "/" in name.
[arvados.git] / sdk / go / arvados / fs_project_test.go
1 // Copyright (C) The Arvados Authors. All rights reserved.
2 //
3 // SPDX-License-Identifier: Apache-2.0
4
5 package arvados
6
7 import (
8         "bytes"
9         "encoding/json"
10         "io"
11         "os"
12         "path/filepath"
13         "strings"
14
15         "git.curoverse.com/arvados.git/sdk/go/arvadostest"
16         check "gopkg.in/check.v1"
17 )
18
19 type spiedRequest struct {
20         method string
21         path   string
22         params map[string]interface{}
23 }
24
25 type spyingClient struct {
26         *Client
27         calls []spiedRequest
28 }
29
30 func (sc *spyingClient) RequestAndDecode(dst interface{}, method, path string, body io.Reader, params interface{}) error {
31         var paramsCopy map[string]interface{}
32         var buf bytes.Buffer
33         json.NewEncoder(&buf).Encode(params)
34         json.NewDecoder(&buf).Decode(&paramsCopy)
35         sc.calls = append(sc.calls, spiedRequest{
36                 method: method,
37                 path:   path,
38                 params: paramsCopy,
39         })
40         return sc.Client.RequestAndDecode(dst, method, path, body, params)
41 }
42
43 func (s *SiteFSSuite) TestCurrentUserHome(c *check.C) {
44         s.fs.MountProject("home", "")
45         s.testHomeProject(c, "/home")
46 }
47
48 func (s *SiteFSSuite) TestUsersDir(c *check.C) {
49         s.testHomeProject(c, "/users/active")
50 }
51
52 func (s *SiteFSSuite) testHomeProject(c *check.C, path string) {
53         f, err := s.fs.Open(path)
54         c.Assert(err, check.IsNil)
55         fis, err := f.Readdir(-1)
56         c.Check(len(fis), check.Not(check.Equals), 0)
57
58         ok := false
59         for _, fi := range fis {
60                 c.Check(fi.Name(), check.Not(check.Equals), "")
61                 if fi.Name() == "A Project" {
62                         ok = true
63                 }
64         }
65         c.Check(ok, check.Equals, true)
66
67         f, err = s.fs.Open(path + "/A Project/..")
68         c.Assert(err, check.IsNil)
69         fi, err := f.Stat()
70         c.Check(err, check.IsNil)
71         c.Check(fi.IsDir(), check.Equals, true)
72         _, basename := filepath.Split(path)
73         c.Check(fi.Name(), check.Equals, basename)
74
75         f, err = s.fs.Open(path + "/A Project/A Subproject")
76         c.Check(err, check.IsNil)
77         fi, err = f.Stat()
78         c.Check(err, check.IsNil)
79         c.Check(fi.IsDir(), check.Equals, true)
80
81         for _, nx := range []string{
82                 path + "/Unrestricted public data",
83                 path + "/Unrestricted public data/does not exist",
84                 path + "/A Project/does not exist",
85         } {
86                 c.Log(nx)
87                 f, err = s.fs.Open(nx)
88                 c.Check(err, check.NotNil)
89                 c.Check(os.IsNotExist(err), check.Equals, true)
90         }
91 }
92
93 func (s *SiteFSSuite) TestSlashInName(c *check.C) {
94         badCollection := Collection{
95                 Name:      "bad/collection",
96                 OwnerUUID: arvadostest.AProjectUUID,
97         }
98         err := s.client.RequestAndDecode(&badCollection, "POST", "arvados/v1/collections", s.client.UpdateBody(&badCollection), nil)
99         c.Assert(err, check.IsNil)
100         defer s.client.RequestAndDecode(nil, "DELETE", "arvados/v1/collections/"+badCollection.UUID, nil, nil)
101
102         badProject := Group{
103                 Name:       "bad/project",
104                 GroupClass: "project",
105                 OwnerUUID:  arvadostest.AProjectUUID,
106         }
107         err = s.client.RequestAndDecode(&badProject, "POST", "arvados/v1/groups", s.client.UpdateBody(&badProject), nil)
108         c.Assert(err, check.IsNil)
109         defer s.client.RequestAndDecode(nil, "DELETE", "arvados/v1/groups/"+badProject.UUID, nil, nil)
110
111         dir, err := s.fs.Open("/users/active/A Project")
112         c.Check(err, check.IsNil)
113         fis, err := dir.Readdir(-1)
114         c.Check(err, check.IsNil)
115         for _, fi := range fis {
116                 c.Logf("fi.Name() == %q", fi.Name())
117                 c.Check(strings.Contains(fi.Name(), "/"), check.Equals, false)
118         }
119 }
120
121 func (s *SiteFSSuite) TestProjectUpdatedByOther(c *check.C) {
122         s.fs.MountProject("home", "")
123
124         project, err := s.fs.OpenFile("/home/A Project", 0, 0)
125         c.Check(err, check.IsNil)
126
127         _, err = s.fs.Open("/home/A Project/oob")
128         c.Check(err, check.NotNil)
129
130         oob := Collection{
131                 Name:      "oob",
132                 OwnerUUID: arvadostest.AProjectUUID,
133         }
134         err = s.client.RequestAndDecode(&oob, "POST", "arvados/v1/collections", s.client.UpdateBody(&oob), nil)
135         c.Assert(err, check.IsNil)
136         defer s.client.RequestAndDecode(nil, "DELETE", "arvados/v1/collections/"+oob.UUID, nil, nil)
137
138         err = project.Sync()
139         c.Check(err, check.IsNil)
140         f, err := s.fs.Open("/home/A Project/oob")
141         c.Assert(err, check.IsNil)
142         fi, err := f.Stat()
143         c.Check(fi.IsDir(), check.Equals, true)
144         f.Close()
145
146         wf, err := s.fs.OpenFile("/home/A Project/oob/test.txt", os.O_CREATE|os.O_RDWR, 0700)
147         c.Assert(err, check.IsNil)
148         _, err = wf.Write([]byte("hello oob\n"))
149         c.Check(err, check.IsNil)
150         err = wf.Close()
151         c.Check(err, check.IsNil)
152
153         // Delete test.txt behind s.fs's back by updating the
154         // collection record with the old (empty) ManifestText.
155         err = s.client.RequestAndDecode(nil, "PATCH", "arvados/v1/collections/"+oob.UUID, s.client.UpdateBody(&oob), nil)
156         c.Assert(err, check.IsNil)
157
158         err = project.Sync()
159         c.Check(err, check.IsNil)
160         _, err = s.fs.Open("/home/A Project/oob/test.txt")
161         c.Check(err, check.NotNil)
162         _, err = s.fs.Open("/home/A Project/oob")
163         c.Check(err, check.IsNil)
164
165         err = s.client.RequestAndDecode(nil, "DELETE", "arvados/v1/collections/"+oob.UUID, nil, nil)
166         c.Assert(err, check.IsNil)
167
168         err = project.Sync()
169         c.Check(err, check.IsNil)
170         _, err = s.fs.Open("/home/A Project/oob")
171         c.Check(err, check.NotNil)
172 }