1 # Copyright (C) The Arvados Authors. All rights reserved.
3 # SPDX-License-Identifier: AGPL-3.0
7 class ArvadosModelTest < ActiveSupport::TestCase
10 def create_with_attrs attrs
11 a = Collection.create({properties: {'foo' => 'bar'}}.merge(attrs))
15 test 'non-admin cannot assign uuid' do
16 set_user_from_auth :active_trustedclient
17 want_uuid = Collection.generate_uuid
18 a = create_with_attrs(uuid: want_uuid)
19 assert_nil a, "Non-admin should not assign uuid."
22 test 'admin can assign valid uuid' do
23 set_user_from_auth :admin_trustedclient
24 want_uuid = Collection.generate_uuid
25 a = create_with_attrs(uuid: want_uuid)
26 assert_equal want_uuid, a.uuid, "Admin should assign valid uuid."
27 assert a.uuid.length==27, "Auto assigned uuid length is wrong."
30 test 'admin cannot assign uuid with wrong object type' do
31 set_user_from_auth :admin_trustedclient
32 want_uuid = Group.generate_uuid
33 a = create_with_attrs(uuid: want_uuid)
34 assert_nil a, "Admin should not be able to assign invalid uuid."
37 test 'admin cannot assign badly formed uuid' do
38 set_user_from_auth :admin_trustedclient
39 a = create_with_attrs(uuid: "ntoheunthaoesunhasoeuhtnsaoeunhtsth")
40 assert_nil a, "Admin should not be able to assign invalid uuid."
43 test 'admin cannot assign empty uuid' do
44 set_user_from_auth :admin_trustedclient
45 a = create_with_attrs(uuid: "")
46 assert_nil a, "Admin cannot assign empty uuid."
51 {:a => ['foo', 'bar']},
52 {'a' => [:foo, 'bar']},
53 {'a' => ['foo', :bar]},
55 {:a => {'foo' => {'bar' => 'baz'}}},
56 {'a' => {:foo => {'bar' => 'baz'}}},
57 {'a' => {'foo' => {:bar => 'baz'}}},
58 {'a' => {'foo' => {'bar' => :baz}}},
59 {'a' => {'foo' => ['bar', :baz]}},
61 test "prevent symbol keys in serialized db columns: #{x.inspect}" do
62 set_user_from_auth :active
63 link = Link.create!(link_class: 'test',
65 raw = ActiveRecord::Base.connection.
66 select_value("select properties from links where uuid='#{link.uuid}'")
67 refute_match(/:[fb]/, raw)
72 {'a' => {['foo', :foo] => 'bar'}},
73 {'a' => {{'foo' => 'bar'} => 'bar'}},
74 {'a' => {['foo', :foo] => ['bar', 'baz']}},
76 test "refuse non-string keys in serialized db columns: #{x.inspect}" do
77 set_user_from_auth :active
78 assert_raises(ArgumentError) do
79 Link.create!(link_class: 'test',
85 test "No HashWithIndifferentAccess in database" do
86 set_user_from_auth :admin_trustedclient
87 link = Link.create!(link_class: 'test',
88 properties: {'foo' => 'bar'}.with_indifferent_access)
89 raw = ActiveRecord::Base.connection.
90 select_value("select properties from links where uuid='#{link.uuid}'")
91 assert_equal '{"foo": "bar"}', raw
94 test "store long string" do
95 set_user_from_auth :active
97 while longstring.length < 2**16
98 longstring = longstring + longstring
100 g = Group.create! name: 'Has a long description', description: longstring, group_class: "project"
101 g = Group.find_by_uuid g.uuid
102 assert_equal g.description, longstring
105 [['uuid', {unique: true}],
106 ['owner_uuid', {}]].each do |the_column, requires|
107 test "unique index on all models with #{the_column}" do
109 ActiveRecord::Base.connection.tables.each do |table|
110 columns = ActiveRecord::Base.connection.columns(table)
112 next unless columns.collect(&:name).include? the_column
114 indexes = ActiveRecord::Base.connection.indexes(table).reject do |index|
115 requires.map do |key, val|
116 index.send(key) == val
119 assert_includes indexes.collect(&:columns), [the_column], 'no index'
122 # Sanity check: make sure we didn't just systematically miss everything.
123 assert_operator(10, :<, checked,
124 "Only #{checked} tables have a #{the_column}?!")
128 test "search index exists on models that go into projects" do
129 all_tables = ActiveRecord::Base.connection.tables - [
130 'ar_internal_metadata',
131 'permission_refresh_lock',
133 # tables that may still exist in the database even though model
134 # classes have been deleted:
140 'pipeline_instances',
141 'pipeline_templates',
147 all_tables.each do |table|
148 table_class = table.classify.constantize
149 if table_class.respond_to?('searchable_columns')
150 search_index_columns = table_class.searchable_columns('ilike')
151 # Disappointing, but text columns aren't indexed yet.
152 search_index_columns -= table_class.columns.select { |c|
153 c.type == :text or c.name == 'description' or c.name == 'file_names'
156 indexes = ActiveRecord::Base.connection.indexes(table)
157 search_index_by_columns = indexes.select do |index|
158 # After rails 5.0 upgrade, AR::Base.connection.indexes() started to include
159 # GIN indexes, with its 'columns' attribute being a String like
161 index.columns.is_a?(Array) ? index.columns.sort == search_index_columns.sort : false
163 search_index_by_name = indexes.select do |index|
164 index.name == "#{table}_search_index"
166 assert !search_index_by_columns.empty?, "#{table} has no search index with columns #{search_index_columns}. Instead found search index with columns #{search_index_by_name.first.andand.columns}"
172 %w[collections collections_trgm_text_search_idx],
173 %w[container_requests container_requests_trgm_text_search_idx],
174 %w[groups groups_trgm_text_search_idx],
175 %w[workflows workflows_trgm_text_search_idx]
179 test "trigram index exists on #{table} model" do
180 table_class = table.classify.constantize
181 expect = table_class.full_text_searchable_columns
183 conn = ActiveRecord::Base.connection
184 conn.exec_query("SELECT indexdef FROM pg_indexes WHERE tablename = '#{table}' AND indexname = '#{indexname}'").each do |res|
185 searchable = res['indexdef'].scan(/COALESCE\(+([A-Za-z_]+)/).flatten
186 ok = (expect == searchable)
187 assert ok, "Invalid or no trigram index on #{table} named #{indexname}\nexpect: #{expect.inspect}\nfound: #{searchable}"
192 test "selectable_attributes includes database attributes" do
193 assert_includes(Collection.selectable_attributes, "name")
196 test "selectable_attributes includes non-database attributes" do
197 assert_includes(Collection.selectable_attributes, "unsigned_manifest_text")
200 test "selectable_attributes includes common attributes in extensions" do
201 assert_includes(Collection.selectable_attributes, "uuid")
204 test "selectable_attributes does not include unexposed attributes" do
205 refute_includes(Collection.selectable_attributes, "id")
208 test "selectable_attributes on a non-default template" do
209 attr_a = Collection.selectable_attributes(:common)
210 assert_includes(attr_a, "uuid")
211 refute_includes(attr_a, "name")
214 test 'create and retrieve using created_at time' do
215 set_user_from_auth :active
216 group = Group.create! name: 'test create and retrieve group', group_class: "project"
217 assert group.valid?, "group is not valid"
219 results = Group.where(created_at: group.created_at)
220 assert_includes results.map(&:uuid), group.uuid,
221 "Expected new group uuid in results when searched with its created_at timestamp"
224 test 'create and update twice and expect different update times' do
225 set_user_from_auth :active
226 group = Group.create! name: 'test create and retrieve group', group_class: "project"
227 assert group.valid?, "group is not valid"
230 group.update!(name: "test create and update name 1")
231 results = Group.where(uuid: group.uuid)
232 assert_equal "test create and update name 1", results.first.name, "Expected name to be updated to 1"
233 modified_at_1 = results.first.modified_at.to_f
236 group.update!(name: "test create and update name 2")
237 results = Group.where(uuid: group.uuid)
238 assert_equal "test create and update name 2", results.first.name, "Expected name to be updated to 2"
239 modified_at_2 = results.first.modified_at.to_f
241 assert_equal true, (modified_at_2 > modified_at_1), "Expected modified time 2 to be newer than 1"
244 test 'jsonb column' do
245 set_user_from_auth :active
247 c = Collection.create!(properties: {})
248 assert_equal({}, c.properties)
250 c.update(properties: {'foo' => 'foo'})
252 assert_equal({'foo' => 'foo'}, c.properties)
254 c.update(properties: nil)
256 assert_equal({}, c.properties)
258 c.update(properties: {foo: 'bar'})
259 assert_equal({'foo' => 'bar'}, c.properties)
261 assert_equal({'foo' => 'bar'}, c.properties)
264 test 'serialized attributes dirty tracking with audit log settings' do
265 Rails.configuration.AuditLogs.MaxDeleteBatch = 1000
266 set_user_from_auth :admin
267 [false, true].each do |auditlogs_enabled|
269 Rails.configuration.AuditLogs.MaxAge = 3600
271 Rails.configuration.AuditLogs.MaxAge = 0
273 tested_serialized = false
275 User.find_by_uuid(users(:active).uuid),
276 ContainerRequest.find_by_uuid(container_requests(:queued).uuid),
277 Container.find_by_uuid(containers(:queued).uuid),
278 Group.find_by_uuid(groups(:afiltergroup).uuid),
279 Collection.find_by_uuid(collections(:collection_with_one_property).uuid),
281 if !obj.class.serialized_attributes.empty?
282 tested_serialized = true
284 # obj shouldn't have changed since it's just retrieved from the database
285 assert_not(obj.changed?, "#{obj.class} model's attribute(s) appear as changed: '#{obj.changes.keys.join(',')}' with audit logs #{auditlogs_enabled ? '': 'not '}enabled.")
287 assert(tested_serialized, "did not test any models with serialized attributes")