lib/dispatchcloud/node_size_test.go

   1 // Copyright (C) The Arvados Authors. All rights reserved.
   2 //
   3 // SPDX-License-Identifier: AGPL-3.0
   4
   5 package dispatchcloud
   6
   7 import (
   8         "git.arvados.org/arvados.git/sdk/go/arvados"
   9         check "gopkg.in/check.v1"
  10 )
  11
  12 var _ = check.Suite(&NodeSizeSuite{})
  13
  14 const GiB = arvados.ByteSize(1 << 30)
  15
  16 type NodeSizeSuite struct{}
  17
  18 func (*NodeSizeSuite) TestChooseNotConfigured(c *check.C) {
  19         _, err := ChooseInstanceType(&arvados.Cluster{}, &arvados.Container{
  20                 RuntimeConstraints: arvados.RuntimeConstraints{
  21                         RAM:   1234567890,
  22                         VCPUs: 2,
  23                 },
  24         })
  25         c.Check(err, check.Equals, ErrInstanceTypesNotConfigured)
  26 }
  27
  28 func (*NodeSizeSuite) TestChooseUnsatisfiable(c *check.C) {
  29         checkUnsatisfiable := func(ctr *arvados.Container) {
  30                 _, err := ChooseInstanceType(&arvados.Cluster{InstanceTypes: map[string]arvados.InstanceType{
  31                         "small1": {Price: 1.1, RAM: 1000000000, VCPUs: 2, Name: "small1"},
  32                         "small2": {Price: 2.2, RAM: 2000000000, VCPUs: 4, Name: "small2"},
  33                         "small4": {Price: 4.4, RAM: 4000000000, VCPUs: 8, Name: "small4", Scratch: GiB},
  34                 }}, ctr)
  35                 c.Check(err, check.FitsTypeOf, ConstraintsNotSatisfiableError{})
  36         }
  37
  38         for _, rc := range []arvados.RuntimeConstraints{
  39                 {RAM: 9876543210, VCPUs: 2},
  40                 {RAM: 1234567890, VCPUs: 20},
  41                 {RAM: 1234567890, VCPUs: 2, KeepCacheRAM: 9876543210},
  42         } {
  43                 checkUnsatisfiable(&arvados.Container{RuntimeConstraints: rc})
  44         }
  45         checkUnsatisfiable(&arvados.Container{
  46                 Mounts:             map[string]arvados.Mount{"/tmp": {Kind: "tmp", Capacity: int64(2 * GiB)}},
  47                 RuntimeConstraints: arvados.RuntimeConstraints{RAM: 12345, VCPUs: 1},
  48         })
  49 }
  50
  51 func (*NodeSizeSuite) TestChoose(c *check.C) {
  52         for _, menu := range []map[string]arvados.InstanceType{
  53                 {
  54                         "costly": {Price: 4.4, RAM: 4000000000, VCPUs: 8, Scratch: 2 * GiB, Name: "costly"},
  55                         "best":   {Price: 2.2, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "best"},
  56                         "small":  {Price: 1.1, RAM: 1000000000, VCPUs: 2, Scratch: 2 * GiB, Name: "small"},
  57                 },
  58                 {
  59                         "costly":     {Price: 4.4, RAM: 4000000000, VCPUs: 8, Scratch: 2 * GiB, Name: "costly"},
  60                         "goodenough": {Price: 2.2, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "goodenough"},
  61                         "best":       {Price: 2.2, RAM: 4000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "best"},
  62                         "small":      {Price: 1.1, RAM: 1000000000, VCPUs: 2, Scratch: 2 * GiB, Name: "small"},
  63                 },
  64                 {
  65                         "small":      {Price: 1.1, RAM: 1000000000, VCPUs: 2, Scratch: 2 * GiB, Name: "small"},
  66                         "goodenough": {Price: 2.2, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "goodenough"},
  67                         "best":       {Price: 2.2, RAM: 4000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "best"},
  68                         "costly":     {Price: 4.4, RAM: 4000000000, VCPUs: 8, Scratch: 2 * GiB, Name: "costly"},
  69                 },
  70                 {
  71                         "small":  {Price: 1.1, RAM: 1000000000, VCPUs: 2, Scratch: GiB, Name: "small"},
  72                         "nearly": {Price: 2.2, RAM: 2000000000, VCPUs: 4, Scratch: GiB, Name: "nearly"},
  73                         "best":   {Price: 3.3, RAM: 4000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "best"},
  74                         "costly": {Price: 4.4, RAM: 4000000000, VCPUs: 8, Scratch: 2 * GiB, Name: "costly"},
  75                 },
  76                 {
  77                         "small":  {Price: 1.1, RAM: 1000000000, VCPUs: 2, Scratch: GiB, Name: "small"},
  78                         "nearly": {Price: 2.2, RAM: 1200000000, VCPUs: 4, Scratch: 2 * GiB, Name: "nearly"},
  79                         "best":   {Price: 3.3, RAM: 4000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "best"},
  80                         "costly": {Price: 4.4, RAM: 4000000000, VCPUs: 8, Scratch: 2 * GiB, Name: "costly"},
  81                 },
  82         } {
  83                 best, err := ChooseInstanceType(&arvados.Cluster{InstanceTypes: menu, Containers: arvados.ContainersConfig{
  84                         LocalKeepBlobBuffersPerVCPU: 1,
  85                         ReserveExtraRAM:             268435456,
  86                 }}, &arvados.Container{
  87                         Mounts: map[string]arvados.Mount{
  88                                 "/tmp": {Kind: "tmp", Capacity: 2 * int64(GiB)},
  89                         },
  90                         RuntimeConstraints: arvados.RuntimeConstraints{
  91                                 VCPUs:        2,
  92                                 RAM:          987654321,
  93                                 KeepCacheRAM: 123456789,
  94                         },
  95                 })
  96                 c.Assert(err, check.IsNil)
  97                 c.Assert(best, check.Not(check.HasLen), 0)
  98                 c.Check(best[0].Name, check.Equals, "best")
  99                 c.Check(best[0].RAM >= 1234567890, check.Equals, true)
 100                 c.Check(best[0].VCPUs >= 2, check.Equals, true)
 101                 c.Check(best[0].Scratch >= 2*GiB, check.Equals, true)
 102                 for i := range best {
 103                         // If multiple instance types are returned
 104                         // then they should all have the same price,
 105                         // because we didn't set MaximumPriceFactor>1.
 106                         c.Check(best[i].Price, check.Equals, best[0].Price)
 107                 }
 108         }
 109 }
 110
 111 func (*NodeSizeSuite) TestMaximumPriceFactor(c *check.C) {
 112         menu := map[string]arvados.InstanceType{
 113                 "best+7":  {Price: 3.4, RAM: 8000000000, VCPUs: 8, Scratch: 64 * GiB, Name: "best+7"},
 114                 "best+5":  {Price: 3.0, RAM: 8000000000, VCPUs: 8, Scratch: 16 * GiB, Name: "best+5"},
 115                 "best+3":  {Price: 2.6, RAM: 4000000000, VCPUs: 8, Scratch: 16 * GiB, Name: "best+3"},
 116                 "best+2":  {Price: 2.4, RAM: 4000000000, VCPUs: 8, Scratch: 4 * GiB, Name: "best+2"},
 117                 "best+1":  {Price: 2.2, RAM: 2000000000, VCPUs: 4, Scratch: 4 * GiB, Name: "best+1"},
 118                 "best":    {Price: 2.0, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "best"},
 119                 "small+1": {Price: 1.1, RAM: 1000000000, VCPUs: 2, Scratch: 16 * GiB, Name: "small+1"},
 120                 "small":   {Price: 1.0, RAM: 2000000000, VCPUs: 2, Scratch: 1 * GiB, Name: "small"},
 121         }
 122         best, err := ChooseInstanceType(&arvados.Cluster{InstanceTypes: menu, Containers: arvados.ContainersConfig{
 123                 MaximumPriceFactor: 1.5,
 124         }}, &arvados.Container{
 125                 Mounts: map[string]arvados.Mount{
 126                         "/tmp": {Kind: "tmp", Capacity: 2 * int64(GiB)},
 127                 },
 128                 RuntimeConstraints: arvados.RuntimeConstraints{
 129                         VCPUs:        2,
 130                         RAM:          987654321,
 131                         KeepCacheRAM: 123456789,
 132                 },
 133         })
 134         c.Assert(err, check.IsNil)
 135         c.Assert(best, check.HasLen, 5)
 136         c.Check(best[0].Name, check.Equals, "best") // best price is $2
 137         c.Check(best[1].Name, check.Equals, "best+1")
 138         c.Check(best[2].Name, check.Equals, "best+2")
 139         c.Check(best[3].Name, check.Equals, "best+3")
 140         c.Check(best[4].Name, check.Equals, "best+5") // max price is $2 * 1.5 = $3
 141 }
 142
 143 func (*NodeSizeSuite) TestChooseWithBlobBuffersOverhead(c *check.C) {
 144         menu := map[string]arvados.InstanceType{
 145                 "nearly": {Price: 2.2, RAM: 4000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "small"},
 146                 "best":   {Price: 3.3, RAM: 8000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "best"},
 147                 "costly": {Price: 4.4, RAM: 12000000000, VCPUs: 8, Scratch: 2 * GiB, Name: "costly"},
 148         }
 149         best, err := ChooseInstanceType(&arvados.Cluster{InstanceTypes: menu, Containers: arvados.ContainersConfig{
 150                 LocalKeepBlobBuffersPerVCPU: 16, // 1 GiB per vcpu => 2 GiB
 151                 ReserveExtraRAM:             268435456,
 152         }}, &arvados.Container{
 153                 Mounts: map[string]arvados.Mount{
 154                         "/tmp": {Kind: "tmp", Capacity: 2 * int64(GiB)},
 155                 },
 156                 RuntimeConstraints: arvados.RuntimeConstraints{
 157                         VCPUs:        2,
 158                         RAM:          987654321,
 159                         KeepCacheRAM: 123456789,
 160                 },
 161         })
 162         c.Check(err, check.IsNil)
 163         c.Assert(best, check.HasLen, 1)
 164         c.Check(best[0].Name, check.Equals, "best")
 165 }
 166
 167 func (*NodeSizeSuite) TestChoosePreemptible(c *check.C) {
 168         menu := map[string]arvados.InstanceType{
 169                 "costly":      {Price: 4.4, RAM: 4000000000, VCPUs: 8, Scratch: 2 * GiB, Preemptible: true, Name: "costly"},
 170                 "almost best": {Price: 2.2, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "almost best"},
 171                 "best":        {Price: 2.2, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Preemptible: true, Name: "best"},
 172                 "small":       {Price: 1.1, RAM: 1000000000, VCPUs: 2, Scratch: 2 * GiB, Preemptible: true, Name: "small"},
 173         }
 174         best, err := ChooseInstanceType(&arvados.Cluster{InstanceTypes: menu}, &arvados.Container{
 175                 Mounts: map[string]arvados.Mount{
 176                         "/tmp": {Kind: "tmp", Capacity: 2 * int64(GiB)},
 177                 },
 178                 RuntimeConstraints: arvados.RuntimeConstraints{
 179                         VCPUs:        2,
 180                         RAM:          987654321,
 181                         KeepCacheRAM: 123456789,
 182                 },
 183                 SchedulingParameters: arvados.SchedulingParameters{
 184                         Preemptible: true,
 185                 },
 186         })
 187         c.Check(err, check.IsNil)
 188         c.Assert(best, check.HasLen, 1)
 189         c.Check(best[0].Name, check.Equals, "best")
 190         c.Check(best[0].RAM >= 1234567890, check.Equals, true)
 191         c.Check(best[0].VCPUs >= 2, check.Equals, true)
 192         c.Check(best[0].Scratch >= 2*GiB, check.Equals, true)
 193         c.Check(best[0].Preemptible, check.Equals, true)
 194 }
 195
 196 func (*NodeSizeSuite) TestScratchForDockerImage(c *check.C) {
 197         n := EstimateScratchSpace(&arvados.Container{
 198                 ContainerImage: "d5025c0f29f6eef304a7358afa82a822+342",
 199         })
 200         // Actual image is 371.1 MiB (according to workbench)
 201         // Estimated size is 384 MiB (402653184 bytes)
 202         // Want to reserve 2x the estimated size, so 805306368 bytes
 203         c.Check(n, check.Equals, int64(805306368))
 204
 205         n = EstimateScratchSpace(&arvados.Container{
 206                 ContainerImage: "d5025c0f29f6eef304a7358afa82a822+-342",
 207         })
 208         // Parse error will return 0
 209         c.Check(n, check.Equals, int64(0))
 210
 211         n = EstimateScratchSpace(&arvados.Container{
 212                 ContainerImage: "d5025c0f29f6eef304a7358afa82a822+34",
 213         })
 214         // Short manifest will return 0
 215         c.Check(n, check.Equals, int64(0))
 216 }
 217
 218 func (*NodeSizeSuite) TestChooseGPU(c *check.C) {
 219         menu := map[string]arvados.InstanceType{
 220                 "costly":         {Price: 4.4, RAM: 4000000000, VCPUs: 8, Scratch: 2 * GiB, Name: "costly", CUDA: arvados.CUDAFeatures{DeviceCount: 2, HardwareCapability: "9.0", DriverVersion: "11.0"}},
 221                 "low_capability": {Price: 2.1, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "low_capability", CUDA: arvados.CUDAFeatures{DeviceCount: 1, HardwareCapability: "8.0", DriverVersion: "11.0"}},
 222                 "best":           {Price: 2.2, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "best", CUDA: arvados.CUDAFeatures{DeviceCount: 1, HardwareCapability: "9.0", DriverVersion: "11.0"}},
 223                 "low_driver":     {Price: 2.1, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "low_driver", CUDA: arvados.CUDAFeatures{DeviceCount: 1, HardwareCapability: "9.0", DriverVersion: "10.0"}},
 224                 "cheap_gpu":      {Price: 2.0, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "cheap_gpu", CUDA: arvados.CUDAFeatures{DeviceCount: 1, HardwareCapability: "8.0", DriverVersion: "10.0"}},
 225                 "invalid_gpu":    {Price: 1.9, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "invalid_gpu", CUDA: arvados.CUDAFeatures{DeviceCount: 1, HardwareCapability: "12.0.12", DriverVersion: "12.0.12"}},
 226                 "non_gpu":        {Price: 1.1, RAM: 2000000000, VCPUs: 4, Scratch: 2 * GiB, Name: "non_gpu"},
 227         }
 228
 229         type GPUTestCase struct {
 230                 CUDA             arvados.CUDARuntimeConstraints
 231                 SelectedInstance string
 232         }
 233         cases := []GPUTestCase{
 234                 GPUTestCase{
 235                         CUDA: arvados.CUDARuntimeConstraints{
 236                                 DeviceCount:        1,
 237                                 HardwareCapability: "9.0",
 238                                 DriverVersion:      "11.0",
 239                         },
 240                         SelectedInstance: "best",
 241                 },
 242                 GPUTestCase{
 243                         CUDA: arvados.CUDARuntimeConstraints{
 244                                 DeviceCount:        2,
 245                                 HardwareCapability: "9.0",
 246                                 DriverVersion:      "11.0",
 247                         },
 248                         SelectedInstance: "costly",
 249                 },
 250                 GPUTestCase{
 251                         CUDA: arvados.CUDARuntimeConstraints{
 252                                 DeviceCount:        1,
 253                                 HardwareCapability: "8.0",
 254                                 DriverVersion:      "11.0",
 255                         },
 256                         SelectedInstance: "low_capability",
 257                 },
 258                 GPUTestCase{
 259                         CUDA: arvados.CUDARuntimeConstraints{
 260                                 DeviceCount:        1,
 261                                 HardwareCapability: "9.0",
 262                                 DriverVersion:      "10.0",
 263                         },
 264                         SelectedInstance: "low_driver",
 265                 },
 266                 GPUTestCase{
 267                         CUDA: arvados.CUDARuntimeConstraints{
 268                                 DeviceCount:        1,
 269                                 HardwareCapability: "",
 270                                 DriverVersion:      "10.0",
 271                         },
 272                         SelectedInstance: "",
 273                 },
 274                 GPUTestCase{
 275                         CUDA: arvados.CUDARuntimeConstraints{
 276                                 DeviceCount:        0,
 277                                 HardwareCapability: "9.0",
 278                                 DriverVersion:      "11.0",
 279                         },
 280                         SelectedInstance: "non_gpu",
 281                 },
 282         }
 283
 284         for _, tc := range cases {
 285                 best, err := ChooseInstanceType(&arvados.Cluster{InstanceTypes: menu}, &arvados.Container{
 286                         Mounts: map[string]arvados.Mount{
 287                                 "/tmp": {Kind: "tmp", Capacity: 2 * int64(GiB)},
 288                         },
 289                         RuntimeConstraints: arvados.RuntimeConstraints{
 290                                 VCPUs:        2,
 291                                 RAM:          987654321,
 292                                 KeepCacheRAM: 123456789,
 293                                 CUDA:         tc.CUDA,
 294                         },
 295                 })
 296                 if len(best) > 0 {
 297                         c.Check(err, check.IsNil)
 298                         c.Assert(best, check.HasLen, 1)
 299                         c.Check(best[0].Name, check.Equals, tc.SelectedInstance)
 300                 } else {
 301                         c.Check(err, check.Not(check.IsNil))
 302                 }
 303         }
 304 }