10797: Merge branch 'master' into 10797-ruby-2.3
[arvados.git] / services / nodemanager / tests / test_computenode_dispatch.py
1 #!/usr/bin/env python
2
3 from __future__ import absolute_import, print_function
4
5 import time
6 import unittest
7
8 import arvados.errors as arverror
9 import httplib2
10 import mock
11 import pykka
12 import threading
13
14 from libcloud.common.exceptions import BaseHTTPError
15
16 import arvnodeman.computenode.dispatch as dispatch
17 from arvnodeman.computenode.driver import BaseComputeNodeDriver
18 from . import testutil
19
20 class ComputeNodeSetupActorTestCase(testutil.ActorTestMixin, unittest.TestCase):
21     def make_mocks(self, arvados_effect=None):
22         if arvados_effect is None:
23             arvados_effect = [testutil.arvados_node_mock()]
24         self.arvados_effect = arvados_effect
25         self.timer = testutil.MockTimer()
26         self.api_client = mock.MagicMock(name='api_client')
27         self.api_client.nodes().create().execute.side_effect = arvados_effect
28         self.api_client.nodes().update().execute.side_effect = arvados_effect
29         self.cloud_client = mock.MagicMock(name='cloud_client')
30         self.cloud_client.create_node.return_value = testutil.cloud_node_mock(1)
31         self.cloud_client.is_cloud_exception = BaseComputeNodeDriver.is_cloud_exception
32
33     def make_actor(self, arv_node=None):
34         if not hasattr(self, 'timer'):
35             self.make_mocks(arvados_effect=[arv_node] if arv_node else None)
36         self.setup_actor = dispatch.ComputeNodeSetupActor.start(
37             self.timer, self.api_client, self.cloud_client,
38             testutil.MockSize(1), arv_node).proxy()
39
40     def assert_node_properties_updated(self, uuid=None,
41                                        size=testutil.MockSize(1)):
42         self.api_client.nodes().update.assert_any_call(
43             uuid=(uuid or self.arvados_effect[-1]['uuid']),
44             body={
45                 'properties': {
46                     'cloud_node': {
47                         'size': size.id,
48                         'price': size.price}}})
49
50     def test_creation_without_arvados_node(self):
51         self.make_actor()
52         finished = threading.Event()
53         self.setup_actor.subscribe(lambda _: finished.set())
54         self.assertEqual(self.arvados_effect[-1],
55                          self.setup_actor.arvados_node.get(self.TIMEOUT))
56         assert(finished.wait(self.TIMEOUT))
57         self.assertEqual(1, self.api_client.nodes().create().execute.call_count)
58         self.assertEqual(1, self.api_client.nodes().update().execute.call_count)
59         self.assert_node_properties_updated()
60         self.assertEqual(self.cloud_client.create_node(),
61                          self.setup_actor.cloud_node.get(self.TIMEOUT))
62
63     def test_creation_with_arvados_node(self):
64         self.make_mocks(arvados_effect=[testutil.arvados_node_mock()]*2)
65         self.make_actor(testutil.arvados_node_mock())
66         finished = threading.Event()
67         self.setup_actor.subscribe(lambda _: finished.set())
68         self.assertEqual(self.arvados_effect[-1],
69                          self.setup_actor.arvados_node.get(self.TIMEOUT))
70         assert(finished.wait(self.TIMEOUT))
71         self.assert_node_properties_updated()
72         self.assertEqual(2, self.api_client.nodes().update().execute.call_count)
73         self.assertEqual(self.cloud_client.create_node(),
74                          self.setup_actor.cloud_node.get(self.TIMEOUT))
75
76     def test_failed_arvados_calls_retried(self):
77         self.make_mocks([
78                 arverror.ApiError(httplib2.Response({'status': '500'}), ""),
79                 testutil.arvados_node_mock(),
80                 ])
81         self.make_actor()
82         self.wait_for_assignment(self.setup_actor, 'arvados_node')
83
84     def test_failed_cloud_calls_retried(self):
85         self.make_mocks()
86         self.cloud_client.create_node.side_effect = [
87             Exception("test cloud creation error"),
88             self.cloud_client.create_node.return_value,
89             ]
90         self.make_actor()
91         self.wait_for_assignment(self.setup_actor, 'cloud_node')
92
93     def test_unknown_basehttperror_not_retried(self):
94         self.make_mocks()
95         self.cloud_client.create_node.side_effect = [
96             BaseHTTPError(400, "Unknown"),
97             self.cloud_client.create_node.return_value,
98             ]
99         self.make_actor()
100         finished = threading.Event()
101         self.setup_actor.subscribe(lambda _: finished.set())
102         assert(finished.wait(self.TIMEOUT))
103         self.assertEqual(0, self.cloud_client.post_create_node.call_count)
104
105     def test_known_basehttperror_retried(self):
106         self.make_mocks()
107         self.cloud_client.create_node.side_effect = [
108             BaseHTTPError(400, "InstanceLimitExceeded"),
109             self.cloud_client.create_node.return_value,
110             ]
111         self.make_actor()
112         self.wait_for_assignment(self.setup_actor, 'cloud_node')
113         self.assertEqual(1, self.cloud_client.post_create_node.call_count)
114
115     def test_failed_post_create_retried(self):
116         self.make_mocks()
117         self.cloud_client.post_create_node.side_effect = [
118             Exception("test cloud post-create error"), None]
119         self.make_actor()
120         done = self.FUTURE_CLASS()
121         self.setup_actor.subscribe(done.set)
122         done.get(self.TIMEOUT)
123         self.assertEqual(2, self.cloud_client.post_create_node.call_count)
124
125     def test_stop_when_no_cloud_node(self):
126         self.make_mocks(
127             arverror.ApiError(httplib2.Response({'status': '500'}), ""))
128         self.make_actor()
129         self.assertTrue(
130             self.setup_actor.stop_if_no_cloud_node().get(self.TIMEOUT))
131         self.assertTrue(
132             self.setup_actor.actor_ref.actor_stopped.wait(self.TIMEOUT))
133
134     def test_no_stop_when_cloud_node(self):
135         self.make_actor()
136         self.wait_for_assignment(self.setup_actor, 'cloud_node')
137         self.assertFalse(
138             self.setup_actor.stop_if_no_cloud_node().get(self.TIMEOUT))
139         self.assertTrue(self.stop_proxy(self.setup_actor),
140                         "actor was stopped by stop_if_no_cloud_node")
141
142     def test_subscribe(self):
143         self.make_mocks(
144             arverror.ApiError(httplib2.Response({'status': '500'}), ""))
145         self.make_actor()
146         subscriber = mock.Mock(name='subscriber_mock')
147         self.setup_actor.subscribe(subscriber)
148         retry_resp = [testutil.arvados_node_mock()]
149         self.api_client.nodes().create().execute.side_effect = retry_resp
150         self.api_client.nodes().update().execute.side_effect = retry_resp
151         self.wait_for_assignment(self.setup_actor, 'cloud_node')
152         self.assertEqual(self.setup_actor.actor_ref.actor_urn,
153                          subscriber.call_args[0][0].actor_ref.actor_urn)
154
155     def test_late_subscribe(self):
156         self.make_actor()
157         subscriber = mock.Mock(name='subscriber_mock')
158         self.wait_for_assignment(self.setup_actor, 'cloud_node')
159         self.setup_actor.subscribe(subscriber).get(self.TIMEOUT)
160         self.stop_proxy(self.setup_actor)
161         self.assertEqual(self.setup_actor.actor_ref.actor_urn,
162                          subscriber.call_args[0][0].actor_ref.actor_urn)
163
164
165 class ComputeNodeShutdownActorMixin(testutil.ActorTestMixin):
166     def make_mocks(self, cloud_node=None, arvados_node=None,
167                    shutdown_open=True, node_broken=False):
168         self.timer = testutil.MockTimer()
169         self.shutdowns = testutil.MockShutdownTimer()
170         self.shutdowns._set_state(shutdown_open, 300)
171         self.cloud_client = mock.MagicMock(name='cloud_client')
172         self.cloud_client.broken.return_value = node_broken
173         self.arvados_client = mock.MagicMock(name='arvados_client')
174         self.updates = mock.MagicMock(name='update_mock')
175         if cloud_node is None:
176             cloud_node = testutil.cloud_node_mock()
177         self.cloud_node = cloud_node
178         self.arvados_node = arvados_node
179
180     def make_actor(self, cancellable=True, start_time=None):
181         if not hasattr(self, 'timer'):
182             self.make_mocks()
183         if start_time is None:
184             start_time = time.time()
185         monitor_actor = dispatch.ComputeNodeMonitorActor.start(
186             self.cloud_node, start_time, self.shutdowns,
187             testutil.cloud_node_fqdn, self.timer, self.updates, self.cloud_client,
188             self.arvados_node)
189         self.shutdown_actor = self.ACTOR_CLASS.start(
190             self.timer, self.cloud_client, self.arvados_client, monitor_actor,
191             cancellable).proxy()
192         self.monitor_actor = monitor_actor.proxy()
193
194     def check_success_flag(self, expected, allow_msg_count=1):
195         # allow_msg_count is the number of internal messages that may
196         # need to be handled for shutdown to finish.
197         for try_num in range(1 + allow_msg_count):
198             last_flag = self.shutdown_actor.success.get(self.TIMEOUT)
199             if last_flag is expected:
200                 break
201         else:
202             self.fail("success flag {} is not {}".format(last_flag, expected))
203
204     def test_cancellable_shutdown(self, *mocks):
205         self.make_mocks(shutdown_open=True, arvados_node=testutil.arvados_node_mock(crunch_worker_state="busy"))
206         self.cloud_client.destroy_node.return_value = True
207         self.make_actor(cancellable=True)
208         self.check_success_flag(False)
209         self.assertFalse(self.cloud_client.destroy_node.called)
210
211     def test_uncancellable_shutdown(self, *mocks):
212         self.make_mocks(shutdown_open=True, arvados_node=testutil.arvados_node_mock(crunch_worker_state="busy"))
213         self.cloud_client.destroy_node.return_value = True
214         self.make_actor(cancellable=False)
215         self.check_success_flag(True, 2)
216         self.assertTrue(self.cloud_client.destroy_node.called)
217
218     def test_arvados_node_cleaned_after_shutdown(self, *mocks):
219         cloud_node = testutil.cloud_node_mock(62)
220         arv_node = testutil.arvados_node_mock(62)
221         self.make_mocks(cloud_node, arv_node)
222         self.make_actor()
223         self.check_success_flag(True, 3)
224         update_mock = self.arvados_client.nodes().update
225         self.assertTrue(update_mock.called)
226         update_kwargs = update_mock.call_args_list[0][1]
227         self.assertEqual(arv_node['uuid'], update_kwargs.get('uuid'))
228         self.assertIn('body', update_kwargs)
229         for clear_key in ['slot_number', 'hostname', 'ip_address',
230                           'first_ping_at', 'last_ping_at']:
231             self.assertIn(clear_key, update_kwargs['body'])
232             self.assertIsNone(update_kwargs['body'][clear_key])
233         self.assertTrue(update_mock().execute.called)
234
235     def test_arvados_node_not_cleaned_after_shutdown_cancelled(self, *mocks):
236         cloud_node = testutil.cloud_node_mock(61)
237         arv_node = testutil.arvados_node_mock(61)
238         self.make_mocks(cloud_node, arv_node, shutdown_open=False)
239         self.cloud_client.destroy_node.return_value = False
240         self.make_actor(cancellable=True)
241         self.shutdown_actor.cancel_shutdown("test")
242         self.check_success_flag(False, 2)
243         self.assertFalse(self.arvados_client.nodes().update.called)
244
245
246 class ComputeNodeShutdownActorTestCase(ComputeNodeShutdownActorMixin,
247                                        unittest.TestCase):
248     ACTOR_CLASS = dispatch.ComputeNodeShutdownActor
249
250     def test_easy_shutdown(self):
251         self.make_actor(start_time=0)
252         self.check_success_flag(True)
253         self.assertTrue(self.cloud_client.destroy_node.called)
254
255     def test_shutdown_cancelled_when_destroy_node_fails(self):
256         self.make_mocks(node_broken=True)
257         self.cloud_client.destroy_node.return_value = False
258         self.make_actor(start_time=0)
259         self.check_success_flag(False, 2)
260         self.assertEqual(1, self.cloud_client.destroy_node.call_count)
261         self.assertEqual(self.ACTOR_CLASS.DESTROY_FAILED,
262                          self.shutdown_actor.cancel_reason.get(self.TIMEOUT))
263
264     def test_late_subscribe(self):
265         self.make_actor()
266         subscriber = mock.Mock(name='subscriber_mock')
267         self.shutdown_actor.subscribe(subscriber).get(self.TIMEOUT)
268         self.stop_proxy(self.shutdown_actor)
269         self.assertTrue(subscriber.called)
270         self.assertEqual(self.shutdown_actor.actor_ref.actor_urn,
271                          subscriber.call_args[0][0].actor_ref.actor_urn)
272
273
274 class ComputeNodeUpdateActorTestCase(testutil.ActorTestMixin,
275                                      unittest.TestCase):
276     def make_actor(self):
277         self.driver = mock.MagicMock(name='driver_mock')
278         self.updater = dispatch.ComputeNodeUpdateActor.start(self.driver).proxy()
279
280     def test_node_sync(self):
281         self.make_actor()
282         cloud_node = testutil.cloud_node_mock()
283         arv_node = testutil.arvados_node_mock()
284         self.updater.sync_node(cloud_node, arv_node).get(self.TIMEOUT)
285         self.driver().sync_node.assert_called_with(cloud_node, arv_node)
286
287     @testutil.no_sleep
288     def test_node_sync_error(self):
289         self.make_actor()
290         cloud_node = testutil.cloud_node_mock()
291         arv_node = testutil.arvados_node_mock()
292         self.driver().sync_node.side_effect = (IOError, Exception, True)
293         self.updater.sync_node(cloud_node, arv_node).get(self.TIMEOUT)
294         self.updater.sync_node(cloud_node, arv_node).get(self.TIMEOUT)
295         self.updater.sync_node(cloud_node, arv_node).get(self.TIMEOUT)
296         self.driver().sync_node.assert_called_with(cloud_node, arv_node)
297
298 class ComputeNodeMonitorActorTestCase(testutil.ActorTestMixin,
299                                       unittest.TestCase):
300     def make_mocks(self, node_num):
301         self.shutdowns = testutil.MockShutdownTimer()
302         self.shutdowns._set_state(False, 300)
303         self.timer = mock.MagicMock(name='timer_mock')
304         self.updates = mock.MagicMock(name='update_mock')
305         self.cloud_mock = testutil.cloud_node_mock(node_num)
306         self.subscriber = mock.Mock(name='subscriber_mock')
307         self.cloud_client = mock.MagicMock(name='cloud_client')
308         self.cloud_client.broken.return_value = False
309
310     def make_actor(self, node_num=1, arv_node=None, start_time=None):
311         if not hasattr(self, 'cloud_mock'):
312             self.make_mocks(node_num)
313         if start_time is None:
314             start_time = time.time()
315         self.node_actor = dispatch.ComputeNodeMonitorActor.start(
316             self.cloud_mock, start_time, self.shutdowns,
317             testutil.cloud_node_fqdn, self.timer, self.updates, self.cloud_client,
318             arv_node, boot_fail_after=300).proxy()
319         self.node_actor.subscribe(self.subscriber).get(self.TIMEOUT)
320
321     def node_state(self, *states):
322         return self.node_actor.in_state(*states).get(self.TIMEOUT)
323
324     def test_in_state_when_unpaired(self):
325         self.make_actor()
326         self.assertTrue(self.node_state('unpaired'))
327
328     def test_in_state_when_pairing_stale(self):
329         self.make_actor(arv_node=testutil.arvados_node_mock(
330                 job_uuid=None, age=90000))
331         self.assertTrue(self.node_state('down'))
332
333     def test_in_state_when_no_state_available(self):
334         self.make_actor(arv_node=testutil.arvados_node_mock(
335                 crunch_worker_state=None))
336         print(self.node_actor.get_state().get())
337         self.assertTrue(self.node_state('idle'))
338
339     def test_in_state_when_no_state_available_old(self):
340         self.make_actor(arv_node=testutil.arvados_node_mock(
341                 crunch_worker_state=None, age=90000))
342         print(self.node_actor.get_state().get())
343         self.assertTrue(self.node_state('down'))
344
345     def test_in_idle_state(self):
346         self.make_actor(2, arv_node=testutil.arvados_node_mock(job_uuid=None))
347         self.assertTrue(self.node_state('idle'))
348         self.assertFalse(self.node_state('busy'))
349         self.assertTrue(self.node_state('idle', 'busy'))
350
351     def test_in_busy_state(self):
352         self.make_actor(3, arv_node=testutil.arvados_node_mock(job_uuid=True))
353         self.assertFalse(self.node_state('idle'))
354         self.assertTrue(self.node_state('busy'))
355         self.assertTrue(self.node_state('idle', 'busy'))
356
357     def test_init_shutdown_scheduling(self):
358         self.make_actor()
359         self.assertTrue(self.timer.schedule.called)
360         self.assertEqual(300, self.timer.schedule.call_args[0][0])
361
362     def test_shutdown_window_close_scheduling(self):
363         self.make_actor()
364         self.shutdowns._set_state(False, 600)
365         self.timer.schedule.reset_mock()
366         self.node_actor.consider_shutdown().get(self.TIMEOUT)
367         self.stop_proxy(self.node_actor)
368         self.assertTrue(self.timer.schedule.called)
369         self.assertEqual(600, self.timer.schedule.call_args[0][0])
370         self.assertFalse(self.subscriber.called)
371
372     def test_shutdown_subscription(self):
373         self.make_actor(start_time=0)
374         self.shutdowns._set_state(True, 600)
375         self.node_actor.consider_shutdown().get(self.TIMEOUT)
376         self.assertTrue(self.subscriber.called)
377         self.assertEqual(self.node_actor.actor_ref.actor_urn,
378                          self.subscriber.call_args[0][0].actor_ref.actor_urn)
379
380     def test_no_shutdown_booting(self):
381         self.make_actor()
382         self.shutdowns._set_state(True, 600)
383         self.assertEquals(self.node_actor.shutdown_eligible().get(self.TIMEOUT),
384                           (False, "node state is ('unpaired', 'open', 'boot wait', 'idle exceeded')"))
385
386     def test_shutdown_without_arvados_node(self):
387         self.make_actor(start_time=0)
388         self.shutdowns._set_state(True, 600)
389         self.assertEquals((True, "node state is ('unpaired', 'open', 'boot exceeded', 'idle exceeded')"),
390                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
391
392     def test_shutdown_missing(self):
393         arv_node = testutil.arvados_node_mock(10, job_uuid=None,
394                                               crunch_worker_state="down",
395                                               last_ping_at='1970-01-01T01:02:03.04050607Z')
396         self.make_actor(10, arv_node)
397         self.shutdowns._set_state(True, 600)
398         self.assertEquals((True, "node state is ('down', 'open', 'boot wait', 'idle exceeded')"),
399                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
400
401     def test_shutdown_running_broken(self):
402         arv_node = testutil.arvados_node_mock(12, job_uuid=None,
403                                               crunch_worker_state="down")
404         self.make_actor(12, arv_node)
405         self.shutdowns._set_state(True, 600)
406         self.cloud_client.broken.return_value = True
407         self.assertEquals((True, "node state is ('down', 'open', 'boot wait', 'idle exceeded')"),
408                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
409
410     def test_shutdown_missing_broken(self):
411         arv_node = testutil.arvados_node_mock(11, job_uuid=None,
412                                               crunch_worker_state="down",
413                                               last_ping_at='1970-01-01T01:02:03.04050607Z')
414         self.make_actor(11, arv_node)
415         self.shutdowns._set_state(True, 600)
416         self.cloud_client.broken.return_value = True
417         self.assertEquals(self.node_actor.shutdown_eligible().get(self.TIMEOUT), (True, "node state is ('down', 'open', 'boot wait', 'idle exceeded')"))
418
419     def test_no_shutdown_when_window_closed(self):
420         self.make_actor(3, testutil.arvados_node_mock(3, job_uuid=None))
421         self.assertEquals((False, "node state is ('idle', 'closed', 'boot wait', 'idle exceeded')"),
422                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
423
424     def test_no_shutdown_when_node_running_job(self):
425         self.make_actor(4, testutil.arvados_node_mock(4, job_uuid=True))
426         self.shutdowns._set_state(True, 600)
427         self.assertEquals((False, "node state is ('busy', 'open', 'boot wait', 'idle exceeded')"),
428                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
429
430     def test_shutdown_when_node_state_unknown(self):
431         self.make_actor(5, testutil.arvados_node_mock(
432             5, crunch_worker_state=None))
433         self.shutdowns._set_state(True, 600)
434         self.assertEquals((True, "node state is ('idle', 'open', 'boot wait', 'idle exceeded')"),
435                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
436
437     def test_no_shutdown_when_node_state_stale(self):
438         self.make_actor(6, testutil.arvados_node_mock(6, age=90000))
439         self.shutdowns._set_state(True, 600)
440         self.assertEquals((False, "node state is stale"),
441                           self.node_actor.shutdown_eligible().get(self.TIMEOUT))
442
443     def test_arvados_node_match(self):
444         self.make_actor(2)
445         arv_node = testutil.arvados_node_mock(
446             2, hostname='compute-two.zzzzz.arvadosapi.com')
447         self.cloud_client.node_id.return_value = '2'
448         pair_id = self.node_actor.offer_arvados_pair(arv_node).get(self.TIMEOUT)
449         self.assertEqual(self.cloud_mock.id, pair_id)
450         self.stop_proxy(self.node_actor)
451         self.updates.sync_node.assert_called_with(self.cloud_mock, arv_node)
452
453     def test_arvados_node_mismatch(self):
454         self.make_actor(3)
455         arv_node = testutil.arvados_node_mock(1)
456         self.assertIsNone(
457             self.node_actor.offer_arvados_pair(arv_node).get(self.TIMEOUT))
458
459     def test_arvados_node_mismatch_first_ping_too_early(self):
460         self.make_actor(4)
461         arv_node = testutil.arvados_node_mock(
462             4, first_ping_at='1971-03-02T14:15:16.1717282Z')
463         self.assertIsNone(
464             self.node_actor.offer_arvados_pair(arv_node).get(self.TIMEOUT))
465
466     def test_update_cloud_node(self):
467         self.make_actor(1)
468         self.make_mocks(2)
469         self.cloud_mock.id = '1'
470         self.node_actor.update_cloud_node(self.cloud_mock)
471         current_cloud = self.node_actor.cloud_node.get(self.TIMEOUT)
472         self.assertEqual([testutil.ip_address_mock(2)],
473                          current_cloud.private_ips)
474
475     def test_missing_cloud_node_update(self):
476         self.make_actor(1)
477         self.node_actor.update_cloud_node(None)
478         current_cloud = self.node_actor.cloud_node.get(self.TIMEOUT)
479         self.assertEqual([testutil.ip_address_mock(1)],
480                          current_cloud.private_ips)
481
482     def test_update_arvados_node(self):
483         self.make_actor(3)
484         job_uuid = 'zzzzz-jjjjj-updatejobnode00'
485         new_arvados = testutil.arvados_node_mock(3, job_uuid)
486         self.node_actor.update_arvados_node(new_arvados)
487         current_arvados = self.node_actor.arvados_node.get(self.TIMEOUT)
488         self.assertEqual(job_uuid, current_arvados['job_uuid'])
489
490     def test_missing_arvados_node_update(self):
491         self.make_actor(4, testutil.arvados_node_mock(4))
492         self.node_actor.update_arvados_node(None)
493         current_arvados = self.node_actor.arvados_node.get(self.TIMEOUT)
494         self.assertEqual(testutil.ip_address_mock(4),
495                          current_arvados['ip_address'])
496
497     def test_update_arvados_node_syncs_when_fqdn_mismatch(self):
498         self.make_mocks(5)
499         self.cloud_mock.extra['testname'] = 'cloudfqdn.zzzzz.arvadosapi.com'
500         self.make_actor()
501         arv_node = testutil.arvados_node_mock(5)
502         self.node_actor.update_arvados_node(arv_node).get(self.TIMEOUT)
503         self.assertEqual(1, self.updates.sync_node.call_count)
504
505     def test_update_arvados_node_skips_sync_when_fqdn_match(self):
506         self.make_mocks(6)
507         arv_node = testutil.arvados_node_mock(6)
508         self.cloud_mock.extra['testname'] ='{n[hostname]}.{n[domain]}'.format(
509             n=arv_node)
510         self.make_actor()
511         self.node_actor.update_arvados_node(arv_node).get(self.TIMEOUT)
512         self.assertEqual(0, self.updates.sync_node.call_count)