3 // Dispatcher service for Crunch that submits containers to the slurm queue.
8 "git.curoverse.com/arvados.git/sdk/go/arvados"
9 "git.curoverse.com/arvados.git/sdk/go/arvadosclient"
10 "git.curoverse.com/arvados.git/sdk/go/config"
11 "git.curoverse.com/arvados.git/sdk/go/dispatch"
12 "github.com/coreos/go-systemd/daemon"
23 // Config used by crunch-dispatch-slurm
27 SbatchArguments []string
28 PollPeriod arvados.Duration
30 // crunch-run command to invoke. The container UUID will be
31 // appended. If nil, []string{"crunch-run"} will be used.
33 // Example: []string{"crunch-run", "--cgroup-parent-subsystem=memory"}
34 CrunchRunCommand []string
36 ArvadosKeepServices []string
51 const defaultConfigPath = "/etc/arvados/crunch-dispatch-slurm/crunch-dispatch-slurm.yml"
54 flags := flag.NewFlagSet("crunch-dispatch-slurm", flag.ExitOnError)
55 flags.Usage = func() { usage(flags) }
57 configPath := flags.String(
60 "`path` to JSON or YAML configuration file")
62 // Parse args; omit the first arg which is the command name
63 flags.Parse(os.Args[1:])
65 err := readConfig(&theConfig, *configPath)
70 if theConfig.CrunchRunCommand == nil {
71 theConfig.CrunchRunCommand = []string{"crunch-run"}
74 if theConfig.PollPeriod == 0 {
75 theConfig.PollPeriod = arvados.Duration(10 * time.Second)
78 if theConfig.Client.APIHost != "" || theConfig.Client.AuthToken != "" {
79 // Copy real configs into env vars so [a]
80 // MakeArvadosClient() uses them, and [b] they get
81 // propagated to crunch-run via SLURM.
82 os.Setenv("ARVADOS_API_HOST", theConfig.Client.APIHost)
83 os.Setenv("ARVADOS_API_TOKEN", theConfig.Client.AuthToken)
84 os.Setenv("ARVADOS_API_INSECURE", "")
85 if theConfig.Client.Insecure {
86 os.Setenv("ARVADOS_API_INSECURE", "1")
88 os.Setenv("ARVADOS_KEEP_SERVICES", strings.Join(theConfig.ArvadosKeepServices, " "))
89 os.Setenv("ARVADOS_EXTERNAL_CLIENT", "")
91 log.Printf("warning: Client credentials missing from config, so falling back on environment variables (deprecated).")
94 arv, err := arvadosclient.MakeArvadosClient()
96 log.Printf("Error making Arvados client: %v", err)
101 squeueUpdater.StartMonitor(time.Duration(theConfig.PollPeriod))
102 defer squeueUpdater.Done()
104 dispatcher := dispatch.Dispatcher{
107 PollInterval: time.Duration(theConfig.PollPeriod),
108 DoneProcessing: make(chan struct{})}
110 if _, err := daemon.SdNotify("READY=1"); err != nil {
111 log.Printf("Error notifying init daemon: %v", err)
114 err = dispatcher.RunDispatcher()
123 func sbatchFunc(container arvados.Container) *exec.Cmd {
124 memPerCPU := math.Ceil(float64(container.RuntimeConstraints.RAM) / (float64(container.RuntimeConstraints.VCPUs) * 1048576))
126 var sbatchArgs []string
127 sbatchArgs = append(sbatchArgs, "--share")
128 sbatchArgs = append(sbatchArgs, theConfig.SbatchArguments...)
129 sbatchArgs = append(sbatchArgs, fmt.Sprintf("--job-name=%s", container.UUID))
130 sbatchArgs = append(sbatchArgs, fmt.Sprintf("--mem-per-cpu=%d", int(memPerCPU)))
131 sbatchArgs = append(sbatchArgs, fmt.Sprintf("--cpus-per-task=%d", container.RuntimeConstraints.VCPUs))
133 return exec.Command("sbatch", sbatchArgs...)
137 func scancelFunc(container arvados.Container) *exec.Cmd {
138 return exec.Command("scancel", "--name="+container.UUID)
141 // Wrap these so that they can be overridden by tests
142 var sbatchCmd = sbatchFunc
143 var scancelCmd = scancelFunc
145 // Submit job to slurm using sbatch.
146 func submit(dispatcher *dispatch.Dispatcher,
147 container arvados.Container, crunchRunCommand []string) (submitErr error) {
149 // If we didn't get as far as submitting a slurm job,
150 // unlock the container and return it to the queue.
151 if submitErr == nil {
152 // OK, no cleanup needed
155 err := dispatcher.Unlock(container.UUID)
157 log.Printf("Error unlocking container %s: %v", container.UUID, err)
161 // Create the command and attach to stdin/stdout
162 cmd := sbatchCmd(container)
163 stdinWriter, stdinerr := cmd.StdinPipe()
165 submitErr = fmt.Errorf("Error creating stdin pipe %v: %q", container.UUID, stdinerr)
169 stdoutReader, stdoutErr := cmd.StdoutPipe()
170 if stdoutErr != nil {
171 submitErr = fmt.Errorf("Error creating stdout pipe %v: %q", container.UUID, stdoutErr)
175 stderrReader, stderrErr := cmd.StderrPipe()
176 if stderrErr != nil {
177 submitErr = fmt.Errorf("Error creating stderr pipe %v: %q", container.UUID, stderrErr)
181 // Mutex between squeue sync and running sbatch or scancel.
182 squeueUpdater.SlurmLock.Lock()
183 defer squeueUpdater.SlurmLock.Unlock()
187 submitErr = fmt.Errorf("Error starting %v: %v", cmd.Args, err)
191 stdoutChan := make(chan []byte)
193 b, _ := ioutil.ReadAll(stdoutReader)
198 stderrChan := make(chan []byte)
200 b, _ := ioutil.ReadAll(stderrReader)
205 // Send a tiny script on stdin to execute the crunch-run command
206 // slurm actually enforces that this must be a #! script
207 io.WriteString(stdinWriter, execScript(append(crunchRunCommand, container.UUID)))
212 stdoutMsg := <-stdoutChan
213 stderrmsg := <-stderrChan
219 submitErr = fmt.Errorf("Container submission failed: %v: %v (stderr: %q)", cmd.Args, err, stderrmsg)
223 log.Printf("sbatch succeeded: %s", strings.TrimSpace(string(stdoutMsg)))
227 // If the container is marked as Locked, check if it is already in the slurm
228 // queue. If not, submit it.
230 // If the container is marked as Running, check if it is in the slurm queue.
231 // If not, mark it as Cancelled.
232 func monitorSubmitOrCancel(dispatcher *dispatch.Dispatcher, container arvados.Container, monitorDone *bool) {
235 if squeueUpdater.CheckSqueue(container.UUID) {
236 // Found in the queue, so continue monitoring
238 } else if container.State == dispatch.Locked && !submitted {
239 // Not in queue but in Locked state and we haven't
240 // submitted it yet, so submit it.
242 log.Printf("About to submit queued container %v", container.UUID)
244 if err := submit(dispatcher, container, theConfig.CrunchRunCommand); err != nil {
245 log.Printf("Error submitting container %s to slurm: %v",
247 // maybe sbatch is broken, put it back to queued
248 dispatcher.Unlock(container.UUID)
252 // Not in queue and we are not going to submit it.
253 // Refresh the container state. If it is
254 // Complete/Cancelled, do nothing, if it is Locked then
255 // release it back to the Queue, if it is Running then
256 // clean up the record.
258 var con arvados.Container
259 err := dispatcher.Arv.Get("containers", container.UUID, nil, &con)
261 log.Printf("Error getting final container state: %v", err)
265 case dispatch.Locked:
266 log.Printf("Container %s in state %v but missing from slurm queue, changing to %v.",
267 container.UUID, con.State, dispatch.Queued)
268 dispatcher.Unlock(container.UUID)
269 case dispatch.Running:
270 st := dispatch.Cancelled
271 log.Printf("Container %s in state %v but missing from slurm queue, changing to %v.",
272 container.UUID, con.State, st)
273 dispatcher.UpdateState(container.UUID, st)
275 // Container state is Queued, Complete or Cancelled so stop monitoring it.
282 // Run or monitor a container.
284 // Monitor status updates. If the priority changes to zero, cancel the
285 // container using scancel.
286 func run(dispatcher *dispatch.Dispatcher,
287 container arvados.Container,
288 status chan arvados.Container) {
290 log.Printf("Monitoring container %v started", container.UUID)
291 defer log.Printf("Monitoring container %v finished", container.UUID)
294 go monitorSubmitOrCancel(dispatcher, container, &monitorDone)
296 for container = range status {
297 if container.State == dispatch.Locked || container.State == dispatch.Running {
298 if container.Priority == 0 {
299 log.Printf("Canceling container %s", container.UUID)
301 // Mutex between squeue sync and running sbatch or scancel.
302 squeueUpdater.SlurmLock.Lock()
303 err := scancelCmd(container).Run()
304 squeueUpdater.SlurmLock.Unlock()
307 log.Printf("Error stopping container %s with scancel: %v",
309 if squeueUpdater.CheckSqueue(container.UUID) {
310 log.Printf("Container %s is still in squeue after scancel.",
316 err = dispatcher.UpdateState(container.UUID, dispatch.Cancelled)
323 func readConfig(dst interface{}, path string) error {
324 err := config.LoadFile(dst, path)
325 if err != nil && os.IsNotExist(err) && path == defaultConfigPath {
326 log.Printf("Config not specified. Continue with default configuration.")