17101: Persisting url before the login process
authorDaniel Kutyła <daniel.kutyla@contractors.roche.com>
Wed, 11 Nov 2020 09:16:59 +0000 (10:16 +0100)
committerDaniel Kutyła <daniel.kutyla@contractors.roche.com>
Wed, 11 Nov 2020 09:16:59 +0000 (10:16 +0100)
Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roche.com>

src/services/auth-service/auth-service.ts
src/views-components/api-token/api-token.tsx

index 7510171106eb2761a4b0a118661ee55dc8c812b2..d075a734e2cc61ffb3359e66dbf4ef56a7868387 100644 (file)
@@ -10,6 +10,7 @@ import { Session, SessionStatus } from "~/models/session";
 import { Config } from "~/common/config";
 import { uniqBy } from "lodash";
 
+export const TARGET_URL = 'targetURL';
 export const API_TOKEN_KEY = 'apiToken';
 export const USER_EMAIL_KEY = 'userEmail';
 export const USER_FIRST_NAME_KEY = 'userFirstName';
@@ -57,6 +58,14 @@ export class AuthService {
         }
     }
 
+    public removeTargetURL() {
+        this.getStorage().removeItem(TARGET_URL);
+    }
+
+    public getTargetURL() {
+       return this.getStorage().getItem(TARGET_URL);
+    }
+
     public removeApiToken() {
         this.getStorage().removeItem(API_TOKEN_KEY);
     }
@@ -83,11 +92,13 @@ export class AuthService {
         this.getStorage().removeItem(USER_IS_ACTIVE);
         this.getStorage().removeItem(USER_USERNAME);
         this.getStorage().removeItem(USER_PREFS);
+        this.getStorage().removeItem(TARGET_URL);
     }
 
     public login(uuidPrefix: string, homeCluster: string, loginCluster: string, remoteHosts: { [key: string]: string }) {
         const currentUrl = `${window.location.protocol}//${window.location.host}/token`;
         const homeClusterHost = remoteHosts[homeCluster];
+        this.getStorage().setItem(TARGET_URL, window.location.href);
         window.location.assign(`https://${homeClusterHost}/login?${(uuidPrefix !== homeCluster && homeCluster !== loginCluster) ? "remote=" + uuidPrefix + "&" : ""}return_to=${currentUrl}`);
     }
 
index e11afa7bf3395b587e23c312bf331b69151c8a97..955d6920984adc84687e9e7a59add73245619ca0 100644 (file)
@@ -25,7 +25,13 @@ export const ApiToken = connect()(
             const apiToken = getUrlParameter(search, 'api_token');
             const loadMainApp = this.props.loadMainApp;
             this.props.dispatch<any>(saveApiToken(apiToken)).finally(() => {
-                if (loadMainApp) {
+                const redirectURL = this.props.authService.getTargetURL();
+
+                if (redirectURL) {
+                    this.props.authService.removeTargetURL();
+                    window.location.href = redirectURL;
+                }
+                else if (loadMainApp) {
                     if (this.props.dispatch(getAccountLinkData())) {
                         this.props.dispatch(navigateToLinkAccount);
                     }