Split move to dialog into two separate dialogs
authorMichal Klobukowski <michal.klobukowski@contractors.roche.com>
Tue, 21 Aug 2018 08:03:43 +0000 (10:03 +0200)
committerMichal Klobukowski <michal.klobukowski@contractors.roche.com>
Tue, 21 Aug 2018 08:03:43 +0000 (10:03 +0200)
Feature #13831

Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski <michal.klobukowski@contractors.roche.com>

src/views-components/context-menu/action-sets/collection-action-set.ts
src/views-components/context-menu/action-sets/collection-resource-action-set.ts
src/views-components/context-menu/action-sets/project-action-set.ts
src/views-components/move-collection-dialog/move-collection-dialog.ts [new file with mode: 0644]
src/views-components/move-project-dialog/move-project-dialog.ts [new file with mode: 0644]
src/views-components/move-to-dialog/move-to-dialog.tsx
src/views/workbench/workbench.tsx

index bbe6f5f6307907d23d56c8b052a42dcfacd811d3..d807fea599b1917a0f1ac729f4584d3e5ddd47f0 100644 (file)
@@ -8,8 +8,7 @@ import { toggleFavorite } from "~/store/favorites/favorites-actions";
 import { RenameIcon, ShareIcon, MoveToIcon, CopyIcon, DetailsIcon, ProvenanceGraphIcon, AdvancedIcon, RemoveIcon } from "~/components/icon/icon";
 import { openUpdater } from "~/store/collections/updater/collection-updater-action";
 import { favoritePanelActions } from "~/store/favorite-panel/favorite-panel-action";
-import { openMoveToDialog } from "../../move-to-dialog/move-to-dialog";
-import { ResourceKind } from "~/models/resource";
+import { openMoveCollectionDialog } from '../../move-collection-dialog/move-collection-dialog';
 
 export const collectionActionSet: ContextMenuActionSet = [[
     {
@@ -29,11 +28,7 @@ export const collectionActionSet: ContextMenuActionSet = [[
     {
         icon: MoveToIcon,
         name: "Move to",
-        execute: (dispatch, resource) => dispatch<any>(openMoveToDialog({
-            name: resource.name,
-            uuid: resource.uuid,
-            kind: ResourceKind.COLLECTION
-        }))
+        execute: (dispatch, resource) => dispatch<any>(openMoveCollectionDialog(resource))
     },
     {
         component: ToggleFavoriteAction,
index 24c1bf15a8e5d06bf743149403678bd9caa204a1..b41176f2b90524d85cbf122001c9fc0b458d559f 100644 (file)
@@ -8,8 +8,7 @@ import { toggleFavorite } from "~/store/favorites/favorites-actions";
 import { RenameIcon, ShareIcon, MoveToIcon, CopyIcon, DetailsIcon, RemoveIcon } from "~/components/icon/icon";
 import { openUpdater } from "~/store/collections/updater/collection-updater-action";
 import { favoritePanelActions } from "~/store/favorite-panel/favorite-panel-action";
-import { openMoveToDialog } from "../../move-to-dialog/move-to-dialog";
-import { ResourceKind } from '~/models/resource';
+import { openMoveCollectionDialog } from '../../move-collection-dialog/move-collection-dialog';
 
 export const collectionResourceActionSet: ContextMenuActionSet = [[
     {
@@ -29,11 +28,7 @@ export const collectionResourceActionSet: ContextMenuActionSet = [[
     {
         icon: MoveToIcon,
         name: "Move to",
-        execute: (dispatch, resource) => dispatch<any>(openMoveToDialog({
-            name: resource.name,
-            uuid: resource.uuid,
-            kind: ResourceKind.COLLECTION
-        }))
+        execute: (dispatch, resource) => dispatch<any>(openMoveCollectionDialog(resource))
     },
     {
         component: ToggleFavoriteAction,
index e5c401a95c929ad6417c2fb1d460a8dca38a9f2c..b8121c3a99bae4d77934e42deb469eb5650d9d6a 100644 (file)
@@ -10,9 +10,8 @@ import { NewProjectIcon, MoveToIcon, RenameIcon } from "~/components/icon/icon";
 import { ToggleFavoriteAction } from "../actions/favorite-action";
 import { toggleFavorite } from "~/store/favorites/favorites-actions";
 import { favoritePanelActions } from "~/store/favorite-panel/favorite-panel-action";
-import { openMoveToDialog } from "../../move-to-dialog/move-to-dialog";
 import { PROJECT_CREATE_DIALOG } from "../../dialog-create/dialog-project-create";
-import { ResourceKind } from '~/models/resource';
+import { openMoveProjectDialog } from '../../move-project-dialog/move-project-dialog';
 
 export const projectActionSet: ContextMenuActionSet = [[
     {
@@ -42,10 +41,6 @@ export const projectActionSet: ContextMenuActionSet = [[
     {
         icon: MoveToIcon,
         name: "Move to",
-        execute: (dispatch, resource) => dispatch<any>(openMoveToDialog({
-            name: resource.name,
-            uuid: resource.uuid,
-            kind: ResourceKind.PROJECT
-        }))
+        execute: (dispatch, resource) => dispatch<any>(openMoveProjectDialog(resource))
     },
 ]];
diff --git a/src/views-components/move-collection-dialog/move-collection-dialog.ts b/src/views-components/move-collection-dialog/move-collection-dialog.ts
new file mode 100644 (file)
index 0000000..bb75bd6
--- /dev/null
@@ -0,0 +1,50 @@
+// Copyright (C) The Arvados Authors. All rights reserved.
+//
+// SPDX-License-Identifier: AGPL-3.0
+
+import { Dispatch, compose } from "redux";
+import { withDialog } from "~/store/dialog/with-dialog";
+import { dialogActions } from "~/store/dialog/dialog-actions";
+import { reduxForm, startSubmit, stopSubmit, initialize } from 'redux-form';
+import { ServiceRepository } from '~/services/services';
+import { RootState } from '~/store/store';
+import { getCommonResourceServiceError, CommonResourceServiceError } from "~/common/api/common-resource-service";
+import { snackbarActions } from '~/store/snackbar/snackbar-actions';
+import { MoveToFormDialogData, MoveToFormDialog } from '../move-to-dialog/move-to-dialog';
+
+export const MOVE_COLLECTION_DIALOG = 'moveCollectionDialog';
+
+export const openMoveCollectionDialog = (resource: { name: string, uuid: string }) =>
+    (dispatch: Dispatch) => {
+        dispatch(initialize(MOVE_COLLECTION_DIALOG, resource));
+        dispatch(dialogActions.OPEN_DIALOG({ id: MOVE_COLLECTION_DIALOG, data: {} }));
+    };
+
+export const moveCollection = (resource: MoveToFormDialogData) =>
+    async (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository) => {
+        dispatch(startSubmit(MOVE_COLLECTION_DIALOG));
+        try {
+            const collection = await services.collectionService.get(resource.uuid);
+            await services.collectionService.update(resource.uuid, { ...collection, ownerUuid: resource.ownerUuid });
+            dispatch(dialogActions.CLOSE_DIALOG({ id: MOVE_COLLECTION_DIALOG }));
+            dispatch(snackbarActions.OPEN_SNACKBAR({ message: 'Collection has been moved', hideDuration: 2000 }));
+        } catch (e) {
+            const error = getCommonResourceServiceError(e);
+            if (error === CommonResourceServiceError.UNIQUE_VIOLATION) {
+                dispatch(stopSubmit(MOVE_COLLECTION_DIALOG, { ownerUuid: 'A collection with the same name already exists in the target project.' }));
+            } else {
+                dispatch(dialogActions.CLOSE_DIALOG({ id: MOVE_COLLECTION_DIALOG }));
+                dispatch(snackbarActions.OPEN_SNACKBAR({ message: 'Could not move the collection.', hideDuration: 2000 }));
+            }
+        }
+    };
+
+export const MoveCollectionDialog = compose(
+    withDialog(MOVE_COLLECTION_DIALOG),
+    reduxForm<MoveToFormDialogData>({
+        form: MOVE_COLLECTION_DIALOG,
+        onSubmit: (data, dispatch) => {
+            dispatch(moveCollection(data));
+        }
+    })
+)(MoveToFormDialog);
diff --git a/src/views-components/move-project-dialog/move-project-dialog.ts b/src/views-components/move-project-dialog/move-project-dialog.ts
new file mode 100644 (file)
index 0000000..9cae51f
--- /dev/null
@@ -0,0 +1,53 @@
+// Copyright (C) The Arvados Authors. All rights reserved.
+//
+// SPDX-License-Identifier: AGPL-3.0
+
+import { Dispatch, compose } from "redux";
+import { withDialog } from "~/store/dialog/with-dialog";
+import { dialogActions } from "~/store/dialog/dialog-actions";
+import { reduxForm, startSubmit, stopSubmit, initialize } from 'redux-form';
+import { ServiceRepository } from '~/services/services';
+import { RootState } from '~/store/store';
+import { getCommonResourceServiceError, CommonResourceServiceError } from "~/common/api/common-resource-service";
+import { snackbarActions } from '~/store/snackbar/snackbar-actions';
+import { MoveToFormDialogData, MoveToFormDialog } from '../move-to-dialog/move-to-dialog';
+
+export const MOVE_PROJECT_DIALOG = 'moveProjectDialog';
+
+export const openMoveProjectDialog = (resource: { name: string, uuid: string }) =>
+    (dispatch: Dispatch) => {
+        dispatch(initialize(MOVE_PROJECT_DIALOG, resource));
+        dispatch(dialogActions.OPEN_DIALOG({ id: MOVE_PROJECT_DIALOG, data: {} }));
+    };
+
+export const moveProject = (resource: MoveToFormDialogData) =>
+    async (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository) => {
+        dispatch(startSubmit(MOVE_PROJECT_DIALOG));
+        try {
+            const project = await services.projectService.get(resource.uuid);
+            await services.projectService.update(resource.uuid, { ...project, ownerUuid: resource.ownerUuid });
+            dispatch(dialogActions.CLOSE_DIALOG({ id: MOVE_PROJECT_DIALOG }));
+            dispatch(snackbarActions.OPEN_SNACKBAR({ message: 'Project has been moved', hideDuration: 2000 }));
+        } catch (e) {
+            const error = getCommonResourceServiceError(e);
+            if (error === CommonResourceServiceError.UNIQUE_VIOLATION) {
+                dispatch(stopSubmit(MOVE_PROJECT_DIALOG, { ownerUuid: 'A project with the same name already exists in the target project.' }));
+            } else if (error === CommonResourceServiceError.OWNERSHIP_CYCLE) {
+                dispatch(stopSubmit(MOVE_PROJECT_DIALOG, { ownerUuid: 'Cannot move a project into itself.' }));
+            } else {
+                dispatch(dialogActions.CLOSE_DIALOG({ id: MOVE_PROJECT_DIALOG }));
+                dispatch(snackbarActions.OPEN_SNACKBAR({ message: 'Could not move the project.', hideDuration: 2000 }));
+            }
+        }
+    };
+
+export const MoveProjectDialog = compose(
+    withDialog(MOVE_PROJECT_DIALOG),
+    reduxForm<MoveToFormDialogData>({
+        form: MOVE_PROJECT_DIALOG,
+        onSubmit: (data, dispatch) => {
+            dispatch(moveProject(data));
+        }
+    })
+)(MoveToFormDialog);
+
index ad3db4829ee7b5af581b3b1b42cd19f1ce036f68..9b5d06a962daa91aa1d2061f4d1cfdc0d9a1cca6 100644 (file)
@@ -3,85 +3,36 @@
 // SPDX-License-Identifier: AGPL-3.0
 
 import * as React from "react";
-import { Dispatch, compose } from "redux";
-import { withDialog } from "~/store/dialog/with-dialog";
-import { dialogActions } from "~/store/dialog/dialog-actions";
-import { reduxForm, startSubmit, stopSubmit, InjectedFormProps, initialize, Field, WrappedFieldProps } from 'redux-form';
+import { InjectedFormProps, Field, WrappedFieldProps } from 'redux-form';
 import { WithDialogProps } from '~/store/dialog/with-dialog';
 import { FormDialog } from '~/components/form-dialog/form-dialog';
 import { ProjectTreePicker } from '~/views-components/project-tree-picker/project-tree-picker';
 import { Typography } from "@material-ui/core";
 import { ResourceKind } from '~/models/resource';
-import { ServiceRepository, getResourceService } from '~/services/services';
-import { RootState } from '~/store/store';
-import { getCommonResourceServiceError, CommonResourceServiceError } from "~/common/api/common-resource-service";
-import { snackbarActions } from '../../store/snackbar/snackbar-actions';
-import { require } from '~/validators/require';
+import { MOVE_TO_VALIDATION } from '../../validators/validators';
 
-export const MOVE_TO_DIALOG = 'moveToDialog';
-
-export interface MoveToDialogResource {
+export interface MoveToFormDialogData {
     name: string;
     uuid: string;
     ownerUuid: string;
     kind: ResourceKind;
 }
 
-export const openMoveToDialog = (resource: { name: string, uuid: string, kind: ResourceKind }) =>
-    (dispatch: Dispatch) => {
-        dispatch(initialize(MOVE_TO_DIALOG, resource));
-        dispatch(dialogActions.OPEN_DIALOG({ id: MOVE_TO_DIALOG, data: {} }));
-    };
-
-export const moveResource = (resource: MoveToDialogResource) =>
-    async (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository) => {
-        const service = getResourceService(resource.kind, services);
-        dispatch(startSubmit(MOVE_TO_DIALOG));
-        if (service) {
-            try {
-                const originalResource = await service.get(resource.uuid);
-                await service.update(resource.uuid, { ...originalResource, ownerUuid: resource.ownerUuid });
-                dispatch(dialogActions.CLOSE_DIALOG({ id: MOVE_TO_DIALOG }));
-                dispatch(snackbarActions.OPEN_SNACKBAR({ message: 'Resource has been moved', hideDuration: 2000 }));
-            } catch (e) {
-                const error = getCommonResourceServiceError(e);
-                if (error === CommonResourceServiceError.UNIQUE_VIOLATION) {
-                    dispatch(stopSubmit(MOVE_TO_DIALOG, { ownerUuid: 'A resource with the same name already exists in the target project.' }));
-                } else if (error === CommonResourceServiceError.OWNERSHIP_CYCLE) {
-                    dispatch(stopSubmit(MOVE_TO_DIALOG, { ownerUuid: 'Cannot move a project into itself.' }));
-                } else {
-                    dispatch(dialogActions.CLOSE_DIALOG({ id: MOVE_TO_DIALOG }));
-                    dispatch(snackbarActions.OPEN_SNACKBAR({ message: 'Could not move the resource.', hideDuration: 2000 }));
-                }
-            }
-        }
-    };
-
-export const MoveToProjectDialog = compose(
-    withDialog(MOVE_TO_DIALOG),
-    reduxForm<MoveToDialogResource>({
-        form: MOVE_TO_DIALOG,
-        onSubmit: (data, dispatch) => {
-            dispatch(moveResource(data));
-        }
-    })
-)((props: WithDialogProps<string> & InjectedFormProps<MoveToDialogResource>) =>
+export const MoveToFormDialog = (props: WithDialogProps<string> & InjectedFormProps<MoveToFormDialogData>) =>
     <FormDialog
         dialogTitle='Move to'
         formFields={MoveToDialogFields}
         submitLabel='Move'
         {...props}
-    />);
+    />;
 
-const MoveToDialogFields = (props: InjectedFormProps<MoveToDialogResource>) =>
+const MoveToDialogFields = () =>
     <Field
         name="ownerUuid"
-        component={Picker}
-        validate={validation} />;
-
-const validation = [require];
+        component={ProjectPicker}
+        validate={MOVE_TO_VALIDATION} />;
 
-const Picker = (props: WrappedFieldProps) =>
+const ProjectPicker = (props: WrappedFieldProps) =>
     <div style={{ height: '200px', display: 'flex', flexDirection: 'column' }}>
         <ProjectTreePicker onChange={handleChange(props)} />
         {props.meta.dirty && props.meta.error &&
@@ -93,4 +44,4 @@ const Picker = (props: WrappedFieldProps) =>
 const handleChange = (props: WrappedFieldProps) => (value: string) =>
     props.input.value === value
         ? props.input.onChange('')
-        : props.input.onChange(value);
\ No newline at end of file
+        : props.input.onChange(value);
index 4d0adf15184ccff1e9d210e9e5dc15bb00832eca..eba11d2c7bba5b880184368990a68626173fa1ff 100644 (file)
@@ -47,11 +47,12 @@ import { RenameFileDialog } from '~/views-components/rename-file-dialog/rename-f
 import { FileRemoveDialog } from '~/views-components/file-remove-dialog/file-remove-dialog';
 import { MultipleFilesRemoveDialog } from '~/views-components/file-remove-dialog/multiple-files-remove-dialog';
 import { DialogCollectionCreateWithSelectedFile } from '~/views-components/create-collection-dialog-with-selected/create-collection-dialog-with-selected';
-import { MoveToProjectDialog } from '../../views-components/move-to-dialog/move-to-dialog';
 import { COLLECTION_CREATE_DIALOG } from '~/views-components/dialog-create/dialog-collection-create';
 import { PROJECT_CREATE_DIALOG } from '~/views-components/dialog-create/dialog-project-create';
 import { UploadCollectionFilesDialog } from '~/views-components/upload-collection-files-dialog/upload-collection-files-dialog';
 import { CollectionPartialCopyDialog } from '../../views-components/collection-partial-copy-dialog/collection-partial-copy-dialog';
+import { MoveProjectDialog } from '~/views-components/move-project-dialog/move-project-dialog';
+import { MoveCollectionDialog } from '~/views-components/move-collection-dialog/move-collection-dialog';
 
 const DRAWER_WITDH = 240;
 const APP_BAR_HEIGHT = 100;
@@ -246,13 +247,14 @@ export const Workbench = withStyles(styles)(
                         <CreateCollectionDialog />
                         <RenameFileDialog />
                         <CollectionPartialCopyDialog />
-                        <MoveToProjectDialog />
                         <DialogCollectionCreateWithSelectedFile />
                         <FileRemoveDialog />
                         <MultipleFilesRemoveDialog />
                         <UpdateCollectionDialog />
                         <UploadCollectionFilesDialog />
                         <UpdateProjectDialog />
+                        <MoveCollectionDialog />
+                        <MoveProjectDialog />
                         <CurrentTokenDialog
                             currentToken={this.props.currentToken}
                             open={this.state.isCurrentTokenDialogOpen}