Clean up columns configurator code
authorMichal Klobukowski <michal.klobukowski@contractors.roche.com>
Thu, 14 Jun 2018 13:36:42 +0000 (15:36 +0200)
committerMichal Klobukowski <michal.klobukowski@contractors.roche.com>
Thu, 14 Jun 2018 13:36:42 +0000 (15:36 +0200)
Feature #13601

Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski <michal.klobukowski@contractors.roche.com>

src/components/data-explorer/columns-configurator/columns-configurator.tsx

index c729ca8d52753c1cb52513e5a9c2bebcac7b4c59..73d38b71f2418580f408ba73d9234c8d99788de3 100644 (file)
@@ -3,10 +3,9 @@
 // SPDX-License-Identifier: AGPL-3.0
 
 import * as React from 'react';
-import { WithStyles, StyleRulesCallback, Theme, withStyles, IconButton, Paper, List, Checkbox, ListItemText, ListItem, Typography, ListSubheader } from '@material-ui/core';
+import { WithStyles, StyleRulesCallback, Theme, withStyles, IconButton, Paper, List, Checkbox, ListItemText, ListItem } from '@material-ui/core';
 import MenuIcon from "@material-ui/icons/Menu";
 import { Column, isColumnConfigurable } from '../column';
-import { PopoverOrigin } from '@material-ui/core/Popover';
 import Popover from "../../popover/popover";
 import { IconButtonProps } from '@material-ui/core/IconButton';
 
@@ -24,9 +23,20 @@ const ColumnsConfigurator: React.SFC<ColumnsConfiguratorProps & WithStyles<CssRu
                         columns
                             .filter(isColumnConfigurable)
                             .map((column, index) => (
-                                <ListItem key={index} button onClick={() => onColumnToggle(column)}>
-                                    <Checkbox disableRipple color="primary" checked={column.selected} className={classes.checkbox} />
-                                    <ListItemText>{column.header}</ListItemText>
+                                <ListItem
+                                    button
+                                    key={index}
+                                    onClick={() => onColumnToggle(column)}
+                                >
+                                    <Checkbox
+                                        disableRipple
+                                        color="primary"
+                                        checked={column.selected}
+                                        className={classes.checkbox}
+                                    />
+                                    <ListItemText>
+                                        {column.header}
+                                    </ListItemText>
                                 </ListItem>
                             ))
                     }
@@ -42,10 +52,9 @@ const ColumnsConfiguratorTrigger: React.SFC<IconButtonProps> = (props) => (
     </IconButton>
 );
 
-type CssRules = "root" | "checkbox";
+type CssRules = "checkbox";
 
 const styles: StyleRulesCallback<CssRules> = (theme: Theme) => ({
-    root: {},
     checkbox: {
         width: 24,
         height: 24