Code review fixes
authorDaniel Kos <daniel.kos@contractors.roche.com>
Tue, 7 Aug 2018 11:07:24 +0000 (13:07 +0200)
committerDaniel Kos <daniel.kos@contractors.roche.com>
Tue, 7 Aug 2018 11:07:24 +0000 (13:07 +0200)
Feature #13856

Arvados-DCO-1.1-Signed-off-by: Daniel Kos <daniel.kos@contractors.roche.com>

src/store/collections/uploader/collection-uploader-reducer.ts

index 9864056090eb6965d2219f0c85b47c25ad076b2a..79a8a62339e5e3633912049ca7701aacfce2925a 100644 (file)
@@ -3,7 +3,6 @@
 // SPDX-License-Identifier: AGPL-3.0
 
 import { CollectionUploaderAction, collectionUploaderActions, UploadFile } from "./collection-uploader-actions";
-import * as _ from 'lodash';
 
 export type CollectionUploaderState = UploadFile[];
 
@@ -25,18 +24,15 @@ export const collectionUploaderReducer = (state: CollectionUploaderState = initi
             const startTime = Date.now();
             return state.map(f => ({...f, startTime, prevTime: startTime}));
         },
-        SET_UPLOAD_PROGRESS: ({ fileId, loaded, total, currentTime }) => {
-            const files = _.cloneDeep(state);
-            const f = files.find(f => f.id === fileId);
-            if (f) {
-                f.prevLoaded = f.loaded;
-                f.loaded = loaded;
-                f.total = total;
-                f.prevTime = f.currentTime;
-                f.currentTime = currentTime;
-            }
-            return files;
-        },
+        SET_UPLOAD_PROGRESS: ({ fileId, loaded, total, currentTime }) =>
+            state.map(f => f.id === fileId ? {
+                ...f,
+                prevLoaded: f.loaded,
+                loaded,
+                total,
+                prevTime: f.currentTime,
+                currentTime
+            } : f),
         CLEAR_UPLOAD: () => [],
         default: () => state
     });