clean code for single-list-item
authorJanicki Artur <artur.janicki@contractors.roche.com>
Wed, 18 Jul 2018 12:55:43 +0000 (14:55 +0200)
committerJanicki Artur <artur.janicki@contractors.roche.com>
Wed, 18 Jul 2018 12:55:43 +0000 (14:55 +0200)
Feature #13797

Arvados-DCO-1.1-Signed-off-by: Janicki Artur <artur.janicki@contractors.roche.com>

src/components/single-list-item/single-list-item.tsx

index 13338c3d556db7641357c707a88c75b873dc56fc..17bf8b5841b35816e2ade81186c3b50771287948 100644 (file)
@@ -23,34 +23,22 @@ class SingleListItem extends React.Component<SingleListItemProps, {}> {
         const { classes, isActive, hasMargin, name, icon: Icon } = this.props;
         return (
             <Typography component='span' className={classes.root}>
-                <ListItemIcon className={this.getListItemIconClassNames(hasMargin, isActive)}>
+                <ListItemIcon className={classnames({
+                        [classes.hasMargin]: hasMargin,
+                        [classes.active]: isActive
+                    })}>
                     <Icon />
                 </ListItemIcon>
                 <ListItemText primary={
-                    <Typography variant='body1' className={this.getListItemTextClassNames(isActive)}>
+                    <Typography variant='body1' className={classnames(classes.listItemText, {
+                            [classes.active]: isActive
+                        })}>
                         {name}
                     </Typography>
                 } />
             </Typography>
         );
     }
-
-    getListItemIconClassNames = (hasMargin?: boolean, isActive?: boolean) => {
-        const { classes } = this.props;
-        return classnames({
-            [classes.hasMargin]: hasMargin,
-            [classes.active]: isActive
-        });
-    }
-
-    getListItemTextClassNames = (isActive?: boolean) => {
-        const { classes } = this.props;
-        return classnames(classes.listItemText, {
-            [classes.active]: isActive
-        });
-    }
-
-
 }
         
 type CssRules = 'root' | 'listItemText' | 'hasMargin' | 'active';