19438: Hooked up panel, no content yet
authorPeter Amstutz <peter.amstutz@curii.com>
Mon, 19 Dec 2022 16:29:13 +0000 (11:29 -0500)
committerPeter Amstutz <peter.amstutz@curii.com>
Mon, 19 Dec 2022 16:29:13 +0000 (11:29 -0500)
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>

src/store/process-panel/process-panel-actions.ts
src/store/process-panel/process-panel-reducer.ts
src/store/process-panel/process-panel.ts
src/views/process-panel/process-panel-root.tsx
src/views/process-panel/process-panel.tsx
src/views/process-panel/process-resource-card.tsx [new file with mode: 0644]

index 6a9ea337b6d5de8144667c286256b74a347325dc..71cb83a151fb9211b523592f20f3fe6833516f17 100644 (file)
@@ -19,8 +19,10 @@ import { ContainerRequestResource } from "models/container-request";
 import { CommandOutputParameter } from 'cwlts/mappings/v1.0/CommandOutputParameter';
 import { CommandInputParameter, getIOParamId, WorkflowInputsData } from 'models/workflow';
 import { getIOParamDisplayValue, ProcessIOParameter } from "views/process-panel/process-io-card";
-import { OutputDetails } from "./process-panel";
+import { OutputDetails, NodeInstanceType, NodeInfo } from "./process-panel";
 import { AuthState } from "store/auth/auth-reducer";
+import { CommonService } from "services/common-service/common-service";
+import { camelCase } from "lodash";
 
 export const processPanelActions = unionize({
     RESET_PROCESS_PANEL: ofType<{}>(),
@@ -32,6 +34,7 @@ export const processPanelActions = unionize({
     SET_OUTPUT_RAW: ofType<OutputDetails | null>(),
     SET_OUTPUT_DEFINITIONS: ofType<CommandOutputParameter[]>(),
     SET_OUTPUT_PARAMS: ofType<ProcessIOParameter[] | null>(),
+    SET_NODE_INFO: ofType<NodeInfo>(),
 });
 
 export type ProcessPanelAction = UnionOf<typeof processPanelActions>;
@@ -67,7 +70,7 @@ export const loadInputs = (containerRequest: ContainerRequestResource) =>
 
 export const loadOutputs = (containerRequest: ContainerRequestResource) =>
     async (dispatch: Dispatch<any>, getState: () => RootState, services: ServiceRepository) => {
-        const noOutputs = {rawOutputs: {}};
+        const noOutputs = { rawOutputs: {} };
         if (!containerRequest.outputUuid) {
             dispatch<ProcessPanelAction>(processPanelActions.SET_OUTPUT_RAW(noOutputs));
             return;
@@ -102,6 +105,35 @@ export const loadOutputs = (containerRequest: ContainerRequestResource) =>
         }
     };
 
+
+export const loadNodeJson = (containerRequest: ContainerRequestResource) =>
+    async (dispatch: Dispatch<any>, getState: () => RootState, services: ServiceRepository) => {
+        const noLog = { nodeInfo: null };
+        if (!containerRequest.logUuid) {
+            dispatch<ProcessPanelAction>(processPanelActions.SET_NODE_INFO(noLog));
+            return;
+        };
+        try {
+            const propsOutputs = getRawOutputs(containerRequest);
+            const filesPromise = services.collectionService.files(containerRequest.logUuid);
+            const collectionPromise = services.collectionService.get(containerRequest.logUuid);
+            const [files, collection] = await Promise.all([filesPromise, collectionPromise]);
+
+            // Fetch node.json from keep
+            const nodeFile = files.find((file) => file.name === 'node.json') as CollectionFile | undefined;
+            let nodeData = nodeFile ? await services.collectionService.getFileContents(nodeFile) : undefined;
+            if (nodeData && (nodeData = JSON.parse(nodeData))) {
+                dispatch<ProcessPanelAction>(processPanelActions.SET_NODE_INFO({
+                    nodeInfo: CommonService.mapKeys(camelCase)(nodeData) as NodeInstanceType
+                }));
+            } else {
+                dispatch<ProcessPanelAction>(processPanelActions.SET_NODE_INFO(noLog));
+            }
+        } catch {
+            dispatch<ProcessPanelAction>(processPanelActions.SET_NODE_INFO(noLog));
+        }
+    };
+
 export const loadOutputDefinitions = (containerRequest: ContainerRequestResource) =>
     async (dispatch: Dispatch<any>, getState: () => RootState, services: ServiceRepository) => {
         if (containerRequest && containerRequest.mounts) {
index 45ca10ca29bf33d211ea1878de60e210014fde6a..8e190ead37aefa838b55c6cd960fb7f48af34ccb 100644 (file)
@@ -11,6 +11,7 @@ const initialState: ProcessPanel = {
     inputRaw: null,
     inputParams: null,
     outputRaw: null,
+    nodeInfo: null,
     outputDefinitions: [],
     outputParams: null,
 };
@@ -50,6 +51,9 @@ export const processPanelReducer = (state = initialState, action: ProcessPanelAc
         SET_OUTPUT_RAW: outputRaw => {
             return { ...state, outputRaw };
         },
+        SET_NODE_INFO: ({ nodeInfo }) => {
+            return { ...state, nodeInfo };
+        },
         SET_OUTPUT_DEFINITIONS: outputDefinitions => {
             // Set output definitions is only additive to avoid clearing when mounts go temporarily missing
             if (outputDefinitions.length) {
index 36c3e29f9130ccf5ed8fdb15c8a04a712005110b..34abd614bd093600292f406d6ab2fbdcd83be3c2 100644 (file)
@@ -13,6 +13,29 @@ export type OutputDetails = {
     pdh?: string;
 }
 
+export interface CUDAFeatures {
+    driverVersion: string;
+    hardwareCapability: string;
+    deviceCount: number;
+}
+
+export interface NodeInstanceType {
+    name: string;
+    providerType: string;
+    VCPUs: number;
+    RAM: number;
+    scratch: number;
+    includedScratch: number;
+    addedScratch: number;
+    price: number;
+    preemptible: boolean;
+    CUDA: CUDAFeatures;
+};
+
+export interface NodeInfo {
+    nodeInfo: NodeInstanceType | null;
+};
+
 export interface ProcessPanel {
     containerRequestUuid: string;
     filters: { [status: string]: boolean };
@@ -21,6 +44,7 @@ export interface ProcessPanel {
     outputRaw: OutputDetails | null;
     outputDefinitions: CommandOutputParameter[];
     outputParams: ProcessIOParameter[] | null;
+    nodeInfo: NodeInstanceType | null;
 }
 
 export const getProcessPanelCurrentUuid = (router: RouterState) => {
index 388dc746587763e2b0065236a8e3af4c70cc2240..28d2e978927ae76914b32d0ad976ab46578b0270 100644 (file)
@@ -13,7 +13,7 @@ import { MPVContainer, MPVPanelContent, MPVPanelState } from 'components/multi-p
 import { ArvadosTheme } from 'common/custom-theme';
 import { ProcessDetailsCard } from './process-details-card';
 import { ProcessIOCard, ProcessIOCardType, ProcessIOParameter } from './process-io-card';
-
+import { ProcessResourceCard } from './process-resource-card';
 import { getProcessPanelLogs, ProcessLogsPanel } from 'store/process-logs-panel/process-logs-panel';
 import { ProcessLogsCard } from './process-log-card';
 import { FilterOption } from 'views/process-panel/process-log-form';
@@ -23,7 +23,7 @@ import { CommandOutputParameter } from 'cwlts/mappings/v1.0/CommandOutputParamet
 import { AuthState } from 'store/auth/auth-reducer';
 import { ProcessCmdCard } from './process-cmd-card';
 import { ContainerRequestResource } from 'models/container-request';
-import { OutputDetails } from 'store/process-panel/process-panel';
+import { OutputDetails, NodeInstanceType } from 'store/process-panel/process-panel';
 
 type CssRules = 'root';
 
@@ -44,6 +44,7 @@ export interface ProcessPanelRootDataProps {
     outputRaw: OutputDetails | null;
     outputDefinitions: CommandOutputParameter[];
     outputParams: ProcessIOParameter[] | null;
+    nodeInfo: NodeInstanceType | null;
 }
 
 export interface ProcessPanelRootActionProps {
@@ -55,6 +56,7 @@ export interface ProcessPanelRootActionProps {
     onCopyToClipboard: (uuid: string) => void;
     loadInputs: (containerRequest: ContainerRequestResource) => void;
     loadOutputs: (containerRequest: ContainerRequestResource) => void;
+    loadNodeJson: (containerRequest: ContainerRequestResource) => void;
     loadOutputDefinitions: (containerRequest: ContainerRequestResource) => void;
     updateOutputParams: () => void;
 }
@@ -62,12 +64,13 @@ export interface ProcessPanelRootActionProps {
 export type ProcessPanelRootProps = ProcessPanelRootDataProps & ProcessPanelRootActionProps & WithStyles<CssRules>;
 
 const panelsData: MPVPanelState[] = [
-    {name: "Details"},
-    {name: "Command"},
-    {name: "Logs", visible: true},
-    {name: "Inputs"},
-    {name: "Outputs"},
-    {name: "Subprocesses"},
+    { name: "Details" },
+    { name: "Command" },
+    { name: "Logs", visible: true },
+    { name: "Inputs" },
+    { name: "Outputs" },
+    { name: "Resources" },
+    { name: "Subprocesses" },
 ];
 
 export const ProcessPanelRoot = withStyles(styles)(
@@ -80,92 +83,103 @@ export const ProcessPanelRoot = withStyles(styles)(
         outputRaw,
         outputDefinitions,
         outputParams,
+        nodeInfo,
         loadInputs,
         loadOutputs,
+        loadNodeJson,
         loadOutputDefinitions,
         updateOutputParams,
         ...props
     }: ProcessPanelRootProps) => {
 
-    const outputUuid = process?.containerRequest.outputUuid;
-    const containerRequest = process?.containerRequest;
-    const inputMounts = getInputCollectionMounts(process?.containerRequest);
+        const outputUuid = process?.containerRequest.outputUuid;
+        const containerRequest = process?.containerRequest;
+        const inputMounts = getInputCollectionMounts(process?.containerRequest);
 
-    React.useEffect(() => {
-        if (containerRequest) {
-            // Load inputs from mounts or props
-            loadInputs(containerRequest);
-            // Fetch raw output (loads from props or keep)
-            loadOutputs(containerRequest);
-            // Loads output definitions from mounts into store
-            loadOutputDefinitions(containerRequest);
-        }
-    }, [containerRequest, loadInputs, loadOutputs, loadOutputDefinitions]);
+        React.useEffect(() => {
+            if (containerRequest) {
+                // Load inputs from mounts or props
+                loadInputs(containerRequest);
+                // Fetch raw output (loads from props or keep)
+                loadOutputs(containerRequest);
+                // Loads output definitions from mounts into store
+                loadOutputDefinitions(containerRequest);
+                // load the assigned instance type from node.json in
+                // the log collection
+                loadNodeJson(containerRequest);
+            }
+        }, [containerRequest, loadInputs, loadOutputs, loadOutputDefinitions, loadNodeJson]);
 
-    // Trigger processing output params when raw or definitions change
-    React.useEffect(() => {
-        updateOutputParams();
-    }, [outputRaw, outputDefinitions, updateOutputParams]);
+        // Trigger processing output params when raw or definitions change
+        React.useEffect(() => {
+            updateOutputParams();
+        }, [outputRaw, outputDefinitions, updateOutputParams]);
 
-    return process
-        ? <MPVContainer className={props.classes.root} spacing={8} panelStates={panelsData}  justify-content="flex-start" direction="column" wrap="nowrap">
-            <MPVPanelContent forwardProps xs="auto" data-cy="process-details">
-                <ProcessDetailsCard
-                    process={process}
-                    onContextMenu={event => props.onContextMenu(event, process)}
-                    cancelProcess={props.cancelProcess}
-                />
-            </MPVPanelContent>
-            <MPVPanelContent forwardProps xs="auto" data-cy="process-cmd">
-                <ProcessCmdCard
-                    onCopy={props.onCopyToClipboard}
-                    process={process} />
-            </MPVPanelContent>
-            <MPVPanelContent forwardProps xs minHeight='50%' data-cy="process-logs">
-                <ProcessLogsCard
-                    onCopy={props.onCopyToClipboard}
-                    process={process}
-                    lines={getProcessPanelLogs(processLogsPanel)}
-                    selectedFilter={{
-                        label: processLogsPanel.selectedFilter,
-                        value: processLogsPanel.selectedFilter
-                    }}
-                    filters={processLogsPanel.filters.map(
-                        filter => ({ label: filter, value: filter })
-                    )}
-                    onLogFilterChange={props.onLogFilterChange}
-                    navigateToLog={props.navigateToLog}
-                />
-            </MPVPanelContent>
-            <MPVPanelContent forwardProps xs maxHeight='50%' data-cy="process-inputs">
-                <ProcessIOCard
-                    label={ProcessIOCardType.INPUT}
-                    process={process}
-                    params={inputParams}
-                    raw={inputRaw}
-                    mounts={inputMounts}
-                 />
-            </MPVPanelContent>
-            <MPVPanelContent forwardProps xs maxHeight='50%' data-cy="process-outputs">
-                <ProcessIOCard
-                    label={ProcessIOCardType.OUTPUT}
-                    process={process}
-                    params={outputParams}
-                    raw={outputRaw?.rawOutputs}
-                    outputUuid={outputUuid || ""}
-                 />
-            </MPVPanelContent>
-            <MPVPanelContent forwardProps xs maxHeight='50%' data-cy="process-children">
-                <SubprocessPanel />
-            </MPVPanelContent>
-        </MPVContainer>
-        : <Grid container
-            alignItems='center'
-            justify='center'
-            style={{ minHeight: '100%' }}>
-            <DefaultView
-                icon={ProcessIcon}
-                messages={['Process not found']} />
-        </Grid>;
+        return process
+            ? <MPVContainer className={props.classes.root} spacing={8} panelStates={panelsData} justify-content="flex-start" direction="column" wrap="nowrap">
+                <MPVPanelContent forwardProps xs="auto" data-cy="process-details">
+                    <ProcessDetailsCard
+                        process={process}
+                        onContextMenu={event => props.onContextMenu(event, process)}
+                        cancelProcess={props.cancelProcess}
+                    />
+                </MPVPanelContent>
+                <MPVPanelContent forwardProps xs="auto" data-cy="process-cmd">
+                    <ProcessCmdCard
+                        onCopy={props.onCopyToClipboard}
+                        process={process} />
+                </MPVPanelContent>
+                <MPVPanelContent forwardProps xs minHeight='50%' data-cy="process-logs">
+                    <ProcessLogsCard
+                        onCopy={props.onCopyToClipboard}
+                        process={process}
+                        lines={getProcessPanelLogs(processLogsPanel)}
+                        selectedFilter={{
+                            label: processLogsPanel.selectedFilter,
+                            value: processLogsPanel.selectedFilter
+                        }}
+                        filters={processLogsPanel.filters.map(
+                            filter => ({ label: filter, value: filter })
+                        )}
+                        onLogFilterChange={props.onLogFilterChange}
+                        navigateToLog={props.navigateToLog}
+                    />
+                </MPVPanelContent>
+                <MPVPanelContent forwardProps xs maxHeight='50%' data-cy="process-inputs">
+                    <ProcessIOCard
+                        label={ProcessIOCardType.INPUT}
+                        process={process}
+                        params={inputParams}
+                        raw={inputRaw}
+                        mounts={inputMounts}
+                    />
+                </MPVPanelContent>
+                <MPVPanelContent forwardProps xs maxHeight='50%' data-cy="process-outputs">
+                    <ProcessIOCard
+                        label={ProcessIOCardType.OUTPUT}
+                        process={process}
+                        params={outputParams}
+                        raw={outputRaw?.rawOutputs}
+                        outputUuid={outputUuid || ""}
+                    />
+                </MPVPanelContent>
+                <MPVPanelContent forwardProps xs maxHeight='50%' data-cy="process-resources">
+                    <ProcessResourceCard
+                        process={process}
+                        nodeInfo={nodeInfo}
+                    />
+                </MPVPanelContent>
+                <MPVPanelContent forwardProps xs maxHeight='50%' data-cy="process-children">
+                    <SubprocessPanel />
+                </MPVPanelContent>
+            </MPVContainer>
+            : <Grid container
+                alignItems='center'
+                justify='center'
+                style={{ minHeight: '100%' }}>
+                <DefaultView
+                    icon={ProcessIcon}
+                    messages={['Process not found']} />
+            </Grid>;
     }
 );
index 6e2d75c6cb6c4f551f0aab704c2dd583387ccbe9..d853fd091d767b6efcc4870689073263ac9dddfa 100644 (file)
@@ -23,6 +23,7 @@ import {
     loadOutputs,
     toggleProcessPanelFilter,
     updateOutputParams,
+    loadNodeJson
 } from 'store/process-panel/process-panel-actions';
 import { cancelRunningWorkflow } from 'store/processes/processes-actions';
 import { navigateToLogCollection, setProcessLogsPanelFilter } from 'store/process-logs-panel/process-logs-panel-actions';
@@ -42,6 +43,7 @@ const mapStateToProps = ({ router, auth, resources, processPanel, processLogsPan
         outputRaw: processPanel.outputRaw,
         outputDefinitions: processPanel.outputDefinitions,
         outputParams: processPanel.outputParams,
+        nodeInfo: processPanel.nodeInfo,
     };
 };
 
@@ -65,7 +67,8 @@ const mapDispatchToProps = (dispatch: Dispatch): ProcessPanelRootActionProps =>
     loadInputs: (containerRequest) => dispatch<any>(loadInputs(containerRequest)),
     loadOutputs: (containerRequest) => dispatch<any>(loadOutputs(containerRequest)),
     loadOutputDefinitions: (containerRequest) => dispatch<any>(loadOutputDefinitions(containerRequest)),
-    updateOutputParams: () => dispatch<any>(updateOutputParams())
+    updateOutputParams: () => dispatch<any>(updateOutputParams()),
+    loadNodeJson: (containerRequest) => dispatch<any>(loadNodeJson(containerRequest)),
 });
 
 const getFilters = (processPanel: ProcessPanelState, processes: Process[]) => {
@@ -78,6 +81,6 @@ const getFilters = (processPanel: ProcessPanelState, processes: Process[]) => {
             checked: processPanel.filters[filter],
             key: filter,
         }));
-    };
+};
 
 export const ProcessPanel = connect(mapStateToProps, mapDispatchToProps)(ProcessPanelRoot);
diff --git a/src/views/process-panel/process-resource-card.tsx b/src/views/process-panel/process-resource-card.tsx
new file mode 100644 (file)
index 0000000..79e600e
--- /dev/null
@@ -0,0 +1,107 @@
+// Copyright (C) The Arvados Authors. All rights reserved.
+//
+// SPDX-License-Identifier: AGPL-3.0
+
+import React from 'react';
+import {
+    StyleRulesCallback,
+    WithStyles,
+    withStyles,
+    Card,
+    CardHeader,
+    IconButton,
+    CardContent,
+    Tooltip,
+    Typography,
+    Grid,
+    CircularProgress,
+} from '@material-ui/core';
+import { ArvadosTheme } from 'common/custom-theme';
+import {
+    CloseIcon,
+    MaximizeIcon,
+    UnMaximizeIcon,
+    ProcessIcon
+} from 'components/icon/icon';
+import { MPVPanelProps } from 'components/multi-panel-view/multi-panel-view';
+import { connect } from 'react-redux';
+import { Process } from 'store/processes/process';
+import { NodeInstanceType } from 'store/process-panel/process-panel';
+import { DefaultView } from 'components/default-view/default-view';
+
+interface ProcessResourceCardDataProps {
+    process: Process;
+    nodeInfo: NodeInstanceType | null;
+}
+
+type CssRules = "card" | "header" | "title" | "avatar" | "iconHeader" | "content";
+
+const styles: StyleRulesCallback<CssRules> = (theme: ArvadosTheme) => ({
+    card: {},
+    header: {},
+    title: {},
+    avatar: {},
+    iconHeader: {},
+    content: {}
+});
+
+type ProcessResourceCardProps = ProcessResourceCardDataProps & WithStyles<CssRules> & MPVPanelProps;
+
+export const ProcessResourceCard = withStyles(styles)(connect()(
+    ({ classes, nodeInfo, doHidePanel, doMaximizePanel, doUnMaximizePanel, panelMaximized, panelName, process, }: ProcessResourceCardProps) => {
+
+        const loading = nodeInfo === null;
+
+        return <Card className={classes.card} data-cy="process-resources-card">
+            <CardHeader
+                className={classes.header}
+                classes={{
+                    content: classes.title,
+                    avatar: classes.avatar,
+                }}
+                avatar={<ProcessIcon className={classes.iconHeader} />}
+                title={
+                    <Typography noWrap variant='h6' color='inherit'>
+                        Resources
+                    </Typography>
+                }
+                action={
+                    <div>
+                        {doUnMaximizePanel && panelMaximized &&
+                            <Tooltip title={`Unmaximize ${panelName || 'panel'}`} disableFocusListener>
+                                <IconButton onClick={doUnMaximizePanel}><UnMaximizeIcon /></IconButton>
+                            </Tooltip>}
+                        {doMaximizePanel && !panelMaximized &&
+                            <Tooltip title={`Maximize ${panelName || 'panel'}`} disableFocusListener>
+                                <IconButton onClick={doMaximizePanel}><MaximizeIcon /></IconButton>
+                            </Tooltip>}
+                        {doHidePanel &&
+                            <Tooltip title={`Close ${panelName || 'panel'}`} disableFocusListener>
+                                <IconButton disabled={panelMaximized} onClick={doHidePanel}><CloseIcon /></IconButton>
+                            </Tooltip>}
+                    </div>
+                } />
+            <CardContent className={classes.content}>
+                <>
+                    {/* raw is undefined until params are loaded */}
+                    {loading && <Grid container item alignItems='center' justify='center'>
+                        <CircularProgress />
+                    </Grid>}
+                    {/* Once loaded, either raw or params may still be empty
+                      *   Raw when all params are empty
+                      *   Params when raw is provided by containerRequest properties but workflow mount is absent for preview
+                      */}
+                    {!loading &&
+                        <>
+                            <div>
+                                stuff
+                            </div>
+                        </>}
+                    {!loading && <Grid container item alignItems='center' justify='center'>
+                        <DefaultView messages={["No parameters found"]} />
+                    </Grid>}
+                </>
+            </CardContent>
+        </Card>;
+    }
+));