17782: Fixes assorted compile warnings.

There're some more not being addressed, the majority being from the cwl-svg
library.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>

diff --git a/src/components/collection-panel-files/collection-panel-files.tsx b/src/components/collection-panel-files/collection-panel-files.tsx
index 4667248c6293f1dd0ec699bb542d39584d0cc07e..4118248283ae7deed8fb2b416a28ed09d764382c 100644 (file)
--- a/src/components/collection-panel-files/collection-panel-files.tsx
+++ b/src/components/collection-panel-files/collection-panel-files.tsx
@@ -75,7 +75,7 @@ export const CollectionPanelFilesComponent = ({ onItemMenuOpen, onSearchChange,
 
     useEffect(() => {
         onSearchChange(searchValue);
 
     useEffect(() => {
         onSearchChange(searchValue);

-    }, [searchValue]);
+    }, [onSearchChange, searchValue]);

 
     return (<Card data-cy='collection-files-panel' className={classes.root}>
         <CardHeader
 
     return (<Card data-cy='collection-files-panel' className={classes.root}>
         <CardHeader

diff --git a/src/store/project-panel/project-panel-middleware-service.ts b/src/store/project-panel/project-panel-middleware-service.ts
index d9bf0d28f4f1fa3a651c09d07715c2f5c8ca3ac8..659cd957a1bbaaac41b32e214927200ab0be89d9 100644 (file)
--- a/src/store/project-panel/project-panel-middleware-service.ts
+++ b/src/store/project-panel/project-panel-middleware-service.ts
@@ -129,7 +129,6 @@ export const getFilters = (dataExplorer: DataExplorer) => {
             break;
         }
         case ProcessStatusFilter.CANCELLED:
             break;
         }
         case ProcessStatusFilter.CANCELLED:

-        case ProcessStatusFilter.FAILED:

         case ProcessStatusFilter.LOCKED:
         case ProcessStatusFilter.QUEUED:
         case ProcessStatusFilter.RUNNING: {
         case ProcessStatusFilter.LOCKED:
         case ProcessStatusFilter.QUEUED:
         case ProcessStatusFilter.RUNNING: {

diff --git a/src/store/resource-type-filters/resource-type-filters.ts b/src/store/resource-type-filters/resource-type-filters.ts
index 8e902606c0013620c127dfe6e2e45a60b20323f8..e42a16d89863e494c22ecef9fc87c8f0329eabae 100644 (file)
--- a/src/store/resource-type-filters/resource-type-filters.ts
+++ b/src/store/resource-type-filters/resource-type-filters.ts
@@ -290,7 +290,6 @@ export const buildProcessStatusFilters = ( fb:FilterBuilder, activeStatusFilter:
             break;
         }
         case ProcessStatusFilter.CANCELLED:
             break;
         }
         case ProcessStatusFilter.CANCELLED:

-        case ProcessStatusFilter.FAILED:

         case ProcessStatusFilter.LOCKED:
         case ProcessStatusFilter.RUNNING: {
             fb.addEqual('container.state', activeStatusFilter);
         case ProcessStatusFilter.LOCKED:
         case ProcessStatusFilter.RUNNING: {
             fb.addEqual('container.state', activeStatusFilter);

diff --git a/src/store/virtual-machines/virtual-machines-actions.ts b/src/store/virtual-machines/virtual-machines-actions.ts
index aa8cbfddd619afd8a16ffd2923292453a1443f75..e3b69d8dab4df73f797a2e44895a9780343d08ff 100644 (file)
--- a/src/store/virtual-machines/virtual-machines-actions.ts
+++ b/src/store/virtual-machines/virtual-machines-actions.ts
@@ -81,7 +81,7 @@ export const loadVirtualMachinesUserData = () =>
 
 export const saveRequestedDate = () =>
     (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository) => {
 
 export const saveRequestedDate = () =>
     (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository) => {

-        const date = formatDate((new Date).toISOString());
+        const date = formatDate((new Date()).toISOString());

         services.virtualMachineService.saveRequestedDate(date);
         dispatch<any>(loadRequestedDate());
     };
         services.virtualMachineService.saveRequestedDate(date);
         dispatch<any>(loadRequestedDate());
     };

diff --git a/src/views-components/auto-logout/auto-logout.tsx b/src/views-components/auto-logout/auto-logout.tsx
index 9a8299b25ca3b351f6c3f9ee161f9e6b67bb5d0c..a2d71d08dc406bf2d1baf96d13ce2929f5291c28 100644 (file)
--- a/src/views-components/auto-logout/auto-logout.tsx
+++ b/src/views-components/auto-logout/auto-logout.tsx
@@ -63,7 +63,7 @@ export const AutoLogoutComponent = (props: AutoLogoutProps) => {
         return () => {
             window.removeEventListener('storage', handleStorageEvents);
         };
         return () => {
             window.removeEventListener('storage', handleStorageEvents);
         };

-    }, []);
+    });

 
     const handleStorageEvents = (e: StorageEvent) => {
         if (e.key === LAST_ACTIVE_TIMESTAMP) {
 
     const handleStorageEvents = (e: StorageEvent) => {
         if (e.key === LAST_ACTIVE_TIMESTAMP) {


@@ -90,7 +90,7 @@ export const AutoLogoutComponent = (props: AutoLogoutProps) => {
 
     const handleOnAction = () => {
         // Notify the other tabs there was some activity.
 
     const handleOnAction = () => {
         // Notify the other tabs there was some activity.

-        const now = (new Date).getTime();
+        const now = (new Date()).getTime();

         localStorage.setItem(LAST_ACTIVE_TIMESTAMP, now.toString());
     };
 
         localStorage.setItem(LAST_ACTIVE_TIMESTAMP, now.toString());
     };
 

diff --git a/src/views/workflow-panel/workflow-description-card.tsx b/src/views/workflow-panel/workflow-description-card.tsx
index 7da39b988870f09536072f96e5e14a4adda40cbb..9c1d81c3ed21ecc712a154fb1abe44b779f9467f 100644 (file)
--- a/src/views/workflow-panel/workflow-description-card.tsx
+++ b/src/views/workflow-panel/workflow-description-card.tsx
@@ -114,7 +114,7 @@ export const WorkflowDetailsCard = withStyles(styles)(
                     return getWorkflowInputs(definition);
                 }
             }
                     return getWorkflowInputs(definition);
                 }
             }

-            return;
+            return undefined;

         }
 
         renderInputsTable() {
         }
 
         renderInputsTable() {