change code after CR
authorJanicki Artur <artur.janicki@contractors.roche.com>
Fri, 16 Nov 2018 16:08:19 +0000 (17:08 +0100)
committerJanicki Artur <artur.janicki@contractors.roche.com>
Fri, 16 Nov 2018 16:08:19 +0000 (17:08 +0100)
Feature #14433_properties_inside_projects

Arvados-DCO-1.1-Signed-off-by: Janicki Artur <artur.janicki@contractors.roche.com>

src/store/details-panel/details-panel-action.ts
src/views-components/details-panel/project-details.tsx

index cd9ab4b17a657a3d77db1da736edde5f317721e8..6aebc050b806951d2a388a4eaae7e8ba664afc91 100644 (file)
@@ -42,7 +42,6 @@ export const deleteProjectProperty = (key: string) =>
                 dispatch(resourcesActions.SET_RESOURCES([updatedProject]));
                 dispatch(snackbarActions.OPEN_SNACKBAR({ message: "Property has been successfully deleted.", hideDuration: 2000 }));
             }
                 dispatch(resourcesActions.SET_RESOURCES([updatedProject]));
                 dispatch(snackbarActions.OPEN_SNACKBAR({ message: "Property has been successfully deleted.", hideDuration: 2000 }));
             }
-            return;
         } catch (e) {
             dispatch(dialogActions.CLOSE_DIALOG({ id: PROJECT_PROPERTIES_FORM_NAME }));
             throw new Error('Could not remove property from the project.');
         } catch (e) {
             dispatch(dialogActions.CLOSE_DIALOG({ id: PROJECT_PROPERTIES_FORM_NAME }));
             throw new Error('Could not remove property from the project.');
index e995291026ce19188ad6ecefa60806e958e1aaa3..91c5e027ba61cb9a68deb9f4b8f214145d76561b 100644 (file)
@@ -3,7 +3,7 @@
 // SPDX-License-Identifier: AGPL-3.0
 
 import * as React from 'react';
 // SPDX-License-Identifier: AGPL-3.0
 
 import * as React from 'react';
-import { Dispatch } from 'redux';
+import { compose } from 'redux';
 import { connect } from 'react-redux';
 import { openProjectPropertiesDialog } from '~/store/details-panel/details-panel-action';
 import { ProjectIcon, RenameIcon } from '~/components/icon/icon';
 import { connect } from 'react-redux';
 import { openProjectPropertiesDialog } from '~/store/details-panel/details-panel-action';
 import { ProjectIcon, RenameIcon } from '~/components/icon/icon';
@@ -49,9 +49,7 @@ interface ProjectDetailsComponentActionProps {
     onClick: () => void;
 }
 
     onClick: () => void;
 }
 
-const mapDispatchToProps = (dispatch: Dispatch): ProjectDetailsComponentActionProps => ({
-    onClick: () => dispatch<any>(openProjectPropertiesDialog())
-});
+const mapDispatchToProps = ({ onClick: openProjectPropertiesDialog });
 
 type ProjectDetailsComponentProps = ProjectDetailsComponentDataProps & ProjectDetailsComponentActionProps & WithStyles<CssRules>;
 
 
 type ProjectDetailsComponentProps = ProjectDetailsComponentDataProps & ProjectDetailsComponentActionProps & WithStyles<CssRules>;