From f45b07b22f6d6e4169899d1d036610c29a7f495d Mon Sep 17 00:00:00 2001 From: radhika Date: Mon, 11 Aug 2014 16:36:18 -0400 Subject: [PATCH] 3296: check for prefs_changed instead of cycling through all changes. --- services/api/app/models/user.rb | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/services/api/app/models/user.rb b/services/api/app/models/user.rb index 7cd6ac40e5..072ad494b0 100644 --- a/services/api/app/models/user.rb +++ b/services/api/app/models/user.rb @@ -200,19 +200,6 @@ class User < ArvadosModel self.save! end - # update current user profile - def profile updated_profile - user_profile = self.prefs['profile'] - user_profile ||= {} - updated_profile.each do |entry| - if entry[0].starts_with? 'profile_' - user_profile[entry[0].partition('_').last] = entry[1] - end - end - self.prefs['profile'] = user_profile - self.save! - end - protected def ensure_ownership_path_leads_to_user @@ -447,8 +434,8 @@ class User < ArvadosModel # Send notification if the user saved profile for the first time def send_profile_created_notification - if self.changes.andand.include?(:prefs) - if !self.changes[:prefs][0].andand.keys.andand.any? + if self.prefs_changed? + if self.prefs_was.andand.empty? profile_notification_address = Rails.configuration.user_profile_notification_address ProfileNotifier.profile_created(self, profile_notification_address).deliver if profile_notification_address end -- 2.30.2