From e5830f6744927c870a8c7a847c1b3400c373f646 Mon Sep 17 00:00:00 2001 From: Fuad Muhic Date: Thu, 10 May 2018 11:05:29 +0200 Subject: [PATCH] Replaced call to non-existent method execute in RESTService class with correct call to exec method. Arvados-DCO-1.1-Signed-off-by: Fuad Muhic --- sdk/R/R/RESTService.R | 32 ++++++++++---------- sdk/R/tests/testthat/fakes/FakeHttpRequest.R | 4 +-- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/sdk/R/R/RESTService.R b/sdk/R/R/RESTService.R index dacf88a8c4..c215cf3595 100644 --- a/sdk/R/R/RESTService.R +++ b/sdk/R/R/RESTService.R @@ -37,8 +37,8 @@ RESTService <- R6::R6Class( headers <- list(Authorization = paste("OAuth2", self$token)) - serverResponse <- self$http$execute("GET", discoveryDocumentURL, headers, - retryTimes = self$numRetries) + serverResponse <- self$http$exec("GET", discoveryDocumentURL, headers, + retryTimes = self$numRetries) discoveryDocument <- self$httpParser$parseJSONResponse(serverResponse) private$webDavHostName <- discoveryDocument$keepWebServiceUrl @@ -64,8 +64,8 @@ RESTService <- R6::R6Class( uuid, "/", relativePath); headers <- list(Authorization = paste("OAuth2", self$token)) - serverResponse <- self$http$execute("DELETE", fileURL, headers, - retryTimes = self$numRetries) + serverResponse <- self$http$exec("DELETE", fileURL, headers, + retryTimes = self$numRetries) if(serverResponse$status_code < 200 || serverResponse$status_code >= 300) stop(paste("Server code:", serverResponse$status_code)) @@ -82,8 +82,8 @@ RESTService <- R6::R6Class( headers <- list("Authorization" = paste("OAuth2", self$token), "Destination" = toURL) - serverResponse <- self$http$execute("MOVE", fromURL, headers, - retryTimes = self$numRetries) + serverResponse <- self$http$exec("MOVE", fromURL, headers, + retryTimes = self$numRetries) if(serverResponse$status_code < 200 || serverResponse$status_code >= 300) stop(paste("Server code:", serverResponse$status_code)) @@ -98,8 +98,8 @@ RESTService <- R6::R6Class( headers <- list("Authorization" = paste("OAuth2", self$token)) - response <- self$http$execute("PROPFIND", collectionURL, headers, - retryTimes = self$numRetries) + response <- self$http$exec("PROPFIND", collectionURL, headers, + retryTimes = self$numRetries) if(all(response == "")) stop("Response is empty, request may be misconfigured") @@ -119,8 +119,8 @@ RESTService <- R6::R6Class( headers <- list("Authorization" = paste("OAuth2", self$token)) - response <- self$http$execute("PROPFIND", subcollectionURL, headers, - retryTimes = self$numRetries) + response <- self$http$exec("PROPFIND", subcollectionURL, headers, + retryTimes = self$numRetries) if(all(response == "")) stop("Response is empty, request may be misconfigured") @@ -156,8 +156,8 @@ RESTService <- R6::R6Class( if(!(contentType %in% self$httpParser$validContentTypes)) stop("Invalid contentType. Please use text or raw.") - serverResponse <- self$http$execute("GET", fileURL, headers, - retryTimes = self$numRetries) + serverResponse <- self$http$exec("GET", fileURL, headers, + retryTimes = self$numRetries) if(serverResponse$status_code < 200 || serverResponse$status_code >= 300) stop(paste("Server code:", serverResponse$status_code)) @@ -173,8 +173,8 @@ RESTService <- R6::R6Class( "Content-Type" = contentType) body <- content - serverResponse <- self$http$execute("PUT", fileURL, headers, body, - retryTimes = self$numRetries) + serverResponse <- self$http$exec("PUT", fileURL, headers, body, + retryTimes = self$numRetries) if(serverResponse$status_code < 200 || serverResponse$status_code >= 300) stop(paste("Server code:", serverResponse$status_code)) @@ -210,8 +210,8 @@ RESTService <- R6::R6Class( "Content-Type" = contentType) body <- NULL - serverResponse <- self$http$execute("PUT", fileURL, headers, body, - retryTimes = self$numRetries) + serverResponse <- self$http$exec("PUT", fileURL, headers, body, + retryTimes = self$numRetries) if(serverResponse$status_code < 200 || serverResponse$status_code >= 300) stop(paste("Server code:", serverResponse$status_code)) diff --git a/sdk/R/tests/testthat/fakes/FakeHttpRequest.R b/sdk/R/tests/testthat/fakes/FakeHttpRequest.R index 533602886a..c4dbc669ce 100644 --- a/sdk/R/tests/testthat/fakes/FakeHttpRequest.R +++ b/sdk/R/tests/testthat/fakes/FakeHttpRequest.R @@ -56,8 +56,8 @@ FakeHttpRequest <- R6::R6Class( self$serverMaxElementsPerRequest <- 5 }, - execute = function(verb, url, headers = NULL, body = NULL, query = NULL, - limit = NULL, offset = NULL, retryTimes = 0) + exec = function(verb, url, headers = NULL, body = NULL, query = NULL, + limit = NULL, offset = NULL, retryTimes = 0) { private$validateURL(url) private$validateHeaders(headers) -- 2.30.2