From e289702131cc103f1e14d94ed49bdc62e0d5d8d7 Mon Sep 17 00:00:00 2001 From: Tom Clegg Date: Mon, 1 Apr 2019 10:40:43 -0400 Subject: [PATCH] 14758: Fix panic on error reading request body. The deferred inline func panics if status != 200 && err == nil. Arvados-DCO-1.1-Signed-off-by: Tom Clegg --- services/keepproxy/keepproxy.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/keepproxy/keepproxy.go b/services/keepproxy/keepproxy.go index fc4783eff9..0cb93ffb31 100644 --- a/services/keepproxy/keepproxy.go +++ b/services/keepproxy/keepproxy.go @@ -541,7 +541,7 @@ func (h *proxyHandler) Put(resp http.ResponseWriter, req *http.Request) { if locatorIn == "" { bytes, err2 := ioutil.ReadAll(req.Body) if err2 != nil { - _ = errors.New(fmt.Sprintf("Error reading request body: %s", err2)) + err = fmt.Errorf("Error reading request body: %s", err2) status = http.StatusInternalServerError return } -- 2.30.2