From d98030aacf47c9b0ce815c40e4bfcc0252f86898 Mon Sep 17 00:00:00 2001 From: Tom Morris Date: Fri, 15 Mar 2019 01:11:59 -0400 Subject: [PATCH] Improve wording with direction of recommendation change. No issue. Arvados-DCO-1.1-Signed-off-by: Tom Morris --- tools/crunchstat-summary/crunchstat_summary/summarizer.py | 8 +++++--- ...r_9tee4-dz642-lymtndkpy39eibk-crunchstat.txt.gz.report | 2 +- .../container_9tee4-dz642-lymtndkpy39eibk.txt.gz.report | 2 +- .../tests/logfile_20151204190335.txt.gz.report | 2 +- .../tests/logfile_20151210063411.txt.gz.report | 2 +- .../tests/logfile_20151210063439.txt.gz.report | 2 +- 6 files changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/crunchstat-summary/crunchstat_summary/summarizer.py b/tools/crunchstat-summary/crunchstat_summary/summarizer.py index 96da98cdd9..bf905a3946 100644 --- a/tools/crunchstat-summary/crunchstat_summary/summarizer.py +++ b/tools/crunchstat-summary/crunchstat_summary/summarizer.py @@ -343,16 +343,18 @@ class Summarizer(object): asked_cores = self.existing_constraints.get(constraint_key) if asked_cores is None: asked_cores = 1 + # TODO: This should be more nuanced in cases where max >> avg if used_cores < asked_cores: yield ( '#!! {} max CPU usage was {}% -- ' - 'try runtime_constraints "{}":{}' + 'try reducing runtime_constraints to "{}":{}' ).format( self.label, math.ceil(cpu_max_rate*100), constraint_key, int(used_cores)) + # FIXME: This needs to be updated to account for current nodemanager algorithms def _recommend_ram(self): """Recommend an economical RAM constraint for this job. @@ -400,7 +402,7 @@ class Summarizer(object): math.ceil(nearlygibs(used_mib)) < nearlygibs(asked_mib))): yield ( '#!! {} max RSS was {} MiB -- ' - 'try runtime_constraints "{}":{}' + 'try reducing runtime_constraints to "{}":{}' ).format( self.label, int(used_mib), @@ -420,7 +422,7 @@ class Summarizer(object): if utilization < 0.8: yield ( '#!! {} Keep cache utilization was {:.2f}% -- ' - 'try runtime_constraints "{}":{} (or more)' + 'try doubling runtime_constraints to "{}":{} (or more)' ).format( self.label, utilization * 100.0, diff --git a/tools/crunchstat-summary/tests/container_9tee4-dz642-lymtndkpy39eibk-crunchstat.txt.gz.report b/tools/crunchstat-summary/tests/container_9tee4-dz642-lymtndkpy39eibk-crunchstat.txt.gz.report index 3f53126e63..c64c34c80e 100644 --- a/tools/crunchstat-summary/tests/container_9tee4-dz642-lymtndkpy39eibk-crunchstat.txt.gz.report +++ b/tools/crunchstat-summary/tests/container_9tee4-dz642-lymtndkpy39eibk-crunchstat.txt.gz.report @@ -23,4 +23,4 @@ time elapsed 20 - 20 # Max network speed in a single interval: 0.00MB/s # Keep cache miss rate 0.00% # Keep cache utilization 0.00% -#!! container max RSS was 67 MiB -- try runtime_constraints "ram":1020054732 +#!! container max RSS was 67 MiB -- try reducing runtime_constraints to "ram":1020054732 diff --git a/tools/crunchstat-summary/tests/container_9tee4-dz642-lymtndkpy39eibk.txt.gz.report b/tools/crunchstat-summary/tests/container_9tee4-dz642-lymtndkpy39eibk.txt.gz.report index 3b0d6a3f7b..3075c24b95 100644 --- a/tools/crunchstat-summary/tests/container_9tee4-dz642-lymtndkpy39eibk.txt.gz.report +++ b/tools/crunchstat-summary/tests/container_9tee4-dz642-lymtndkpy39eibk.txt.gz.report @@ -34,4 +34,4 @@ time elapsed 20 - 20 # Max network speed in a single interval: 0.00MB/s # Keep cache miss rate 0.00% # Keep cache utilization 0.00% -#!! container max RSS was 67 MiB -- try runtime_constraints "ram":1020054732 +#!! container max RSS was 67 MiB -- try reducing runtime_constraints to "ram":1020054732 diff --git a/tools/crunchstat-summary/tests/logfile_20151204190335.txt.gz.report b/tools/crunchstat-summary/tests/logfile_20151204190335.txt.gz.report index eee7715196..5e3ad152f7 100644 --- a/tools/crunchstat-summary/tests/logfile_20151204190335.txt.gz.report +++ b/tools/crunchstat-summary/tests/logfile_20151204190335.txt.gz.report @@ -31,4 +31,4 @@ time elapsed 80 - 80 # Max network speed in a single interval: 42.58MB/s # Keep cache miss rate 0.00% # Keep cache utilization 0.00% -#!! 4xphq-8i9sb-jq0ekny1xou3zoh max RSS was 334 MiB -- try runtime_constraints "min_ram_mb_per_node":972 +#!! 4xphq-8i9sb-jq0ekny1xou3zoh max RSS was 334 MiB -- try reducing runtime_constraints to "min_ram_mb_per_node":972 diff --git a/tools/crunchstat-summary/tests/logfile_20151210063411.txt.gz.report b/tools/crunchstat-summary/tests/logfile_20151210063411.txt.gz.report index c8b6774508..e260ca5bde 100644 --- a/tools/crunchstat-summary/tests/logfile_20151210063411.txt.gz.report +++ b/tools/crunchstat-summary/tests/logfile_20151210063411.txt.gz.report @@ -20,4 +20,4 @@ time elapsed 2 - 4 # Max network speed in a single interval: 0.00MB/s # Keep cache miss rate 0.00% # Keep cache utilization 0.00% -#!! 4xphq-8i9sb-zvb2ocfycpomrup max RSS was 1 MiB -- try runtime_constraints "min_ram_mb_per_node":972 +#!! 4xphq-8i9sb-zvb2ocfycpomrup max RSS was 1 MiB -- try reducing runtime_constraints to "min_ram_mb_per_node":972 diff --git a/tools/crunchstat-summary/tests/logfile_20151210063439.txt.gz.report b/tools/crunchstat-summary/tests/logfile_20151210063439.txt.gz.report index b138b18931..ffe1072250 100644 --- a/tools/crunchstat-summary/tests/logfile_20151210063439.txt.gz.report +++ b/tools/crunchstat-summary/tests/logfile_20151210063439.txt.gz.report @@ -20,4 +20,4 @@ time elapsed 2 - 3 # Max network speed in a single interval: 0.00MB/s # Keep cache miss rate 0.00% # Keep cache utilization 0.00% -#!! 4xphq-8i9sb-v831jm2uq0g2g9x max RSS was 1 MiB -- try runtime_constraints "min_ram_mb_per_node":972 +#!! 4xphq-8i9sb-v831jm2uq0g2g9x max RSS was 1 MiB -- try reducing runtime_constraints to "min_ram_mb_per_node":972 -- 2.30.2