From b6b7a5d8948a3749dabe1a983368065dd21e4599 Mon Sep 17 00:00:00 2001 From: Tom Clegg Date: Mon, 20 Nov 2023 14:03:43 -0500 Subject: [PATCH] 21189: Improve wording in config comments and logs. Arvados-DCO-1.1-Signed-off-by: Tom Clegg --- lib/config/config.default.yml | 4 ++-- services/keep-balance/server.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/config/config.default.yml b/lib/config/config.default.yml index 4fe75bd680..844e67bfcc 100644 --- a/lib/config/config.default.yml +++ b/lib/config/config.default.yml @@ -642,8 +642,8 @@ Clusters: # block" requests to send to each keepstore server at a # time. Smaller values use less memory in keepstore and # keep-balance. Larger values allow more progress per - # keep-balance iteration. Setting both limits to zero amounts - # to a "dry run". + # keep-balance iteration. A zero value computes all of the + # needed changes but does not apply any. BalancePullLimit: 100000 BalanceTrashLimit: 100000 diff --git a/services/keep-balance/server.go b/services/keep-balance/server.go index bb7294c4ba..b20144e3af 100644 --- a/services/keep-balance/server.go +++ b/services/keep-balance/server.go @@ -112,7 +112,7 @@ func (srv *Server) runForever(ctx context.Context) error { for { if srv.Cluster.Collections.BalancePullLimit < 1 && srv.Cluster.Collections.BalanceTrashLimit < 1 { logger.Print("WARNING: Will scan periodically, but no changes will be committed.") - logger.Print("======= Consider using non-zero BalancePullLimit and BalanceTrashLimit configs.") + logger.Print("======= To commit changes, set BalancePullLimit and BalanceTrashLimit values greater than zero.") } if !dblock.KeepBalanceService.Check() { -- 2.30.2