From ae7a179649bbe19761c49de65b10127592ef646b Mon Sep 17 00:00:00 2001 From: Tom Clegg Date: Mon, 11 Mar 2024 15:15:38 -0400 Subject: [PATCH] 15317: Rename limiting -> apparent speed, link to explanation. Arvados-DCO-1.1-Signed-off-by: Tom Clegg --- services/keep-web/metrics.go | 4 ++-- services/keep-web/server_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/services/keep-web/metrics.go b/services/keep-web/metrics.go index 60964f409b..bfc533a73e 100644 --- a/services/keep-web/metrics.go +++ b/services/keep-web/metrics.go @@ -32,8 +32,8 @@ func newMetrics(reg *prometheus.Registry) *metrics { mDownloadBackendSpeed: prometheus.NewHistogramVec(prometheus.HistogramOpts{ Namespace: "arvados", Subsystem: "keepweb", - Name: "download_limiting_backend_speed", - Help: "Limiting backend speed (bytes per second) when serving file downloads, bucketed by transfer size range", + Name: "download_apparent_backend_speed", + Help: "Apparent download speed from the backend (bytes per second) when serving file downloads, bucketed by transfer size range (see https://dev.arvados.org/issues/15317#note-25 for explanation)", Buckets: []float64{10_000, 1_000_000, 10_000_000, 100_000_000, 1_000_000_000, math.Inf(+1)}, }, []string{"size_range"}), mUploadSpeed: prometheus.NewHistogramVec(prometheus.HistogramOpts{ diff --git a/services/keep-web/server_test.go b/services/keep-web/server_test.go index 0d5ea4df3a..f79df20212 100644 --- a/services/keep-web/server_test.go +++ b/services/keep-web/server_test.go @@ -518,7 +518,7 @@ func (s *IntegrationSuite) TestMetrics(c *check.C) { allmetrics, err := ioutil.ReadAll(resp.Body) c.Check(err, check.IsNil) - c.Check(string(allmetrics), check.Matches, `(?ms).*\narvados_keepweb_download_limiting_backend_speed_bucket{size_range="0",le="1e\+06"} 4\n.*`) + c.Check(string(allmetrics), check.Matches, `(?ms).*\narvados_keepweb_download_apparent_backend_speed_bucket{size_range="0",le="1e\+06"} 4\n.*`) c.Check(string(allmetrics), check.Matches, `(?ms).*\narvados_keepweb_download_speed_bucket{size_range="0",le="\+Inf"} 4\n.*`) c.Check(string(allmetrics), check.Matches, `(?ms).*\narvados_keepweb_upload_speed_bucket{size_range="0",le="\+Inf"} 2\n.*`) c.Check(string(allmetrics), check.Matches, `(?ms).*\narvados_keepweb_upload_sync_delay_seconds_bucket{size_range="0",le="10"} 2\n.*`) -- 2.30.2