From aa29646b94556f244a2a8ef5f422d9e91b95ffe0 Mon Sep 17 00:00:00 2001 From: Stephen Smith Date: Tue, 19 Dec 2023 10:52:43 -0500 Subject: [PATCH] 19675: Rename memory icon to reflect resource usage, use icon for instance type panel Arvados-DCO-1.1-Signed-off-by: Stephen Smith --- services/workbench2/src/components/icon/icon.tsx | 3 +-- .../workbench2/src/store/breadcrumbs/breadcrumbs-actions.ts | 4 ++-- .../src/views/instance-types-panel/instance-types-panel.tsx | 4 ++-- .../src/views/process-panel/process-resource-card.tsx | 4 ++-- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/services/workbench2/src/components/icon/icon.tsx b/services/workbench2/src/components/icon/icon.tsx index 69ebffd7ed..d81f43eb7a 100644 --- a/services/workbench2/src/components/icon/icon.tsx +++ b/services/workbench2/src/components/icon/icon.tsx @@ -210,7 +210,7 @@ export const KeyIcon: IconType = props => ; export const LogIcon: IconType = props => ; export const MailIcon: IconType = props => ; export const MaximizeIcon: IconType = props => ; -export const MemoryIcon: IconType = props => ; +export const ResourceIcon: IconType = props => ; export const UnMaximizeIcon: IconType = props => ; export const MoreVerticalIcon: IconType = props => ; export const MoreHorizontalIcon: IconType = props => ; @@ -268,4 +268,3 @@ export const StartIcon: IconType = props => ; export const StopIcon: IconType = props => ; export const SelectAllIcon: IconType = props => ; export const SelectNoneIcon: IconType = props => ; -export const InstanceTypeIcon: IconType = props => ; diff --git a/services/workbench2/src/store/breadcrumbs/breadcrumbs-actions.ts b/services/workbench2/src/store/breadcrumbs/breadcrumbs-actions.ts index 80348f3791..018a64ce9b 100644 --- a/services/workbench2/src/store/breadcrumbs/breadcrumbs-actions.ts +++ b/services/workbench2/src/store/breadcrumbs/breadcrumbs-actions.ts @@ -20,7 +20,7 @@ import { ProcessResource } from 'models/process'; import { OrderBuilder } from 'services/api/order-builder'; import { Breadcrumb } from 'components/breadcrumbs/breadcrumbs'; import { ContainerRequestResource, containerRequestFieldsNoMounts } from 'models/container-request'; -import { AdminMenuIcon, CollectionIcon, IconType, InstanceTypeIcon, ProcessIcon, ProjectIcon, WorkflowIcon } from 'components/icon/icon'; +import { AdminMenuIcon, CollectionIcon, IconType, ProcessIcon, ProjectIcon, ResourceIcon, WorkflowIcon } from 'components/icon/icon'; import { CollectionResource } from 'models/collection'; import { getSidePanelIcon } from 'views-components/side-panel-tree/side-panel-tree'; import { WorkflowResource } from 'models/workflow'; @@ -296,7 +296,7 @@ export const INSTANCE_TYPES_PANEL_LABEL = 'Instance Types'; export const setInstanceTypesBreadcrumbs = () => async (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository) => { dispatch(setBreadcrumbs([ - { label: INSTANCE_TYPES_PANEL_LABEL, uuid: INSTANCE_TYPES_PANEL_LABEL, icon: InstanceTypeIcon }, + { label: INSTANCE_TYPES_PANEL_LABEL, uuid: INSTANCE_TYPES_PANEL_LABEL, icon: ResourceIcon }, ])); }; diff --git a/services/workbench2/src/views/instance-types-panel/instance-types-panel.tsx b/services/workbench2/src/views/instance-types-panel/instance-types-panel.tsx index 006a119797..cb901639d6 100644 --- a/services/workbench2/src/views/instance-types-panel/instance-types-panel.tsx +++ b/services/workbench2/src/views/instance-types-panel/instance-types-panel.tsx @@ -5,7 +5,7 @@ import React from 'react'; import { StyleRulesCallback, WithStyles, withStyles, Card, CardContent, Typography, Grid } from '@material-ui/core'; import { ArvadosTheme } from 'common/custom-theme'; -import { InstanceTypeIcon } from 'components/icon/icon'; +import { ResourceIcon } from 'components/icon/icon'; import { RootState } from 'store/store'; import { connect } from 'react-redux'; import { ClusterConfigJSON } from 'common/config'; @@ -88,7 +88,7 @@ export const InstanceTypesPanel = withStyles(styles)(connect(mapStateToProps)( }) : } diff --git a/services/workbench2/src/views/process-panel/process-resource-card.tsx b/services/workbench2/src/views/process-panel/process-resource-card.tsx index b39f48ea12..4e849173fb 100644 --- a/services/workbench2/src/views/process-panel/process-resource-card.tsx +++ b/services/workbench2/src/views/process-panel/process-resource-card.tsx @@ -19,7 +19,7 @@ import { ArvadosTheme } from 'common/custom-theme'; import { CloseIcon, MaximizeIcon, - MemoryIcon, + ResourceIcon, UnMaximizeIcon, } from 'components/icon/icon'; import { MPVPanelProps } from 'components/multi-panel-view/multi-panel-view'; @@ -88,7 +88,7 @@ export const ProcessResourceCard = withStyles(styles)(connect()( content: classes.title, avatar: classes.avatar, }} - avatar={} + avatar={} title={ Resources -- 2.30.2