From 9a6559f936fb93f63e163690be4ed670a76dd135 Mon Sep 17 00:00:00 2001 From: Radhika Chippada Date: Mon, 2 Feb 2015 18:23:16 -0500 Subject: [PATCH] 2659: Do not require login for project tab_counts method as well. Remove anonymous login tests for /users and /groups pages since we are no longer doing session establishment for anonymous user login. These are like any other un-shared pages and show login page to user. --- .../app/controllers/projects_controller.rb | 2 +- .../test/integration/anonymous_access_test.rb | 17 ----------------- 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/apps/workbench/app/controllers/projects_controller.rb b/apps/workbench/app/controllers/projects_controller.rb index 82743b9095..978395140b 100644 --- a/apps/workbench/app/controllers/projects_controller.rb +++ b/apps/workbench/app/controllers/projects_controller.rb @@ -1,6 +1,6 @@ class ProjectsController < ApplicationController before_filter :set_share_links, if: -> { defined? @object } - skip_around_filter :require_thread_api_token, only: :show + skip_around_filter :require_thread_api_token, only: [:show, :tab_counts] def model_class Group diff --git a/apps/workbench/test/integration/anonymous_access_test.rb b/apps/workbench/test/integration/anonymous_access_test.rb index 43bbf96cf3..f32fcbdbb4 100644 --- a/apps/workbench/test/integration/anonymous_access_test.rb +++ b/apps/workbench/test/integration/anonymous_access_test.rb @@ -178,21 +178,4 @@ class AnonymousAccessTest < ActionDispatch::IntegrationTest assert_text 'script version' assert_no_selector 'a', text: 'Run this pipeline' end - - [ - '/users', - '/groups', - ].each do |page| - test "anonymous user accesses publicly accessible project and then traverses to #{page}" do - # when anonymous, first visit publicly accessible project - visit_publicly_accessible_project - visit page - - if page == '/users' - assert_no_selector 'a', text: 'Add a new user' - elsif page == '/groups' - assert_no_selector 'button', text: 'Add a new group' - end - end - end end -- 2.30.2