From 9792171cd97a576c34d85291ff64cbc29061fc08 Mon Sep 17 00:00:00 2001 From: Ward Vandewege Date: Thu, 16 Sep 2021 12:48:12 -0400 Subject: [PATCH] 17770: while throttled, do not log that instances are being created when they are not. Arvados-DCO-1.1-Signed-off-by: Ward Vandewege --- lib/dispatchcloud/scheduler/run_queue.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/dispatchcloud/scheduler/run_queue.go b/lib/dispatchcloud/scheduler/run_queue.go index e9fc5f9021..f729f0dc23 100644 --- a/lib/dispatchcloud/scheduler/run_queue.go +++ b/lib/dispatchcloud/scheduler/run_queue.go @@ -78,10 +78,12 @@ tryrun: logger.Trace("overquota") overquota = sorted[i:] break tryrun - } else if logger.Info("creating new instance"); sch.pool.Create(it) { + } else if sch.pool.Create(it) { // Success. (Note pool.Create works // asynchronously and does its own - // logging, so we don't need to.) + // logging about the eventual outcome, + // so we don't need to.) + logger.Info("creating new instance") } else { // Failed despite not being at quota, // e.g., cloud ops throttled. TODO: -- 2.39.5