From 831540fd5eedb6226996b5c72a86f2dba64cb196 Mon Sep 17 00:00:00 2001 From: Tom Clegg Date: Mon, 11 Jul 2022 11:17:17 -0400 Subject: [PATCH] 19249: Add test for control chars in properties key. Arvados-DCO-1.1-Signed-off-by: Tom Clegg --- services/keep-web/s3_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/services/keep-web/s3_test.go b/services/keep-web/s3_test.go index 14dfa62dba..851bee4b72 100644 --- a/services/keep-web/s3_test.go +++ b/services/keep-web/s3_test.go @@ -83,6 +83,10 @@ func (s *IntegrationSuite) s3setup(c *check.C) s3stage { "object": map[string]interface{}{"key": map[string]interface{}{"key2": "value⛵"}}, "nonascii": "⛵", "newline": "foo\r\nX-Bad: header", + // This key cannot be expressed as a MIME + // header key, so it will be silently skipped + // (see "Inject" in PropertiesAsMetadata test) + "a: a\r\nInject": "bogus", }, }}) c.Assert(err, check.IsNil) @@ -281,6 +285,7 @@ func (s *IntegrationSuite) TestS3PropertiesAsMetadata(c *check.C) { rdr.Close() c.Check(content, check.HasLen, 4) s.checkMetaEquals(c, hdr, expectCollectionTags) + c.Check(hdr["Inject"], check.IsNil) c.Log("HEAD bucket with metadata from collection") resp, err = stage.collbucket.Head("/", nil) -- 2.30.2