From 81fd54f647fdbea139ffd8f74c33fc8d888683f1 Mon Sep 17 00:00:00 2001
From: Nico Cesar <ncesar@veritasgenetics.com>
Date: Tue, 12 Jun 2018 14:14:19 -0400
Subject: [PATCH] 13544: Removing packages-with-versions target in Makefile.
 Consolidated in packages

Arvados-DCO-1.1-Signed-off-by: Nico Cesar <ncesar@veritasgenetics.com>
---
 Makefile | 31 +++++--------------------------
 1 file changed, 5 insertions(+), 26 deletions(-)

diff --git a/Makefile b/Makefile
index 8e29481116..5ad686bf17 100644
--- a/Makefile
+++ b/Makefile
@@ -15,9 +15,10 @@ TS_GIT?=$(shell git log -n1 --first-parent "--format=format:%ct" .)
 # 1528815021 -> 20180612145021
 DATE_FROM_TS_GIT?=$(shell date -ud @$(TS_GIT) +%Y%m%d%H%M%S)
 
-# NIGHTLY_VERSION uses all the above to produce X.Y.Z.timestamp
+# VERSION uses all the above to produce X.Y.Z.timestamp
 # something in the lines of 1.2.0.20180612145021, this will be the package version
-NIGHTLY_VERSION?=$(GIT_TAG).$(DATE_FROM_TS_GIT)
+# it can be overwritten when invoking make as in make packages VERSION=1.2.0
+VERSION?=$(GIT_TAG).$(DATE_FROM_TS_GIT)
 
 # ITERATION is the package iteration, intended for manual change if anything non-code related
 # changes in the package. (i.e. example config files externally added
@@ -64,35 +65,13 @@ test: yarn-install
 build: yarn-install test
 	yarn build
 
-# use FPM to create DEB and RPM with a version (usually triggered from CI to make a release)
-packages-with-version: build
-	fpm \
-	 -s dir \
-	 -t deb \
-	 -n "$(APP_NAME)" \
-	 -v "$(VERSION)" \
-	 --iteration "$(ITERATION)" \
-	 --maintainer="$(MAINTAINER)" \
-	 --description="$(DESCRIPTION)" \
-	 --deb-no-default-config-files \
-	$(WORKSPACE)/build/=DEST_DIR
-	fpm \
-	 -s dir \
-	 -t rpm \
-	 -n "$(APP_NAME)" \
-	 -v "$(VERSION)" \
-	 --iteration "$(ITERATION)" \
-	 --maintainer="$(MAINTAINER)" \
-	 --description="$(DESCRIPTION)" \
-	 $(WORKSPACE)/build/=DEST_DIR
-
 # use FPM to create DEB and RPM
 packages: build
 	fpm \
 	 -s dir \
 	 -t deb \
 	 -n "$(APP_NAME)" \
-	 -v "$(NIGHTLY_VERSION)" \
+	 -v "$(VERSION)" \
 	 --iteration "$(ITERATION)" \
 	 --maintainer="$(MAINTAINER)" \
 	 --description="$(DESCRIPTION)" \
@@ -102,7 +81,7 @@ packages: build
 	 -s dir \
 	 -t rpm \
 	 -n "$(APP_NAME)" \
-	 -v "$(NIGHTLY_VERSION)" \
+	 -v "$(VERSION)" \
 	 --iteration "$(ITERATION)" \
 	 --maintainer="$(MAINTAINER)" \
 	 --description="$(DESCRIPTION)" \
-- 
2.30.2