From 72616dad6615ef2379cf26bc2393f90bdd2c8164 Mon Sep 17 00:00:00 2001
From: Lucas Di Pentima <lucas.dipentima@curii.com>
Date: Thu, 13 Jun 2024 16:40:25 -0300
Subject: [PATCH] 21832: Allows custom backup retention period config.

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima@curii.com>
---
 tools/salt-install/terraform/aws/services/locals.tf        | 1 +
 tools/salt-install/terraform/aws/services/main.tf          | 2 +-
 tools/salt-install/terraform/aws/services/terraform.tfvars | 1 +
 tools/salt-install/terraform/aws/services/variables.tf     | 6 ++++++
 4 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/tools/salt-install/terraform/aws/services/locals.tf b/tools/salt-install/terraform/aws/services/locals.tf
index 906a2cf636..d3f00231ba 100644
--- a/tools/salt-install/terraform/aws/services/locals.tf
+++ b/tools/salt-install/terraform/aws/services/locals.tf
@@ -35,4 +35,5 @@ locals {
   rds_allocated_storage = var.rds_allocated_storage
   rds_max_allocated_storage = max(var.rds_max_allocated_storage, var.rds_allocated_storage)
   rds_instance_type = var.rds_instance_type
+  rds_backup_retention_period = var.rds_backup_retention_period
 }
diff --git a/tools/salt-install/terraform/aws/services/main.tf b/tools/salt-install/terraform/aws/services/main.tf
index d1e88a8dca..7ff6f4093f 100644
--- a/tools/salt-install/terraform/aws/services/main.tf
+++ b/tools/salt-install/terraform/aws/services/main.tf
@@ -111,7 +111,7 @@ resource "aws_db_instance" "postgresql_service" {
   vpc_security_group_ids = [local.arvados_sg_id]
   db_subnet_group_name = aws_db_subnet_group.arvados_db_subnet_group[0].name
 
-  backup_retention_period = 7
+  backup_retention_period = local.rds_backup_retention_period
   publicly_accessible = false
   storage_encrypted = true
   multi_az = false
diff --git a/tools/salt-install/terraform/aws/services/terraform.tfvars b/tools/salt-install/terraform/aws/services/terraform.tfvars
index 1a2e13d042..1732465b19 100644
--- a/tools/salt-install/terraform/aws/services/terraform.tfvars
+++ b/tools/salt-install/terraform/aws/services/terraform.tfvars
@@ -31,6 +31,7 @@
 # rds_instance_type = "db.m5.xlarge"
 # rds_allocated_storage = 200
 # rds_max_allocated_storage = 1000
+# rds_backup_retention_period = 30
 
 # AWS secret's name which holds the SSL certificate private key's password.
 # Default: "arvados-ssl-privkey-password"
diff --git a/tools/salt-install/terraform/aws/services/variables.tf b/tools/salt-install/terraform/aws/services/variables.tf
index 583ba70976..455cfb5f02 100644
--- a/tools/salt-install/terraform/aws/services/variables.tf
+++ b/tools/salt-install/terraform/aws/services/variables.tf
@@ -78,3 +78,9 @@ variable "rds_max_allocated_storage" {
   type = number
   default = 300
 }
+
+variable "rds_backup_retention_period" {
+  description = "RDS Backup retention (days). Set to 0 to disable."
+  type = number
+  default = 7
+}
-- 
2.30.2