From 64dd84f22415c55e69403eacbfec431b5568921c Mon Sep 17 00:00:00 2001 From: Peter Amstutz Date: Mon, 5 Aug 2024 17:17:52 -0400 Subject: [PATCH] 21814: Remove legacy undocumented 'last_object_class' parameter This was only ever used by workbench 1, was never documented, and has no tests. The option never was included in the Go SDK 'GroupContentsOptions' struct so I believe this means it has already been the case for years that Controller would just ignore it. Arvados-DCO-1.1-Signed-off-by: Peter Amstutz --- .../app/controllers/arvados/v1/groups_controller.rb | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/services/api/app/controllers/arvados/v1/groups_controller.rb b/services/api/app/controllers/arvados/v1/groups_controller.rb index 0937c254d7..39c8a6da07 100644 --- a/services/api/app/controllers/arvados/v1/groups_controller.rb +++ b/services/api/app/controllers/arvados/v1/groups_controller.rb @@ -279,25 +279,13 @@ class Arvados::V1::GroupsController < ApplicationController included_by_uuid = {} - seen_last_class = false error_by_class = {} any_success = false klasses.each do |klass| - # check if current klass is same as params['last_object_class'] - seen_last_class = true if((params['count'].andand.==('none')) and - (params['last_object_class'].nil? or - params['last_object_class'].empty? or - params['last_object_class'] == klass.to_s)) - # if klasses are specified, skip all other klass types next if wanted_klasses.any? and !wanted_klasses.include?(klass.to_s) - # if specified, and count=none, then only look at the klass in - # last_object_class. - # for whatever reason, this parameter exists separately from 'wanted_klasses' - next if params['count'] == 'none' and !seen_last_class - # don't process rest of object types if we already have needed number of objects break if params['count'] == 'none' and all_objects.size >= limit_all -- 2.30.2