From 54781f3d3c1dea0e14542d129b1c8e061ad406fc Mon Sep 17 00:00:00 2001 From: Tom Clegg Date: Tue, 29 Jun 2021 10:11:40 -0400 Subject: [PATCH] 17840: Check for unparsed command line arguments. Arvados-DCO-1.1-Signed-off-by: Tom Clegg --- services/keep-balance/main.go | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/services/keep-balance/main.go b/services/keep-balance/main.go index e1573e7f73..605ee5fc82 100644 --- a/services/keep-balance/main.go +++ b/services/keep-balance/main.go @@ -55,7 +55,15 @@ func runCommand(prog string, args []string, stdin io.Reader, stdout, stderr io.W loader.SetupFlags(flags) munged := loader.MungeLegacyConfigArgs(logger, args, "-legacy-keepbalance-config") - flags.Parse(munged) + err := flags.Parse(munged) + if err != nil { + logger.Errorf("error parsing command line flags: %s", err) + return 2 + } + if flags.NArg() != 0 { + logger.Errorf("error parsing command line flags: extra arguments: %q", flags.Args()) + return 2 + } if *dumpFlag { dumper := logrus.New() -- 2.30.2